Author: vedantk
Date: Thu Feb 15 23:59:43 2018
New Revision: 325319
URL: http://llvm.org/viewvc/llvm-project?rev=325319&view=rev
Log:
[Coverage] Handle break/continue outside of loop bodies
Teach the coverage mapping logic to handle break or continue statements
within for loop increments.
Fixes
CarlosAlbertoEnciso added a comment.
Build now is OK. Thanks @ilya-biryukov
Repository:
rL LLVM
https://reviews.llvm.org/D43227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG apart from the .inc handling (happy to chat more)
Comment at: clangd/index/CanonicalIncludes.h:52
+ /// a canonical header name.
+ llvm::StringRef mapHeader(llvm::
Author: ahatanak
Date: Fri Feb 16 00:47:37 2018
New Revision: 325321
URL: http://llvm.org/viewvc/llvm-project?rev=325321&view=rev
Log:
[Sema] Take into account the current context when checking the
accessibility of a class member.
This fixes PR32898.
rdar://problem/33737747
Differential revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325321: [Sema] Take into account the current context when
checking the (authored by ahatanak, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D36918
Files:
lib/Sema/SemaAccess.cpp
te
jakehehrlich added a comment.
Can we add tests for a function at the top level and for a method?
https://reviews.llvm.org/D41102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D43277#1009659, @brucem wrote:
> Without this, anyone using `clang-tidy` with this check gets 6 system header
> warnings whenever they transitively have included `limits`.
Only if `-system-headers` is passed to clang-tidy, or if those lib
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: samparker, olista01, rengolin.
Herald added subscribers: kristof.beyls, javed.absar.
This adds Sema and Codegen tests for the vcvtr builtins
(because they were missing).
https://reviews.llvm.org/D43372
Files:
test/CodeGen/built
Author: sammccall
Date: Fri Feb 16 01:41:43 2018
New Revision: 325326
URL: http://llvm.org/viewvc/llvm-project?rev=325326&view=rev
Log:
[clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove
SmallString micro-opt for more ergonomic tests. NFC
Modified:
clang-tools-extra/tru
sammccall added inline comments.
Comment at: unittests/clangd/HeadersTests.cpp:29
+ // absolute path.
+ std::string addToSubdir(PathRef File, llvm::StringRef Code = "") {
+assert(llvm::sys::path::is_relative(File) && "FileName should be
relative");
sammcca
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
massberg updated this revision to Diff 134578.
massberg edited the summary of this revision.
https://reviews.llvm.org/D42730
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedFunctionalCheck.cpp
clang-tidy/modernize/DeprecatedFunctionalCheck.h
clang-tidy/modernize/
massberg marked 8 inline comments as done.
massberg added a comment.
Thanks for the comments!
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:26
+.bind("base")),
+ anyOf(isClass(), ast_matchers:
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
==
Hi Brian,
Your change is causing a test failure on the clang-cmake-armv7-a15 bot in the
test Clang::SemaCXX/coroutines.cpp.
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/15742
error: 'error' diagnostics seen but not expected:
File
/home/buildslave/buildslave/clang-cmake-arm
ilya-biryukov added a comment.
Technically this is NFC, but it has a huge `toString` helper and I'm not sure
if I chose the appropriate place for logging the filename.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43377
___
cfe-co
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D35894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
devnexen created this revision.
devnexen added reviewers: krytarowski, vitalybuka, dberris.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, emaste.
devnexen edited the summary of this revision.
-pthread was into linkage step.
-Warning about the -fxr
sammccall added a comment.
This looks really useful! Main suggestion is to drop the added span and attach
kind to the main span instead. (It's relevant to index too, not just to sema)
Comment at: clangd/CodeComplete.cpp:403
+StringRef printCompletionKind(enum CodeCompletionC
devnexen updated this revision to Diff 134586.
devnexen edited the summary of this revision.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
===
--
ilya-biryukov updated this revision to Diff 134589.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Attach completion kind in CodeCompleteFlow::run().
- Move printCompletionKind closer to CompletionContext::Kind.
- Added FIXME to remove tracing of filename.
Repos
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added a subscriber: ioeric.
Will be used in clangd. See https://reviews.llvm.org/D43377.
Repository:
rC Clang
https://reviews.llvm.org/D43379
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Sema/C
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:503
+trace::Span Span("Process sema results");
+SPAN_ATTACH(Span, "total_sema_items", NumResults);
sammccall wrote:
> I think this s
kosarev updated this revision to Diff 134590.
kosarev added a comment.
Updated to consider the total size of the explicit initializers instead of
their number. The threshold value is adjusted respectively.
https://reviews.llvm.org/D43181
Files:
lib/CodeGen/CGExprAgg.cpp
test/CodeGen/init.c
Author: hans
Date: Fri Feb 16 04:06:32 2018
New Revision: 325335
URL: http://llvm.org/viewvc/llvm-project?rev=325335&view=rev
Log:
Revert r325321 "[Sema] Take into account the current context when checking the"
This broke the Chromium build, see https://crbug.com/813017
> accessibility of a clas
Reverted in r325335 as this broke the Chromium build.
See https://bugs.chromium.org/p/chromium/issues/detail?id=813017 for
stack trace and reproducer.
(I think Ben said it might have also broken a Clang bootstrap build,
but I didn't see that anywhere?)
On Fri, Feb 16, 2018 at 9:47 AM, Akira Hata
Author: krasimir
Date: Fri Feb 16 04:10:06 2018
New Revision: 325336
URL: http://llvm.org/viewvc/llvm-project?rev=325336&view=rev
Log:
[clang-format] Enable google text proto formatting in R"proto('s
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
ht
ilya-biryukov updated this revision to Diff 134592.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Rename getFile() to file()
- Removed the Path.h include
- Rebased onto head
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43246
Files:
clangd/
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/Protocol.h:52
struct URIForFile {
+ URIForFile() = default;
sammccall wrote:
> ioeric wrote:
> > ilya-biryukov wrote:
> > > sammccall wrote:
> > > > I don'
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325337: [clangd] Assert path is absolute when assigning to
URIForFile. (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43246?vs=134592&id=134593#toc
Reposit
Author: ibiryukov
Date: Fri Feb 16 04:20:47 2018
New Revision: 325337
URL: http://llvm.org/viewvc/llvm-project?rev=325337&view=rev
Log:
[clangd] Assert path is absolute when assigning to URIForFile.
Summary:
The assertion will point directly to misbehaving code, so that
debugging related problems
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
There are a few implementation options here - alternatives are either both
awkward and inefficient, or really inefficient.
This is at least potentially
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Thanks a lot for the fix!
Suggest a test case which reproduced the bug:
// comment with 'quote'
void f() {}
`runSymbolCollector` -> `SymbolToYAML` -> `SymbolFromYAML` -> check
`Documenta
dberris added a comment.
Looks OK, but can we have a test for this somehow?
https://reviews.llvm.org/D43378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: test/Sema/attr-target-ast.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -ast-dump %s | FileCheck %s
+
Can you drop the svn props from this file?
Comment at: test/Sema/attr-target.c:9-10
int _
Hi Douglas, thanks for letting me know. I'm looking into this now.
At first these error messages made me think
https://reviews.llvm.org/rL325291 was merged in, but not
https://reviews.llvm.org/rL325288. But I guess that's not possible.
Is there a way to find out the host triple used on this build
ioeric updated this revision to Diff 134600.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Merged with origin/master
- Addressed review comments; removed .inc handling.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42640
Files:
clangd/CMakeLists.txt
cl
ioeric added a comment.
Thank you for reviewing this!
Comment at: clangd/index/CanonicalIncludes.h:52
+ /// a canonical header name.
+ llvm::StringRef mapHeader(llvm::StringRef Header) const;
+
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > So I'
Ah I'm sorry, I've reproduced this with a `-triple armeb-none-eabi`
argument. Douglas, do you mind if I fix forward?
- Brian
On Fri, Feb 16, 2018 at 8:55 AM, Brian Gesiak wrote:
> Hi Douglas, thanks for letting me know. I'm looking into this now.
>
> At first these error messages made me think
Author: modocache
Date: Fri Feb 16 06:11:27 2018
New Revision: 325342
URL: http://llvm.org/viewvc/llvm-project?rev=325342&view=rev
Log:
[Coroutines] Use target-agnostic size_t in test
Summary:
Fix a test failure on ARM hosts that was caused by a difference in the type of
size_t, by using a target
This should be fixed in https://reviews.llvm.org/rL325342. Thanks for your
help!
- Brian
On Fri, Feb 16, 2018 at 9:07 AM, Brian Gesiak wrote:
> Ah I'm sorry, I've reproduced this with a `-triple armeb-none-eabi`
> argument. Douglas, do you mind if I fix forward?
>
> - Brian
>
> On Fri, Feb 16,
Author: ioeric
Date: Fri Feb 16 06:15:55 2018
New Revision: 325343
URL: http://llvm.org/viewvc/llvm-project?rev=325343&view=rev
Log:
[clangd] collect symbol #include & insert #include in global code completion.
Summary:
o Collect suitable #include paths for index symbols. This also does smart
ma
aaron.ballman added inline comments.
Comment at: test/Sema/attr-nocf_check.c:18-20
+ FuncPointerWithNoCfCheck fNoCfCheck = f; // no-warning
+ (*fNoCfCheck)(); // no-warning
+ f = fNoCfCheck;// no-warning
oren_ben_s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325343: [clangd] collect symbol #include & insert
#include in global code completion. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325343: [clangd] collect symbol #include & insert
#include in global code completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42640?vs=134600&id=134603#
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you! Do you have commit access or should I commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D43312
___
cfe-commits
krytarowski added a comment.
I was wrong about `-pthread` here, as we pass it directly to a linker. ld(1)
accepts `-lpthread` not `-pthread`. cc(1) requires `-pthread` as it defines
additional flags like `_REENTRANT` (OS-specific).
https://reviews.llvm.org/D43378
___
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
I think it's better to not hardcode `x86_64` here in a message, we wi
emaste added a comment.
Please upload reviews with context (e.g. `git diff -U9`, `git show
-U9`, or `svn diff -x -U99`).
See https://llvm.org/docs/Phabricator.html for more info.
Comment at: lib/Driver/XRayArgs.cpp:60
D.Diag(diag::err_drv_clang_unsupported)
devnexen updated this revision to Diff 134605.
devnexen added a comment.
Updating the warning messages.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
=
Author: ioeric
Date: Fri Feb 16 06:47:08 2018
New Revision: 325346
URL: http://llvm.org/viewvc/llvm-project?rev=325346&view=rev
Log:
[clangd] remove redundant ';' introduced in r325343
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clan
szepet added a comment.
In https://reviews.llvm.org/D16403#992452, @NoQ wrote:
> Thank you, this explanation looks very reasonable.
>
> All right, so right after the termination of the loop we have
>
> [B1]
> 1: ForStmt (LoopExit)
> 2: [B4.5].~A() (Implicit destructor)
> 3: [B5.3].~A() (I
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
szepet added a comment.
Herald added a reviewer: george.karpenkov.
ping
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet added a comment.
Herald added a reviewer: george.karpenkov.
ping
https://reviews.llvm.org/D39398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kevinl added a comment.
I do not have commit access.
Would appreciate you committing it for me. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D43312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
Setting the CLANGD_TRACE environment variable directly is awkward with VSCode's
"reload from the command palette" workflow.
Repository:
rCTE Clang T
CarlosAlbertoEnciso added a comment.
Hi @ioeric:
Just to let you know that your submission seems to break a Windows test.
FAIL: Extra Tools Unit Tests ::
clangd/Checking/./ClangdTests.exe/SymbolCollectorTest.IWYUPragma (15474 of
36599)
Thanks
Repository:
rL LLVM
https://reviews.llvm.or
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:182
+ // it would always be false.
+ string DisallowImplicitThisParamName = disallowImplicitThisParamName;
+}
jdenny wrote:
> jdenny wrote:
> > aaron.ballman wrote:
> > > Is there much
aaron.ballman added inline comments.
Comment at: test/Sema/attr-nocf_check.c:18-20
+ FuncPointerWithNoCfCheck fNoCfCheck = f; // no-warning
+ (*fNoCfCheck)(); // no-warning
+ f = fNoCfCheck;// no-warning
aaron.ball
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:33
+ this);
+ Finder->addMatcher(callExpr(callee(functionDecl(hasName("std::mem_fun"
+ .bind("mem_fun_call"),
mass
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
This has a bit of a blast radius, but I think there's enough value in "forcing"
us to give names to these async tasks for debugging. Guessing about what
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
krytarowski wrote:
> I think it's better to not hardcode `x86_64` her
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
krytarowski wrote:
> krytarowski wrote:
> > I think it's better to not h
SjoerdMeijer added a comment.
Thanks for reviewing!
https://reviews.llvm.org/D43372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 134622.
devnexen added a comment.
Reusing generic message/reformating.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
===
krytarowski added a comment.
Please add a clang test to verify that we can pass xray flags, as requested by
@dberris.
https://reviews.llvm.org/D43378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: sjoerdmeijer
Date: Fri Feb 16 08:01:08 2018
New Revision: 325351
URL: http://llvm.org/viewvc/llvm-project?rev=325351&view=rev
Log:
[ARM] Add tests for the vcvtr builtins
This adds Sema and Codegen tests for the vcvtr builtins
(because they were missing).
Differential Revision: https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325351: [ARM] Add tests for the vcvtr builtins (authored by
SjoerdMeijer, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D43372
Files:
test/CodeGen/builtins-arm.c
test/Sema/builtins-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325351: [ARM] Add tests for the vcvtr builtins (authored by
SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43372?vs=134570&id=1
devnexen updated this revision to Diff 134628.
devnexen added a comment.
Herald added a subscriber: srhines.
Enabling one test for FreeBSD
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xra
Author: marsupial
Date: Fri Feb 16 08:07:33 2018
New Revision: 325352
URL: http://llvm.org/viewvc/llvm-project?rev=325352&view=rev
Log:
Use Token::isOneOf method in Parser.
Summary: Easier to read and possibly optimize.
Reviewers: rsmith, sepavloff
Reviewed By: sepavloff
Subscribers: sepavloff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325352: Use Token::isOneOf method in Parser. (authored by
marsupial, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D36701?vs=111034&id=134629
devnexen updated this revision to Diff 134634.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xray-instrument-os.c
test/Driver/XRay/xray-shared-noxray.cpp
Index: test/Driver/XRay/xray-shar
erichkeane added inline comments.
Comment at: test/Sema/attr-target-ast.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -ast-dump %s | FileCheck %s
+
aaron.ballman wrote:
> Can you drop the svn props from this file?
Absolutely, I'll do that on commit.
aaron.ballman added inline comments.
Comment at: test/Sema/attr-target.c:9-10
int __attribute__((target("fpmath=387"))) walrus() { return 4; }
//expected-warning {{ignoring unsupported 'fpmath=' in the target attribute
string}}
+// expected-warning@+1 {{'target' attribute igno
Author: sammccall
Date: Fri Feb 16 08:41:42 2018
New Revision: 325357
URL: http://llvm.org/viewvc/llvm-project?rev=325357&view=rev
Log:
[clangd] Include timestamps in log messages.
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified: clang-tools-extra/trunk/clangd/JSONRPC
Hi Carlos, did this fail on a Windows build bot? Would you mind pointing me
to the broken test? Thanks!
On Fri, Feb 16, 2018 at 4:23 PM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a comment.
>
> Hi @ioeric:
>
> Just to let you know that you
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, alexfh.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adding a checker to find a function given its name and add a visibility
attribute if none is present (i.e.
jdenny added inline comments.
Comment at: include/clang/Basic/Attr.td:182
+ // it would always be false.
+ string DisallowImplicitThisParamName = disallowImplicitThisParamName;
+}
aaron.ballman wrote:
> jdenny wrote:
> > jdenny wrote:
> > > aaron.ballman wrote:
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
Looks good to me now. Wait a couple of days before submitting it just in case
the other reviewers have more comments.
Do you plan to submit (in another change) the unscoped enum → integer
dim created this revision.
dim added reviewers: craig.topper, coby, efriedma, rsmith.
Make clang accept `-msahf` (and `-mno-sahf`) flags to activate the
`+sahf` feature for the backend, for bug 36028 (Incorrect use of
pushf/popf enables/disables interrupts on amd64 kernels). This was
originally s
Typz updated this revision to Diff 134641.
Typz added a comment.
Fix bug which was lingering: prevent inlining of ObjC special control blocks.
Repository:
rC Clang
https://reviews.llvm.org/D43232
Files:
include/clang/Format/Format.h
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/Unwr
erichkeane updated this revision to Diff 134643.
erichkeane added a comment.
Do as @aaron.ballman suggested for the message. Also, removed properties from
the new file.
https://reviews.llvm.org/D43359
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
Mi
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
kryta
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Aside from a minor wording nit, LGTM!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2448-2449
def warn_unsupported_target_attribute
-: Warning<"ignoring %select{unsupported|duplicate}0"
-
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
de
miyuki added a comment.
Herald added a subscriber: christof.
ping
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Fri Feb 16 09:31:59 2018
New Revision: 325364
URL: http://llvm.org/viewvc/llvm-project?rev=325364&view=rev
Log:
Clean up 'target' attribute diagnostics
There were a few issues previously with the target
attribute diagnostics implementation that lead to the
attribute being
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325364: Clean up 'target' attribute diagnostics
(authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43359?vs=134643&id=134648#toc
Repository:
rC Clang
https:/
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:32
+ if (Name.empty()) return;
+ Finder->addMatcher(functionDecl(allOf(hasName(Name), isDefinition(),
+unless(hasVisibilityAttr(
--
devnexen added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:330-331
// the GPU side.
for (const std::string &GpuBinaryFileName :
CGM.getCodeGenOpts().CudaGpuBinaryFileNames) {
llvm::ErrorOr> GpuBinaryOrErr =
Hahnfeld wrote:
> Can we actuall
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:182
+ // it would always be false.
+ string DisallowImplicitThisParamName = disallowImplicitThisParamName;
+}
jdenny wrote:
> aaron.ballman wrote:
> > jdenny wrote:
> > > jdenny wrote:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D43181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:330-331
// the GPU side.
for (const std::string &GpuBinaryFileName :
CGM.getCodeGenOpts().CudaGpuBinaryFileNames) {
llvm::ErrorOr> GpuBinaryOrErr =
tra wrote:
> Hahnfeld wrote
jdenny added inline comments.
Comment at: include/clang/Basic/Attr.td:182
+ // it would always be false.
+ string DisallowImplicitThisParamName = disallowImplicitThisParamName;
+}
aaron.ballman wrote:
> jdenny wrote:
> > aaron.ballman wrote:
> > > jdenny wrote:
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:182
+ // it would always be false.
+ string DisallowImplicitThisParamName = disallowImplicitThisParamName;
+}
jdenny wrote:
> aaron.ballman wrote:
> > jdenny wrote:
> > > aaron.ballman
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:330-331
// the GPU side.
for (const std::string &GpuBinaryFileName :
CGM.getCodeGenOpts().CudaGpuBinaryFileNames) {
llvm::ErrorOr> GpuBinaryOrErr =
Hahnfeld wrote:
> tra wrote:
> >
1 - 100 of 159 matches
Mail list logo
