[PATCH] D43221: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm It looks like we already generate llvm.assume() for these and that eventually behaves the same as the unreachable instruction. Neat. :) https://reviews.llvm.org/D43221

r325052 - Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable.

Author: nico Date: Tue Feb 13 13:31:47 2018 New Revision: 325052 URL: http://llvm.org/viewvc/llvm-project?rev=325052&view=rev Log: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable. Fixes PR29134. https://reviews.llvm.org/D4

[PATCH] D42800: Let CUDA toolchain support amdgpu target

yaxunl updated this revision to Diff 134107. yaxunl added a comment. Update with Greg's change. https://reviews.llvm.org/D42800 Files: include/clang/Basic/Cuda.h include/clang/Driver/ToolChain.h lib/Basic/Cuda.cpp lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h lib/Basic/Tar

[PATCH] D43221: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable.

thakis closed this revision. thakis added a comment. r325052, thanks! https://reviews.llvm.org/D43221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r325054 - amdgpu/half_sqrt: Switch implementation to native_sqrt

Author: jvesely Date: Tue Feb 13 14:09:33 2018 New Revision: 325054 URL: http://llvm.org/viewvc/llvm-project?rev=325054&view=rev Log: amdgpu/half_sqrt: Switch implementation to native_sqrt Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_sqrt.cl Mod

[libclc] r325056 - amdgpu/half_exp10: Switch implementation to native_exp10

Author: jvesely Date: Tue Feb 13 14:09:37 2018 New Revision: 325056 URL: http://llvm.org/viewvc/llvm-project?rev=325056&view=rev Log: amdgpu/half_exp10: Switch implementation to native_exp10 Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_exp10.cl

[libclc] r325057 - amdgpu/half_exp2: Switch implementation to native_exp2

Author: jvesely Date: Tue Feb 13 14:09:38 2018 New Revision: 325057 URL: http://llvm.org/viewvc/llvm-project?rev=325057&view=rev Log: amdgpu/half_exp2: Switch implementation to native_exp2 Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_exp2.cl Mod

[libclc] r325059 - amdgpu/half_log10: Switch implementation to native_log10

Author: jvesely Date: Tue Feb 13 14:09:42 2018 New Revision: 325059 URL: http://llvm.org/viewvc/llvm-project?rev=325059&view=rev Log: amdgpu/half_log10: Switch implementation to native_log10 Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_log10.cl

[libclc] r325053 - amdgpu/half_rsqrt: Switch implementation to native_rsqrt

Author: jvesely Date: Tue Feb 13 14:09:31 2018 New Revision: 325053 URL: http://llvm.org/viewvc/llvm-project?rev=325053&view=rev Log: amdgpu/half_rsqrt: Switch implementation to native_rsqrt Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_native_un

[libclc] r325058 - amdgpu/half_log: Switch implementation to native_log

Author: jvesely Date: Tue Feb 13 14:09:41 2018 New Revision: 325058 URL: http://llvm.org/viewvc/llvm-project?rev=325058&view=rev Log: amdgpu/half_log: Switch implementation to native_log Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_log.cl Modifi

[libclc] r325055 - amdgpu/half_exp: Switch implementation to native_exp

Author: jvesely Date: Tue Feb 13 14:09:35 2018 New Revision: 325055 URL: http://llvm.org/viewvc/llvm-project?rev=325055&view=rev Log: amdgpu/half_exp: Switch implementation to native_exp Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_exp.cl Modifi

[libclc] r325060 - amdgpu/half_log2: Switch implementation to native_log2

Author: jvesely Date: Tue Feb 13 14:09:44 2018 New Revision: 325060 URL: http://llvm.org/viewvc/llvm-project?rev=325060&view=rev Log: amdgpu/half_log2: Switch implementation to native_log2 Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_log2.cl Mod

[libclc] r325061 - amdgpu/half_recip: Switch implementation to native_recip

Author: jvesely Date: Tue Feb 13 14:09:46 2018 New Revision: 325061 URL: http://llvm.org/viewvc/llvm-project?rev=325061&view=rev Log: amdgpu/half_recip: Switch implementation to native_recip Reviewer: Tom Stellard Signed-off-by: Jan Vesely Added: libclc/trunk/amdgpu/lib/math/half_recip.cl

[PATCH] D43259: Implement function attribute artificial

eandrews created this revision. eandrews added reviewers: erichkeane, aaron.ballman. Added support in clang for GCC function attribute 'artificial'. This attribute is used to control stepping behavior of debugger with respect to inline functions. https://reviews.llvm.org/D43259 Files: inclu

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1102 +PDK_Struct // non-trivial C struct. + }; + This is unused. Comment at: lib/CodeGen/CGBlocks.cpp:1565 // For all other types, the memcpy is fine. return

[PATCH] D43259: Implement function attribute artificial

rnk accepted this revision. rnk added subscribers: probinson, aprantl, dblaikie. rnk added a comment. This revision is now accepted and ready to land. lgtm --- Clang's builtin headers use `__attribute__((__nodebug__))` for this purpose. Do you think we should follow this up by using artificial

r325070 - [analyzer] [tests] Update CmpRuns to write to stdout correctly in multithreaded environment

Author: george.karpenkov Date: Tue Feb 13 15:36:01 2018 New Revision: 325070 URL: http://llvm.org/viewvc/llvm-project?rev=325070&view=rev Log: [analyzer] [tests] Update CmpRuns to write to stdout correctly in multithreaded environment Modified: cfe/trunk/utils/analyzer/CmpRuns.py cfe/tru

[PATCH] D40925: Add option -fkeep-static-consts

erichkeane added a comment. >> OK. My concern is that users need to use __attribute__((used)) or something >> more robust if they want SVN identifiers to reliably appear in the output. >> Adding this flag just creates a trap that will fail once they turn on >>-O2. >> I'd rather not have it in t

r325081 - Implement function attribute artificial

Author: erichkeane Date: Tue Feb 13 16:14:07 2018 New Revision: 325081 URL: http://llvm.org/viewvc/llvm-project?rev=325081&view=rev Log: Implement function attribute artificial Added support in clang for GCC function attribute 'artificial'. This attribute is used to control stepping behavior of

[PATCH] D43259: Implement function attribute artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rL325081: Implement function attribute artificial (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43259?vs=134123&id=13

[PATCH] D43167: Fix incorrect indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325087: Fix incorrect indentation. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43167 Files: libcxx/trunk/include/ios

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

vsapsai added a comment. Herald added a subscriber: jkorous-apple. Ping. https://reviews.llvm.org/D42498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

EricWF added a comment. LGTM except the removal of the test. I think it's probably valuable to keep around on platforms that allow it. What do you think? Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -

[libcxxabi] r325093 - [demangler] Support for exception specifications on function types.

Author: epilk Date: Tue Feb 13 17:08:20 2018 New Revision: 325093 URL: http://llvm.org/viewvc/llvm-project?rev=325093&view=rev Log: [demangler] Support for exception specifications on function types. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cp

[libcxxabi] r325092 - [demangler] Simplify the AST for function types, NFC.

Author: epilk Date: Tue Feb 13 17:08:17 2018 New Revision: 325092 URL: http://llvm.org/viewvc/llvm-project?rev=325092&view=rev Log: [demangler] Simplify the AST for function types, NFC. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: http:/

Re: r325081 - Implement function attribute artificial

On 13 February 2018 at 16:14, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Tue Feb 13 16:14:07 2018 > New Revision: 325081 > > URL: http://llvm.org/viewvc/llvm-project?rev=325081&view=rev > Log: > Implement function attribute artificial > > Added su

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

rsmith added a comment. Please handle this by temporarily updating the `This` pointer appropriately when evaluating the `CXXDefaultInitExpr` rather than trying to work around the `This` value being wrong later (your approach will still go wrong if the `This` pointer is used in other ways, such

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added inline comments. Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -ec = GetTestEC(); -last_write_time(p, Clock::now()); EricWF wrote: > I would really love to keep this tes

r325095 - Fix a couple of places where we assumed that non-type template parameters are always rvalues.

Author: rsmith Date: Tue Feb 13 18:07:53 2018 New Revision: 325095 URL: http://llvm.org/viewvc/llvm-project?rev=325095&view=rev Log: Fix a couple of places where we assumed that non-type template parameters are always rvalues. Added: cfe/trunk/test/SemaTemplate/sizeof-pack.cpp Modified:

Re: [PATCH] D43259: Implement function attribute artificial

Maybe - though that'd actually make for larger debug info & not be much use. With nodebug+always_inline (which is how the intrinsics are provided) the function call dissolves into the raw instruction it's meant to represent. The debug info describes that instruction as if it had been written at th

[PATCH] D43272: [clangd] Fix tracing now that spans lifetimes can overlap on a thread.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. The chrome trace viewer requires events within a thread to strictly nest. So we need to record the lifetime of the Span objects, not the contexts. But

[clang-tools-extra] r325097 - [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag

Author: sammccall Date: Tue Feb 13 19:20:07 2018 New Revision: 325097 URL: http://llvm.org/viewvc/llvm-project?rev=325097&view=rev Log: [clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp clang-tools-e

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix MSVC warnings and errors. test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass.cpp test/std/numerics/numeric.

[PATCH] D43277: limits: Use `false` instead of `type(0)`.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. This fixes warnings when using clang-tidy and the `modernize-use-bool-literals` check. Repository: rCXX libc++ https://reviews.llvm.org/D43277 Files: include/limits Index: include/limits ==

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:245 + const char *SourceContents = R"cpp( + #include "$2^invalid.h" + #include "^foo.h" ilya-biryukov wrote: > Could we also add tests for corner cases: cursor before opening quote, c

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

EricWF added inline comments. Comment at: libcxx/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:360 - -ec = GetTestEC(); -last_write_time(p, Clock::now()); vsapsai wrote: > EricWF wrote: > > I would really lov

r325103 - Test commit access

Author: henrywong Date: Tue Feb 13 23:32:27 2018 New Revision: 325103 URL: http://llvm.org/viewvc/llvm-project?rev=325103&view=rev Log: Test commit access Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/Pa

<    1   2