[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks https://reviews.llvm.org/D42993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. Could you please commit this on my behalf? I don't have commit access. https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 133569. kzhuravl added a comment. Define only canonical names. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgpu-macros.cl Index: test/Driver/amdgpu-macros.cl ==

Re: r324594 - Fix for #31362 - ms_abi is implemented incorrectly for values >=16 bytes.

Merged to 6.0 in r324718. On Thu, Feb 8, 2018 at 12:15 PM, Alexander Ivchenko via cfe-commits wrote: > Author: aivchenk > Date: Thu Feb 8 03:15:21 2018 > New Revision: 324594 > > URL: http://llvm.org/viewvc/llvm-project?rev=324594&view=rev > Log: > Fix for #31362 - ms_abi is implemented incorrec

Re: r324537 - PR36055: fix computation of *-dependence in nested initializer lists.

Merged to 6.0 in r324719. On Wed, Feb 7, 2018 at 11:25 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Feb 7 14:25:16 2018 > New Revision: 324537 > > URL: http://llvm.org/viewvc/llvm-project?rev=324537&view=rev > Log: > PR36055: fix computation of *-dependence in nested ini

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. The blocks used to be formatted using the "default" behavior, and would thus be mistaken for function calls followed by blocks: this could lead to unexpected inlining of the block and extra line-break before the opening b

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/index/Index.h:129 // - // A C++ symbol could have multiple declarations and one definition (e.g. - // a function is declared in ".h" file, and i

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

Typz added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1130 +if (FormatTok->Tok.is(tok::l_brace)) { + if (Style.BraceWrapping.AfterObjCDeclaration) +addUnwrappedLine(); Wondering if formatting with this style is ap

r324721 - Fif for an issue when Clang permits assignment to vector/extvector elements in a const method.

Author: avt77 Date: Fri Feb 9 01:30:42 2018 New Revision: 324721 URL: http://llvm.org/viewvc/llvm-project?rev=324721&view=rev Log: Fif for an issue when Clang permits assignment to vector/extvector elements in a const method. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/lib/Sema/

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 added a comment. Committed revision 324721. BTW, could you review https://reviews.llvm.org/D42728: it's rather similar to this one and rather small as well. https://reviews.llvm.org/D42530 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

ilya-biryukov added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; MaskRay wrote: > ilya-biryukov wrote: > > MaskRay wrote: > > > ilya-biryukov wrote: > > > > Why do we need to store both `CXIdxEntity

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric accepted this revision. ioeric added a comment. Lg Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance &CI) override { +const aut

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D42684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. In https://reviews.llvm.org/D42787#1000687, @krasimir wrote: > We could adapt the single-argument version instead, turning: > > foo(bb + > c); > > > into: > > foo(bb + > c); > We could inde

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added inline comments. Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:261 + +} //namespace Nit: this should be `// namespace clang` https://reviews.llvm.org/D5767 ___ cfe-commits mailing list

[clang-tools-extra] r324725 - [clangd] Remove threading-related code from ClangdUnit.h

Author: ibiryukov Date: Fri Feb 9 02:17:23 2018 New Revision: 324725 URL: http://llvm.org/viewvc/llvm-project?rev=324725&view=rev Log: [clangd] Remove threading-related code from ClangdUnit.h Reviewers: sammccall, hokein, ioeric Reviewed By: sammccall Subscribers: klimek, jkorous-apple, cfe-co

[PATCH] D43065: [clangd] Remove threading-related code from ClangdUnit.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL324725: [clangd] Remove threading-related code from ClangdUnit.h (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43065 Fi

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:646 } +} + Use either `LLVM_FALLTHROUGH;` here or break to avoid compiler warnings. https://reviews.llvm.org/D5767 ___ cf

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: martong. Looks good to me. Only found a few nits. Comment at: lib/AST/ASTImporter.cpp:4296 // Create the declaration that is being templa

[PATCH] D43075: [clang-move] Don't dump macro symbols.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Ooops, forgot to stamp! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43075 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus created this revision. Szelethus added reviewers: cfe-commits, xazax.hun. Szelethus added a project: clang-tools-extra. Herald added subscribers: hintonda, rnkovacs, mgorny. New checker called misc-throw-keyword-missing warns about cases where a temporary object's type is (likely) an ex

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. When the target object expression is short and the first selector name is long, clang-format used to break the colon alignment: [I performSelectorOnMainThread:@selector(loadAccessories) withObjec

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133589. Typz added a comment. fix type in commit message Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/Format

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:900 + std::max(NextNonComment->LongestObjCSelectorName, + unsigned(NextNonComment->TokenText.size())) - NextNonComment->ColumnWidth; I'd

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

krasimir added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:700 + "withObjectOnMainThread:nil\n" + " waitUntilDone:false];"); + } Could you add an instance where the first one is the longest

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

CarlosAlbertoEnciso added a comment. Hi @sdesmalen! First of all my apologies for commenting after the issue has been closed, but I do not have an account to add a comment to the associated bugzilla. I have found what it seems to be an issue with the current implementation. For the given test

[PATCH] D43122: [clangd] Fix crash when CompilerInvocation can't be created.

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: jkorous-apple, klimek. This can happen if the CompileCommand provided by compilation database is malformed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D431

[PATCH] D43122: [clangd] Fix crash when CompilerInvocation can't be created.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. just nits Comment at: clangd/ClangdUnit.cpp:417 } assert(CI && "Couldn't create CompilerInvocation"); remove? Comment at: un

[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

thakis added a comment. Nice! Test? https://reviews.llvm.org/D43110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

whisperity requested changes to this revision. whisperity added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:21 +void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) { + // This is a C++

[PATCH] D43123: [clangd] Log all ignored diagnostics.

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, hokein, sammccall. Herald added subscribers: jkorous-apple, klimek. To aid debugging failures and crashes. Only part of ignored diagnostics was logged before, now we log all of them. Repository: rCTE Clang Tools Extra

[PATCH] D43122: [clangd] Fix crash when CompilerInvocation can't be created.

ilya-biryukov updated this revision to Diff 133593. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Removed assert that is now redundant - Moved EXPECT_ERROR to Matchers.h - Added more context into EXPECT_ERROR's error message Repository: rCTE Clang Tools Extra

[clang-tools-extra] r324732 - [clangd] Fix crash when CompilerInvocation can't be created.

Author: ibiryukov Date: Fri Feb 9 05:51:57 2018 New Revision: 324732 URL: http://llvm.org/viewvc/llvm-project?rev=324732&view=rev Log: [clangd] Fix crash when CompilerInvocation can't be created. Summary: This can happen if the CompileCommand provided by compilation database is malformed. Revie

[PATCH] D43122: [clangd] Fix crash when CompilerInvocation can't be created.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324732: [clangd] Fix crash when CompilerInvocation can't be created. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43122

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

Szelethus added a comment. In https://reviews.llvm.org/D5767#1000347, @xazax.hun wrote: > In https://reviews.llvm.org/D5767#999143, @sabel83 wrote: > > > 2. What do you mean by regression tests? We have run the clang-test target > > successfully on the patched code (which has the hook). Note tha

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133595. ioeric marked 5 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133596. Typz marked 2 inline comments as done. Typz added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:900 + std::max(NextNonComment->LongestObjCSelectorName, + unsigned(NextNonComment->TokenText.size())) - NextNonComment->ColumnWidth; djasper

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric added a comment. Thanks! PTAL Comment at: clangd/ClangdServer.cpp:465 +auto &HeaderSearchInfo = Clang->getPreprocessor().getHeaderSearchInfo(); +std::string Suggested = HeaderSearchInfo.suggestPathToFileForDiagnostics( +*Resolved, CompileCommand.Directory

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus updated this revision to Diff 133597. Szelethus added a comment. Changes made according to @whisperity's comments. https://reviews.llvm.org/D43120 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowKeywordMissingCheck.cpp clang-tidy/m

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:32 + hasType(cxxRecordDecl( + isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION", + unless(anyOf(hasAn

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133599. ioeric added a comment. - fix a leftover bug Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Szelethus updated this revision to Diff 133600. Szelethus marked an inline comment as done. https://reviews.llvm.org/D43120 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowKeywordMissingCheck.cpp clang-tidy/misc/ThrowKeywordMissingCheck.h do

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

whisperity resigned from this revision. whisperity added a comment. Works for me but I haven't any sayings in these. 😇 https://reviews.llvm.org/D43120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added a comment. Thanks, will commit it after the commit of the LLVM part Repository: rC Clang https://reviews.llvm.org/D42581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D43124: Improve ObjC headers detection

jolesiak created this revision. jolesiak added a reviewer: benhamilton. Herald added subscribers: cfe-commits, klimek. Improve ObjC headers detection by adding additional keywords. Repository: rC Clang https://reviews.llvm.org/D43124 Files: lib/Format/Format.cpp Index: lib/Format/Format.

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D43121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek. LSP has asynchronous semantics, being able to block on an async operation completing is unneccesary and leads to tighter coupling with the threading. I

[PATCH] D43124: Improve ObjC headers detection

jolesiak updated this revision to Diff 133608. jolesiak added a comment. Add NSBundle. Repository: rC Clang https://reviews.llvm.org/D43124 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall updated this revision to Diff 133609. sammccall added a comment. Tidy up comment, and revert notify_all to notify_one - it was a red herring. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/TUSched

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:210 + BasicSymbol = addDeclaration(*ND, std::move(ID)); +if (Roles & static_cast(index::SymbolRole::Definition)) + addDefinition(*cast(ASTNode.O

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. Another example where pretty-printing the AST gives better results: int x, y = 5, z = 6; Hover the `z` will now show `int z = 6`, before it would have shown `int x, y = 5, z = 6`. I think new version is better because it only shows the variable we care about. Repos

[clang-tools-extra] r324735 - [clangd] Collect definitions when indexing.

Author: sammccall Date: Fri Feb 9 06:42:01 2018 New Revision: 324735 URL: http://llvm.org/viewvc/llvm-project?rev=324735&view=rev Log: [clangd] Collect definitions when indexing. Within a TU: - as now, collect a declaration from the first occurrence of a symbol (taking clang's canonical decl

[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42942?vs=133502&id

[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D42942?vs=133502&id=133613#toc Repository: rL LLVM htt

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 updated this revision to Diff 133614. https://reviews.llvm.org/D5767 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h include/clang/FrontendTool/Utils.h include/clang/Sema/Sema.h include/clang/Sema/Temp

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, this looks good to me! I will try this out soon and commit after that. https://reviews.llvm.org/D5767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

sammccall updated this revision to Diff 133615. sammccall added a comment. rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/TUScheduler.cpp clangd/TUScheduler.h clangd/Threading.cpp clangd/Thread

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

CarlosAlbertoEnciso added a comment. Hi @sdesmalen! For the following test case int main() { int size = 2; int var[size]; var[1] = 1; return 0; } I compared the DWARF generated by GCC and it looks like DW_TAG_variable "var" DW_AT_location ... DW_AT_type DW_F

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. The only problem I see is that when hovering a function name, it now prints the whole function definition. When talking with @malaperle, he told me that you had discussed it before and we should not have the definition in the hover, just the prototype. Glancing quickly

[clang-tools-extra] r324736 - [clangd] Fix crash in tests in debug mode.

Author: ibiryukov Date: Fri Feb 9 07:11:07 2018 New Revision: 324736 URL: http://llvm.org/viewvc/llvm-project?rev=324736&view=rev Log: [clangd] Fix crash in tests in debug mode. Caused by the lack of checking of an Expected value in the previous commit. Modified: clang-tools-extra/trunk/uni

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

sammccall added a comment. Insertion side LGTM, feel free to split and land. Sorry I need to take off and will need to get to indexing on monday :( Comment at: clangd/ClangdServer.cpp:368 +/// Calculates the shortest possible include path when inserting \p Header to \p +///

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

Hahnfeld added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D42840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. In https://reviews.llvm.org/D35894#1003342, @simark wrote: > The only problem I see is that when hovering a function/struct name, it now > prints the whole function/struct definition. When talking with @malaperle, > he told me that you had discussed it before and we sho

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman added a comment. One concern I have is with RAII objects with "exception" in the name. You may already properly handle this, but I'd like to see a test case like: struct ExceptionRAII { ExceptionRAII() {} ~ExceptionRAII() {} }; void foo() { ExceptionRAII E; //

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133619. Typz added a comment. rebase on latest master. Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTe

r324741 - clang-format: keep ObjC colon alignment with short object name

Author: typz Date: Fri Feb 9 07:41:56 2018 New Revision: 324741 URL: http://llvm.org/viewvc/llvm-project?rev=324741&view=rev Log: clang-format: keep ObjC colon alignment with short object name Summary: When the target object expression is short and the first selector name is long, clang-format u

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

This revision was automatically updated to reflect the committed changes. Closed by commit rC324741: clang-format: keep ObjC colon alignment with short object name (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D43121?vs=133619&id=133620#toc Repository:

[PATCH] D43124: [clang-format] Improve ObjC headers detection

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. testcase Repository: rC Clang https://reviews.llvm.org/D43124 __

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

benhamilton added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1130 +if (FormatTok->Tok.is(tok::l_brace)) { + if (Style.BraceWrapping.AfterObjCDeclaration) +addUnwrappedLine(); Typz wrote: > Wondering if formatting

[PATCH] D43075: [clang-move] Don't dump macro symbols.

hokein updated this revision to Diff 133621. hokein marked an inline comment as done. hokein added a comment. Add more tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43075 Files: clang-move/ClangMove.cpp unittests/clang-move/ClangMoveTests.cpp Index: unittests/clan

[clang-tools-extra] r324742 - [clang-move] Don't dump macro symbols.

Author: hokein Date: Fri Feb 9 07:57:30 2018 New Revision: 324742 URL: http://llvm.org/viewvc/llvm-project?rev=324742&view=rev Log: [clang-move] Don't dump macro symbols. Reviewers: ioeric Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D43075 Modified: cl

[PATCH] D43075: [clang-move] Don't dump macro symbols.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:526 unless(usingDirectiveDecl()), // using namespace decl. + notInMacro(), InOldHeader, ioeric wrote: > I'd probably relax the condition a bit; theoretically tools would be able

[PATCH] D43075: [clang-move] Don't dump macro symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324742: [clang-move] Don't dump macro symbols. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D43075?vs=133621&id=133623#toc Repository: rCTE Clang Tools Ext

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

Typz added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1130 +if (FormatTok->Tok.is(tok::l_brace)) { + if (Style.BraceWrapping.AfterObjCDeclaration) +addUnwrappedLine(); benhamilton wrote: > Typz wrote: > > Wonderin

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

a.sidorin marked 2 inline comments as done. a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:4296 // Create the declaration that is being templated. - SourceLocation StartLoc = Importer.Import(DTemplated->getLocStart()); - SourceLocation IdLoc = Importer.

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

a.sidorin updated this revision to Diff 133626. a.sidorin marked an inline comment as done. a.sidorin added a comment. Fix style issues found on review. Repository: rC Clang https://reviews.llvm.org/D43012 Files: lib/AST/ASTImporter.cpp test/ASTMerge/var-cpp/Inputs/var1.cpp test/ASTMer

r324748 - AMDGPU: Update for datalayout change

Author: arsenm Date: Fri Feb 9 08:58:41 2018 New Revision: 324748 URL: http://llvm.org/viewvc/llvm-project?rev=324748&view=rev Log: AMDGPU: Update for datalayout change Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/trunk/test/CodeGen/target-data.c cfe/trunk/test/CodeGenOpenCL/

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

aprantl created this revision. aprantl added reviewers: bruno, jingham. LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the -fmodule-cache-path. This patch makes the clang driver code accessible to LLDB. https://reviews.llvm.org/D43128 Files: incl

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133632. MaskRay added a comment. Bring back refkind: Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133635. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

ioeric added inline comments. Comment at: clangd/ClangdServer.cpp:368 +/// Calculates the shortest possible include path when inserting \p Header to \p +/// File, by matching \p Header against all include search directories for \p sammccall wrote: > ioeric wro

[PATCH] D42969: [Sema] Fix decltype of static data members

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This LGTM. Thanks for fixing this. Wait a couple of days before committing in case there are other comments. https://reviews.llvm.org/D42969 ___

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz added a comment. ping? Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-throw-keyword-missing.rst:6 + +This check warns about the potentially missing `throw` keyword. If a temporary object is created, +but the object's type derives from (or the same as) a class that has '

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:24 + + auto CtorInitializerList = + cxxConstructorDecl(hasAnyConstructorInitializer(anything())); Please don't use auto where type could not be easily deduced.

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ThrowKeywordMissingCheck.cpp:24 + + auto CtorInitializerList = + cxxConstructorDecl(hasAnyConstructorInitializer(anything())); Eugene.Zelenko wrote: > Please don't use auto where type could no

[PATCH] D43098: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output

This revision was automatically updated to reflect the committed changes. Closed by commit rC324759: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https

r324759 - [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output

Author: george.karpenkov Date: Fri Feb 9 10:39:47 2018 New Revision: 324759 URL: http://llvm.org/viewvc/llvm-project?rev=324759&view=rev Log: [analyzer] [tests] [NFC] Remove a fragile tightly-coupled component emulating parser output ...when we can just use the real parser instead. Differentia

r324761 - Introduce an API for LLDB to compute the default module cache path

Author: adrian Date: Fri Feb 9 10:43:10 2018 New Revision: 324761 URL: http://llvm.org/viewvc/llvm-project?rev=324761&view=rev Log: Introduce an API for LLDB to compute the default module cache path LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the -

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rL324761: Introduce an API for LLDB to compute the default module cache path (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

lebedev.ri added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:46 + + static const llvm::StringMap Mapping{ +// [simd.alg] I think you can use `llvm::StringRef` here instead of `std::string` Comment at: clang-

r324762 - [analyzer] [tests] Fixing an error after non-atomic cherry-pick

Author: george.karpenkov Date: Fri Feb 9 10:48:31 2018 New Revision: 324762 URL: http://llvm.org/viewvc/llvm-project?rev=324762&view=rev Log: [analyzer] [tests] Fixing an error after non-atomic cherry-pick Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpR

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 133660. bsdjhb added a comment. - Rebase. - Rework ABI macro checks. Repository: rUNW libunwind https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp src/UnwindRegistersRestore.S src/U

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb marked 7 inline comments as done. bsdjhb added a comment. Nice sleuthing! Repository: rUNW libunwind https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

george.karpenkov added a comment. Python code looks OK to me, I have one last request: could we have a small documentation how the whole thing is supposed work in integration, preferably on an available open-source project any reader could check out? I am asking because I have actually tried and

r324765 - Remove "CHECK: entry" in test case.

Author: ahatanak Date: Fri Feb 9 11:25:31 2018 New Revision: 324765 URL: http://llvm.org/viewvc/llvm-project?rev=324765&view=rev Log: Remove "CHECK: entry" in test case. rdar://problem/37397814 Modified: cfe/trunk/test/CodeGenObjCXX/trivial_abi.mm Modified: cfe/trunk/test/CodeGenObjCXX/tri

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

efriedma added a comment. So you want int128_t for compiler-rt itself, so you can use the soft-float implementation, but you want to make int128_t opt-in to avoid the possibility of someone getting a link error trying to link code built with clang against libgcc.a? That seems a little convolut

[PATCH] D42745: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

sp4r74n-117 added a comment. I do not have commit access so it would be great if you could do it for me. Thanks. https://reviews.llvm.org/D42745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

  1   2   >