EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I agree with Marshall. This should define
`_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS` instead of
`_LIBCPP_BUILDING_LIBRARY`. Other than that, this LGTM.
Repository:
rCXXA libc++abi
Author: rsmith
Date: Wed Feb 7 14:25:16 2018
New Revision: 324537
URL: http://llvm.org/viewvc/llvm-project?rev=324537&view=rev
Log:
PR36055: fix computation of *-dependence in nested initializer lists.
When we synthesize an implicit inner initializer list when analyzing an outer
initializer list
dim added a comment.
FWIW, this allows me to build wine again for x86_64, without any crashes or
assertions. So that looks good, in any case.
Repository:
rC Clang
https://reviews.llvm.org/D43016
___
cfe-commits mailing list
cfe-commits@lists.llv
EricWF created this revision.
EricWF added reviewers: rsmith, majnemer, aaron.ballman, erik.pilkington,
bogner, ahatanak.
Libc++'s default allocator uses `__builtin_operator_new` and
`__builtin_operator_delete` in order to allow the calls to new/delete to be
ellided. However, libc++ now needs t
Author: rafael
Date: Wed Feb 7 15:04:06 2018
New Revision: 324539
URL: http://llvm.org/viewvc/llvm-project?rev=324539&view=rev
Log:
Don't try to use copy relocations with tls variables.
Should fix the lldb bot.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/test/CodeGen/dso
Author: erichkeane
Date: Wed Feb 7 15:04:38 2018
New Revision: 324540
URL: http://llvm.org/viewvc/llvm-project?rev=324540&view=rev
Log:
[NFCi] Replace a couple of usages of const StringRef& with StringRef
No sense passing these by reference when a copy is about as free, and
saves on potential in
compnerd updated this revision to Diff 133319.
compnerd edited the summary of this revision.
compnerd added a comment.
Address comments from @rjmccall
Repository:
rC Clang
https://reviews.llvm.org/D42614
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenObjCXX/msabi-objc-extensions.mm
tes
compnerd added a comment.
@rjmccall, I've updated the approach and no longer abuse the existing
decoration styles. This uses a custom namespace with artificial types to
differentiate the types. I've also ensured that the parameter types do not
encode the type information.
Repository:
rC C
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
- bool
rsmith added a comment.
I defined `_LIBCPP_BUILDING_LIBRARY` instead to match the existing code in
libc++abi (stdlib_exception.cpp, stdlib_new_delete.cpp), which uses the
`_BUILDING_LIBRARY` macro as a general way to say "give me all the symbols
because I'm building the library". That seemed to
Author: rsmith
Date: Wed Feb 7 15:23:23 2018
New Revision: 324542
URL: http://llvm.org/viewvc/llvm-project?rev=324542&view=rev
Log:
Fix compilation in C++17 mode.
C++17 removes `std::unexpected_handler`, but libc++abi needs it to define
`__cxa_exception`. When building against libc++, this is ea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324542: Fix compilation in C++17 mode. (authored by rsmith,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42987?vs=133089&id=133323#toc
Rep
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
Since we've implemented P0600, I believe that this patch is out of date.
The correct macro is `_LIBCPP_NODISCARD_AFTER_CXX17`, and I think that several
of these cases are no
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me, but I think you should include your explanatory comments
in the commit message to the comment itself to help future violators of the
assertion out!
Author: ericwf
Date: Wed Feb 7 15:50:25 2018
New Revision: 324545
URL: http://llvm.org/viewvc/llvm-project?rev=324545&view=rev
Log:
Fix size and alignment of array.
An array T[1] isn't necessarily the same say when it's
a member of a struct. This patch addresses that problem and corrects
the tes
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
SGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
stephanemoore accepted this revision.
stephanemoore added a comment.
Pretty unanimous from the Google style arbitration side. Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D42708
___
cfe-commits mailing list
cfe-commits@lists.ll
bsdjhb updated this revision to Diff 10.
bsdjhb added a comment.
- Add a test case.
Repository:
rC Clang
https://reviews.llvm.org/D42972
Files:
lib/Driver/ToolChains/FreeBSD.cpp
test/Driver/freebsd.c
Index: test/Driver/freebsd.c
=
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This covers temporary constructors for which a destructor is necessary. It is
necessary to support `CXXTemporaryObjectExpr` here, which is a
Author: rafael
Date: Wed Feb 7 17:17:26 2018
New Revision: 324552
URL: http://llvm.org/viewvc/llvm-project?rev=324552&view=rev
Log:
Add a testcase for PR36268.
Added:
cfe/trunk/test/CodeGenObjC/availability-dso-local.m
Added: cfe/trunk/test/CodeGenObjC/availability-dso-local.m
URL:
http://
jakehehrlich added a comment.
After the comments I just made are resolved, I'm fine with the low level
details of the parts of this change that are here
Comment at: clang-doc/ClangDoc.cpp:47
+
+comments::FullComment *ClangDocCallback::getComment(const NamedDecl *D) {
+ RawCom
Author: benhamilton
Date: Wed Feb 7 17:49:10 2018
New Revision: 324553
URL: http://llvm.org/viewvc/llvm-project?rev=324553&view=rev
Log:
[clang-format] Set ObjCBinPackProtocolList to Never for google style
Summary:
This is split off from D42650, and sets ObjCBinPackProtocolList
to Never for the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324553: [clang-format] Set ObjCBinPackProtocolList to Never
for google style (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42708?vs=132189&id=133349#toc
R
NoQ added a comment.
I poked Devin offline and we agreed that the overall approach is good to go.
Maxim, thank you for picking it up!
We still don't have scopes for segments of code that don't have any variables
in them, so i guess it's not yet in the shape where it is super useful for
loops,
NoQ added a reviewer: rsmith.
NoQ added a subscriber: rsmith.
NoQ added a comment.
Added @rsmith because we're trying to give him a heads up every time large CFG
changes are coming, because if we mess up it would affect not only the analyzer
but the whole compiler through analysis-based compiler
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, craig.topper.
Herald added subscribers: fedor.sergeev, kbarton, aheejin, jgravelle-google,
sbc100, nhaehnle, nemanjai, sdardis, dylanmckay, jyknight, dschuff, jfb.
A followup to: https://reviews.ll
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
-
EricWF added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
- bool
smeenai added a comment.
LGTM, but I'd like @majnemer to take a look, since I'm not very familiar with
this code.
https://reviews.llvm.org/D43033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
NoQ added a dependency: D43056: [CFG] [analyzer] Add construction context for
CXXBindTemporaryExpr..
Patch https://reviews.llvm.org/D43056 ad
EricWF updated this revision to Diff 133365.
EricWF added a comment.
@rsmith Is this the direction you were thinking?
I haven't updated the tests yet, but I wanted to make the other changes visible
earlier.
https://reviews.llvm.org/D43047
Files:
include/clang/Basic/Builtins.def
include/cl
simark updated this revision to Diff 133367.
simark added a comment.
Herald added subscribers: ioeric, jkorous-apple.
New version
Here's a new version of the patch, quite reworked. I scaled down the scope a
little bit to make it simpler (see commit log). We'll add more features later
on.
Repo
Author: marshall
Date: Wed Feb 7 21:47:40 2018
New Revision: 324566
URL: http://llvm.org/viewvc/llvm-project?rev=324566&view=rev
Log:
Improve a test. NFC
Modified:
libcxx/trunk/test/libcxx/memory/is_allocator.pass.cpp
Modified: libcxx/trunk/test/libcxx/memory/is_allocator.pass.cpp
URL:
htt
Author: marshall
Date: Wed Feb 7 22:34:03 2018
New Revision: 324569
URL: http://llvm.org/viewvc/llvm-project?rev=324569&view=rev
Log:
Implement deduction guide for basic_string as described in P0433
Added:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc.fail.cpp
Modified:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D42614#1001279, @compnerd wrote:
> @rjmccall, I've updated the approach and no longer abuse the existing
> decoration styles. This uses a custom namespace with
Author: marshall
Date: Wed Feb 7 23:20:45 2018
New Revision: 324573
URL: http://llvm.org/viewvc/llvm-project?rev=324573&view=rev
Log:
Temporarily comment out deduction guide tests while I figure out what to do
with old bots
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/it
martell updated this revision to Diff 133374.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D41597
Files:
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
===
--- i
martell added a comment.
Updated to just ignore the flag just like how clang-cl does for /bigobj
Repository:
rC Clang
https://reviews.llvm.org/D41597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: ibiryukov
Date: Wed Feb 7 23:37:35 2018
New Revision: 324575
URL: http://llvm.org/viewvc/llvm-project?rev=324575&view=rev
Log:
Resubmit "[clangd] The new threading implementation"
Initially submitted as r324356 and reverted in r324386.
This change additionally contains a fix to crashes
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
101 - 140 of 140 matches
Mail list logo