vitalybuka added a comment.
In https://reviews.llvm.org/D42995#125, @tejohnson wrote:
> > Empty ThinLTOIndexFile signals that we don't need this module during
> > linking.
>
> Not the only case actually. We now also pass an empty index file when we want
> to compile the bitcode down to obje
yvvan added a comment.
ping...
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samparker added a comment.
No tests?
Repository:
rC Clang
https://reviews.llvm.org/D42978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 133164.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
On Wed, Feb 7, 2018 at 8:01 AM, Saleem Abdulrasool via cfe-commits
wrote:
> On Tue, Feb 6, 2018 at 5:55 PM, Saleem Abdulrasool via cfe-commits
> wrote:
>>
>> Author: compnerd
>> Date: Tue Feb 6 17:55:08 2018
>> New Revision: 324439
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=324439&view=r
devnexen added a comment.
None of the possible solutions are ideal, but I think I chose the least complex
(e.g. via analyzer-config), less edgy one, and 4 is the most common value I ve
found so far for PROT_EXEC.
Repository:
rC Clang
https://reviews.llvm.org/D42645
__
vitalybuka added a comment.
In https://reviews.llvm.org/D42995#1000155, @vitalybuka wrote:
> In https://reviews.llvm.org/D42995#125, @tejohnson wrote:
>
> > > Empty ThinLTOIndexFile signals that we don't need this module during
> > > linking.
> >
> > Not the only case actually. We now also p
hokein added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67
+ // XXX this is just to make running the tool fast during dev!
+ bool BeginInvocation(CompilerInstance &CI) override {
+const auto &Inputs = CI.getInvocation()
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43009
Files:
clangd/URI.cpp
unittests/clangd/URITests.cpp
Index: unittests/clangd/URITests.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324469: [clang-format] Fix ObjC message arguments
formatting. (authored by jolesiak, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42493
Files:
yvvan added reviewers: ilya-biryukov, bkramer, arphaman.
yvvan added a comment.
Looks ok-ish, I haven't built it though.
Also I don't have much exp with indexing part of libclang. Adding more
reviewers.
Repository:
rC Clang
https://reviews.llvm.org/D42895
_
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, szepet, jingham.
Herald added a subscriber: rnkovacs.
Also minor refactoring in related functions was done.
Repository:
rC Clang
https://reviews.llvm.org/D43012
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/var-cpp/Inp
xazax.hun added a comment.
In https://reviews.llvm.org/D5767#999143, @sabel83 wrote:
> 2. What do you mean by regression tests? We have run the clang-test target
> successfully on the patched code (which has the hook). Note that the hook
> this pull request provides is implemented as a ProgramA
filcab created this revision.
filcab added reviewers: rjmccall, kcc, rsmith.
The C++ Itanium ABI says:
No cookie is required if the new operator being used is ::operator
new[](size_t, void*).
This commit adds a flag to tell clang to poison all operator new[]
cookies.
A previous review was poiso
nik added a comment.
Ping...
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping^3
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Wed Feb 7 04:12:06 2018
New Revision: 324475
URL: http://llvm.org/viewvc/llvm-project?rev=324475&view=rev
Log:
[clangd] Do not precent-encode numbers in URI.
Reviewers: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits, sammccall
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324475: [clangd] Do not precent-encode numbers in URI.
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43009
Files:
clang-
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26
+
+ static const llvm::StringMap Mapping{
+// [simd.alg]
You probably want to move `Mapping` out of the function.
Comment at: clang-tidy/readab
Typz created this revision.
Typz added reviewers: djasper, krasimir, klimek.
This option replaces the BreakBeforeInheritanceComma option with an
enum, thus introducing a mode where the colon stays on the same line as
constructor declaration:
// When it fits on line:
class A : public B, public
belickim created this revision.
Herald added a subscriber: cfe-commits.
This patch is a fix for following issue:
https://bugs.llvm.org/show_bug.cgi?id=31362
The problem was caused by front end lowering C calling conventions without
taking into account calling conventions enforced by __attribute_
sepavloff created this revision.
sepavloff added reviewers: akyrtzi, rnk.
This change cleans up uses of malloc/calloc/realloc. In the case where
the return value is not checked agains null pointer, the call to
'std::malloc' is replaced by 'llvm::malloc', which reports fatal error
on allocation fai
ioeric updated this revision to Diff 133202.
ioeric added a comment.
- Added tests for IncludeURI and CanonicalIncludes and minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42640
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
ioeric updated this revision to Diff 133203.
ioeric added a comment.
- Merge with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42640
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComple
Typz updated this revision to Diff 133204.
Typz added a comment.
Fix indentation of inheritance list, which is actually based on
`ConstructorInitializerIndentWidth`.
Maybe a new option (`InheritanceListIndentWidth`) should be used instead?
Repository:
rC Clang
https://reviews.llvm.org/D4301
fhahn added a reviewer: rengolin.
fhahn added a comment.
I like the idea. However for all backends, except Arm and AArch64, we would
have to maintain another list of CPU names. At least for the targets which
implement `isValidCPUName`, we could add an array with valid names and use
that. That'
Author: wizard
Date: Tue Feb 6 13:40:38 2018
New Revision: 324407
URL: http://llvm.org/viewvc/llvm-project?rev=324407&view=rev
Log:
Support special acronyms inside property names and allow plural forms
Reviewers: benhamilton, hokein
Reviewed By: benhamilton, hokein
Subscribers: klimek, cfe-com
fhahn added a comment.
Also with tests for each backend, this diff will get quite big. As this is
opt-in, it might make sense to enable backends separately.
Repository:
rC Clang
https://reviews.llvm.org/D42978
___
cfe-commits mailing list
cfe-co
Author: jolesiak
Date: Wed Feb 7 02:35:08 2018
New Revision: 324469
URL: http://llvm.org/viewvc/llvm-project?rev=324469&view=rev
Log:
[clang-format] Fix ObjC message arguments formatting.
Summary:
Fixes formatting of ObjC message arguments when inline block is a first
argument.
Having inline bl
thakis added a comment.
Herald added a subscriber: llvm-commits.
What's the status here?
Repository:
rL LLVM
https://reviews.llvm.org/D36191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
thakis added a comment.
Err sorry, landed in https://reviews.llvm.org/rL310382.
Repository:
rL LLVM
https://reviews.llvm.org/D36191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson added a comment.
In https://reviews.llvm.org/D42995#1000155, @vitalybuka wrote:
> In https://reviews.llvm.org/D42995#125, @tejohnson wrote:
>
> > > Empty ThinLTOIndexFile signals that we don't need this module during
> > > linking.
> >
> > Not the only case actually. We now also pa
grokos created this revision.
grokos added a reviewer: ABataev.
grokos added projects: clang, OpenMP.
Herald added a subscriber: guansong.
This patch implements CodeGen support for the "declare target" directive.
Code is generated for variables, functions and ctors/dtors.
I understand that the p
Author: chill
Date: Wed Feb 7 08:52:02 2018
New Revision: 324490
URL: http://llvm.org/viewvc/llvm-project?rev=324490&view=rev
Log:
[DebugInfo] Improvements to representation of enumeration types (PR36168)
This patch:
* fixes an incorrect sign-extension of unsigned values, when emitting
debug
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324490: [DebugInfo] Improvements to representation of
enumeration types (PR36168) (authored by chill, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324490: [DebugInfo] Improvements to representation of
enumeration types (PR36168) (authored by chill, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D42736
Files:
lib/CodeGen/CGDebugIn
krasimir added a comment.
We could adapt the single-argument version instead, turning:
foo(bb +
c);
into:
foo(bb +
c);
Repository:
rC Clang
https://reviews.llvm.org/D42787
___
MaskRay updated this revision to Diff 133233.
MaskRay marked 2 inline comments as done.
MaskRay added a comment.
Fix word order of readability-simd-intrinsics
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readab
ABataev added a comment.
It is impossible to understand what is going on here. We need to discuss this
before even reviewing of this patch.
Comment at: lib/CodeGen/CGCXXABI.h:543
+ llvm::GlobalVariable *DeclPtr, bool PerformInit,
+
ilya-biryukov added inline comments.
Comment at: include/clang-c/Index.h:6159
+ */
+ CXSymbolRole role;
} CXIdxEntityRefInfo;
Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can we
store just `CXSymbolRole`?
Is this for compatibility wi
MaskRay updated this revision to Diff 133237.
MaskRay added a comment.
Add check-specific option `Experimental`
StringRef Std;
if (Result.Context->getLangOpts().CPlusPlus2a) {
Std = "std";
} else if (Result.Context->getLangOpts().CPlusPlus11 && Experimental) {
// libcxx implementati
MaskRay updated this revision to Diff 133239.
MaskRay added a comment.
Use unnamed namespace to enclose AST_MATCHER and TrySuggest*
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule
mclow.lists added a comment.
This all looks good to me.
I think that one more test should be added - and that's one that tests `__sqr`
directly.
Since that's not a public routine, the test should go in
"test/libcxx/numerics/complex.number"
https://reviews.llvm.org/D41629
___
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
-
MaskRay marked 3 inline comments as done.
MaskRay added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26
+
+ static const llvm::StringMap Mapping{
+// [simd.alg]
lebedev.ri wrote:
> You probably want to move `Mapping` out of the
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77
+void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+
callExpr(callee(functionDecl(matchesName("^::(_mm_|_mm256_|_mm512_|vec_)"))),
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM.
Comment at: include/valarray:3728
+{
+__clear();
if (__n)
I thought that you had lost an exception guarantee here, but it turns
espindola added a comment.
Ping.
https://reviews.llvm.org/D42924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
Comment at: include/clang-c/Index.h:6159
+ */
+ CXSymbolRole role;
} CXIdxEntityRefInfo;
ilya-biryukov wrote:
> Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can
EricWF marked 5 inline comments as done.
EricWF added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:3269-3274
+ const bool IsAssertBuild =
#ifdef NDEBUG
- CmdArgs.push_back("-disable-llvm-verifier");
- // Discard LLVM value names in -asserts builds.
- CmdArgs.
EricWF updated this revision to Diff 133251.
EricWF marked an inline comment as done.
EricWF added a comment.
- Fix documentation as requested.
- Put entire statement inside of `#ifdef` blocks.
https://reviews.llvm.org/D42887
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
lib
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm guessing things were structured this way so that a function definition
could have its visibility set before giving it a body, i.e. it would look like
a declaration, but the visibility shou
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D42887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: ericwf
Date: Wed Feb 7 10:36:51 2018
New Revision: 324498
URL: http://llvm.org/viewvc/llvm-project?rev=324498&view=rev
Log:
[Driver] Add option to manually control discarding value names in LLVM IR.
Summary:
Currently, assertion-disabled Clang builds emit value names when generating
LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324498: [Driver] Add option to manually control discarding
value names in LLVM IR. (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42887
Files:
docs/UsersManual.r
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D43017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
MaskRay updated this revision to Diff 133255.
MaskRay marked an inline comment as done.
MaskRay added a comment.
readability-simd-intrinsics.rst
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabil
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
These ABIInfo classes don't have any state, so just building one on the stack
as needed is the way to go. Thanks for the fix!
Repository:
rC Clang
https://reviews.llvm.org/D43016
__
Author: rafael
Date: Wed Feb 7 11:04:41 2018
New Revision: 324499
URL: http://llvm.org/viewvc/llvm-project?rev=324499&view=rev
Log:
Don't pass ForDefinition_t in places it is redundant.
I found this while looking at the ppc failures caused by the dso_local
change.
The issue was that the patch w
espindola closed this revision.
espindola added a comment.
r324499
https://reviews.llvm.org/D42924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
MaskRay wrote:
> lebedev.r
Author: rafael
Date: Wed Feb 7 11:16:49 2018
New Revision: 324500
URL: http://llvm.org/viewvc/llvm-project?rev=324500&view=rev
Log:
Recommit r324107.
It now includes a fix to not mark available_externally definitions as
dso_local.
Original message:
Start setting dso_local in clang.
This start
Author: ericwf
Date: Wed Feb 7 11:17:03 2018
New Revision: 324501
URL: http://llvm.org/viewvc/llvm-project?rev=324501&view=rev
Log:
Fix r324498: the commit removed the '-' before the disable-llvm-verifier flag
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Drive
rnk created this revision.
rnk added reviewers: smeenai, majnemer.
Herald added a subscriber: eraman.
Fixes PR36247, which is where WinEHPrepare replaces inline asm in
funclets with unreachable.
Make getBundlesForFunclet return by value to simplify some call sites.
https://reviews.llvm.org/D430
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
timshen wrote:
> MaskRa
Author: marshall
Date: Wed Feb 7 11:24:37 2018
New Revision: 324503
URL: http://llvm.org/viewvc/llvm-project?rev=324503&view=rev
Log:
Comment on 'Review' issues
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llv
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
dschuff, jfb.
Repository:
rC Clang
https://reviews.llvm.org/D43035
Files:
include/clang/Basic/TargetCXXABI.h
lib/Basic/Targets.cpp
lib/Basic/Targets/WebAssembly.cpp
lib/CodeGen/CGB
Author: rafael
Date: Wed Feb 7 11:44:15 2018
New Revision: 324505
URL: http://llvm.org/viewvc/llvm-project?rev=324505&view=rev
Log:
Revert "Recommit r324107."
This reverts commit r324500.
The bots found two failures:
ThreadSanitizer-x86_64 :: Linux/pie_no_aslr.cc
ThreadSanitizer-x86_64
Author: george.karpenkov
Date: Wed Feb 7 11:56:52 2018
New Revision: 324507
URL: http://llvm.org/viewvc/llvm-project?rev=324507&view=rev
Log:
[analyzer] [NFC] Factor out generating path diagnostics for a statement into a
function
Differential Revision: https://reviews.llvm.org/D42558
Modified:
Author: chill
Date: Wed Feb 7 11:57:04 2018
New Revision: 324508
URL: http://llvm.org/viewvc/llvm-project?rev=324508&view=rev
Log:
Revert [DebugInfo] Improvements to representation of enumeration types
(PR36168)"
Revert due to breaking buildbots (LLDB tests)
Removed:
cfe/trunk/test/CodeGen
rjmccall added a comment.
I don't understand why your description of this patch mentions the void*
placement new[] operator. There's no cookie to poison for that operator.
Repository:
rC Clang
https://reviews.llvm.org/D43013
___
cfe-commits mai
Author: arphaman
Date: Wed Feb 7 12:45:39 2018
New Revision: 324514
URL: http://llvm.org/viewvc/llvm-project?rev=324514&view=rev
Log:
[PR36008] Avoid -Wsign-compare warning for enum constants in
typeof expressions
This commit looks through typeof type at the original expression when diagnosing
-
Author: hans
Date: Wed Feb 7 12:46:26 2018
New Revision: 324519
URL: http://llvm.org/viewvc/llvm-project?rev=324519&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libcxxabi/tags/RELEASE_600/rc2/
- copied from r324518, libcxxabi/branches/release_60/
___
Author: hans
Date: Wed Feb 7 12:46:19 2018
New Revision: 324518
URL: http://llvm.org/viewvc/llvm-project?rev=324518&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libcxx/tags/RELEASE_600/rc2/ (props changed)
- copied from r324517, libcxx/branches/release_
SjoerdMeijer added a comment.
Thanks for fixing this. Looks very reasonable to me.
Question about the failures: I am now wondering if this means we were and still
are missing tests?
Nit: for future reviews, I think it is better to split patches up if they are
commits to
different repos.
htt
Author: hans
Date: Wed Feb 7 12:47:12 2018
New Revision: 324525
URL: http://llvm.org/viewvc/llvm-project?rev=324525&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libunwind/tags/RELEASE_600/rc2/
- copied from r324524, libunwind/branches/release_60/
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324514: [PR36008] Avoid -Wsign-compare warning for enum
constants in (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42
russellmcc updated this revision to Diff 133280.
russellmcc added a comment.
Responded to review feedback:
- Fix bug where `AllowAllArgumentsOnNextLine` overrode
`AllowAllParametersOfDeclarationOnNextLine`
- Add tests demonstrating independence of `AllowAllArgumentsOnNextLine` and
`AllowAllPara
russellmcc added a comment.
Thanks for the feedback! I'm very motivated to get some support for these
features since they are required for my style guide. Let me know if my recent
changes made sense to you.
Comment at: lib/Format/ContinuationIndenter.cpp:756
State
EricWF updated this revision to Diff 133285.
EricWF added a comment.
- Update with new, hopefully working, version.
https://reviews.llvm.org/D41223
Files:
include/__config
include/array
test/libcxx/containers/sequences/array/array.zero/db_back.pass.cpp
test/libcxx/containers/sequences/a
EricWF reopened this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This was reverted as it caused build failures. Re-opening with new version.
Repository:
rCXX libc++
https://reviews.llvm.org/D41223
___
cfe-co
Author: ericwf
Date: Wed Feb 7 13:06:13 2018
New Revision: 324526
URL: http://llvm.org/viewvc/llvm-project?rev=324526&view=rev
Log:
[libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default
constructible types.
Summary:
This patch fixes llvm.org/PR35491 and LWG2157
(https:/
EricWF accepted this revision.
EricWF added a comment.
Accepting new version.
https://reviews.llvm.org/D41223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX324526: [libc++] Fix PR35491 - std::array of zero-size
doesn't work with non-default… (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41223
Files:
include/__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324526: [libc++] Fix PR35491 - std::array of zero-size
doesn't work with non-default… (authored by EricWF, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
EricWF added a comment.
Ping.
https://reviews.llvm.org/D40218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Wed Feb 7 13:17:22 2018
New Revision: 324527
URL: http://llvm.org/viewvc/llvm-project?rev=324527&view=rev
Log:
[clang-import-test] Run clang-format, NFC
I ran across clang-import-test while looking into testing for lldb.
There shouldn't be any harm in running clang-format o
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, craig.topper.
A followup to: https://reviews.llvm.org/D42978
This patch adds X86 and X86_64 support for
enabling the march notes.
Repository:
rC Clang
https://reviews.llvm.org/D43041
Files:
EricWF updated this revision to Diff 133290.
EricWF added a comment.
- Rebase off master.
https://reviews.llvm.org/D40218
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
t
Author: ericwf
Date: Wed Feb 7 13:25:25 2018
New Revision: 324529
URL: http://llvm.org/viewvc/llvm-project?rev=324529&view=rev
Log:
Fix -verify static assert messages for older Clang versions
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.fill/fill.fail.cpp
libcxx/trunk
vitalybuka added a comment.
ping
https://reviews.llvm.org/D42680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 133294.
EricWF added reviewers: aaron.ballman, bogner, majnemer.
EricWF added a comment.
Ping.
- Rebase off trunk.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/
Author: marshall
Date: Wed Feb 7 13:30:17 2018
New Revision: 324531
URL: http://llvm.org/viewvc/llvm-project?rev=324531&view=rev
Log:
Fix PR#31454 - 'basic_string::push_back() crashes if sizeof(T)>sizeof(long
long)'. We were mishandling the small-string optimization calculations for very
large
scott.linder created this revision.
scott.linder added reviewers: aprantl, JDevlieghere.
Herald added a subscriber: cfe-commits.
scott.linder added a dependency: D43043: [DebugInfo] Unify ChecksumKind and
Checksum value in DIFile.
Update to match new DIFile API.
Repository:
rC Clang
https://
NoQ updated this revision to Diff 133299.
NoQ added a comment.
Remove the check in `shouldInlineCall()` as well. It's quite covered by the
`IsConstructorWithImproperlyModeledTargetRegion` check.
https://reviews.llvm.org/D42991
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine
Author: danalbert
Date: Wed Feb 7 13:58:48 2018
New Revision: 324534
URL: http://llvm.org/viewvc/llvm-project?rev=324534&view=rev
Log:
Stop using __strtonum_fallback on Android.
Fallback implementations are now provided by bionic when necessary,
which these may conflict with.
Modified:
libc
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, Hahnfeld.
Herald added a subscriber: jholewinski.
A followup to: https://reviews.llvm.org/D42978
This patch adds NVPTX support for
enabling the march notes.
Repository:
rC Clang
https://reviews
kzhuravl added a comment.
Need to only define canonical names.
https://reviews.llvm.org/D36802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman abandoned this revision.
arphaman added subscribers: dcoughlin, dexonsmith.
arphaman added a comment.
Thanks for your input. You're right, this warning is quite correct (even though
it seems like too much).
I discussed this with @dexonsmith and @dcoughlin and we decided to keep the
wa
Author: rafael
Date: Wed Feb 7 14:15:33 2018
New Revision: 324535
URL: http://llvm.org/viewvc/llvm-project?rev=324535&view=rev
Log:
Recommit r324107 again.
The difference from the previous try is that we no longer directly
access function declarations from position independent executables. It
sh
1 - 100 of 140 matches
Mail list logo
