[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Yep, LGTM, thanks! https://reviews.llvm.org/D42863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42863 Files: lib/AST/ASTContext.cpp te

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. All right, so the code looks good now, but in order to commit this, we also need tests. We've got those automatic tests of ours in `test/Analysis/` that feed small code snippets into the analyzer and verify that it does (or doesn't) emit warnings in certain cases, so you'd

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me, although as I noted inline I think both the name and the comment for VisitForConstructionContext() are confusing. If you can be more precise I think it would help

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

Yeah, I'll write stuff up for them. On Fri, Feb 2, 2018 at 3:06 AM Hans Wennborg wrote: > Thanks! I've merged them to 6.0 as below and they will be part of rc2, > scheduled for next week. > > Chandler, do you want to write release notes for this? > > On Thu, Feb 1, 2018 at 8:09 PM, Chandler Carr

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:653 + // triggered by the given trigger. + void VisitForConstructionContext(Stmt *Trigger, Stmt *Child); + dcoughlin wrote: > I find the name of this method very confusing. It sounds like you are > vi

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson added a comment. @Hans if you're happy with this could you commit to the branch? Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r324142 - More documentation cleanup for Decl.h.

Author: jdennett Date: Fri Feb 2 13:38:22 2018 New Revision: 324142 URL: http://llvm.org/viewvc/llvm-project?rev=324142&view=rev Log: More documentation cleanup for Decl.h. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132685. NoQ added a comment. Rename the method, add comments. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h include/clang/StaticAnalyz

r324151 - Add missing direct-init / parameter-declaration-clause disambiguation when

Author: rsmith Date: Fri Feb 2 14:24:54 2018 New Revision: 324151 URL: http://llvm.org/viewvc/llvm-project?rev=324151&view=rev Log: Add missing direct-init / parameter-declaration-clause disambiguation when parsing a trailing-return-type of a (function pointer) variable declaration. Modified:

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); rsmith wrote: > Do we really need both of these qu

[libcxx] r324153 - Fix has_unique_object_representation after Clang commit r324134.

Author: ericwf Date: Fri Feb 2 14:39:59 2018 New Revision: 324153 URL: http://llvm.org/viewvc/llvm-project?rev=324153&view=rev Log: Fix has_unique_object_representation after Clang commit r324134. Clang previously reported an empty union as having a unique object representation. This was incorre

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); compnerd wrote: > erichkeane wrote: > > rsmith wrote: > > > erichkeane w

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. @sdardis Can you confirm if the existing N64 bits work fine for you or if the tests crash similarly? https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); erichkeane wrote: > compnerd wrote: > > erichkeane wrote: > > > rsmith wro

[PATCH] D41039: Add support for attribute "trivial_abi"

rsmith accepted this revision. rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:2240-2241 + enum TrivialityKind { +TK_NoTrivialABI, // The triviality of a method unaffected by "trivial_abi". +TK_TrivialABI // The triviality of a method affected by "tri

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

NoQ updated this revision to Diff 132699. NoQ added a comment. Rebase. Add direct tests, though one was already there since https://reviews.llvm.org/D42699 as a fixme. https://reviews.llvm.org/D42719 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore -fthinlto-index= for non-ThinLTO files

vitalybuka updated this revision to Diff 132701. vitalybuka added a comment. skip full LTO objects https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. PTAL https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132702. vitalybuka marked an inline comment as done. vitalybuka added a comment. comment https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/

r324160 - Fix crash when trying to pack-expand a GNU statement expression.

Author: rsmith Date: Fri Feb 2 16:44:57 2018 New Revision: 324160 URL: http://llvm.org/viewvc/llvm-project?rev=324160&view=rev Log: Fix crash when trying to pack-expand a GNU statement expression. We could in principle support such pack expansion, using techniques similar to what we do for pack

r324161 - [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

Author: george.karpenkov Date: Fri Feb 2 16:55:21 2018 New Revision: 324161 URL: http://llvm.org/viewvc/llvm-project?rev=324161&view=rev Log: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL We already suppress such reports for inline

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rC324161: [analyzer] Do not infer nullability inside function-like macros, even when… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

NoQ added a comment. Woohoo even better. Repository: rC Clang https://reviews.llvm.org/D42404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

NoQ updated this revision to Diff 132707. NoQ added a comment. Rebase. https://reviews.llvm.org/D42721 Files: include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index: lib/StaticAnalyzer/Core/ExprEngineCXX.c

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

eugenis created this revision. eugenis added a reviewer: kcc. https://reviews.llvm.org/D42874 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index: clang/docs/HardwareAssistedAddressSanitizerDesign.rst === --- clang

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM++ https://reviews.llvm.org/D42874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r324163 - [hwasan] Add a paragraph on stack instrumentation.

Author: eugenis Date: Fri Feb 2 17:06:21 2018 New Revision: 324163 URL: http://llvm.org/viewvc/llvm-project?rev=324163&view=rev Log: [hwasan] Add a paragraph on stack instrumentation. Reviewers: kcc Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D42874 Modified:

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324163: [hwasan] Add a paragraph on stack instrumentation. (authored by eugenis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42874?vs=1327

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

dblaikie accepted this revision. dblaikie added a comment. Few things that could tidy up the tests a bit, but otherwise looks good :) Comment at: test/CodeGen/debug-info-enum.cpp:6-10 +// CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, name: "E0" +// CHECK-SAME: flags: DI

Re: r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

This causes some stray diagnostics to be emitted in certian cases where a base class is already invalid: Reproducer: https://gist.github.com/EricWF/588a361030edeaebbbc1155b8347cab0 On Fri, Feb 2, 2018 at 1:40 AM, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryu

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This one's new, the analyzer didn't enjoy this before. This patch adds construction context for `ReturnStmt`, which means that we'd

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132713. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#996668, @NoQ wrote: > All right, so the code looks good now, but in order to commit this, we also > need tests. We've got those automatic tests of ours in `test/Analysis/` that > feed small code snippets into the analyzer and verify t

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

> On Jan 31, 2018, at 9:15 AM, Akira Hatanaka wrote: > > > >> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool > > wrote: >> >> Thanks for the note here. I’ll try to take a look at that, but, yes, the >> frontend change itself is correct. I’ve seen many, many

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. Wonderful! Could you also add a `// no-warning` kind of test, i.e. when the respective flags are not set, no warning is emitted? Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@l

[libcxx] r324164 - Work around Clang bug introduced in r324062

Author: ericwf Date: Fri Feb 2 17:45:35 2018 New Revision: 324164 URL: http://llvm.org/viewvc/llvm-project?rev=324164&view=rev Log: Work around Clang bug introduced in r324062 When Clang encounters an already invalid class declaration, it can emit incorrect diagnostics about the exception specif

[libcxx] r324165 - Work around GCC constexpr initialization bug

Author: ericwf Date: Fri Feb 2 17:48:21 2018 New Revision: 324165 URL: http://llvm.org/viewvc/llvm-project?rev=324165&view=rev Log: Work around GCC constexpr initialization bug Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.lex.comparison/lexicographical_compare_comp.pass.cpp M

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132715. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thanks! I'll commit. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added dependencies: D42875: [analyzer] Add construction context for ReturnStmt., D42779: [analyzer] NFC: Make sure we don't ever inline th

r324166 - [analyzer] Add a checker for mmap()s which are both writable and executable.

Author: dergachev Date: Fri Feb 2 18:33:42 2018 New Revision: 324166 URL: http://llvm.org/viewvc/llvm-project?rev=324166&view=rev Log: [analyzer] Add a checker for mmap()s which are both writable and executable. This is a security check which is disabled by default but will be enabled whenever t

[PATCH] D42645: New simple Checker for mmap calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC324166: [analyzer] Add a checker for mmap()s which are both writable and executable. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D42645?vs=132715&id=132719#

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

NoQ updated this revision to Diff 132720. NoQ added a comment. Add a test in which we return a variable. https://reviews.llvm.org/D42875 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp Index: test/Analysis/temp-obj-dtors-cfg

r324167 - Revert r324166 "[analyzer] Add a checker for mmap()...".

Author: dergachev Date: Fri Feb 2 19:57:32 2018 New Revision: 324167 URL: http://llvm.org/viewvc/llvm-project?rev=324167&view=rev Log: Revert r324166 "[analyzer] Add a checker for mmap()...". Due to Buildbot failures - most likely that's because target triples were not specified in the tests, ev

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. This failed on the buildbots (for example http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - committer gets notified of those), so i reverted it for now as r324167. I guess the reason is that buildbots have different triples, and even though you check the

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132727. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132728. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#997062, @NoQ wrote: > This failed on the buildbots (for example > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - > committer gets notified of those), so i reverted it for now as r324167. > > I guess the reason is

<    1   2