[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:3899 + if (auto *CE = const_cast(NE->getConstructExpr())) +CurrentConstructionContext = {/*Constructor=*/CE, /*Trigger=*/NE}; + dcoughlin wrote: > Is it possible that there is already a CurrentConst

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132476. NoQ marked 5 inline comments as done. NoQ added a comment. Address comments. Most importantly, separate out sema and analyzer CFG tests. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h

r324027 - [analyzer] [tests] [NFC] Remove dead code from CmpRuns

Author: george.karpenkov Date: Thu Feb 1 14:40:01 2018 New Revision: 324027 URL: http://llvm.org/viewvc/llvm-project?rev=324027&view=rev Log: [analyzer] [tests] [NFC] Remove dead code from CmpRuns Indeed, "CHANGE" is not a thing yet, and we should probably not carry around dead code which does n

[PATCH] D42819: [analyzer] [tests] [NFC] Remove dead code from CmpRuns

This revision was automatically updated to reflect the committed changes. Closed by commit rC324027: [analyzer] [tests] [NFC] Remove dead code from CmpRuns (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D4281

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

I backported these to the release_50 branch in the following revisions: llvm r324007, r324009 cfe r324012 lld r324025, r324026 The regression test suites pass on my machine with the exception of two pre-existing failures. I also built my small retpoline execution test that does a variety of indir

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( simark wrote: > ilya-biryukov wrote: > > simark wrote: > > > simark wrote: > > > > ilya-

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added a comment. In https://reviews.llvm.org/D42755#994775, @Hahnfeld wrote: > Can you please add a summary that describes which filesystem this problem can > be seen with? I think outside people can't access rdar tickets, so I can only > guess that it's related to APFS? Further guessin

[libcxx] r324033 - Disable test in C++<11 mode due to use of alignas.

Author: rsmith Date: Thu Feb 1 15:31:22 2018 New Revision: 324033 URL: http://llvm.org/viewvc/llvm-project?rev=324033&view=rev Log: Disable test in C++<11 mode due to use of alignas. Modified: libcxx/trunk/test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp Modified: libcxx/tru

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

probinson added a comment. +1 for testcase. Repository: rC Clang https://reviews.llvm.org/D42351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42343: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

EricWF updated this revision to Diff 132495. EricWF added a comment. I had to revert due to failing tests when using a non-assert Clang build. This change fixes those tests to no longer depend on label names. https://reviews.llvm.org/D42343 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCor

r324037 - [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

Author: ericwf Date: Thu Feb 1 15:47:54 2018 New Revision: 324037 URL: http://llvm.org/viewvc/llvm-project?rev=324037&view=rev Log: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object. Summary: Fix NRVO for Gro variable. Previously, we only marked the GRO declaration as an

[PATCH] D22505: clang-format Access Modifier Use Normal Indent

mithro added a comment. Herald added subscribers: hintonda, mgorny. I was wondering what the status of this feature was? Looks like it was last touched back in Aug 2 2016 -- do you know if a different or replacement patch was landed? I have a project (https://github.com/verilog-to-routing/vtr-v

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

kromanova added subscribers: kromanova, alexfh. kromanova added a comment. We have a request for this feature in clang-format in Sony. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF created this revision. EricWF added reviewers: erichkeane, aaron.ballman, majnemer. Previously, Clang only emitted label names in assert builds. However there is a CC1 option -discard-value-names that should have been used to control emission instead. This patch removes the NDEBUG

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rnk added a comment. In https://reviews.llvm.org/D42768#994458, @rjmccall wrote: > No, I mean things like `void foo(__attribute__((swiftcall)) void > (*fnptr)());`. Yeah, this was the example I was going to bring up. There's no function parameter declaration to put the NNS on. So, here's an

[PATCH] D42606: [Coroutines] Use allocator overload when available

GorNishanov requested changes to this revision. GorNishanov added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to the

[PATCH] D42606: [Coroutines] Use allocator overload when available

GorNishanov added inline comments. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to the coroutine frame allocation function. + auto *AllocateCall = cast(EmitScalarExpr(S.getAllocate

r324046 - [analyzer] Fix yet-another-crash in body-farming std::call_once

Author: george.karpenkov Date: Thu Feb 1 17:44:07 2018 New Revision: 324046 URL: http://llvm.org/viewvc/llvm-project?rev=324046&view=rev Log: [analyzer] Fix yet-another-crash in body-farming std::call_once Crash occurs when parameters to the callback and to std::call_once mismatch, and C++ is su

[PATCH] D42777: [analyzer] Fix yet-another-crash in body-farming std::call_once

This revision was automatically updated to reflect the committed changes. Closed by commit rC324046: [analyzer] Fix yet-another-crash in body-farming std::call_once (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132520. NoQ added a comment. Add more targeted tests. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h include/clang/StaticAnalyzer/Core/

r324049 - [analyzer] Expose exploration strategy through analyzer options.

Author: george.karpenkov Date: Thu Feb 1 18:01:55 2018 New Revision: 324049 URL: http://llvm.org/viewvc/llvm-project?rev=324049&view=rev Log: [analyzer] Expose exploration strategy through analyzer options. Differential Revision: https://reviews.llvm.org/D42774 Modified: cfe/trunk/include/c

[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

MTC added a comment. In https://reviews.llvm.org/D42785#995211, @NoQ wrote: > Ew. So it means that checker transitions are currently discarded. Great > catch. I guess we don't use this functionality yet, so we can't test it, but > the fix should definitely go in. You are right, that's why I d

r324050 - Remove the change which accidentally crept in into the cherry-pick

Author: george.karpenkov Date: Thu Feb 1 18:14:33 2018 New Revision: 324050 URL: http://llvm.org/viewvc/llvm-project?rev=324050&view=rev Log: Remove the change which accidentally crept in into the cherry-pick Modified: cfe/trunk/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp Modified: cfe/trun

r324052 - [analyzer] Expose return statement from CallExit program point

Author: george.karpenkov Date: Thu Feb 1 18:19:43 2018 New Revision: 324052 URL: http://llvm.org/viewvc/llvm-project?rev=324052&view=rev Log: [analyzer] Expose return statement from CallExit program point If the return statement is stored, we might as well allow querying against it. Also fix the

r324053 - [analyzer] Fix transitions in check::PreStmt checker callback.

Author: dergachev Date: Thu Feb 1 18:23:37 2018 New Revision: 324053 URL: http://llvm.org/viewvc/llvm-project?rev=324053&view=rev Log: [analyzer] Fix transitions in check::PreStmt checker callback. No in-tree checkers use this callback so far, hence no tests. But better fix this now than remembe

[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rL324053: [analyzer] Fix transitions in check::PreStmt checker callback. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D42800: Let CUDA toolchain support amdgpu target

gregrodgers requested changes to this revision. gregrodgers added a comment. This revision now requires changes to proceed. Thanks to everyone for the reviews. I hope I replied to all inline comments. Since I sent this to Sam to post, we discovered a major shortcoming. As tra points out, the

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd updated this revision to Diff 132528. compnerd added a comment. Handle the non-top-level decl case Repository: rC Clang https://reviews.llvm.org/D42768 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-swiftcall-cc.cpp Index: test/CodeGenCXX/msabi-swiftcall-cc.cpp ==

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added a comment. @rnk thats not a bad idea. However, I had implemented it slightly differently. I mangled it as if it was a PMF: so you get `__Swift::__swift_cc::*` as the type. Repository: rC Clang https://reviews.llvm.org/D42768 __

[PATCH] D42800: Let CUDA toolchain support amdgpu target

gregrodgers added a comment. Sorry, all my great inline comments got lost somehow. I am a newbie to Phabricator. I will try to reconstruct my comments. https://reviews.llvm.org/D42800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

stephanemoore added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132532. NoQ marked an inline comment as done. NoQ added a comment. Cleanup construction contexts after they have been consumed. Add assertions to verify that our understanding of the context's lifespan is reasonable. I will run the new mode on a large codebase b

r324059 - [MinGW] Emit typeinfo locally for dllimported classes without key functions

Author: mstorsjo Date: Thu Feb 1 22:22:35 2018 New Revision: 324059 URL: http://llvm.org/viewvc/llvm-project?rev=324059&view=rev Log: [MinGW] Emit typeinfo locally for dllimported classes without key functions This fixes building Qt as shared libraries with clang in MinGW mode; previously subcla

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL324059: [MinGW] Emit typeinfo locally for dllimported classes without key functions (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132538. massberg added a comment. Addressed comments of reviewers. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt clang-tidy/moder

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: test/clang-tidy/modernize-avoid-functional.cpp:30 + +// CHECK-MESSAGES: [[@LINE+1]]:25: warning: 'binary_function' is deprecated in C++11 and removed in C++17 [modernize-avoid-functional] +cla

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. LGTM. Repository: rC Clang https://reviews.llvm.org/D42811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans I'd like to have this in 6.0 as well, to allow building Qt for windows as DLLs. Repository: rL LLVM https://reviews.llvm.org/D42641 ___ cfe-commits mailing list cfe-commits@lists

<    1   2