[PATCH] D42552: [analyzer] dump() environment frame-by-frame.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Like this: Expressions by stack frame: #0 Calling bar at line 9 (0x7fbe2a60ea10,0x7fbe2b86ca30) x : 1 S32b #1 Calling foo (0x7fbe2a

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda requested review of this revision. hintonda added a comment. I probably should have put this in the summary, but the reason for this patch isn't just to clean up the cmake files, it's to fix a cmake configuration failure when cross-compiling for Linux on Darwin: CMake Error at /Users/

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

I don't really understand why, but our bots seemed to survive this: http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/ Console output is here: http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_mas

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > ilya-biryukov wrote: > > > simark wrote: > > >

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 12:29 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > I don't really understand why, but our bots seemed to survive this: > http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/ > > Console output is here: > http://lab.llvm.org:8080/green/vie

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Historically we have supported building libcxx without llvm-config available on the system. In all likelihood the bots didn't fail because the bots do have llvm-config because we usually require an llvm build or source checkout in order to build and run the tests since tests depend on lit and g

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

mstorsjo created this revision. mstorsjo added reviewers: compnerd, smeenai, phosek. Herald added subscribers: kristof.beyls, aemerson. Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbols. This didn't occur for the apple && arm case due to specifically ch

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman wrote: > Historically we have supported building libcxx without llvm-config > available on the system. > > In all likelihood the bots didn't fail because the bots do have > llvm-config because we usually require an llvm build or source checkout in

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D42552: [analyzer] dump() environment frame-by-frame.

NoQ added a comment. Also printing the location context pointer on every line is redundant, but putting it on the frame line would clamp up the crash dump with weird pointers and also make the frame lines in the state dump visually similar to the environment entry lines. Repository: rC Clan

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131506. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rCXX libc++ https://reviews.llvm.org/D42459 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt ===

r323473 - Don't let test write to the source dir after r323426.

Author: nico Date: Thu Jan 25 13:49:03 2018 New Revision: 323473 URL: http://llvm.org/viewvc/llvm-project?rev=323473&view=rev Log: Don't let test write to the source dir after r323426. Modified: cfe/trunk/test/Driver/cl-x86-flags.c Modified: cfe/trunk/test/Driver/cl-x86-flags.c URL: http://

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:93 + [](const std::string &s) { return llvm::Regex::escape(s); }); // Allow any of these names: // foo hokein wrote: > Does the comment still make sense?

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131511. Wizard marked 8 inline comments as done. Wizard added a comment. update some documents and comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/o

[libcxx] r323479 - Mark 2903 as complete; we already do this

Author: marshall Date: Thu Jan 25 14:33:17 2018 New Revision: 323479 URL: http://llvm.org/viewvc/llvm-project?rev=323479&view=rev Log: Mark 2903 as complete; we already do this Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/vie

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. Ping https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. When viewing the `ExplodedGraph` through graphviz, make `ExprEngine`'s two private program state traits - namely C++ allocator values and C++

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

george.karpenkov added a comment. Looks good Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:392 + +auto InitTempSet = State->get(); +if (!InitTempSet.isEmpty()) { Actually I would put both of those into static functions: printInitializedTemporaries

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added a comment. Gosh I think the chances we get through this without a copy-paste error are way too high. I'm not sure what to do about it, though. I don't have the focus to check this as carefully as it needs. Perhaps we need to test this in the test-suite (eventually)? We've seen t

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

We have lots of duplicated functionality across the LLVM runtime libraries to continue supporting building them without LLVM sources or installations. Despite my history of being a strong advocate for the runtimes being used without LLVM, I don't really have a horse in this race anymore. Duncan

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 13:07, Don Hinton wrote: > > On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman > wrote: > Historically we have supported building libcxx without llvm-config available > on the system. > > In all likelihood the bots didn't fail because the bots do

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits > wrote: > > > >> On Jan 25, 2018, at 13:07, Don Hinton > > wrote: >> >> On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman > > wrote: >> Historically we have supported buil

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

This revision was automatically updated to reflect the committed changes. Closed by commit rC323485: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel. (authored by aemerson, committed by ). Repository: rC Clang https://reviews.llvm.org/D42276 Files: include/cla

[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

arphaman created this revision. arphaman added a reviewer: lebedev.ri. This patch looks through typeof type at the original expression when diagnosing -Wsign-compare to avoid an unfriendly diagnostic. Repository: rC Clang https://reviews.llvm.org/D42561 Files: lib/Sema/SemaChecking.cpp

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Ugh, I really wish that we could simplify that wrapping conditional. https://reviews.llvm.org/D42555 ___ cfe-commits mailing list cfe-commits

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 4:21 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > On Jan 25, 2018, at 13:07, Don Hinton wrote: > > On Thu, Jan 25, 2018 at 12:54 PM, Chris

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

tra marked 2 inline comments as done. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are ---

[libcxx] r323490 - libcxx: Move #include_next out of header guard in wrapper header.

Author: pcc Date: Thu Jan 25 17:19:23 2018 New Revision: 323490 URL: http://llvm.org/viewvc/llvm-project?rev=323490&view=rev Log: libcxx: Move #include_next out of header guard in wrapper header. Code on Windows expects to be able to do: #define _USE_MATH_DEFINES #include and receive the de

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 17:09, Don Hinton wrote: > > > > On Thu, Jan 25, 2018 at 4:21 PM, Duncan P. N. Exon Smith > mailto:dexonsm...@apple.com>> wrote: > > >> On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> >> >>> On

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are tra wrote: > jlebar wrote: >

[libcxx] r323491 - libcxx: Use vcruntime declarations for typeinfo on Windows.

Author: pcc Date: Thu Jan 25 17:22:17 2018 New Revision: 323491 URL: http://llvm.org/viewvc/llvm-project?rev=323491&view=rev Log: libcxx: Use vcruntime declarations for typeinfo on Windows. We need to use the vcruntime declarations on Windows to avoid an ODR violation involving rtti.obj, which pr

[PATCH] D42220: libcxx: Use vcruntime declarations for typeinfo on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323491: libcxx: Use vcruntime declarations for typeinfo on Windows. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D42220?v

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia added a comment. I am just a bit unclear about the use of this extension in the kernel language. Could you please clarify? Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are jlebar wrote: > tra wrote: > > j

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are tra wrote: > jlebar wrote: >

[libcxx] r323492 - Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 17:34:51 2018 New Revision: 323492 URL: http://llvm.org/viewvc/llvm-project?rev=323492&view=rev Log: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize r

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed b

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia accepted this revision. Anastasia added a comment. Oh I guess it can be used to exclude the code with long? LGTM! Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131528. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rCXXA libc++abi https://reviews.llvm.org/D42460 Files: src/CMakeLists.txt Index: src/CMakeLists.txt ===

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

mclow.lists added a comment. I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` in *that* header file. Now I'm wondering if those values `__zero` and `__max` are actually used. Repository: rCXX libc++ https://reviews.llvm.org/D42354

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington updated this revision to Diff 131535. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. In this new patch: - Make the cached values use a 3-way bool type, and default it to false. This simplifies all the Node ctors. - Remove some minor style fixes

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington added inline comments. Comment at: src/cxa_demangle.cpp:260-261 + +#if 0 + void dump() const { +char *Buffer = static_cast(std::malloc(1024)); dexonsmith wrote: > Why is this behind `#if 0`? Should you just use something like > `LLVM_DUMP_M

[libcxxabi] r323495 - Reland:

Author: dhinton Date: Thu Jan 25 19:41:58 2018 New Revision: 323495 URL: http://llvm.org/viewvc/llvm-project?rev=323495&view=rev Log: Reland: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standariz

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323495: Reland: (authored by dhinton, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42460 Files: libcxxabi/trunk/src/CMakeLists.txt Index: libcxxabi/trunk/src/CMakeLists.txt ===

[PATCH] D42461: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131537. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rUNW libunwind https://reviews.llvm.org/D42461 Files: src/CMakeLists.txt Index: src/CMakeLists.txt

[libunwind] r323496 - [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 20:01:50 2018 New Revision: 323496 URL: http://llvm.org/viewvc/llvm-project?rev=323496&view=rev Log: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath

[PATCH] D42461: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323496: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep "__zero"

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep "__zero"

[libunwind] r323499 - Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

Author: mstorsjo Date: Thu Jan 25 22:50:07 2018 New Revision: 323499 URL: http://llvm.org/viewvc/llvm-project?rev=323499&view=rev Log: Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbol

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rL323499: Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

<    1   2