xazax.hun added a comment.
High level note: `clang::TypeAliasDecl` has the same issue as `CXXRecordDecl`,
so templated versions should not be added to the DeclContext. Could you add
that just for the sake of completeness?
Repository:
rC Clang
https://reviews.llvm.org/D42301
_
xazax.hun added a comment.
I do not see a test for the following changes:
- ASTImporter: don't add templated declarations into DeclContext
- ASTImporter: proper set ParmVarDecls for imported FunctionProtoTypeLoc
Comment at: lib/AST/ASTImporter.cpp:2085
+ case FunctionDecl::TK
djasper added a comment.
I am not sure we should actually do this. I agree that badly reflowing
multiline string literals is not ideal, but neither is violating the column
limit. In any case, proper reflowing would probably the best solution. How hard
would it be to implement that (for proto as
a.sidorin added a comment.
> I do not see a test for the following changes:
>
> - ASTImporter: don't add templated declarations into DeclContext
It's in ASTImporterTest. It checks that the templated decl cannot be found in
the enclosing TU.
> - ASTImporter: proper set ParmVarDecls for imported
xazax.hun added a comment.
In https://reviews.llvm.org/D42301#984713, @a.sidorin wrote:
> > I do not see a test for the following changes:
> >
> > - ASTImporter: don't add templated declarations into DeclContext
>
> It's in ASTImporterTest. It checks that the templated decl cannot be found in
>
SjoerdMeijer updated this revision to Diff 131009.
SjoerdMeijer added a comment.
Moved the tests to the existing file (and fixed a few typos in the tests).
https://reviews.llvm.org/D42318
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-fp16-arguments.c
Index:
samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation, LGTM, thanks!
https://reviews.llvm.org/D42318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D42363#983769, @hokein wrote:
> Yeah, we should fix the clang bug (root cause). But I think this patch still
> makes sense -- as we usually ignore inv
lebedev.ri added inline comments.
Comment at: test/std/utilities/meta/meta.type.synop/endian.pass.cpp:10
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++1z
+
c++17, not c++1z
At least grep says there are no c++1z left in the libc++ tests.
https://reviews.llvm
Author: sjoerdmeijer
Date: Tue Jan 23 02:13:49 2018
New Revision: 323185
URL: http://llvm.org/viewvc/llvm-project?rev=323185&view=rev
Log:
[ARM] Pass _Float16 as int or float
Pass and return _Float16 as if it were an int or float for ARM, but with the
top 16 bits unspecified, similarly like we al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323185: [ARM] Pass _Float16 as int or float (authored by
SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42318?vs=131009&id=1310
krasimir updated this revision to Diff 131012.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestText
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(
hokein updated this revision to Diff 131013.
hokein marked 5 inline comments as done.
hokein added a comment.
Address remaining comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unitt
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:653
+// Get all scopes that will be queried in indexes.
+std::vector getQueryScopes(Sema &S,
+CodeCompletionContext &CCContext) {
sammccall wrote:
> as Ilya
hokein updated this revision to Diff 131014.
hokein added a comment.
Cleanup tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
hokein updated this revision to Diff 131018.
hokein added a comment.
remove the leading "::".
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
==
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:695
+ Info.UnresolvedQualifier =
+ Lexer::getSourceText(CharSourceRange::getCharRange((*SS)->getRange()),
+ S.getSourceManager(), clang::LangOptions());
hokein wrote
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
hokein updated this revision to Diff 131019.
hokein added a comment.
Format the test code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
=
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Happy to go forward with this. I think we might also wanna investigate whether
entirely removing UnbreakableTailLength would be beneficial. I think we
implemented it as an optimization, but
krasimir updated this revision to Diff 131023.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
krasimir added a comment.
Let's not do this then. For reflowing string literals, it could take a
two-three months.
Repository:
rC Clang
https://reviews.llvm.org/D42373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: krasimir
Date: Tue Jan 23 03:26:19 2018
New Revision: 323188
URL: http://llvm.org/viewvc/llvm-project?rev=323188&view=rev
Log:
[clang-format] Ignore UnbreakableTailLength sometimes during breaking
Summary:
This patch fixes an issue where the UnbreakableTailLength would be counted
towards
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323188: [clang-format] Ignore UnbreakableTailLength
sometimes during breaking (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.or
miyuki added a comment.
ping^2
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Tue Jan 23 03:37:26 2018
New Revision: 323189
URL: http://llvm.org/viewvc/llvm-project?rev=323189&view=rev
Log:
[clangd] Use accessible scopes to query indexes for global code completion.
Summary:
* For qualified completion (foo::a^)
* unresolved qualifier - use globa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323189: [clangd] Use accessible scopes to query indexes for
global code completion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
C++2a allows bitfields to have default member initializers.
Add support for this to clang-tidy's modernize-use-default-member-init check.
Repos
Author: hokein
Date: Tue Jan 23 03:43:18 2018
New Revision: 323191
URL: http://llvm.org/viewvc/llvm-project?rev=323191&view=rev
Log:
[clang-tidy] Don't generate fixes for invalid new expr location in
modernize-make-unique.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323191: [clang-tidy] Don't generate fixes for invalid
new expr location in modernize… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.l
jkorous-apple added inline comments.
Comment at: Parse/ParseTemplate.cpp:492
+ // Is there just a typo in the input code? ('typedef' instead of 'typename')
+ if (Tok.is(tok::kw_typedef)) {
+Diag(Tok.getLocation(), diag::err_expected_template_parameter);
vsa
jkorous-apple updated this revision to Diff 131041.
jkorous-apple added a comment.
Changes based on Volodymyr's comments.
https://reviews.llvm.org/D42170
Files:
FixIt/fixit-typedef-instead-of-typename-typo.cpp
Parse/ParseTemplate.cpp
clang/Basic/DiagnosticParseKinds.td
Index: FixIt/fixi
Author: fedor.sergeev
Date: Tue Jan 23 04:24:01 2018
New Revision: 323194
URL: http://llvm.org/viewvc/llvm-project?rev=323194&view=rev
Log:
[Solaris] Make RHEL devtoolsets handling Linux-specific
Summary:
This patch is meant to address the last outstanding review comment on the
already approved
Author: fedor.sergeev
Date: Tue Jan 23 04:23:52 2018
New Revision: 323193
URL: http://llvm.org/viewvc/llvm-project?rev=323193&view=rev
Log:
[Solaris] gcc toolchain handling revamp
Summary:
General idea is to utilize generic (mostly Generic_GCC) code
and get rid of Solaris-specific handling as muc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323194: [Solaris] Make RHEL devtoolsets handling
Linux-specific (authored by fedor.sergeev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323193: [Solaris] gcc toolchain handling revamp (authored by
fedor.sergeev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D35755?vs=110194&id
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323195: [Tooling] Added a VFS parameter to ClangTool
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41947?vs=130573&id=131045#toc
Repository:
rC Clang
htt
Author: ibiryukov
Date: Tue Jan 23 04:30:02 2018
New Revision: 323195
URL: http://llvm.org/viewvc/llvm-project?rev=323195&view=rev
Log:
[Tooling] Added a VFS parameter to ClangTool
Summary:
The parameter overrides the underlying vfs used by ClangTool for
filesystem operations.
Patch by Vladimir
Author: ibiryukov
Date: Tue Jan 23 04:31:06 2018
New Revision: 323196
URL: http://llvm.org/viewvc/llvm-project?rev=323196&view=rev
Log:
[clang-tidy] Add -vfsoverlay flag
Summary:
It allows to remap and override files and directories on disk when
running clang-tidy. The intended use case for the f
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323196: [clang-tidy] Add -vfsoverlay flag (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41535?vs=130891&id=131046#toc
Repository:
rCTE Clang Tools Extra
sdardis created this revision.
sdardis added reviewers: cryptoad, atanasyan.
Herald added a subscriber: arichardson.
r317337 missed that scudo is supported on MIPS32, so permit that option for
MIPS32.
Repository:
rC Clang
https://reviews.llvm.org/D42416
Files:
lib/Driver/ToolChains/Linux.c
simark updated this revision to Diff 131051.
simark added a comment.
Herald added subscribers: ioeric, jkorous-apple.
I just got familiar with the patch, I cleaned up the bits that I thought were
unnecessary for this change. For example, we don't need a toJSON function for
DidChangeConfigurationP
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: fedor.sergeev
Date: Tue Jan 23 05:59:11 2018
New Revision: 323199
URL: http://llvm.org/viewvc/llvm-project?rev=323199&view=rev
Log:
Fix Driver/solaris-ld.c test on Windows
Fixing failure introduced with r323193.
Modified:
cfe/trunk/test/Driver/solaris-ld.c
Modified: cfe/trunk/test/D
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165
- Finder->addMatcher(
- cxxConstructorDecl(
- isDefaultConstructor(), unless(isInstantiated()),
- forEachConstructorInitializer(
- cxxCto
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
o Replace the existing clangd::URI with a wrapper of FileURI which also
carries a resolved file path.
o s/FileURI/URI/
Repository:
rCTE Clang Tools Ext
ioeric added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:386
+ if (!U)
+llvm_unreachable(
+"onDiagnosticsReady: Expect creating URI for file to always work.");
not sure if this is the right thing to do. idea?
Comment at
xazax.hun updated this revision to Diff 131059.
xazax.hun added a comment.
- Added import for CXXTypeidExpr. What is the best way to test this?
header is required for using the typeid operator, but relying on the
presence of an STL library in tests is usually considered as a bad practice.
Sho
ilya-biryukov updated this revision to Diff 131062.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Unwrap the comment
- Remove ParseInputs constructor
- Document the CppFile invariant
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42173
Files:
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:62
+/// Information required to run clang (e.g., to parse AST or do code
+/// completion).
+struct ParseInputs {
sammccall wrote:
> sammccall wrot
Author: ibiryukov
Date: Tue Jan 23 07:07:52 2018
New Revision: 323204
URL: http://llvm.org/viewvc/llvm-project?rev=323204&view=rev
Log:
[clangd] Simplify code handling compile commands
Summary:
CppFile can now change compilation arguments during rebuild. This allows
simplifying code that manages
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323204: [clangd] Simplify code handling compile commands
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42173?vs=131062&id=131067#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323204: [clangd] Simplify code handling compile commands
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42173
Files:
c
xazax.hun updated this revision to Diff 131065.
xazax.hun retitled this revision from "[ASTImporter] Supporting
CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType,
DependentSizedArray importing." to "[ASTImporter] Supporting
CXXOperatorCallExpr, SizeOfPackExpr, DependentTem
malcolm.parsons updated this revision to Diff 131069.
malcolm.parsons added a comment.
Use ternary operator.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42413
Files:
clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
test/clang-tidy/modernize-use-default-member-init-bitf
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165
- Finder->addMatcher(
- cxxConstructorDecl(
- isDefaultConstructor(), unless(isInstantiated()),
- forEachConstructorInitializer(
- cxxC
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165
- Finder->addMatcher(
- cxxConstructorDecl(
- isDefaultConstructor(),
Author: malcolm.parsons
Date: Tue Jan 23 07:32:42 2018
New Revision: 323208
URL: http://llvm.org/viewvc/llvm-project?rev=323208&view=rev
Log:
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using
C++2a
Summary:
C++2a allows bitfields to have default member initializers.
Add
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323208: [clang-tidy] Handle bitfields in
modernize-use-default-member-init if using… (authored by malcolm.parsons,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://
elsteveogrande added a comment.
Hi @vsk + @arphaman : I did find such problems with either MSAN (with
poison-in-dtor) and ASAN, so we should be able to discover these instances
pretty easily :)
Repository:
rC Clang
https://reviews.llvm.org/D42043
_
Author: maskray
Date: Mon Jan 22 14:34:15 2018
New Revision: 323157
URL: http://llvm.org/viewvc/llvm-project?rev=323157&view=rev
Log:
[ASTMatchers] [NFC] Fix code examples
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D42213
Modified:
cfe/trunk/docs/LibAST
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+{"configurationChangeProvider", true},
{"renameProvider", true},
I find `configurationChangeProvider` a bit weird.
cryptoad accepted this revision.
cryptoad added a comment.
Cool thanks!
Repository:
rC Clang
https://reviews.llvm.org/D42416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cryptoad added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:850
+ const bool IsMIPS = getTriple().getArch() == llvm::Triple::mips ||
+getTriple().getArch() == llvm::Triple::mipsel;
const bool IsMIPS64 = getTriple().getArch() == llvm::Tr
Author: nico
Date: Tue Jan 23 08:30:56 2018
New Revision: 323218
URL: http://llvm.org/viewvc/llvm-project?rev=323218&view=rev
Log:
clang-format: Support formatting Java 8 interface default methods.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/unittests/Format/FormatTes
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai, klimek.
C++2a allows bitfields to have default member initializers.
Add support for this to clang-tidy's cppcoreguidelines-pro-type-me
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D42428
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteOptions.h
lib/Sema/SemaLookup.cpp
test/Index/complete-p
m.ostapenko updated this revision to Diff 131091.
m.ostapenko added a comment.
Herald added a subscriber: llvm-commits.
Rebased and ping.
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/CFG.h
include/clang/S
Author: djg
Date: Tue Jan 23 09:04:04 2018
New Revision: 323224
URL: http://llvm.org/viewvc/llvm-project?rev=323224&view=rev
Log:
[WebAssembly] Add mem.* builtin functions.
This corresponds to r323222 in LLVM. The new names are not yet
finalized, so use them at your own risk.
Modified:
cfe/t
Author: compnerd
Date: Tue Jan 23 09:05:57 2018
New Revision: 323225
URL: http://llvm.org/viewvc/llvm-project?rev=323225&view=rev
Log:
test: adjust the target for some Windows tests
The tests are targeting Windows but do not specify an environment. When
executed on Linux, they would use an ELF o
Author: nico
Date: Tue Jan 23 09:10:25 2018
New Revision: 323226
URL: http://llvm.org/viewvc/llvm-project?rev=323226&view=rev
Log:
clang-format: Support macros in front of @interface / @protocol for ObjC code.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/lib/Format/Unw
Author: malcolm.parsons
Date: Tue Jan 23 09:13:57 2018
New Revision: 323227
URL: http://llvm.org/viewvc/llvm-project?rev=323227&view=rev
Log:
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if
using C++2a
Summary:
C++2a allows bitfields to have default member initializers
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323227: [clang-tidy] Handle bitfields in
cppcoreguidelines-pro-type-member-init if… (authored by malcolm.parsons,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42426?vs=131088&id
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
It allows to get rid of CppFile::getLastCommand and simplify the
code in the upcoming threading patch.
Repository:
rCTE Clang Tools Extra
https://reviews.ll
Author: nico
Date: Tue Jan 23 09:29:41 2018
New Revision: 323228
URL: http://llvm.org/viewvc/llvm-project?rev=323228&view=rev
Log:
Name two bool parameters. No behavior change.
Modified:
cfe/trunk/lib/Format/FormatToken.h
Modified: cfe/trunk/lib/Format/FormatToken.h
URL:
http://llvm.org/vie
Author: compnerd
Date: Tue Jan 23 09:57:04 2018
New Revision: 323230
URL: http://llvm.org/viewvc/llvm-project?rev=323230&view=rev
Log:
test: simplify the matching logic a bit (NFC)
Use CHECK-SAME directives to simplify the test conditions a bit. This
makes it easier to see what is being checked.
mclow.lists updated this revision to Diff 131102.
mclow.lists added a comment.
Find *all* the places that we are using `exception_class` and wrap them in
helper routines.
https://reviews.llvm.org/D42242
Files:
src/cxa_default_handlers.cpp
src/cxa_exception.cpp
src/cxa_exception.hpp
src
Author: abataev
Date: Tue Jan 23 10:12:38 2018
New Revision: 323232
URL: http://llvm.org/viewvc/llvm-project?rev=323232&view=rev
Log:
[OPENMP] Remove more empty SourceLocations() from the code.
Removed more empty SourceLocations() from the OpenMP code and replaced
with the correct locations for b
Author: hahnfeld
Date: Tue Jan 23 10:12:12 2018
New Revision: 323231
URL: http://llvm.org/viewvc/llvm-project?rev=323231&view=rev
Log:
test/Driver: Add some --stdlib=platform, NFC.
This fixes the failing test when building with CLANG_DEFAULT_CXX_STDLIB.
Modified:
cfe/trunk/test/Driver/solari
ilya-biryukov updated this revision to Diff 131105.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Renamed SimpleThreadPool to ThreadPool
- Removed PCHs from Scheduler's constructor
- Renamed waitFor(AST|Preamble)Action to blocking(AST|Preamble)Read
- Updates
- Re
Author: ctopper
Date: Tue Jan 23 10:40:15 2018
New Revision: 323235
URL: http://llvm.org/viewvc/llvm-project?rev=323235&view=rev
Log:
[Docs] Re-generate command line documentation.
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
U
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:222
+ }
+ // We currently do all the reads of the AST on a running thread to avoid
+ // inconsistent states coming from subsequent updates.
sammccall wrote:
> Having trouble with this one
mclow.lists added inline comments.
Comment at: include/algorithm:2515
+{
+pointer __buff_end = __move(__first, __middle, __buff);
+__move(__middle, __last, __first);
mclow.lists wrote:
> Probably a good idea to qualify these calls with `_VSTD
Author: abataev
Date: Tue Jan 23 10:44:14 2018
New Revision: 323236
URL: http://llvm.org/viewvc/llvm-project?rev=323236&view=rev
Log:
[OPENMP] Replace call of EmitLoadOfLValue() by EmitLoadOfScalar(), NFC.
Replace calls of EmitLoadOfLValue() by EmitLoadOfScalar() functions if
it is known that the
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
aemerson wrote:
> qcolombet wrote:
> > qcolombet wrote:
> > > I think that it would be useful to also set -global-isel-abo
Author: pcc
Date: Tue Jan 23 10:53:33 2018
New Revision: 323237
URL: http://llvm.org/viewvc/llvm-project?rev=323237&view=rev
Log:
libcxx: Rename vasprintf function to __libcpp_vasprintf.
The language standard does not define a function with this name,
so it is part of the user's namespace. This c
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:164
+/// Handles running tasks for ClangdServer and managing the resources (e.g.,
+/// preambles and ASTs) for opened files.
sammccall wrote:
> This is a nice abstraction, so much better tha
Author: tra
Date: Tue Jan 23 11:08:18 2018
New Revision: 323239
URL: http://llvm.org/viewvc/llvm-project?rev=323239&view=rev
Log:
[CUDA] CUDA has no device-side library builtins.
We should (almost) never consider a device-side declaration to match a
library builtin functio. Otherwise clang may i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323239: [CUDA] CUDA has no device-side library builtins.
(authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42319?vs=130697&id=
Author: compnerd
Date: Tue Jan 23 11:17:25 2018
New Revision: 323241
URL: http://llvm.org/viewvc/llvm-project?rev=323241&view=rev
Log:
AST: adjust ObjC MS mangling to work with typedefs
Rather than hardcode the pointerness of the `id` and `class` types,
handle them generically. This allows for t
Author: george.karpenkov
Date: Tue Jan 23 11:28:43 2018
New Revision: 323244
URL: http://llvm.org/viewvc/llvm-project?rev=323244&view=rev
Log:
[html] [NFC] Use raw strings to dump the style table.
Modified:
cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
Author: george.karpenkov
Date: Tue Jan 23 11:28:52 2018
New Revision: 323245
URL: http://llvm.org/viewvc/llvm-project?rev=323245&view=rev
Log:
[analyzer] Show full analyzer invocation for reproducibility in HTML reports
Analyzing problems which appear in scan-build results can be very
difficult,
vsapsai added inline comments.
Comment at: Parse/ParseTemplate.cpp:492
+ // Is there just a typo in the input code? ('typedef' instead of 'typename')
+ if (Tok.is(tok::kw_typedef)) {
+Diag(Tok.getLocation(), diag::err_expected_template_parameter);
jkorous-a
Author: compnerd
Date: Tue Jan 23 11:35:51 2018
New Revision: 323247
URL: http://llvm.org/viewvc/llvm-project?rev=323247&view=rev
Log:
CodeGen: use `llvm.used` for ObjC protocols
These symbols are supposed to be preserved even by the linker. Use the
`llvm.used` to ensure that the symbols are not
Author: george.karpenkov
Date: Tue Jan 23 12:01:31 2018
New Revision: 323251
URL: http://llvm.org/viewvc/llvm-project?rev=323251&view=rev
Log:
[analyzer] Mark lines as relevant even if they weren't executed but have a
label attached
Differential Revision: https://reviews.llvm.org/D42320
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323251: [analyzer] Mark lines as relevant even if they
weren't executed but have a… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://r
Author: djg
Date: Tue Jan 23 12:22:12 2018
New Revision: 323253
URL: http://llvm.org/viewvc/llvm-project?rev=323253&view=rev
Log:
[WebAssembly] Factor out settings common to wasm32 and wasm64. NFC.
MaxAtomicPromoteWidth and MaxAtomicInlineWidth are 64 on both
wasm32 and wasm64, so they can be set
1 - 100 of 133 matches
Mail list logo
