[PATCH] D42343: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: test/CodeGenCoroutines/coro-gro-nrvo.cpp:17 +using SizeT = decltype(sizeof(int)); +void* operator new(SizeT __sz, const std::nothrow_t&) noexcept; +void operator delete(void* __p, const std::nothr

[PATCH] D42343: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

EricWF updated this revision to Diff 130801. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments in test. https://reviews.llvm.org/D42343 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/CodeGenCoroutines/coro-gro-nrvo.cpp

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, hans. Herald added subscribers: cfe-commits, guansong. Also list supported configurations (architectures + operating systems). Repository: rC Clang https://reviews.llvm.org/D42349 Files: docs/OpenMPSupport.rst Index: docs

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

Hahnfeld added a comment. @hans I'd also like to merge this to `release_60` because the support landed before the branching. Is this ok? Repository: rC Clang https://reviews.llvm.org/D42349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

aguinet created this revision. aguinet added a reviewer: rnk. Herald added subscribers: cfe-commits, JDevlieghere. This needs https://reviews.llvm.org/D42350 in LLVM! Repository: rC Clang https://reviews.llvm.org/D42351 Files: lib/CodeGen/CGDebugInfo.cpp Index: lib/CodeGen/CGDebugInfo.cp

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, ABataev, hans. Herald added subscribers: cfe-commits, guansong. The OpenMP runtime has no dedicated Release Notes, so add it to Clang's section about OpenMP. Repository: rC Clang https://reviews.llvm.org/D42352 Files: docs/

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie created this revision. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. When use clang-cl -std:c++17 -Iinclude\c++\v1 hello.cc c++.lib In file included from hello.cc:1: In file included from include\c++\v1\iostream:38: In file included from include\c++\

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130812. ng added a comment. As per the above suggestions, enabled _multi tree search only for transparent comparator functions, and added tests. https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/as

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

rnk added a subscriber: aprantl. rnk added a comment. @aprantl Repository: rC Clang https://reviews.llvm.org/D42351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

mclow.lists added a comment. Sometimes you get lucky ;-) I have a task for next week that says "The transparent lookup stuff in the associative containers needs tests", and here is this patch. Instead of "transparent_count.pass.cpp", please name the test "count_transparent.pass.cpp" so it will

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

mclow.lists added a comment. Shouldn't there be tests for `multimap` and `multiset`, too? https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote: > Shouldn't there be tests for `multimap` and `multiset`, too? Sure; will the same tests as for map/set be alright? https://reviews.llvm.org/D42344 ___ cfe-commits

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

mclow.lists added a comment. In https://reviews.llvm.org/D42344#983265, @ng wrote: > In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote: > > > Shouldn't there be tests for `multimap` and `multiset`, too? > > > Sure; will the same tests as for map/set be alright? Actually, I think the

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130814. ng added a comment. Renamed tests for map/set, and added multimap/multiset tests https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/associative/map/map.ops/count_transparent.pass.cpp libcxx/

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

mclow.lists added a comment. In https://reviews.llvm.org/D41976#982978, @tvanslyke wrote: > I don't have commit access myself so I've added the test to the diff. I'll commit it then. https://reviews.llvm.org/D41976 ___ cfe-commits mailing list cf

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng updated this revision to Diff 130817. ng added a comment. Fix multiset variable definition in tests https://reviews.llvm.org/D42344 Files: libcxx/include/map libcxx/include/set libcxx/test/std/containers/associative/map/map.ops/count_transparent.pass.cpp libcxx/test/std/containers

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

mclow.lists added a comment. > Since __clear_and_shrink() is private There's no reason it has to be private. People aren't supposed to call anything with a reserved name. https://reviews.llvm.org/D41976 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

hintonda updated this revision to Diff 130820. hintonda added a comment. - Save CMAKE_REQUIRED_FLAGS for another patch. Repository: rCXX libc++ https://reviews.llvm.org/D41622 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke updated this revision to Diff 130819. tvanslyke added a comment. Moved `__clear_and_shrink()` to live with the other public dunder methods and adapted the associated test accordingly. https://reviews.llvm.org/D41976 Files: include/string test/libcxx/strings/basic.string/string.m

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

bader accepted this revision. bader added a comment. Looks good to me. Thanks for working on this. https://reviews.llvm.org/D42307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

dcoughlin added a comment. This seems reasonable. Would it make sense to use the last element of the block edge's source for the diagnostic location when the destination block is empty? Repository: rC Clang https://reviews.llvm.org/D42266 ___ c

[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

dcoughlin accepted this revision. dcoughlin added a comment. Looks good to me, thanks! https://reviews.llvm.org/D41816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

szepet added a comment. > Would it make sense to use the last element of the block edge's source for > the diagnostic location when the destination block is empty? I do not think so. In the testfile `emptyConditionLoop` function is a great counter example since the last element of the source bl

[PATCH] D41384: [analyzer] Suppress false positive warnings form security.insecureAPI.strcpy

dcoughlin added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:517 +if (const auto *Array = dyn_cast(DeclRef->getType())) { + uint64_t ArraySize = BR.getContext().getTypeSize(Array) / 8; + if (const auto *String = dyn

[libcxx] r323070 - implement (but leave commented out) the constexpr tests from P0202 for std::merge. merge requires std::copy, which isn't constexpr yet.

Author: marshall Date: Sun Jan 21 16:11:44 2018 New Revision: 323070 URL: http://llvm.org/viewvc/llvm-project?rev=323070&view=rev Log: implement (but leave commented out) the constexpr tests from P0202 for std::merge. merge requires std::copy, which isn't constexpr yet. Modified: libcxx/trun

[libcxx] r323071 - Change a static_assert to check for is_trivial instead of is_pod, as is mandated by P0767.

Author: marshall Date: Sun Jan 21 16:17:48 2018 New Revision: 323071 URL: http://llvm.org/viewvc/llvm-project?rev=323071&view=rev Log: Change a static_assert to check for is_trivial instead of is_pod, as is mandated by P0767. Modified: libcxx/trunk/include/string libcxx/trunk/include/str

[libcxx] r323072 - Really comment out the constexpr tests.

Author: marshall Date: Sun Jan 21 17:51:49 2018 New Revision: 323072 URL: http://llvm.org/viewvc/llvm-project?rev=323072&view=rev Log: Really comment out the constexpr tests. Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp libcxx/trunk/test/std/algorithms/a

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge does NOT take usge of partial allocated buffer but uses native rotate directly. It makes the performace far behind from correspondin

WeiChungChang created this revision. Herald added a subscriber: cfe-commits. ...buffer firstly. Experiment shows 28.35% & 25.06% speedup for merging two equal size sorted integers for -O3 & no -O3 cases. Repository: rCXX libc++ https://reviews.llvm.org/D42357 Files: include/algorithm In

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

jlebar added a comment. How does this affect e.g. calling memcpy()? There isn't a standard library implementation of this on nvptx, but we do want calls to memcpy() to be lowered to llvm.memcpy so that they can be optimized. https://reviews.llvm.org/D42319 _

[PATCH] D42359: a simple comment fix in include/list

oldk1331 created this revision. Herald added a subscriber: cfe-commits. Hello all, This is a simple (and my first) patch that fixes a comment in include/list. Qian Yun Repository: rCXX libc++ https://reviews.llvm.org/D42359 Files: include/list Index: include/list ==

r323078 - [NFC] fix trivial typos in comments

Author: inouehrs Date: Sun Jan 21 23:44:38 2018 New Revision: 323078 URL: http://llvm.org/viewvc/llvm-project?rev=323078&view=rev Log: [NFC] fix trivial typos in comments "the the" -> "the" Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp cfe/trunk/lib/StaticAnalyzer