[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:350 + std::string QueryScope = + (normalizeScope(VS) + + (UnresolvedQualifier sammccall wrote: > It seems like you have stored the scopes in an unknown format, and call

[PATCH] D42318: [ARM] Pass _Float16 as int or float

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: olista01, t.p.northover, rjmccall, aschwaighofer. Herald added subscribers: kristof.beyls, javed.absar, aemerson. Pass and return _Float16 as if it were an int or float for ARM, but with the top 16 bits unspecified, similarly like w

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. We should (almost) never consider a device-side declaration to match a builtin. If we do, the un-inlined device-side functions provided by CUDA headers that ship with clang may be ignored. We may end up em

r323006 - [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

Author: az Date: Fri Jan 19 15:11:18 2018 New Revision: 323006 URL: http://llvm.org/viewvc/llvm-project?rev=323006&view=rev Log: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics https://reviews.llvm.org/D41792 Added: cfe/trunk/include/clang/Basic/arm_fp16.td cfe/trunk/include/clang/Basic/a

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think that's a sensible fix, thanks! https://reviews.llvm.org/D41688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: r322813 - Fix Scope::dump()

Hans, I recommend merging this revision into the release. It fixes an infinite loop in Scope::dump() Richard On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Wed Jan 17 20:28:56 2018 > New Revision: 322813 > > URL: htt

Re: r322984 - Allow BlockDecl in CXXRecord scope to have no access specifier.

Hans, I recommend merging this revision into the release. It fixes an assertion error when mixing modules and blocks. Richard On Fri, Jan 19, 2018 at 12:46 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Jan 19 12:46:19 2018 > New Revision:

r323008 - [Lex] Fix crash on code completion in comment in included file.

Author: vsapsai Date: Fri Jan 19 15:41:47 2018 New Revision: 323008 URL: http://llvm.org/viewvc/llvm-project?rev=323008&view=rev Log: [Lex] Fix crash on code completion in comment in included file. This fixes PR32732 by updating CurLexerKind to reflect available lexers. We were hitting null point

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

This revision was automatically updated to reflect the committed changes. Closed by commit rC323008: [Lex] Fix crash on code completion in comment in included file. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41688?vs=128480&id=130710#toc Repository

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130711. MaskRay added a comment. functionProtoType Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h =

Re: r322813 - Fix Scope::dump()

Sounds like a good idea to me. On 19 Jan 2018 15:23, "Richard Trieu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Hans, > > I recommend merging this revision into the release. It fixes an infinite > loop in Scope::dump() > > Richard > > On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu vi

[clang-tools-extra] r323011 - [clang-tidy] Adding Fuchsia checker for multiple inheritance

Author: juliehockett Date: Fri Jan 19 15:59:59 2018 New Revision: 323011 URL: http://llvm.org/viewvc/llvm-project?rev=323011&view=rev Log: [clang-tidy] Adding Fuchsia checker for multiple inheritance Adds a check to the Fuchsia module to warn when a class inherits from multiple classes that are n

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. juliehockett marked 4 inline comments as done. Closed by commit rCTE323011: [clang-tidy] Adding Fuchsia checker for multiple inheritance (aut

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904 +return F->hasTrailingReturn(); + return false; +} lebedev.ri wrote: > There are no negative tests in the unittest that cover this false path. Is there a test case y

r323022 - Link sanitized programs on NetBSD with -lkvm

Author: kamil Date: Fri Jan 19 17:03:45 2018 New Revision: 323022 URL: http://llvm.org/viewvc/llvm-project?rev=323022&view=rev Log: Link sanitized programs on NetBSD with -lkvm Summary: kvm - kernel memory interface The kvm(3) functions like kvm_open(), kvm_getargv() or kvm_getenvv() are used in

[PATCH] D42017: Link sanitized programs on NetBSD with -lkvm

This revision was automatically updated to reflect the committed changes. Closed by commit rC323022: Link sanitized programs on NetBSD with -lkvm (authored by kamil, committed by ). Repository: rC Clang https://reviews.llvm.org/D42017 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib

[PATCH] D41829: [cmake] Add cache file to bootstrap linux cross compile on Darwin.

hintonda updated this revision to Diff 130748. hintonda added a comment. - Use LLVM_CONFIG_PATH instead of LLVM_CONFIG_EXE. Repository: rC Clang https://reviews.llvm.org/D41829 Files: cmake/caches/Linux.cmake Index: cmake/caches/Linux.cmake

<    1   2