[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

2018-01-17 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer requested changes to this revision. bkramer added a comment. dump_ast_matchers.py should be working again now. Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

2018-01-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In https://reviews.llvm.org/D42168#978634, @ABataev wrote: > 1. Please, mark the record as packed. Where and how do I need to do this? I found that `PackedAttr` is checked on `FieldDecl`s but I'm not sure if we go through tha

[PATCH] D42173: [clangd] Simplify code handling compile commands

2018-01-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This looks better overall to me. I'm not sure about clangdserver rather than clangdunit computing the commands. You're probably right but I'd like you to explain it to me :-) Rest is just readability nits. Comment at: clangd/ClangdServer.cpp:35 +t

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Sorry for the delay Comment at: clang-tidy/ClangTidy.cpp:93 +vfs::OverlayFileSystem &OverlayFS) { + if (OverlayFile.empty

[PATCH] D41852: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

2018-01-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30 vector(initializer_list<_E> init); + ~vector(); }; ilya-biryukov wrote: > Why do we need to add this destructo

[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

2018-01-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D42168#978689, @Hahnfeld wrote: > In https://reviews.llvm.org/D42168#978634, @ABataev wrote: > > > 1. Please, mark the record as packed. > > > Where and how do I need to do this? I found that `PackedAttr` is checked on > `FieldDecl`s but I'm n

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 130200. juliehockett marked 8 inline comments as done. juliehockett added a comment. Updating matchers & fixing comments https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/

[PATCH] D41946: [clangd] Add support for different file URI schemas.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 130201. ioeric marked 17 inline comments as done. ioeric added a comment. Herald added a reviewer: jkorous-apple. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41946 Files: clangd/CMakeLists.txt clangd/URI.c

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

2018-01-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: bkramer wrote: > What's so simple about it? Why not `clangd::ThreadPool`? > > Also there's `llvm::T

[PATCH] D41946: [clangd] Add support for different file URI schemas.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Thanks for the comments! I've refactored the code according to your suggestions. PTAL Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

2018-01-17 Thread Yvan Roux via cfe-commits
On 17 January 2018 at 17:05, Nico Weber wrote: > r322674 attempts to fix. Fixed on ARM bots. Thanks > On Wed, Jan 17, 2018 at 10:54 AM, Yvan Roux via cfe-commits > wrote: >> >> Hi Nico, >> >> On 17 January 2018 at 14:35, Nico Weber via Phabricator via >> cfe-commits wrote: >> > thakis closed t

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

2018-01-17 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton updated this revision to Diff 130202. benhamilton added a comment. Use unordered_set, consolidate at-token checks Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

r322690 - [Format] Improve ObjC header guessing heuristic

2018-01-17 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Wed Jan 17 09:33:08 2018 New Revision: 322690 URL: http://llvm.org/viewvc/llvm-project?rev=322690&view=rev Log: [Format] Improve ObjC header guessing heuristic Summary: This improves upon the previous Objective-C header guessing heuristic from rC320479. Now, we run the

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

2018-01-17 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322690: [Format] Improve ObjC header guessing heuristic (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42135 Files:

r322691 - [Tooling] Don't deduplicate tool results in the All-TUs executor.

2018-01-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 17 09:37:11 2018 New Revision: 322691 URL: http://llvm.org/viewvc/llvm-project?rev=322691&view=rev Log: [Tooling] Don't deduplicate tool results in the All-TUs executor. Summary: As result deduplication or reduction is not supported in the framework, we should leave t

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322691: [Tooling] Don't deduplicate tool results in the All-TUs executor. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42111?vs=129982&id=130204#toc Repositor

[clang-tools-extra] r322692 - [clang-tidy] Fixing Fuchsia overloaded operator warning message

2018-01-17 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Wed Jan 17 09:41:50 2018 New Revision: 322692 URL: http://llvm.org/viewvc/llvm-project?rev=322692&view=rev Log: [clang-tidy] Fixing Fuchsia overloaded operator warning message Updating Fuchsia overloaded operator warning message for clarity. Differential Revision: http

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D42120?vs=129998&id=130205#toc Rep

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

2018-01-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 130206. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - s/buffer for MainFile/MainFile/ Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41991 Files: clangd/CodeComplete.cpp clangd/Compiler.cpp cla

[libcxx] r322702 - Creating release directory for release_600.

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:21 2018 New Revision: 322702 URL: http://llvm.org/viewvc/llvm-project?rev=322702&view=rev Log: Creating release directory for release_600. Added: libcxx/tags/RELEASE_600/ ___ cfe-commits mailing list cfe-commits@

[libcxxabi] r322704 - Creating release directory for release_600.

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:24 2018 New Revision: 322704 URL: http://llvm.org/viewvc/llvm-project?rev=322704&view=rev Log: Creating release directory for release_600. Added: libcxxabi/tags/RELEASE_600/ ___ cfe-commits mailing list cfe-commi

[libcxx] r322703 - Creating release candidate rc1 from release_600 branch

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:23 2018 New Revision: 322703 URL: http://llvm.org/viewvc/llvm-project?rev=322703&view=rev Log: Creating release candidate rc1 from release_600 branch Added: libcxx/tags/RELEASE_600/rc1/ (props changed) - copied from r322702, libcxx/branches/release_

[libcxxabi] r322705 - Creating release candidate rc1 from release_600 branch

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:24 2018 New Revision: 322705 URL: http://llvm.org/viewvc/llvm-project?rev=322705&view=rev Log: Creating release candidate rc1 from release_600 branch Added: libcxxabi/tags/RELEASE_600/rc1/ - copied from r322704, libcxxabi/branches/release_60/ ___

[libunwind] r322716 - Creating release directory for release_600.

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:33 2018 New Revision: 322716 URL: http://llvm.org/viewvc/llvm-project?rev=322716&view=rev Log: Creating release directory for release_600. Added: libunwind/tags/RELEASE_600/ ___ cfe-commits mailing list cfe-commi

[libunwind] r322717 - Creating release candidate rc1 from release_600 branch

2018-01-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Jan 17 09:50:33 2018 New Revision: 322717 URL: http://llvm.org/viewvc/llvm-project?rev=322717&view=rev Log: Creating release candidate rc1 from release_600 branch Added: libunwind/tags/RELEASE_600/rc1/ - copied from r322716, libunwind/branches/release_60/ ___

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 130207. ioeric marked 3 inline comments as done. ioeric added a comment. Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42113 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp Index: clangd/global

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:109 + // Deduplicate the result by key. + // FIXME(ioeric): we need a better way to merge symbols with the same key. For + // example, class forward-declarations can have the sa

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

2018-01-17 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch adds canonical delimiter support to the raw string formatting. This allows matching delimiters to be updated to the canonical one. Repository: rC Clang https://reviews.llvm.org/D42187 Files: docs/Clan

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think it'd be fine to do the rearrangement for additive ops without the option check, as we discussed. I.e., rearrange when it's either an additive op, or both the flag is set and the values are overflow-clamped. And remove the clamp checks (which are presumably heavy) fo

[PATCH] D42106: [analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneededCalls()'.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, weird. Thanks :) Repository: rC Clang https://reviews.llvm.org/D42106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r322720 - [Index] Fix GCC warning again :-(

2018-01-17 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Jan 17 10:20:57 2018 New Revision: 322720 URL: http://llvm.org/viewvc/llvm-project?rev=322720&view=rev Log: [Index] Fix GCC warning again :-( Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL: http://l

[clang-tools-extra] r322722 - [clangd] Deduplicate symbols collected in global-symbol-builder tool.

2018-01-17 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Jan 17 10:27:41 2018 New Revision: 322722 URL: http://llvm.org/viewvc/llvm-project?rev=322722&view=rev Log: [clangd] Deduplicate symbols collected in global-symbol-builder tool. Summary: After D42111, the executor framework no longer deduplicate tool results. Reviewers:

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

2018-01-17 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322722: [clangd] Deduplicate symbols collected in global-symbol-builder tool. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. krasimir added a reviewer: bkramer. Herald added subscribers: cfe-commits, klimek. krasimir added subscribers: benhamilton, jolesiak. This replaces an unordered_set from r322690 with an array and binary search. Repository: rC Clang https://reviews.llvm.org/D421

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords &Keywords) { -static const std::unordered_set FoundationIdentifiers = { +static const llvm::ArrayRef FoundationIdentifiers = { "CGFloat", ---

r322729 - [Parse] Forward brace locations to TypeConstructExpr

2018-01-17 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Wed Jan 17 10:53:51 2018 New Revision: 322729 URL: http://llvm.org/viewvc/llvm-project?rev=322729&view=rev Log: [Parse] Forward brace locations to TypeConstructExpr When parsing C++ type construction expressions with list initialization, forward the locations of the braces t

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322729: [Parse] Forward brace locations to TypeConstructExpr (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41921?vs=130021&id=130216#toc Repository: rC Clan

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 130220. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. - rebased - finally updated docs - found a new bug in doc generator https://bugs.llvm.org/show_bug.cgi?id=35989 Going to finally land this. Repository: rC Clang https:

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 130221. lebedev.ri added a comment. Update extra newline that prevented full documentation generation :/ Repository: rC Clang https://reviews.llvm.org/D41455 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/AS

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 130223. krasimir added a comment. - Address review comment Repository: rC Clang https://reviews.llvm.org/D42189 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/For

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

2018-01-17 Thread Steve O'Brien via Phabricator via cfe-commits
elsteveogrande updated this revision to Diff 130225. elsteveogrande added a comment. Add a needed null-check on input string's data ptr. Repository: rC Clang https://reviews.llvm.org/D42043 Files: include/clang-c/CXString.h tools/c-index-test/c-index-test.c tools/libclang/CXString.cpp

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 130228. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Address review note: reduce amount of examples in documentation. Repository: rC Clang https://reviews.llvm.org/D41455 Files: docs/LibASTMatchersReference.html include

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks, this is smarter. Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords &Keywords) { -static const std::unordered_set FoundationIdentifiers = { +static constexpr llvm::StringLiteral FoundationIdentifiers[] = {

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In the `c++-allocator-inlining=true` mode, we need to make the assumption that the conservatively evaluated operator new() has returned a non

[PATCH] D41946: [clangd] Add support for different file URI schemas.

2018-01-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Few more interface nits, sorry for picking here! Will get through the impl in the morning. Comment at: clangd/URI.cpp:43 + Body.consume_front("/"); +return llvm::sys::path::convert_to_slash(Body); + } Don't you want the opp

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Great, looks good to commit. Thanks, Roman! Repository: rC Clang https://reviews.llvm.org/D41455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/TrailingReturnCheck.cpp:25 + +AST_TYPE_MATCHER(DecltypeType, decltypeType); + Good try, but if you rebase, you'll find that this macro has gone away entirely in r322687. I believe this macro was

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 130232. krasimir added a comment. - Add comment Repository: rC Clang https://reviews.llvm.org/D42189 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.

r322742 - [DeclPrinter] Fix two cases that crash clang -ast-print.

2018-01-17 Thread Artem Belevich via cfe-commits
Author: tra Date: Wed Jan 17 11:29:39 2018 New Revision: 322742 URL: http://llvm.org/viewvc/llvm-project?rev=322742&view=rev Log: [DeclPrinter] Fix two cases that crash clang -ast-print. Both are related to handling anonymous structures. * clang didn't handle () around an anonymous struct variabl

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

2018-01-17 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322742: [DeclPrinter] Fix two cases that crash clang -ast-print. (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41788?vs=12

[libcxx] r322744 - libcxx: Disable CFI in function std::get_temporary_buffer.

2018-01-17 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Jan 17 11:32:35 2018 New Revision: 322744 URL: http://llvm.org/viewvc/llvm-project?rev=322744&view=rev Log: libcxx: Disable CFI in function std::get_temporary_buffer. The specification of this function mandates a cast to uninitialized T*, which is forbidden under CFI. Diffe

[PATCH] D42146: libcxx: Disable CFI in function std::get_temporary_buffer.

2018-01-17 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322744: libcxx: Disable CFI in function std::get_temporary_buffer. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D42146?vs

r322746 - [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Wed Jan 17 11:40:55 2018 New Revision: 322746 URL: http://llvm.org/viewvc/llvm-project?rev=322746&view=rev Log: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations Reviewers: aaron.ballman Reviewed By: aaron.ballman Subscribers: dblaikie, klimek, cfe-c

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322746: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 130242. juliehockett added a comment. Rebasing and updating decltypeType matcher https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/TrailingReturnCheck.cpp clang-

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

2018-01-17 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:514 + QualType Ty = FD->getType(); + if (const FunctionProtoType *ProtoType = Ty->getAs()) +if (!ProtoType->isNothrow(getContext())) auto? ==

[PATCH] D41039: Add support for attribute "trivial_abi"

2018-01-17 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. I think I've addressed all the review comments. Any other comments from anyone? https://reviews.llvm.org/D41039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Forgot to mention that this patch follows the tradition of duplicating code from `VisitCXXNewExpr()` to `VisitCXXNewAllocatorCall()` - until we enable `c++-allocator-inlining` by default and clean away the old mode support from `VisitCXXNewExpr()` (which would become pretty

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. lgtm Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 130243. NoQ marked 2 inline comments as done. NoQ added a comment. Address the final comments. https://reviews.llvm.org/D40560 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Co

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:487 +if (const MemRegion *MR = I.second.getAsRegion()) + SymReaper.markElementIndicesLive(MR); + } dcoughlin wrote: > Do we have a test for the MemRegion case? Commenting it o

r322749 - [clang-format] Replace unordered_set with an array

2018-01-17 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Wed Jan 17 12:01:02 2018 New Revision: 322749 URL: http://llvm.org/viewvc/llvm-project?rev=322749&view=rev Log: [clang-format] Replace unordered_set with an array Summary: This replaces an unordered_set from r322690 with an array and binary search. Reviewers: bkramer, ben

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If you felt so inclined, I would say those two AST matchers would both be reasonable candidates to add to ASTMatchers.h if you wanted to do that in a follow-up patch. htt

[PATCH] D42189: [clang-format] Replace unordered_set with an array

2018-01-17 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322749: [clang-format] Replace unordered_set with an array (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42189 Files:

r322750 - [analyzer] Better UI in html reports for displaying shortcuts help

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:06:26 2018 New Revision: 322750 URL: http://llvm.org/viewvc/llvm-project?rev=322750&view=rev Log: [analyzer] Better UI in html reports for displaying shortcuts help Make the help window accessible, but don't show by default. Use a different CSS class f

r322752 - [analyzer] Make isSubRegionOf reflexive

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:27:26 2018 New Revision: 322752 URL: http://llvm.org/viewvc/llvm-project?rev=322752&view=rev Log: [analyzer] Make isSubRegionOf reflexive All usages of isSubRegionOf separately check for reflexive case, and in any case, set theory tells us that each se

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

2018-01-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 130249. NoQ added a comment. Remove pointer casts from the newly added symbolic index test, because once we properly perform the cast of the allocated value (as in https://reviews.llvm.org/D41250), our solver would blow up. https://reviews.llvm.org/D40560 Fil

r322753 - [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

2018-01-17 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Wed Jan 17 12:27:29 2018 New Revision: 322753 URL: http://llvm.org/viewvc/llvm-project?rev=322753&view=rev Log: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently In most cases using `N->getState()->getSVal(E, N->

[PATCH] D42140: [analyzer] Make isSubRegionOf reflexive

2018-01-17 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322752: [analyzer] Make isSubRegionOf reflexive (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D42140 Files: inc

[PATCH] D42155: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

2018-01-17 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322753: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.

[clang-tools-extra] r322759 - [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Wed Jan 17 13:18:15 2018 New Revision: 322759 URL: http://llvm.org/viewvc/llvm-project?rev=322759&view=rev Log: [clang-tidy] Adding Fuchsia checker for trailing returns Adds a check to the Fuchsia module to warn if a function has a trailing return. See https://fuchsia.

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42116 Files: clang-tidy/fuc

[libclc] r322760 - pow: Port from amd_builtins

2018-01-17 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Wed Jan 17 13:21:35 2018 New Revision: 322760 URL: http://llvm.org/viewvc/llvm-project?rev=322760&view=rev Log: pow: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes CTS on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer:

[libclc] r322761 - pown: Port from amd_builtins

2018-01-17 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Wed Jan 17 13:22:03 2018 New Revision: 322761 URL: http://llvm.org/viewvc/llvm-project?rev=322761&view=rev Log: pown: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes CTS on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer

[libclc] r322762 - powr: Port from amd_builtins

2018-01-17 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Wed Jan 17 13:22:06 2018 New Revision: 322762 URL: http://llvm.org/viewvc/llvm-project?rev=322762&view=rev Log: powr: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes cts on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer

[libclc] r322763 - rootn: Port from amd_builtins

2018-01-17 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Wed Jan 17 13:22:14 2018 New Revision: 322763 URL: http://llvm.org/viewvc/llvm-project?rev=322763&view=rev Log: rootn: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes ctx on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewe

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

2018-01-17 Thread Ana Pazos via Phabricator via cfe-commits
apazos added a comment. Thanks for the clarifications Alex. No need to fix these known issues right now. I will proceed with checking in this change. https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

2018-01-17 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett abandoned this revision. juliehockett added a comment. After some discussion, we decided that the false positive risk for non-kernel code isn't worth the check. https://reviews.llvm.org/D41963 ___ cfe-commits mailing list cfe-commits@l

[libcxxabi] r322768 - Fix standalone test-suite run.

2018-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 17 14:07:09 2018 New Revision: 322768 URL: http://llvm.org/viewvc/llvm-project?rev=322768&view=rev Log: Fix standalone test-suite run. This patch updates libc++abi's HandleOutOfTreeLLVM.cmake to match libc++'s -- and more importantly, to fix a bug where llvm-lit wasn'

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

2018-01-17 Thread Ana Pazos via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322769: [RISCV] Propagate -mabi and -march values to GNU assembler. (authored by apazos, committed by ). Changed prior to commit: https://reviews.llvm.org/D41271?vs=129981&id=130272#toc Repository: r

r322769 - [RISCV] Propagate -mabi and -march values to GNU assembler.

2018-01-17 Thread Ana Pazos via cfe-commits
Author: apazos Date: Wed Jan 17 14:09:58 2018 New Revision: 322769 URL: http://llvm.org/viewvc/llvm-project?rev=322769&view=rev Log: [RISCV] Propagate -mabi and -march values to GNU assembler. When using -fno-integrated-as flag, the gnu assembler produces code with some default march/mabi which l

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

2018-01-17 Thread Ana Pazos via Phabricator via cfe-commits
apazos added a comment. Committed R322769 Repository: rL LLVM https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322774 - [analyzer] operator new: Use the correct region for the constructor.

2018-01-17 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 17 14:34:23 2018 New Revision: 322774 URL: http://llvm.org/viewvc/llvm-project?rev=322774&view=rev Log: [analyzer] operator new: Use the correct region for the constructor. The -analyzer-config c++-allocator-inlining experimental option allows the analyzer to reaso

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322774: [analyzer] operator new: Use the correct region for the constructor. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r322775 - [analyzer] NFC: Forbid array elements of void type.

2018-01-17 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 17 14:40:36 2018 New Revision: 322775 URL: http://llvm.org/viewvc/llvm-project?rev=322775&view=rev Log: [analyzer] NFC: Forbid array elements of void type. Represent the symbolic value for results of pointer arithmetic on void pointers in a different way: instead o

[PATCH] D40939: [analyzer] NFC: Avoid element regions of void type.

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322775: [analyzer] NFC: Forbid array elements of void type. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D40939 Files: include/clang/StaticAnalyzer/Core/Path

[PATCH] D40925: Add option -fkeep-static-consts

2018-01-17 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. OK. My concern is that users need to use `__attribute__((used))` or something more robust if they want SVN identifiers to reliably appear in the output. Adding this flag just creates a trap that will fail once they turn on `-O2`. I'd rather not have it in the interface to a

[libcxx] r322776 - Fix nodiscard failure tests on compilers w/o -verify.

2018-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 17 14:48:09 2018 New Revision: 322776 URL: http://llvm.org/viewvc/llvm-project?rev=322776&view=rev Log: Fix nodiscard failure tests on compilers w/o -verify. Previously .fail.cpp tests for nodiscard were run with -Wunused-result being a warning, not an error, when the

r322777 - [analyzer] operator new: Model the cast of returned pointer into object type.

2018-01-17 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 17 14:51:19 2018 New Revision: 322777 URL: http://llvm.org/viewvc/llvm-project?rev=322777&view=rev Log: [analyzer] operator new: Model the cast of returned pointer into object type. According to [basic.stc.dynamic.allocation], the return type of any C++ overloaded

[PATCH] D41250: [analyzer] Model implied cast around operator new().

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322777: [analyzer] operator new: Model the cast of returned pointer into object type. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41250 Files: lib/StaticAn

r322778 - [DOXYGEN] Fix doxygen and content issues in xmmintrin.h

2018-01-17 Thread Douglas Yung via cfe-commits
Author: dyung Date: Wed Jan 17 14:53:15 2018 New Revision: 322778 URL: http://llvm.org/viewvc/llvm-project?rev=322778&view=rev Log: [DOXYGEN] Fix doxygen and content issues in xmmintrin.h - Fix inaccurate instruction listings. - Fix small issues in _mm_getcsr and _mm_setcsr. - Fix description of

[PATCH] D41523: xmmintrin.h documentation fixes and updates

2018-01-17 Thread Douglas Yung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322778: [DOXYGEN] Fix doxygen and content issues in xmmintrin.h (authored by dyung, committed by ). Repository: rC Clang https://reviews.llvm.org/D41523 Files: lib/Headers/xmmintrin.h Index: lib/He

r322779 - [Sema] Allow conversion between long double and __float128.

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 14:56:57 2018 New Revision: 322779 URL: http://llvm.org/viewvc/llvm-project?rev=322779&view=rev Log: [Sema] Allow conversion between long double and __float128. We should only ban this if long double is a double double. x86's 80 bit long double is fine and supported b

r322780 - [analyzer] operator new: Fix memory space for the returned region.

2018-01-17 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 17 14:58:35 2018 New Revision: 322780 URL: http://llvm.org/viewvc/llvm-project?rev=322780&view=rev Log: [analyzer] operator new: Fix memory space for the returned region. Make sure that with c++-allocator-inlining=true we have the return value of conservatively eva

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

2018-01-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322780: [analyzer] operator new: Fix memory space for the returned region. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41266 Files: lib/StaticAnalyzer/Core

r322781 - [analyzer] operator new: Fix ambigious type name.

2018-01-17 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Wed Jan 17 15:03:25 2018 New Revision: 322781 URL: http://llvm.org/viewvc/llvm-project?rev=322781&view=rev Log: [analyzer] operator new: Fix ambigious type name. Hopefully fixes an MSVC buildbot failure. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modi

r322783 - [ASTMatchers] Support generating docs for single-line matchers

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 15:14:49 2018 New Revision: 322783 URL: http://llvm.org/viewvc/llvm-project?rev=322783&view=rev Log: [ASTMatchers] Support generating docs for single-line matchers clang-format likes this format. PR35989. Modified: cfe/trunk/docs/tools/dump_ast_matchers.py cf

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

2018-01-17 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added reviewers: akyrtzi, benlangmuir. vsk added inline comments. Comment at: tools/c-index-test/c-index-test.c:3268 - filename = clang_getFileName(file); - index_data->main_filename = clang_getCString(filename); - clang_disposeString(filename); + index_data->main_filen

<    1   2   3   >