ahatanak updated this revision to Diff 129038.
ahatanak added a comment.
Add more tests for template instantiation of "trivial_abi" classes.
https://reviews.llvm.org/D41039
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
include/clang/AST/Type.
ahatanak marked 7 inline comments as done.
ahatanak added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11700
+}
+ }
+
rsmith wrote:
> rjmccall wrote:
> > I think it's correct not to call CheckDestructorAccess and
> > DiagnoseUseOfDecl here, since acco
ed accepted this revision.
ed added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D41500#965157, @zhmu wrote:
> @ed I tried to keep things as much in line as the other
> ::linker::Construct() functions do. Do you wish to stray from that path?
>
> I actua
sammccall added a comment.
This makes `SymbolCollector` (production code) depend on YAML (explicitly
experimental), as well as on Tooling interfaces.
At least we should invert this by making the thing passed to SymbolCollector a
`function` or so.
Moreover, it's unfortunate we'd need to change S
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322063: Added Control Flow Protection Flag (authored by
orenb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40478?vs=128601&id=129041#toc
Repository:
rC Clang
https://reviews.l
Author: orenb
Date: Tue Jan 9 00:53:59 2018
New Revision: 322063
URL: http://llvm.org/viewvc/llvm-project?rev=322063&view=rev
Log:
Added Control Flow Protection Flag
Cf-protection is a target independent flag that instructs the back-end to
instrument control flow mechanisms like: Branch, Return
hokein created this revision.
hokein added reviewers: ilya-biryukov, alexfh.
Herald added subscribers: xazax.hun, klimek.
A follow-up fix of https://reviews.llvm.org/rL311652.
The previous `vector` in our test is different with `std::vector`, so
The check still generates fixes for std::vector (`a
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Just some nits
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
ioeric wrote:
> sammccall wrote:
> > ioeric wrote:
> > > sammccall wr
Author: ed
Date: Tue Jan 9 01:18:14 2018
New Revision: 322064
URL: http://llvm.org/viewvc/llvm-project?rev=322064&view=rev
Log:
ananas: Add shared library support
The Ananas Operating System (https://github.com/zhmu/ananas) has shared
library support as of commit 57739c0b6ece56dd4872aedf30264ed4
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322064: ananas: Add shared library support (authored by ed,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41500?vs=127907&id=129045#toc
Repository:
rC Clang
https://reviews.llvm
Author: sammccall
Date: Tue Jan 9 01:32:53 2018
New Revision: 322065
URL: http://llvm.org/viewvc/llvm-project?rev=322065&view=rev
Log:
Avoid assumption that lit tests are writable (in a couple more places). NFC
Modified:
cfe/trunk/test/Modules/modify-module.m
cfe/trunk/test/PCH/modified-
hokein added a comment.
With this patch, the index-based code completion will not provide any
candidates for `ns1::MyClass::^` (as the index-based completion drops all
results from clang's completion engine), we need a way to combine symbols from
3 sources (static index, dynamic index and clan
hokein updated this revision to Diff 129047.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix remaining comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41668
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM (see the review comment about adding a comment in the code too)
Comment at: clangd/index/SymbolCollector.cpp:89
+// violations.
+if (ND->isInAnonym
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41823#970725, @hokein wrote:
> With this patch, the index-based code completion will not provide any
> candidates for `ns1::MyClass::^` (as the index-based completion drops all
> results from clang's completion engine), we need a way
hokein updated this revision to Diff 129053.
hokein added a comment.
Add a comment for symbols in anonymous namespace.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41759
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/c
Author: hokein
Date: Tue Jan 9 02:44:09 2018
New Revision: 322067
URL: http://llvm.org/viewvc/llvm-project?rev=322067&view=rev
Log:
[clangd] Catch more symbols in SymbolCollector.
Summary:
We currently only collect external-linkage symbols in the collector,
which results in missing some typical
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rCTE322067: [clangd] Catch more symbols in SymbolCollector.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41759?vs=129053
ilya-biryukov added a comment.
@malaperle, hi! Both new diff and updating this works, so feel free the one
that suits you best. I tend to look over the whole change on each new round of
reviews anyway.
Comment at: clangd/ClangdUnit.cpp:113
+ CppFilePreambleCallbacks(Includ
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D41487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
xazax.hun added a comment.
Overall looks good to me, one comment inline. I think it is good to have these
checks to prevent the analyzer executing undefined behavior. Maybe this would
make it more feasible to run the analyzer with ubsan :)
In the future, it would be great to also look for these
sammccall added inline comments.
Comment at: clangd/ClangdLSPServer.h:40
+ bool BuildDynamicSymbolIndex,
+ std::unique_ptr StaticIdx);
is there a reason ClangdServer should own this? I can imagine this complicating
life for em
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Great! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D6550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.h:40
+ bool BuildDynamicSymbolIndex,
+ std::unique_ptr StaticIdx);
sammccall wrote:
> is there a reason ClangdServer should own this? I can imagine this
>
ioeric updated this revision to Diff 129058.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- [clangd] Address review comments; made Detail a pointer.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
c
ioeric updated this revision to Diff 129059.
ioeric marked an inline comment as done.
ioeric added a comment.
- Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
clangd/index/File
ioeric updated this revision to Diff 129063.
ioeric added a comment.
Address review comment: move all ToolExecutor and YAML-specific logics out of
SymbolCollector.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41730
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMai
ioeric added a comment.
In https://reviews.llvm.org/D41730#970704, @sammccall wrote:
> This makes `SymbolCollector` (production code) depend on YAML (explicitly
> experimental), as well as on Tooling interfaces.
> At least we should invert this by making the thing passed to SymbolCollector
> a
milianw added a comment.
still looks good to me. can someone else please review and commit this?
Repository:
rC Clang
https://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
milianw requested changes to this revision.
milianw added a comment.
This revision now requires changes to proceed.
I'm pretty sure this is not ABI compatible. You change the size of
`CXCompletionResult`, so when anyone is iterating over the array in
`CXCompletionResults` it will break. If you d
Author: aaronballman
Date: Tue Jan 9 05:07:03 2018
New Revision: 322074
URL: http://llvm.org/viewvc/llvm-project?rev=322074&view=rev
Log:
Track in the AST whether the operand to a UnaryOperator can overflow and then
use that logic when evaluating constant expressions and emitting codegen.
Modif
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! Committed in r322074.
https://reviews.llvm.org/D33563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
LG!
Comment at: include/clang/Analysis/ProgramPoint.h:592
+ friend class ProgramPoint;
+ PostAllocatorCall() {}
+ static bool isKind(const ProgramPoint &Location) {
Maybe `= default` is getting mor
xazax.hun added a comment.
Do you have a plan for the new false negatives when `c++-allocator-inlining` is
on? Should the user mark allocation functions with attributes?
Also, I was wondering if it would make sense to only have the PostCall callback
return the casted memory region in these spec
rnkovacs updated this revision to Diff 129071.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D41816
Files:
lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp
lib/StaticAnalyzer/Core/BasicValueFactory.cpp
test/Analysis/bitwise-ops.c
Index: test/Analysis/bitwise-ops.c
rnkovacs added a comment.
In https://reviews.llvm.org/D41816#970845, @xazax.hun wrote:
> Overall looks good to me, one comment inline. I think it is good to have
> these checks to prevent the analyzer executing undefined behavior. Maybe this
> would make it more feasible to run the analyzer wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322079: [ASTImporter] Fix missing SourceLoc import for
ObjCMethodDecl selectors (authored by a.sidorin, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D6550
Files:
lib/AST/ASTImporter
Author: a.sidorin
Date: Tue Jan 9 06:25:05 2018
New Revision: 322079
URL: http://llvm.org/viewvc/llvm-project?rev=322079&view=rev
Log:
[ASTImporter] Fix missing SourceLoc import for ObjCMethodDecl selectors
Patch by Nico Rieck, test case by Sean Callanan!
Differential Revision: https://reviews.
xazax.hun added a comment.
> (@xazax.hun - this is an alpha checker last touched by you, do you still have
> plans for it?)
I think this check could be very useful. Last I checked it was too noisy (e.g.:
around 850 hits on LLVM), and I did plan to look into what are the main sources
of false p
alexfh added inline comments.
Comment at: test/CodeGen/x86-cf-protection.c:1
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple
i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s
--check-prefix=RETURN
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm
Author: ibiryukov
Date: Tue Jan 9 06:39:27 2018
New Revision: 322080
URL: http://llvm.org/viewvc/llvm-project?rev=322080&view=rev
Log:
[clangd] Fix a bug in asynchronous code completion
A StringRef that goes out of scope was copied and used in a handler
running on a separate thread.
We didn't ca
xazax.hun added a comment.
I am fine with suppressing the escape globally.
I did see some code in the wild where the constructors registered the objects
with a (global) map.
But I think it is still easier to annotate code that does something
unconventional than the other way around.
Repository
ioeric updated this revision to Diff 129075.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang-tools-extra into symbol
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
ioeric added inline comments.
Comment at: clangd/index/Index.h:122
+
+ llvm::Optional Detail;
+
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > ioeric wrote:
> > > > sammccall wrote:
> > > > > I think you probably want a raw pointer rather than optio
oren_ben_simhon added inline comments.
Comment at: test/CodeGen/x86-cf-protection.c:1
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple
i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s
--check-prefix=RETURN
+// RUN: not %clang_cc1 -fsyntax-only -S -e
Author: alexfh
Date: Tue Jan 9 07:05:13 2018
New Revision: 322082
URL: http://llvm.org/viewvc/llvm-project?rev=322082&view=rev
Log:
Explicitly specify output file.
Otherwise the test fails when LLVM sources are on a read-only partition.
Modified:
cfe/trunk/test/CodeGen/x86-cf-protection.c
alexfh added inline comments.
Comment at: test/CodeGen/x86-cf-protection.c:1
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple
i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s
--check-prefix=RETURN
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm
ioeric updated this revision to Diff 129078.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed comments.
- Merged with origin/master
- Merge with diff base.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41823
Files:
clangd/global-symbol-builder/Glo
ioeric added a comment.
Thanks for the reviews!
Comment at: clangd/index/FileIndex.cpp:22
llvm::ArrayRef Decls) {
- auto Collector = std::make_shared();
+ auto CollectorOpts = SymbolCollector::Options();
+ CollectorOpts.IndexMainFiles =
hokein updated this revision to Diff 129081.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41668
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
Author: ioeric
Date: Tue Jan 9 07:21:45 2018
New Revision: 322084
URL: http://llvm.org/viewvc/llvm-project?rev=322084&view=rev
Log:
[clangd] Use ToolExecutor to write the global-symbol-builder tool.
Summary:
This enables more execution modes like standalone and Mapreduce-style execution.
See al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322084: [clangd] Use ToolExecutor to write the
global-symbol-builder tool. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41
This is is the status of OpenMP support in 6.0. There is nothing new
since branching.
-
Best regards,
Alexey Bataev
08.01.2018 14:09, Jonas Hahnfeld via cfe-commits пишет:
> Can we backport this page to release_60? I think the documented
> support is also valid for 6.0 or did I miss r
Author: maskray
Date: Mon Jan 8 10:57:38 2018
New Revision: 322017
URL: http://llvm.org/viewvc/llvm-project?rev=322017&view=rev
Log:
[index] Return when DC is null in handleReference
Summary:
DC may sometimes be NULL and getContainerInfo(DC, Container) will dereference a
null pointer.
Default
oren_ben_simhon marked an inline comment as done.
oren_ben_simhon added inline comments.
Comment at: test/CodeGen/x86-cf-protection.c:1
+// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple
i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s
--check-prefix=
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
rjmccall wrote:
> aaron.ballman wrote:
> > rjmccall wrote:
> > > I have no objection to allowing ObjC attributes to be spelled in
> > > [[clang::obj
modocache created this revision.
modocache added a reviewer: v.g.vassilev.
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager should not need to be used when parsing
preprocessor arguments. In fact, its only use was removed 6 years ago
(2012), in htt
khuttun updated this revision to Diff 129090.
khuttun added a comment.
The checker is now disabled inside GNU statement expressions
https://reviews.llvm.org/D41655
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/UnusedReturnValueChe
alexfh added a comment.
A high-level comment: NOLINT category parsing and warning on incorrect NOLINT
categories makes it more difficult for code to comply both with clang-tidy and
cpplint (https://github.com/cpplint/cpplint), since:
1. the category names in these tools are different,
2. cpplin
Author: a.sidorin
Date: Tue Jan 9 08:40:40 2018
New Revision: 322091
URL: http://llvm.org/viewvc/llvm-project?rev=322091&view=rev
Log:
[ASTImporter] Support importing CXXUnresolvedConstructExpr and
UnresolvedLookupExpr
* Note: This solution is based on
https://github.com/haoNoQ/clang/blob/su
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322091: [ASTImporter] Support importing
CXXUnresolvedConstructExpr and… (authored by a.sidorin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38694?vs=127283&id=129095#toc
Reposito
a.sidorin added a comment.
Hi Artem,
I think that global suppression is fine. If one really wants to check such
escapes, he can implement a separate callback for this.
Repository:
rC Clang
https://reviews.llvm.org/D41797
___
cfe-commits mailing
NoQ added a comment.
In https://reviews.llvm.org/D41406#970985, @xazax.hun wrote:
> Also, I was wondering if it would make sense to only have the PostCall
> callback return the casted memory region in these specific cases instead of
> introducing a new callback.
Yep, i actually think it's a v
Author: jhb
Date: Tue Jan 9 09:07:18 2018
New Revision: 322093
URL: http://llvm.org/viewvc/llvm-project?rev=322093&view=rev
Log:
[libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.
This is in preparation for adding support for N32 unwinding which reuses
the newabi register cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322093: [libunwind][MIPS]: Rename Registers_mips_n64 to
Registers_mips_newabi. (authored by jhb, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/index/SymbolYAML.cpp:78
+assert(io.getContext());
+Detail = static_cast(io.getContext())
+ ->Allocate();
this removes the Detail object if it
sammccall accepted this revision.
sammccall added a comment.
Ilya's suggestion to have a single index on the CodeCompleteOptions that
encapsulates the merging seems reasonable to me, but not urgent.
So let's get this in as-is and we can make that change whenever.
Comment at: c
bsdjhb updated this revision to Diff 129103.
bsdjhb added a comment.
- Rebase after N64 -> newabi commit.
https://reviews.llvm.org/D39074
Files:
include/__libunwind_config.h
src/AddressSpace.hpp
src/DwarfInstructions.hpp
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
src/lib
ioeric updated this revision to Diff 129106.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addrress review comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComplete.cpp
clangd/
Author: ioeric
Date: Tue Jan 9 09:32:00 2018
New Revision: 322097
URL: http://llvm.org/viewvc/llvm-project?rev=322097&view=rev
Log:
[clangd] Add more symbol information for code completion.
Reviewers: hokein, sammccall
Reviewed By: sammccall
Subscribers: klimek, ilya-biryukov, cfe-commits
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322097: [clangd] Add more symbol information for code
completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41345?vs=129106&id=129110#toc
Repository:
r
ioeric updated this revision to Diff 129112.
ioeric added a comment.
- Rebase on origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41823
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
clangd/index/FileIndex.cpp
clangd/index/SymbolCollector.cpp
TyanNN updated this revision to Diff 129115.
TyanNN retitled this revision from "[libc++] Fix PR#35780 - make
std::experimental::filesystem::remove return false if the file doesn't exist"
to "[libc++] Fix PR#35780 - make std::experimental::filesystem::remove and
remove_all return false or 0 if t
rjmccall added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
aaron.ballman wrote:
> rjmccall wrote:
> > aaron.ballman wrote:
> > > rjmccall wrote:
> > > > I have no objection to allowing ObjC attributes to be spelle
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D41841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vsapsai updated this revision to Diff 129125.
vsapsai added a comment.
- Don't parse exponent past the end of token, add same test+fix for hexadecimal
numbers.
https://reviews.llvm.org/D41834
Files:
clang/lib/Lex/LiteralSupport.cpp
clang/test/Lexer/cxx1y_digit_separators.cpp
Index: clang
mclow.lists added inline comments.
Comment at: src/experimental/filesystem/operations.cpp:666
if (::remove(p.c_str()) == -1) {
-set_or_throw(ec, "remove", p);
+if (ec != nullptr && *ec != errc::no_such_file_or_directory)
+set_or_throw(ec, "remove"
jdenny added a comment.
Alexey: Thanks for accepting. I do not have commit privileges. Would
you please commit for me?
https://reviews.llvm.org/D41841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
ABataev added a comment.
In https://reviews.llvm.org/D41841#971375, @jdenny wrote:
> Alexey: Thanks for accepting. I do not have commit privileges. Would
> you please commit for me?
Sure
https://reviews.llvm.org/D41841
___
cfe-commits mailing li
mclow.lists added inline comments.
Comment at: src/experimental/filesystem/operations.cpp:699
auto count = remove_all_impl(p, mec);
if (mec) {
+if (mec != errc::no_such_file_or_directory) {
I don't think that this is quite right, either.
In the
Author: abataev
Date: Tue Jan 9 11:21:04 2018
New Revision: 322107
URL: http://llvm.org/viewvc/llvm-project?rev=322107&view=rev
Log:
[OpenMP] Fix handling of clause on wrong directive, by Joel. E. Denny
Summary:
First, this patch fixes an assert failure when, for example, "omp for"
has num_teams
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322107: [OpenMP] Fix handling of clause on wrong directive,
by Joel. E. Denny (authored by ABataev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
phosek updated this revision to Diff 129138.
Repository:
rCXX libc++
https://reviews.llvm.org/D41755
Files:
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -356,10 +356,11 @@
phosek updated this revision to Diff 129140.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41754
Files:
src/CMakeLists.txt
Index: src/CMakeLists.txt
===
--- src/CMakeLists.txt
+++ src/CMakeLists.txt
@@ -180,10 +180,11
Author: abataev
Date: Tue Jan 9 11:59:25 2018
New Revision: 322112
URL: http://llvm.org/viewvc/llvm-project?rev=322112&view=rev
Log:
[OPENMP] Fix directive kind on stand-alone target data directives, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CG
svenbrauch added a comment.
I know it breaks ABI compatiblity, I just don't know whether it needs to be
kept (e.g. for clang-6.0). The alternative requires sorting by a separate index
list which is a bit ugly (and slower). If you feel like working on it in the
next few days that would of course
STL_MSFT added a comment.
Ping? (And happy Patch Tuesday!)
https://reviews.llvm.org/D41213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: ioeric
Date: Tue Jan 9 12:26:49 2018
New Revision: 322116
URL: http://llvm.org/viewvc/llvm-project?rev=322116&view=rev
Log:
Try to fix build failure caused by r322097
Avoid mapping during output when Detail is nullptr; otherwise, an empty
"Detail" field will be populated in YAML output.
Why is this NFC and doesn't change a test?
Am 2018-01-09 20:59, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Tue Jan 9 11:59:25 2018
New Revision: 322112
URL: http://llvm.org/viewvc/llvm-project?rev=322112&view=rev
Log:
[OPENMP] Fix directive kind on stand-alone target data dir
efriedma added inline comments.
Comment at: cfe/trunk/lib/Headers/emmintrin.h:4683
///
-/// This intrinsic has no corresponding instruction.
+/// This intrinsic corresponds to the MOVDQ2Q instruction.
///
kromanova wrote:
> efriedma wrote:
> > kromanova wrote
oren_ben_simhon created this revision.
oren_ben_simhon added reviewers: erichkeane, craig.topper, AndreiGrischenko,
aaboud.
Herald added subscribers: llvm-commits, javed.absar.
The patch adds nocf_check target independent attribute for disabling checks
that were enabled by cf-protection flag.
Th
trixirt created this revision.
trixirt added a reviewer: dcoughlin.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
bcmp, bcopy and bzero are obsolete functions.
Flag them as such so users will not use them.
Repository:
rC Clang
https://reviews.llvm.org/D41881
Files:
i
mclow.lists added a comment.
> According to 15.8.2 [class.copy.assign]/2 and /4, this makes call_wrapper
> non-assignable.
Then I think we've got a LWG issue, because that's not what I remember the
intent to have been.
https://reviews.llvm.org/D41213
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322118: [Frontend] Remove unused FileMgr in pp arg parse
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41867?vs=129089&id=129152#toc
Repository:
rC Clang
Author: modocache
Date: Tue Jan 9 13:26:47 2018
New Revision: 322118
URL: http://llvm.org/viewvc/llvm-project?rev=322118&view=rev
Log:
[Frontend] Remove unused FileMgr in pp arg parse
Summary:
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager shou
modocache added a comment.
Great, thanks for the review, @v.g.vassilev!
Repository:
rC Clang
https://reviews.llvm.org/D41867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
> which would re-evaluate the cast and return the casted object
Rather not. Because i'm changing my mind again about avoiding the redundant
cast in `&element{T, HeapSymRegion{conj}}` - this time by not calling
`evalCast` after a conservatively evaluated operator new call (t
Author: dblaikie
Date: Tue Jan 9 14:03:47 2018
New Revision: 322126
URL: http://llvm.org/viewvc/llvm-project?rev=322126&view=rev
Log:
Wire up GCOV to the new pass manager
GCOV in the old pass manager also strips debug info (if debug info is
disabled/only produced for profiling anyway) after the
mclow.lists added a comment.
Investigating the assignability of `not_fn`. All the rest of this looks fine.
https://reviews.llvm.org/D41213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
1 - 100 of 139 matches
Mail list logo
