[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

2018-01-04 Thread Tim Shen via Phabricator via cfe-commits
timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. popcount is implemented in terms of for loop. On x86, it can be specialized to _mm_movemask_* + __builtin_popcountll() in the future. https://reviews.llvm.org/D41756 Files: libcxx/

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

2018-01-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added inline comments. Comment at: test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp:31 -template -struct identity : std::unary_function -{ -constexpr const T& operator()(const T& x) const { return x;} -}; -

[PATCH] D41750: Fix TLS support check for Darwin 32-bit simulator targets.

2018-01-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks https://reviews.llvm.org/D41750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

2018-01-04 Thread Tim Shen via Phabricator via cfe-commits
timshen updated this revision to Diff 128706. timshen added a comment. Add tests to boolean version of the horizontal operations. https://reviews.llvm.org/D41756 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/to_compatible.pass.cpp libcxx/test/std/exp

[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

2018-01-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Basic/DiagnosticIDs.cpp:58 /// GetDiagInfo - Return the StaticDiagInfoRec entry for the specified DiagID, /// or null if the ID is invalid. This comment is out of date with the struct being renamed. ==

r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

2018-01-04 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Jan 4 18:33:18 2018 New Revision: 321855 URL: http://llvm.org/viewvc/llvm-project?rev=321855&view=rev Log: Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified

[PATCH] D41517: mmintrin.h documentation fixes and updates

2018-01-04 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// I tried clang on Linux, x86_64, and if -mavx option is p

[PATCH] D41517: mmintrin.h documentation fixes and updates

2018-01-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// kromanova wrote: > I tried clang on Linux, x86_64, an

[PATCH] D41523: xmmintrin.h documentation fixes and updates

2018-01-04 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: lib/Headers/xmmintrin.h:2199 /// -/// This intrinsic corresponds to the VPINSRW / PINSRW instruction. +/// This intrinsic corresponds to the PINSRW instruction. /// craig.topper wrote: > Why is VPINSRW removed? I

[PATCH] D41523: xmmintrin.h documentation fixes and updates

2018-01-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Headers/xmmintrin.h:2199 /// -/// This intrinsic corresponds to the VPINSRW / PINSRW instruction. +/// This intrinsic corresponds to the PINSRW instruction. /// kromanova wrote: > craig.topper wrote: > > W

[PATCH] D41039: Add support for attribute "trivial_abi"

2018-01-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D41039#951807, @rjmccall wrote: > In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: > > > I had a discussion with Duncan today and he pointed out that perhaps we > > shouldn't allow users to annotate a struct with "trivial_abi" if o

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

2018-01-04 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/StreamInt8Check.cpp:1 +//===--- StreamInt8Check.cpp - clang-tidy--===// +// Please add real description, use space after it and shorten to 80 symbols. ===

[PATCH] D41516: emmintrin.h documentation fixes and updates

2018-01-04 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:1143 /// -///If either of the two lower double-precision values is NaN, 1 is returned. +///If either of the two lower double-precision values is NaN, 0 is returned. /// For

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

2018-01-04 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Could you please add a test case with a template that reduces the type to int8 or uint8? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t

2018-01-04 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/bugprone/StreamInt8Check.cpp:26 + hasDeclaration(cxxRecordDecl(hasName("std::basic_ostream", +hasArgument(1, expr(hasType(hasCanonicalType( +anyOf(asString("signed char

r321859 - No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

2018-01-04 Thread Stephan Bergmann via cfe-commits
Author: sberg Date: Thu Jan 4 23:57:12 2018 New Revision: 321859 URL: http://llvm.org/viewvc/llvm-project?rev=321859&view=rev Log: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17 As discussed in the mail thread

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

2018-01-04 Thread Stephan Bergmann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321859: No -fsanitize=function warning when calling noexcept function through non… (authored by sberg, committed by ). Changed prior to commit: https://reviews.llvm.org/D40720?vs=128289&id=128710#toc R

<    1   2