r321775 - PR35815: Separate out the ns-consumed diagnostic into an error and

Author: arphaman Date: Wed Jan 3 15:52:42 2018 New Revision: 321775 URL: http://llvm.org/viewvc/llvm-project?rev=321775&view=rev Log: PR35815: Separate out the ns-consumed diagnostic into an error and a warning This commit separates out the warn_nsconsumed_attribute_mismatch and warn_nsreturns_r

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

itessier created this revision. itessier added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. This change will allow enabling of colour diagnostics when not directly running within a terminal, but colour output is possible. For example, if stdout is being captured and redire

Re: trivial_abi

On 3 January 2018 at 15:24, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Jan 3, 2018, at 5:53 PM, Richard Smith wrote: > On 3 January 2018 at 14:29, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> On Jan 3, 2018, at 5:12 PM, Richard Smith wrote

r321776 - Fix test to use -S instead of -c so it doesn't unnecessarily run the assembler.

Author: dyung Date: Wed Jan 3 16:16:57 2018 New Revision: 321776 URL: http://llvm.org/viewvc/llvm-project?rev=321776&view=rev Log: Fix test to use -S instead of -c so it doesn't unnecessarily run the assembler. Reviewed by Paul Robinson Modified: cfe/trunk/test/Driver/config-file.c Modifi

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Vedant, I'm looking into it. On Wed, Jan 3, 2018 at 11:12 AM, Vedant Kumar wrote: > Oops, the build log was too big to attach. Resending with just the bot > link, then: > http://lab.llvm.org:8080/green/view/Experimental/job/ > clang-stage2-coverage-R/2193/consoleText > > vedant > > On Jan 3, 20

r321777 - PR35028: Retain duplicate alignas attributes in template instantiation.

Author: rsmith Date: Wed Jan 3 17:02:18 2018 New Revision: 321777 URL: http://llvm.org/viewvc/llvm-project?rev=321777&view=rev Log: PR35028: Retain duplicate alignas attributes in template instantiation. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/test/SemaTemplate/alignas.

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast updated this revision to Diff 128584. hubert.reinterpretcast added a comment. Use cp -R, which is sufficient instead of cp -RPp Repository: rC Clang https://reviews.llvm.org/D41545 Files: test/Modules/crash-vfs-path-emptydir-entries.m test/Modules/crash-vfs-path-sy

[PATCH] D41545: Replace cp -a in various Clang tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC321778: Replace cp -a in various Clang tests (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41545?vs=128584&id=128586#toc Repository: rC Clang

r321778 - Replace cp -a in various Clang tests

Author: hubert.reinterpretcast Date: Wed Jan 3 17:15:52 2018 New Revision: 321778 URL: http://llvm.org/viewvc/llvm-project?rev=321778&view=rev Log: Replace cp -a in various Clang tests Summary: cp -a is neither part of POSIX nor the LSB. The nearest equivalent under POSIX is cp -RPp; however, cp

r321779 - PR35045: Convert injected-class-name to its corresponding simple-template-id

Author: rsmith Date: Wed Jan 3 17:24:17 2018 New Revision: 321779 URL: http://llvm.org/viewvc/llvm-project?rev=321779&view=rev Log: PR35045: Convert injected-class-name to its corresponding simple-template-id during template argument deduction. We already did this when the injected-class-name wa

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added inline comments. Comment at: test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59 +{ +assert(r.real() == 0); +assert(!std::signbit(r.real())); Ideally, I would prefer some approximate comparison

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// craig.topper wrote: > PXOR? For which platform/compil

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

bruno added a comment. > It might make more sense to have the module loaded from the AST file shadow > the module from the module map, especially for an explicit module build, now > that we have that functionality.) +1, seems a much more consistent model. Comment at: lib/Lex

r321781 - [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Author: bruno Date: Wed Jan 3 18:17:40 2018 New Revision: 321781 URL: http://llvm.org/viewvc/llvm-project?rev=321781&view=rev Log: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones When modules come from module map files explicitly specified by -fmodule-map-

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

This revision was automatically updated to reflect the committed changes. Closed by commit rL321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly… (authored by bruno, committed by ). Changed prior to commit: https://reviews.llvm.org/D31269?vs=92738&id=128590#toc

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments, otherwise I'm pretty happy. I'd wait for an ack by Richard for this though. -eric Comment at: lib/CodeGen/CGBuiltin.cpp:7673 -Value *CodeGe

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Wed, Jan 3, 2018 at 2:07 PM, Akira Hatanaka wrote: > On Jan 3, 2018, at 10:25 AM, John McCall wrote: > > On Wed, Jan 3, 2018 at 12:24 PM, Akira Hatanaka > wrote: > >> On Jan 2, 2018, at 9:42 AM, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> >> >> On Tue, Dec 19,

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

rsmith added a comment. Lots of comments, but no high-level design concerns. I think this is very close to being ready to go. Comment at: include/clang/AST/Decl.h:2162-2168 + /// Sets the multiversion state for this declaration and all of its + /// redeclarations. + void se

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

> On Jan 3, 2018, at 6:39 PM, John McCall wrote: > > On Wed, Jan 3, 2018 at 2:07 PM, Akira Hatanaka > wrote: >> On Jan 3, 2018, at 10:25 AM, John McCall > > wrote: >> >> On Wed, Jan 3, 2018 at 12:24 PM, Akira Hatanaka >

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

elsteveogrande updated this revision to Diff 128593. elsteveogrande added a comment. Update: now works properly with modules as well. This needed to handle the case where a `ParmDecl` is already inheriting, but it's innocuously inheriting from the same decl. Now `inheritDefaultTemplateArgument

r321786 - Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones"

Author: bruno Date: Wed Jan 3 23:31:24 2018 New Revision: 321786 URL: http://llvm.org/viewvc/llvm-project?rev=321786&view=rev Log: Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones" This reverts r321781 until I fix the leaks pointed out by bots: htt

[PATCH] D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name

lebedev.ri added a comment. > And also enable it by default to be consistent with e.g. modernize-use-using. That changes the defaults though. I thought clang-tidy *tried* to produce the same results on different clang-tidy versions with the same `.clang-tidy` config? Or is there no such guarant

[PATCH] D41711: [docs] Mention support for Windows/ARM64 in the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL321788: [docs] Mention support for Windows/ARM64 in the release notes (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D41711?vs=128555&id=128596#toc Repository:

<    1   2