[PATCH] D41627: [Modules TS] Fix namespace visibility

2017-12-29 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood created this revision. hamzasood added reviewers: rsmith, bruno, boris. Namespaces without an explicit `export` were being mistakenly marked as module private. This patch fixes the visibility as per `[basic.namespace]p1` and adds a test case with previously rejected (yet valid) code.

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2017-12-29 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently std::asinh and std::acosh use std::pow to compute x^2. This results in a significant error when computing e.g. asinh(i) or acosh(-1). This patch expresses x^2 directly via x.real() and x.imag(), like it is done i

[clang-tools-extra] r321554 - [clangd] Properly set filterText for index-based completion items

2017-12-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Dec 29 06:59:22 2017 New Revision: 321554 URL: http://llvm.org/viewvc/llvm-project?rev=321554&view=rev Log: [clangd] Properly set filterText for index-based completion items It was previously set to an identifier that the user typed, leading to surprising behavior in V

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

2017-12-29 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:277 + BT_leakedvalist.reset(new BugType( + CheckNames[ReportUninit ? CK_Uninitialized : CK_Unterminated], + "Leaked va_list", categories::MemoryError)); -

r321558 - [OPENMP] Initial support for `-fopenmp-simd` option.

2017-12-29 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 29 09:36:15 2017 New Revision: 321558 URL: http://llvm.org/viewvc/llvm-project?rev=321558&view=rev Log: [OPENMP] Initial support for `-fopenmp-simd` option. Added basic support for `-fopenmp-simd` options. Modified: cfe/trunk/include/clang/Basic/LangOptions.def

r321559 - [driver][darwin] Take the OS version from -m-version-min argument when

2017-12-29 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Dec 29 09:42:40 2017 New Revision: 321559 URL: http://llvm.org/viewvc/llvm-project?rev=321559&view=rev Log: [driver][darwin] Take the OS version from -m-version-min argument when -target has no OS version This ensures that Clang won't warn about redundant -m-version-min

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

2017-12-29 Thread Alex L via cfe-commits
I committed the patch that allows -m-version-min to specify the OS version when -target doesn't specify in r321559. Let me know if it works for you! Thanks, Alex On 21 December 2017 at 12:34, James Y Knight wrote: > I totally agree with moving towards eliminating the -m-version-min > flags, it'

r321561 - [docs] Updated ReleaseNotes for OpenMP part.

2017-12-29 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 29 10:23:12 2017 New Revision: 321561 URL: http://llvm.org/viewvc/llvm-project?rev=321561&view=rev Log: [docs] Updated ReleaseNotes for OpenMP part. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/

r321562 - [docs] Added description of `-f[no]-openmp-simd` option to UsersManual.

2017-12-29 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Dec 29 10:27:00 2017 New Revision: 321562 URL: http://llvm.org/viewvc/llvm-project?rev=321562&view=rev Log: [docs] Added description of `-f[no]-openmp-simd` option to UsersManual. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[PATCH] D41500: ananas: Add shared library support

2017-12-29 Thread Rink via Phabricator via cfe-commits
zhmu added a comment. @ed I tried to keep things as much in line as the other ::linker::Construct() functions do. Do you wish to stray from that path? I actually prefer to keep it like this as it's quite readable already, but YMMV of course :-) Repository: rC Clang https://reviews.llvm.org

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

2017-12-29 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D41544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41545: Replace cp -a in various Clang tests

2017-12-29 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Maybe `cp -R` is sufficient? `cp -RPp` was the just-to-be-safe "minimal change". Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D40737: [clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test

2017-12-29 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. @sbenza and/or @klimek did you have time to address the stackoverflow caused from the ASTMatchers? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40737 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[libcxx] r321563 - Update CREDITS.txt with personal email

2017-12-29 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Fri Dec 29 11:15:20 2017 New Revision: 321563 URL: http://llvm.org/viewvc/llvm-project?rev=321563&view=rev Log: Update CREDITS.txt with personal email Modified: libcxx/trunk/CREDITS.TXT Modified: libcxx/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx

[libcxxabi] r321564 - Update CREDITS.txt with personal email address

2017-12-29 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Fri Dec 29 11:16:12 2017 New Revision: 321564 URL: http://llvm.org/viewvc/llvm-project?rev=321564&view=rev Log: Update CREDITS.txt with personal email address Modified: libcxxabi/trunk/CREDITS.TXT Modified: libcxxabi/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-

[libcxxabi] r321569 - Try again, this time with the correct address

2017-12-29 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Fri Dec 29 11:26:28 2017 New Revision: 321569 URL: http://llvm.org/viewvc/llvm-project?rev=321569&view=rev Log: Try again, this time with the correct address Modified: libcxxabi/trunk/CREDITS.TXT Modified: libcxxabi/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-p

[libcxx] r321570 - Try again, this time with the correct address

2017-12-29 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Fri Dec 29 11:26:53 2017 New Revision: 321570 URL: http://llvm.org/viewvc/llvm-project?rev=321570&view=rev Log: Try again, this time with the correct address Modified: libcxx/trunk/CREDITS.TXT Modified: libcxx/trunk/CREDITS.TXT URL: http://llvm.org/viewvc/llvm-project

[PATCH] D41623: [cmake] [libcxxabi] Fix path problems when cross compiling.

2017-12-29 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I think that it might be better to handle this as a single global change: if(CMAKE_FIND_ROOT_PATH) set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE NEVER) endif() Repository: rCXXA libc++abi https://reviews.llvm.org/D41623 ___

[PATCH] D41621: [cmake] [libunwind] Fix path problems when cross compiling.

2017-12-29 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Similar to the libc++abi and libc++ changes. https://reviews.llvm.org/D41621 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

2017-12-29 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. Similar to the libc++abi wrt `find_path`. The `CMAKE_REQUIRED_FLAGS` handling LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

2017-12-29 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Would it be possible to split the `CMAKE_REQUIRED_FLAGS` fix into a separate change since it's unrelated to the `CMAKE_FIND_ROOT_PATH` bit? Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing l

[PATCH] D41623: [cmake] [libcxxabi] Fix path problems when cross compiling.

2017-12-29 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In https://reviews.llvm.org/D41623#965271, @compnerd wrote: > I think that it might be better to handle this as a single global change: > > if(CMAKE_FIND_ROOT_PATH) > set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE NEVER) > endif() When I cross compile on Darwin and targ

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

2017-12-29 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In https://reviews.llvm.org/D41622#965280, @phosek wrote: > Would it be possible to split the `CMAKE_REQUIRED_FLAGS` fix into a separate > change since it's unrelated to the `CMAKE_FIND_ROOT_PATH` bit? Sure, but both are needed to actually work. This fixes cross comp

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

2017-12-29 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. Btw, here's the WIP toolchain file I"m using, which might help clear up why these changes is necessary: https://github.com/donhinton/misc/blob/master/cmake/linux-toolchain.cmake Repository: rCXX libc++ https://reviews.llvm.org/D41622 __

r321574 - [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum UnqualifiedIdKind.

2017-12-29 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Fri Dec 29 20:15:27 2017 New Revision: 321574 URL: http://llvm.org/viewvc/llvm-project?rev=321574&view=rev Log: [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum UnqualifiedIdKind. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h cfe/trunk/lib/Parse/