lichray updated this revision to Diff 128071.
lichray added a comment.
Use Marshall's method to generate digits in reversed order in generic to_chars.
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
.gitignore
include/charconv
include/support/itoa/
include/support/itoa
JonasToth added a comment.
Is the singleton allowed, that uses a static object in the `instance` method?
https://reviews.llvm.org/D41546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
JonasToth added a comment.
What happens for c++98? I realize that fuchsia is c++14 but we might still
think about not having `constexpr`.
If we just assume c++11 you can do the matching only for it. (`getLangOpts` or
similar, see other checks for it.)
https://reviews.llvm.org/D41546
___
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/StaticallyConstructedObjectsCheck.cpp:23
+ // Match statically stored objects...
+ hasStaticStorageDuration(),
+ // ... which have C++ constructors...
--
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
One plausible use for the new double square-bracket attribute support in C are
attributes appertaining to Objective-C constructs. This patch adds parsing
support for such attributes and exposes a handful of ObjC attribu
aaron.ballman added a comment.
This patch depends on https://reviews.llvm.org/D41317 for the modifications to
the Clang<> attribute spelling.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
rsmith added a comment.
This appears to add attributes on some Obj-C constructs as an on-by-default
feature in Obj-C++11 onwards; it needs review by folks more heavily involved in
the Obj-C language design and direction to confirm that this makes sense and
(ideally) to update the Obj-C document
faisalv added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7735
+ ActOnDocumentableDecl(NewDecl);
+ CurContext->addDecl(NewDecl);
+ return NewDecl;
changyu wrote:
> faisalv wrote:
> > Why not use 'PushOnScopeChains' onto the enclosing scope?
> > Some
aaron.ballman added reviewers: rjmccall, arphaman, ahatanak.
aaron.ballman added a comment.
In https://reviews.llvm.org/D41553#963536, @rsmith wrote:
> This appears to add attributes on some Obj-C constructs as an on-by-default
> feature in Obj-C++11 onwards; it needs review by folks more heavil
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: faisalv
Date: Sat Dec 23 10:56:34 2017
New Revision: 321409
URL: http://llvm.org/viewvc/llvm-project?rev=321409&view=rev
Log:
[NFC] Update the template-parameter parsers and analyzers to return NamedDecl
(vs Decl)
This patch addresses a FIXME and has the template-parameter processing
fu
Author: faisalv
Date: Sat Dec 23 11:27:07 2017
New Revision: 321410
URL: http://llvm.org/viewvc/llvm-project?rev=321410&view=rev
Log:
[NFC] Remove a cast rendered unnecessary by r321409
See https://reviews.llvm.org/rC321409 for additional context.
Modified:
cfe/trunk/lib/Parse/ParseTemplate
Author: sammccall
Date: Sat Dec 23 11:31:24 2017
New Revision: 321411
URL: http://llvm.org/viewvc/llvm-project?rev=321411&view=rev
Log:
[Index] Reduce size of SymbolInfo struct.
Summary:
This is currently 16 bytes, the patch reduces it to 4.
(Building with clang on linux x84, I guess others are s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321411: [Index] Reduce size of SymbolInfo struct. (authored
by sammccall, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41514
Files:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe
Author: sammccall
Date: Sat Dec 23 11:38:03 2017
New Revision: 321412
URL: http://llvm.org/viewvc/llvm-project?rev=321412&view=rev
Log:
[clangd] Use Builder for symbol slabs, and use sorted-vector for storage
Summary:
This improves a few things:
- the insert -> freeze -> read sequence is now enf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321412: [clangd] Use Builder for symbol slabs, and use
sorted-vector for storage (authored by sammccall, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41506
Files:
clang-tools-extra
coby created this revision.
Herald added subscribers: cfe-commits, mgorny.
added intrinsics support for (while of) vbmi2 instructions, matching a similar
work on the backend
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Dri
xgsa marked 13 inline comments as done.
xgsa added a comment.
Aaron, thank you for your review and sorry for the coding convention mistakes
-- I still cannot get used to the llvm coding convention, because it quite
differs from the one I have been using in my projects.
Commen
xgsa updated this revision to Diff 128091.
xgsa marked an inline comment as done.
xgsa added a comment.
Review comments applied.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
xgsa updated this revision to Diff 128092.
xgsa added a comment.
The full diff (but not only the incremental one) was uploaded. Please, skip
previous revision. Sorry.
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/Cla
craig.topper added a comment.
Update the ICL macros in test/Preprocessor/predefined-arch-macros.c
Comment at: include/clang/Basic/BuiltinsX86.def:1254
+TARGET_BUILTIN(__builtin_ia32_vpshldd512_mask, "V16iV16iV16iiV16iUs", "",
"avx512vbmi2")
+TARGET_BUILTIN(__builtin_ia32_vpshl
craig.topper added a comment.
Add tests for -mavx512vbmi2 and -mno-avx512vbmi2 to
test/Driver/x86-target-features.c
Add a test for -mno-avx512bw also disabling avx512vbmi2 to
test/Preprocessor/x86_target_features.c. Look for AVX512VBMINOAVX512BW for the
existing test for avx512vbmi. Also add t
changyu marked 27 inline comments as done.
changyu added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7713
+
+ if (!ConstraintExpr->isTypeDependent() &&
+ ConstraintExpr->getType() != Context.BoolTy) {
faisalv wrote:
> saar.raz wrote:
> > faisalv
changyu updated this revision to Diff 128094.
changyu marked an inline comment as done.
https://reviews.llvm.org/D40381
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DeclNodes.td
include/clang/Basic/DiagnosticParseKinds.td
include/cl
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for VNNI instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40208)
Repository:
rC Clang
https://reviews.llvm.org/D41558
Files:
include/
25 matches
Mail list logo
