[PATCH] D40381: Parse concept definition

changyu marked 6 inline comments as done. changyu added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7735 + ActOnDocumentableDecl(NewDecl); + CurContext->addDecl(NewDecl); + return NewDecl; faisalv wrote: > Why not use 'PushOnScopeChains' onto the en

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r321250 - [CodeGen] Fix access sizes in new-format TBAA tags

Author: kosarev Date: Thu Dec 21 00:14:16 2017 New Revision: 321250 URL: http://llvm.org/viewvc/llvm-project?rev=321250&view=rev Log: [CodeGen] Fix access sizes in new-format TBAA tags The new format requires to specify both the type of the access and its size. This patch fixes setting access siz

[PATCH] D41452: [CodeGen] Fix access sizes in new-format TBAA tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL321250: [CodeGen] Fix access sizes in new-format TBAA tags (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41452?vs=127724&id=127834#toc Repository: rL LLVM

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md juliehockett wrote: > JonasToth wrote: > > Could you

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

kosarev updated this revision to Diff 127838. kosarev added a comment. Updated as suggested. https://reviews.llvm.org/D41394 Files: lib/CodeGen/CodeGenTBAA.cpp test/CodeGen/tbaa.cpp Index: test/CodeGen/tbaa.cpp === --- test/Co

[PATCH] D41391: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321252: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd`… (authored by hokein, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41391 Files: clang-tools-extra

[clang-tools-extra] r321252 - [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

Author: hokein Date: Thu Dec 21 00:45:18 2017 New Revision: 321252 URL: http://llvm.org/viewvc/llvm-project?rev=321252&view=rev Log: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension. Summary: Previously, we use a separate GitHub repository (https://github.co

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

Hahnfeld added a comment. @hfinkel I think you requested this documentation on the mailing list. Can you take a look if it matches your expectations so we can get this bundled in the 6.0 release? Comment at: docs/OpenMPSupport.rst:17 + +Clang fully supports OpenMP 3.1 + some

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

malcolm.parsons added a comment. This check could also handle else after goto. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D41345: [clangd] Add more symbol information for code completion.

sammccall added inline comments. Comment at: clangd/index/Index.h:122 + + llvm::Optional Detail; + ioeric wrote: > sammccall wrote: > > I think you probably want a raw pointer rather than optional: > > - reduce the size of the struct when it's absent > > - mak

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41454: [clangd] Add ClangdUnit diagnostics tests using annotated code.

sammccall updated this revision to Diff 127843. sammccall added a comment. Tighten preprocessor test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41454 Files: clangd/Protocol.cpp clangd/Protocol.h test/clangd/diagnostics-preamble.test unittests/clangd/CMakeLists.txt

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. I added two more reviewers as we would like to get that in trunk before 6.0 branches. https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of the underlying data. Before this lands, I'm going to measure the bef

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127849. sammccall added a comment. Don't intern unless the symbol was actually inserted. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h unittests/clangd/FileIndexTests.cpp u

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

gtbercea created this revision. gtbercea added reviewers: carlo.bertolli, ABataev, Hahnfeld, grokos, caomhin, hfinkel. This patch extends the libomptarget functionality in patch https://reviews.llvm.org/D14254 with support for the data sharing scheme for supporting implicitly shared variables.

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, hfinkel, Hahnfeld, caomhin. Herald added a subscriber: jholewinski. This patch adds a missing argument to the runtime interface. Tests are adjusted accordingly. Repository: rL LLVM https://reviews.llvm.org/D41

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

Hahnfeld added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291 EXTERN void __kmpc_spmd_kernel_deinit(); -EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized); -EXTERN bool __kmpc_kernel_parallel(void **Wo

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. https://reviews.llvm.org/D41012? This patch doesn't update the documentation with function signatures. Repository: rL LLVM https://reviews.llvm.org/D41486

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea added a comment. In https://reviews.llvm.org/D41486#961981, @Hahnfeld wrote: > https://reviews.llvm.org/D41012? This patch doesn't update the documentation > with function signatures. Ok so I see that your patch uses a different order of the arguments. I've just added the data sharin

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; I wonder

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 127863. sberg added a comment. As suggested, solve the issue instead by removing any "noexcept" from the typeinfo emitted for the -fsanitize=function checks. https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFun

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea updated this revision to Diff 127865. gtbercea added a comment. Address comments. Repository: rL LLVM https://reviews.llvm.org/D41486 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_target_teams_codegen.cpp Index: test/OpenMP/n

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

a.sidorin added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; xazax.hun wrote: > I wonder if in the future it would be worth to use something else, like >

[PATCH] D40451: [OpenMP] Add function attribute for triggering shared memory lowering in the LLVM backend

gtbercea closed this revision. gtbercea added a comment. Committed here https://reviews.llvm.org/D41123 Repository: rL LLVM https://reviews.llvm.org/D40451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir created this revision. krasimir added reviewers: klimek, djasper. This patch adds a FormatStyleSet for storing per-language FormatStyles for the purposes of formatting code blocks inside the main code. Repository: rC Clang https://reviews.llvm.org/D41487 Files: include/clang/Forma

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

ilya-biryukov added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols; A comment on why we use `BumpPtrAllocator` here mig

r321266 - Added helper to get size of PrecompiledPreamble

Author: ibiryukov Date: Thu Dec 21 06:04:39 2017 New Revision: 321266 URL: http://llvm.org/viewvc/llvm-project?rev=321266&view=rev Log: Added helper to get size of PrecompiledPreamble Modified: cfe/trunk/include/clang/Frontend/PrecompiledPreamble.h cfe/trunk/lib/Frontend/PrecompiledPreamb

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

lebedev.ri added a comment. In https://reviews.llvm.org/D41456#961826, @malcolm.parsons wrote: > This check could also handle else after goto. Yes, certainly. Though i'm not too sure on the restrictions. The obvious precondition is, the label can to be defined anywhere **except** after the `go

[clang-tools-extra] r321267 - [clangd] Log more info about preambles

Author: ibiryukov Date: Thu Dec 21 06:05:28 2017 New Revision: 321267 URL: http://llvm.org/viewvc/llvm-project?rev=321267&view=rev Log: [clangd] Log more info about preambles Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing the patch. Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

szepet accepted this revision. szepet added a comment. In https://reviews.llvm.org/D41444#961110, @a.sidorin wrote: > Test both with and without '-fdelayed-template-parsing' in C++ mode. This solution LGTM as well. Just a small nit added inline. Comment at: unittests/AST/AS

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice, LGTM. Comment at: clangd/index/Index.h:108 // // FIXME: Use a space-efficient implementation, a lot of Symbol fields could // share the same storage. ---

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols; ilya-biryuk

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127877. sammccall marked 4 inline comments as done. sammccall added a comment. Comment changes requiested in review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h unittests/c

[clang-tools-extra] r321272 - [clangd] Index symbols share storage within a slab.

Author: sammccall Date: Thu Dec 21 06:58:44 2017 New Revision: 321272 URL: http://llvm.org/viewvc/llvm-project?rev=321272&view=rev Log: [clangd] Index symbols share storage within a slab. Summary: Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of th

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321272: [clangd] Index symbols share storage within a slab. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41483?vs=127877&id=127879#toc Repository: rCTE

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

klimek added inline comments. Comment at: lib/Format/Format.cpp:893 for (int i = Styles.size() - 1; i >= 0; --i) { -if (Styles[i].Language == Language || -Styles[i].Language == FormatStyle::LK_None) { +if (!LanguageFound && (Styles[i].Language == Language || +

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir added inline comments. Comment at: lib/Format/Format.cpp:903-907 + for (int i = Styles.size() - 1; i >= 0; --i) { +if (Styles[i].Language != FormatStyle::LK_None) { + Style->AddLanguageStyle(Styles[i]); } } klimek wrote: > This seems a

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#961367, @probinson wrote: > With the GDB test results and LLDB able to handle it, this LGTM. > Carlos, do you have commit access? Hi Paul, Thanks for the LGTM. I do not have commit access. https://reviews.llvm.org/D392

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ilya-biryukov, mgorny, klimek. The tools is used to generate global symbols for clangd (global code completion), The format is YAML, which is only for **experiment**. TEST: used the tool to generate globa

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

ilya-biryukov created this revision. ilya-biryukov added reviewers: sepavloff, klimek. Previsouly clang tried instantiating member initializers even if ctor body was skipped, this caused spurious errors (see the test). Repository: rC Clang https://reviews.llvm.org/D41492 Files: lib/Sema/Se

[PATCH] D38639: [clangd] #include statements support for Open definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:183 + unsigned CharNumber = SourceMgr.getSpellingColumnNumber( + DeclMacrosFinder->getSearchedLocation()); + ilya-biryukov wrote: > Replace with `DeclMacrosFinder->getSearchedLocation

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir updated this revision to Diff 127887. krasimir added a comment. - Address review comments Repository: rC Clang https://reviews.llvm.org/D41487 Files: ; include/clang/Format/Format.h lib/Format/Format.cpp Index: include/clang/Format/Format.h ===

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

This is causing problems in some internal builds that specify both -mios-simulator-version-min=9.0 and --target=x86_64-apple-ios My expectation would be for the code to take the minimum OS version number from the -mios-simulator-version-min flag. In fact, however, the code seems to be completely i

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir updated this revision to Diff 127888. krasimir added a comment. - Remove accidentally created file Repository: rC Clang https://reviews.llvm.org/D41487 Files: include/clang/Format/Format.h lib/Format/Format.cpp Index: lib/Format/Format.cpp ==

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

I think if a version number isn't explicitly specified in the -target value, the value from -m-version-min ought to still be used, as it was before. Currently, clang will ignore the -m-version-min version number if the target has a particular OS specified, even if it has no version number as part

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: klimek. To make building preambles faster and keep them smaller. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41495 Files: clangd/ClangdUnit.cpp Index: clangd/Clangd

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov added a comment. I haven't done proper benchmarks, but here are some numbers from running this on my machine: Sizes of preamble with (before the change) and without (after the change) functon bodies: | File | Before | After | | ClangdUnit.cpp | 49.58M

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. That's great, thanks. LGTM. https://reviews.llvm.org/D41394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer

szepet updated this revision to Diff 127894. szepet marked an inline comment as done. szepet added a comment. Comment added to LoopEntrance CFGElement. https://reviews.llvm.org/D41150 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp lib/StaticAnalyzer/Core/PathDiagnostic.cpp tes

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 127899. sberg added a comment. (need to call getAs instead of cast in one place, in case the name in the function decl is wrapped in parens, as happens in HarfBuzz's hb-buffer.cc) https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp clang

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 127900. Nebiroth marked 11 inline comments as done. Nebiroth added a comment. Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/XRefs

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

lhchavez created this revision. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. This adds clang negative thread safery assertion support to std::mutex, as documented in: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html Fixes #34951. Repository: rCXX libc++ http

r321285 - [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing'

Author: a.sidorin Date: Thu Dec 21 09:41:06 2017 New Revision: 321285 URL: http://llvm.org/viewvc/llvm-project?rev=321285&view=rev Log: [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing' * While running ASTImporterTests, we often forget about Windows MSVC buildbots whic

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

This revision was automatically updated to reflect the committed changes. Closed by commit rL321285: [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing' (authored by a.sidorin, committed by ). Changed prior to commit: https://reviews.llvm.org/D41444?vs=127748&id=127903#toc

[clang-tools-extra] r321286 - [clangd] Fix use after free.

Author: d0k Date: Thu Dec 21 09:51:35 2017 New Revision: 321286 URL: http://llvm.org/viewvc/llvm-project?rev=321286&view=rev Log: [clangd] Fix use after free. Found by asan. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/Sym

[PATCH] D41500: ananas: Add shared library support

zhmu created this revision. zhmu added a reviewer: ed. Herald added a subscriber: cfe-commits. The Ananas Operating System (https://github.com/zhmu/ananas) has shared library support as of commit 57739c0b6ece56dd4872aedf30264ed4b9412c77. This change adds the necessary settings to clang so that s

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. ping https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper added a comment. Are we sure we want a different command line option name from gcc? From our internal conversations with the gcc folks I thought they were suggesting that -fcf-protection could imply a software mechanism if a hardware mechanism was not available thorugh -mibt or -ma

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 127911. sepavloff marked 2 inline comments as done. sepavloff added a comment. Small corrections to the patch - Avoid quick return in the case of error, it may cause fails of clang tools. - Fixed typo. Repository: rC Clang https://reviews.llvm.org/D249

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D41478: [analyzer] Fix zero-initialization of stack VLAs under ARC.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. The tests are great!! Repository: rC Clang https://reviews.llvm.org/D41478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.h:378 + /// specification removed. + QualType removeNothrowQualification(const FunctionProtoType *Proto) const; }; Please use the frontend language terminology here: "nothrow" is appropri

r321290 - [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC.

Author: dergachev Date: Thu Dec 21 10:43:02 2017 New Revision: 321290 URL: http://llvm.org/viewvc/llvm-project?rev=321290&view=rev Log: [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC. Using ARC, strong, weak, and autoreleasing stack variables are implicitly initialized with nil.

[PATCH] D41478: [analyzer] Fix zero-initialization of stack VLAs under ARC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321290: [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41478 Files: lib/StaticAnalyzer/Core/R

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgrang, klimek. This improves a few things: - the insert -> freeze -> read sequence is now enforced/communicated by the type system - SymbolSlab::const_iterator iterates over symbol

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

Thanks for raising your concerns. We decided to avoid -m-version-min flag in favor of -target to simplify the driver logic and to encourage the adoption of -target. Now after r321145 we only warn about -m-version-min flag when the OS version specified in it is different to the OS version specified

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall updated this revision to Diff 127918. sammccall added a comment. minor doc and code layout tweaks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41506 Files: clangd/index/FileIndex.cpp clangd/index/Index.cpp clangd/index/Index.h clangd/index/SymbolCollector.cp

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

mclow.lists added inline comments. Comment at: include/__mutex_base:65 void unlock() _NOEXCEPT _LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability()); +#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS +const mutex& operator!() const { return *this; } We don

[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

hamzasood added a comment. Ping https://reviews.llvm.org/D40443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41507: avxintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used "low-

r321296 - [CodeGen] Fix crash when a function taking transparent union is redeclared.

Author: vsapsai Date: Thu Dec 21 11:42:37 2017 New Revision: 321296 URL: http://llvm.org/viewvc/llvm-project?rev=321296&view=rev Log: [CodeGen] Fix crash when a function taking transparent union is redeclared. When a function taking transparent union is declared as taking one of union members ear

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321296: [CodeGen] Fix crash when a function taking transparent union is redeclared. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41311?vs=127779&id=127923#toc

r321297 - When instantiating a deduction guide, transform its name.

Author: rsmith Date: Thu Dec 21 11:43:39 2017 New Revision: 321297 URL: http://llvm.org/viewvc/llvm-project?rev=321297&view=rev Log: When instantiating a deduction guide, transform its name. Otherwise it will serve as a deduction guide for the wrong class template. Added: cfe/trunk/test/Sema

r321298 - Revert "Fix for PR32990"

Author: rnk Date: Thu Dec 21 11:44:23 2017 New Revision: 321298 URL: http://llvm.org/viewvc/llvm-project?rev=321298&view=rev Log: Revert "Fix for PR32990" This reverts commit r321239. It broke the Chromium DLL build: [8834/50217] LINK(DLL) icui18n.dll icui18n.dll.lib icui18n.dll.pdb FAILED: icui

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL321299: [CMake] Allow passing extra CMake arguments to custom libc++ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41103?vs=126488&id=127924#toc Repository:

r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

Author: az Date: Thu Dec 21 12:10:03 2017 New Revision: 321301 URL: http://llvm.org/viewvc/llvm-project?rev=321301&view=rev Log: [AArch64] Enable fp16 data type for the Builtin for AArch64 only. Differential Revision: https:://reviews.llvm.org/D41360 Modified: cfe/trunk/lib/CodeGen/CGBuiltin

[clang-tools-extra] r321302 - [clangd] Don't re-hash SymbolID in maps, just use the SHA1 data

Author: sammccall Date: Thu Dec 21 12:11:46 2017 New Revision: 321302 URL: http://llvm.org/viewvc/llvm-project?rev=321302&view=rev Log: [clangd] Don't re-hash SymbolID in maps, just use the SHA1 data Modified: clang-tools-extra/trunk/clangd/index/Index.cpp clang-tools-extra/trunk/clangd/i

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

Thanks for the quick response and your suggestions! I believe the workaround you suggest in 1) will work for us, so there's no need for an urgent change. Thanks again! On 21 December 2017 at 20:11, Alex L wrote: > Thanks for raising your concerns. > > We decided to avoid -m-version-min flag in

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

I totally agree with moving towards eliminating the -m-version-min flags, it's much better to put it in the target, and will clean up a lot of cruft in the driver, eventually. Now -- we (or anyone else who runs into this) can simply start specifying the version in both locations ("-target x86_64-a

r321304 - Don't produce redundant parentheses warning for "A (::B); " and the like.

Author: rsmith Date: Thu Dec 21 12:50:39 2017 New Revision: 321304 URL: http://llvm.org/viewvc/llvm-project?rev=321304&view=rev Log: Don't produce redundant parentheses warning for "A (::B);" and the like. The parentheses here are not redundant as they affect the binding of the '::' token. Modif

r321306 - Revert "[CodeGen] Fix crash when a function taking transparent union is redeclared."

Author: vsapsai Date: Thu Dec 21 12:52:59 2017 New Revision: 321306 URL: http://llvm.org/viewvc/llvm-project?rev=321306&view=rev Log: Revert "[CodeGen] Fix crash when a function taking transparent union is redeclared." This reverts commit r321296. It caused performance regressions FAIL: imp.exec

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > We don't actually di

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rsmith, smeenai, rjmccall, rnk, mclow.lists. lebedev.ri added a project: clang. The diagnostic was mostly introduced in https://reviews.llvm.org/D38101 by me, as a reaction to wasting a lot of time, see mail

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman marked 2 inline comments as done. arphaman added a comment. In https://reviews.llvm.org/D40983#958809, @bruno wrote: > Hi Alex, > > Thanks for improving this. > > - Instead of adding `-cc1gen-reproducer`, why can't you run that through > `-cc1` and have a flag similar to `-###`, which j

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman updated this revision to Diff 127935. arphaman marked an inline comment as done. arphaman added a comment. Address review comments https://reviews.llvm.org/D40983 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Index/create-libclang-completion-reproducer.c test/

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

On 21 December 2017 at 12:34, James Y Knight wrote: > I totally agree with moving towards eliminating the -m-version-min > flags, it's much better to put it in the target, and will clean up a lot of > cruft in the driver, eventually. > > Now -- we (or anyone else who runs into this) can simply st

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321312: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. (authored by probinson, committed by ). Changed prior to commit: https://reviews.llvm.org/D39239?vs=120066&id=12793

r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

Author: probinson Date: Thu Dec 21 13:47:22 2017 New Revision: 321312 URL: http://llvm.org/viewvc/llvm-project?rev=321312&view=rev Log: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. An unscoped enumeration used as template argument, should not have any qualified i

r321314 - [scudo] Add -fsanitize=scudo option to Fuchsia

Author: phosek Date: Thu Dec 21 14:04:31 2017 New Revision: 321314 URL: http://llvm.org/viewvc/llvm-project?rev=321314&view=rev Log: [scudo] Add -fsanitize=scudo option to Fuchsia Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Patch By: flowerhack Reviewers: cryptoad,

[PATCH] D41413: [scudo] Add -fsanitize=scudo option to Fuchsia.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321314: [scudo] Add -fsanitize=scudo option to Fuchsia (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41413 Files: lib/Dr

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

aaron.ballman added a comment. Are the Fuchsia library headers intended to also comply with this rule? I notice there's mention of a unique_ptr class, and I can't imagine that working without overloading more operators than just assignment. Perhaps this check should not be triggered for system

Re: r315984 - [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

Hi, This commit has caused a new regression in LLVM 6. I filed the following PR: https://bugs.llvm.org/show_bug.cgi?id=35724 . Could you please take a look? Thanks, Alex On 17 October 2017 at 02:12, Ivan A. Kosarev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kosarev > Date: T

Re: r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

On Thu, Dec 21, 2017 at 12:10 PM, Abderrazek Zaafrani via cfe-commits wrote: > Author: az > Date: Thu Dec 21 12:10:03 2017 > New Revision: 321301 > > URL: http://llvm.org/viewvc/llvm-project?rev=321301&view=rev > Log: > [AArch64] Enable fp16 data type for the Builtin for AArch64 only. > > Differen

r321316 - [CMake][Fuchsia] Enable assertions

Author: phosek Date: Thu Dec 21 14:10:27 2017 New Revision: 321316 URL: http://llvm.org/viewvc/llvm-project?rev=321316&view=rev Log: [CMake][Fuchsia] Enable assertions Enable assertions in both stages. Release+Asserts is fast enough. No need to let insanity through. Patch By: mcgrathr Reviewers

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rL321316: [CMake][Fuchsia] Enable assertions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41471?vs=127801&id=127943#toc Repository: rL LLVM https://reviews.l

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

sammccall created this revision. sammccall added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, ilya-biryukov. This is currently 16 bytes, the patch reduces it to 4. (Building with clang on linux x84, I guess others are similar) The only subfield that might need a bigger type is Symb

  1   2   >