bsdjhb updated this revision to Diff 126620.
bsdjhb added a comment.
- Rebase after O32/N64 commit.
https://reviews.llvm.org/D39074
Files:
include/__libunwind_config.h
src/AddressSpace.hpp
src/DwarfInstructions.hpp
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
alekseyshl added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684
if (AddExportDynamic)
-CmdArgs.push_back("-export-dynamic");
+CmdArgs.push_back("--export-dynamic");
If it does not exist on Solaris, why change it then? For the c
danzimm updated this revision to Diff 126628.
danzimm added a comment.
Call objc_retainAutoreleasedReturnValue after invoking a wrapped lambda
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarded-l
danzimm added a comment.
@rjmccall aha, right - thanks for explaining that to me (sorry for the bad
logic I had earlier).
It turns out this was also broken for a lambda that was auto-converted to a
function pointer who returned an ObjC object. I changed the test case to
reflect the more genera
danzimm updated this revision to Diff 126633.
danzimm added a comment.
Remove unnecessary change of braces
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarded-lambda-call.mm
Index: test/CodeGenObjCXX/arc-forwarded-lambda-
colden updated this revision to Diff 126634.
colden retitled this revision from "[CodeGen] Implement
_InterlockedCompareExchange128 intrinsic" to "[CodeGen][X86] Implement
_InterlockedCompareExchange128 intrinsic".
colden added a comment.
Moved implementation to X86_64 specific code, as accordin
erichkeane added a comment.
Herald added a subscriber: mgrang.
Ping! Anyone have time to take a look for me?
https://reviews.llvm.org/D40819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
Builder.getInt128Ty()
https://revie
efriedma created this revision.
efriedma added a reviewer: vsk.
efriedma added a project: clang.
Non-determinism is confusing at best.
Repository:
rC Clang
https://reviews.llvm.org/D41140
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
Index: lib/CodeGen/CodeGenModule.
colden updated this revision to Diff 126641.
colden added a comment.
llvm::IntegerType::get(getLLVMContext(), 128) -> Builder.getInt128Ty()
https://reviews.llvm.org/D41032
Files:
llvm/tools/clang/include/clang/Basic/BuiltinsX86_64.def
llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp
llvm/tools/
colden marked an inline comment as done.
colden added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
---
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm!
Repository:
rC Clang
https://reviews.llvm.org/D41140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: efriedma
Date: Tue Dec 12 16:14:17 2017
New Revision: 320533
URL: http://llvm.org/viewvc/llvm-project?rev=320533&view=rev
Log:
[Coverage] Always emit unused coverage mappings in the same order.
Non-determinism is confusing at best.
Differential Revision: https://reviews.llvm.org/D41140
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320533: [Coverage] Always emit unused coverage mappings in
the same order. (authored by efriedma, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41140?vs=126640&id=126644#toc
Reposi
juliehockett updated this revision to Diff 126645.
juliehockett marked 15 inline comments as done.
juliehockett added a comment.
Fixed comments and updated YAML output to use a StringMap.
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/cla
K-ballo added a comment.
Thanks @lichray
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stl_msft
Date: Tue Dec 12 16:51:27 2017
New Revision: 320535
URL: http://llvm.org/viewvc/llvm-project?rev=320535&view=rev
Log:
[libcxx] [test] Fix MSVC warnings, null pointer deref.
test/std/algorithms/alg.modifying.operations/alg.generate/generate_n.pass.cpp
Silence MSVC warning C4244. T
Author: stl_msft
Date: Tue Dec 12 16:51:31 2017
New Revision: 320536
URL: http://llvm.org/viewvc/llvm-project?rev=320536&view=rev
Log:
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
benchmarks/util_smartptr.bench.cpp
Change CRLF to LF.
test/std/localization/locale.categories/cate
STL_MSFT accepted this revision.
STL_MSFT added a comment.
This revision is now accepted and ready to land.
Thanks, I've checked this in without the changes to TODO.TXT. Please let me
know if you still want them, otherwise I consider this to be complete.
https://reviews.llvm.org/D40991
_
Hi,
this does not compile for me because of a tag mismatch:
clang-tools-extra/clangd/index/Index.h:52:10: error: class
'DenseMapInfo' was previously declared as a struct
[-Werror,-Wmismatched-tags]
friend class llvm::DenseMapInfo;
On Tue, Dec 12, 2017 at 7:42 AM, Haojian Wu via cfe-commits
wro
lodato created this revision.
lodato added reviewers: djasper, klimek, Alexander-Shukaev.
The only user-visible change is rewriting of the --help message to make the
different modes more clear.
Internally, this is a significant refactoring to make the source and
destination of the diff to be mo
juliehockett updated this revision to Diff 126657.
juliehockett added a comment.
Updating formatting
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/clang-doc/ClangDoc.cpp
tools/clang-doc/ClangDoc.h
tools/clang-doc/ClangDocReporter.cpp
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
The patch includes all declarations, and also implements the following features:
- ABI.
- narrowing-conversion related SFIANE, including simd<> ctors and
(sta
lodato created this revision.
lodato added reviewers: djasper, klimek, Alexander-Shukaev.
This new mode, which requires --diff, operates very similarly to the two
mode, except that the stage is formatted instead of the second commit.
The main intent of this feature is to use in pre-commit hooks
lodato added a comment.
I think the simplest solution to those problems is to require `--diff`. An
alternative is to write the changes directly to the index without touching the
working directory, but that would require some flag because the behavior is
unintuitive, and the implementation would
lodato added a comment.
Oh, and I meant to start with: I'm so sorry for the extremely long delay. I was
swamped with work before then I forgot about this. Please know that I
appreciate your effort here and that I didn't mean to blow you off.
Best regards, Mark
Repository:
rL LLVM
https://r
vsk created this revision.
vsk added reviewers: efriedma, rjmccall, dtzWill.
This patch introduces a specialized way to lower overflow-checked
multiplications with mixed-sign operands. This fixes link failures and
ICEs on code like this:
void mul(int64_t a, uint64_t b) {
int64_t res;
__
vsk abandoned this revision.
vsk added a comment.
Abandoned in favor of a proper fix: https://reviews.llvm.org/D41149
https://reviews.llvm.org/D38861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
vsk updated this revision to Diff 12.
vsk added a comment.
- Make sure the result can be stored into the result ptr.
https://reviews.llvm.org/D41149
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-overflow.c
Index: test/CodeGen/builtins-overflow.c
===
szepet created this revision.
szepet added reviewers: dcoughlin, zaks.anna, NoQ, rsmith.
Herald added subscribers: dkrupp, a.sidorin, baloghadamsoftware, whisperity.
Adding LoopEntrance as a new CFGElement to the CFG.
This element is added as the last element of the CFGBlock just before the loop
szepet created this revision.
szepet added reviewers: dcoughlin, NoQ, zaks.anna, xazax.hun, a.sidorin.
Herald added subscribers: dkrupp, baloghadamsoftware, whisperity.
Based on the CFGLoopEntrance element, it is possible to have a CFG driven
LocationContext update which contains loop information
lichray added a comment.
I beg you to resubmit this patch relative to "libcxx"; I had to `arc export`
this patch and `patch -p1 < your.diff` manually rather than just `arc patch
D41148`.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, sim
lichray added a comment.
I'm not confident enough about the effects of this patch with only one test;
the last patch also passes the test. I hope I can understand the effects
better.
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cf
rjmccall added a comment.
We do try to avoid relying on optimizer behavior in our tests. I don't know
why you need that here.
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
mclow.lists added a comment.
> Thanks, I've checked this in without the changes to TODO.TXT
Thanks - that works for me.
https://reviews.llvm.org/D40991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
MTC added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:619
/// CallExitBegin and CallExitEnd. The following operations occur between the
-/// two program points:
+/// two preogram points:
/// - CallExitBegin
A minor typo, it should be 'pro
On 12/13/2017 02:09 AM, Evgenii Stepanov via cfe-commits wrote:
Hi,
this does not compile for me because of a tag mismatch:
clang-tools-extra/clangd/index/Index.h:52:10: error: class
'DenseMapInfo' was previously declared as a struct
[-Werror,-Wmismatched-tags]
friend class llvm::DenseMapIn
xgsa added a comment.
@aaron.ballman, sorry for my insistence, but it seems all the comments are
fixed and the patch is ready for commit or am I missing something? Could you
please commit it on my behalf, as I don't have rights to do that?
https://reviews.llvm.org/D40671
___
101 - 140 of 140 matches
Mail list logo
