STL_MSFT added a comment.
Would you like me to drop the changes to TODO.TXT?
https://reviews.llvm.org/D40991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray added a comment.
LGTM as-is with the changes to the TODO file...
https://reviews.llvm.org/D40991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
This is missing a test case.
Repository:
rC Clang
https://reviews.llvm.org/D41080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kparzysz
Date: Mon Dec 11 11:29:56 2017
New Revision: 320410
URL: http://llvm.org/viewvc/llvm-project?rev=320410&view=rev
Log:
[Hexagon] Remove unsupported vlut intrinsics
Modified:
cfe/trunk/test/CodeGen/builtins-hexagon.c
Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c
URL:
ht
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
Yes, wasm has its own object format, so this change makes sense.
Repository:
rCXX libc++
https://reviews.llvm.org/D41073
___
cfe-commits mai
CaseyCarter marked 2 inline comments as done.
CaseyCarter added a comment.
This unconditional workaround addresses Marshall's concerns about the naked
version test.
https://reviews.llvm.org/D41048
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: erichkeane
Date: Mon Dec 11 11:44:28 2017
New Revision: 320411
URL: http://llvm.org/viewvc/llvm-project?rev=320411&view=rev
Log:
PR35586: Relax two asserts that are overly restrictive
The two asserts are too aggressive. In C++ mode, an
enum is NOT considered an integral type, but an enu
vsk added a project: debug-info.
vsk added a comment.
Thanks for your patches @wolfgangp! I agree with Eli that we should evaluate
enabling this automatically with -Og. I'll test this out on a few internal
projects and report back.
https://reviews.llvm.org/D41044
___
khuttun added a comment.
In https://reviews.llvm.org/D41056#951145, @aaron.ballman wrote:
> In https://reviews.llvm.org/D41056#951083, @alexfh wrote:
>
> > In https://reviews.llvm.org/D41056#950605, @khuttun wrote:
> >
> > > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote:
> > >
belleyb added inline comments.
Comment at: test/lit.cfg.py:52-57
+if platform.system() in ['Windows']:
+config.substitutions.append(('dos2unix', 'sed -b "s/\r$//"'))
+config.substitutions.append(('unix2dos', 'sed -b "s/\r*$/\r/"'))
+else:
+config.substitutions.append(
See my other response. Maybe we don’t even need a substitution at all?
On Mon, Dec 11, 2017 at 12:24 PM Benoit Belley via Phabricator <
revi...@reviews.llvm.org> wrote:
> belleyb added inline comments.
>
>
>
> Comment at: test/lit.cfg.py:52-57
> +if platform.system() in ['Windows'
arphaman created this revision.
This patch implements the `__is_target_arch`, `__is_target_vendor`,
`__is_target_os`, and `__is_target_environment` Clang preprocessor extensions
that were proposed by @compnerd in Bob's cfe-dev post:
http://lists.llvm.org/pipermail/cfe-dev/2017-November/056166.h
Nebiroth updated this revision to Diff 126429.
Nebiroth added a comment.
Creating unique_ptr for wrapper class now uses overriden method
createPPCallbacks() from PrecompiledPreamble class
Moved wrapper class to inline inside createPPCallbacks()
Wrapper class now uses CppFilePreambleCallback
Nebiroth updated this revision to Diff 126430.
Nebiroth added a comment.
Removed unique_ptr parameter in PrecompiledPreamble::Build
Added method createPPCallbacks() in PreambleCallback to be overriden
Repository:
rC Clang
https://reviews.llvm.org/D39375
Files:
include/clang/Frontend/Precom
Author: ctopper
Date: Mon Dec 11 13:09:16 2017
New Revision: 320418
URL: http://llvm.org/viewvc/llvm-project?rev=320418&view=rev
Log:
[Docs] Regenerate command line documentation.
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
UR
Author: ctopper
Date: Mon Dec 11 13:09:19 2017
New Revision: 320419
URL: http://llvm.org/viewvc/llvm-project?rev=320419&view=rev
Log:
[Driver][CodeGen] Add -mprefer-vector-width driver option and attribute during
CodeGen.
This adds a new command line option -mprefer-vector-width to specify a
pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320419: [Driver][CodeGen] Add -mprefer-vector-width driver
option and attribute during… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D40230?vs=123709&id=126434#toc
Repositor
I think adding two lit substitutions is not a significant issue since dos2unix
and unix2dos are common Unix utilities. This solution also has the advantage of
testing both styles of line-endings with only one test case, which I think
actually reduces complexity and maintenance burden.
From: Zac
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
I'll let rnk@ weigh in (he's on vacation today though).
I don't feel comfortable lgtm'ing any change where "don't use
core.autocrlf=true" is an alternative solution, but if other people want to
disagree with me and lgtm this, then that suggests I'm in the minority,
which is fine. :)
On Mon, Dec
Thank you very much, Zachary :)
From: Zachary Turner [mailto:ztur...@google.com]
Sent: Monday, December 11, 2017 4:21 PM
To: Zhen Cao
Cc: Benoit Belley ;
reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org; r...@google.com;
cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D41081: Fix clang L
dim updated this revision to Diff 126436.
dim added a comment.
Add a test case.
Repository:
rC Clang
https://reviews.llvm.org/D41080
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/no-warn-user-defined-literals-in-system-headers.cpp
test/SemaCXX/no-warn-user-defined-literals-in-system-hea
Hans,
Thank you for fixing the test!
Thanks
Galina
On Mon, Dec 11, 2017 at 10:59 AM, Hans Wennborg wrote:
> I've committed a fix to pacify the test in r320405.
>
> On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hello Richard,
>>
ahatanak added a comment.
I had a discussion with Duncan today and he pointed out that perhaps we
shouldn't allow users to annotate a struct with "trivial_abi" if one of its
subobjects is non-trivial and is not annotated with "trivial_abi" since that
gives users too much power.
Should we error
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM (wait for a day or so for @rsmith to respond in case he disagrees).
Repository:
rC Clang
https://reviews.llvm.org/D41080
__
dcoughlin added a comment.
Thanks for looking into this!
This checker is in the 'core' package, which means (when moved out of alpha) it
will be enabled by default.
- Do you think that this checker should be enabled by default for all users of
the analyzer?
- If users do actually want to use l
probinson added a comment.
I should note we've had at least one request to make this specifiable
per-function, which would mean defining an attribute to control the emission of
the fake-use intrinsics. Doing the feature that way would be consistent with
'optnone'.
https://reviews.llvm.org/D4
My bet would be: warn and ignore it, but probably Richard's & John might
have stronger thoughts/justifications/etc.
On Mon, Dec 11, 2017 at 1:38 PM Akira Hatanaka via Phabricator <
revi...@reviews.llvm.org> wrote:
> ahatanak added a comment.
>
> I had a discussion with Duncan today and he pointed
ioeric added a comment.
Thanks a lot for the changes! Some more comments inlined.
Please mark addressed comments as done so that reviewers could know what to
look :) Thanks!
Comment at: include/clang/Frontend/CompilerInstance.h:187
+ typedef std::function(
+ const Front
Nebiroth updated this revision to Diff 126447.
Nebiroth added a comment.
Herald added a subscriber: klimek.
Merged with latest llvm + clang
Minor code cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
c
Nebiroth updated this revision to Diff 126449.
Nebiroth added a comment.
Removed some more empty lines
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40956
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rjmccall added a comment.
In https://reviews.llvm.org/D41039#951648, @ahatanak wrote:
> I had a discussion with Duncan today and he pointed out that perhaps we
> shouldn't allow users to annotate a struct with "trivial_abi" if one of its
> subobjects is non-trivial and is not annotated with "tr
On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
revi...@reviews.llvm.org> wrote:
> rjmccall added a comment.
>
> In https://reviews.llvm.org/D41039#951648, @ahatanak wrote:
>
> > I had a discussion with Duncan today and he pointed out that perhaps we
> shouldn't allow users to annota
Author: phosek
Date: Mon Dec 11 17:20:37 2017
New Revision: 320445
URL: http://llvm.org/viewvc/llvm-project?rev=320445&view=rev
Log:
[libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit
These are expected to be set by the shared lit scripts used from libc++.
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320445: [libcxxabi] Pass LIBCXXABI_SYSROOT and
LIBCXXABI_GCC_TOOLCHAIN to lit (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40818?vs=125457&id=126481#toc
Repository:
rL LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320446: [CMake] Support runtimes and monorepo layouts when
looking for libcxx (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40637?vs=124876&id=126482#toc
Repository:
rL LLV
juliehockett created this revision.
juliehockett added a project: clang.
Herald added a subscriber: mgorny.
Setting up a basic frontend framework for a clang-doc tool. It creates a
frontend action for traversing the AST to extract comments and declarations,
with a flag to only extract documentat
On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote:
> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> rjmccall added a comment.
>>
>> In https://reviews.llvm.org/D41039#951648, @ahatanak wrote:
>>
>> > I had a discussion with Duncan today an
phosek created this revision.
Herald added subscribers: Sanitizers, llvm-commits, mgorny.
Herald added a reviewer: EricWF.
This can be used to customize the libc++ build.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D41103
Files:
cmake/Modules/AddCompilerRT.cmake
Index: cma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320451: [analyzer] In getSVal() API, disable auto-detection
of void type as char type. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D38801?vs=12&id=126493#toc
Reposito
Author: dergachev
Date: Mon Dec 11 18:27:55 2017
New Revision: 320451
URL: http://llvm.org/viewvc/llvm-project?rev=320451&view=rev
Log:
[analyzer] In getSVal() API, disable auto-detection of void type as char type.
This is a follow-up from r314910. When a checker developer attempts to
dereference
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320455: [analyzer] StackAddrEscape: For now, disable the new
async escape checks. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D41042?vs=126390&id=126496#toc
Repository:
Author: dergachev
Date: Mon Dec 11 18:59:09 2017
New Revision: 320455
URL: http://llvm.org/viewvc/llvm-project?rev=320455&view=rev
Log:
[analyzer] StackAddrEscape: For now, disable the new async escape checks.
The new check introduced in r318705 is useful, but suffers from a particular
class of f
eandrews added a comment.
*ping*
https://reviews.llvm.org/D40925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert added inline comments.
Comment at: include/__hash_table:2141
__n = 2;
else if (__n & (__n - 1))
__n = __next_prime(__n);
With `rehash(0)` this is `0 & (0 - 1)`, which triggers
unsigned-integer-overflow.
Repository:
rCXX libc+
lichray accepted this revision.
lichray added a comment.
This revision is now accepted and ready to land.
Reproduced with
lit -sv --param=cxx_under_test="$HOME/bin/clang++" test/std/utilities/tuple/
lit: [...] note: Using available_features: ['libc++', 'verify-support',
'clang-6', 'modules-s
compnerd added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1923
+ Tok, *this, diag::err_feature_check_malformed);
+ return II ? getTargetInfo().getTriple().getArchName().equals_lower(
+ II->getName())
H
alexey.knyshev added a comment.
In https://reviews.llvm.org/D40715#951665, @dcoughlin wrote:
> Thanks for looking into this!
>
> This checker is in the 'core' package, which means (when moved out of alpha)
> it will be enabled by default.
>
> - Do you think that this checker should be enabled by
sammccall added a comment.
In https://reviews.llvm.org/D40486#945193, @ilya-biryukov wrote:
> I'll update the implementation and place the `Context` as the first parameter
> everywhere instead.
> Could you take a look at other changes in the patch while I'm at it?
Just pinging this - there's
101 - 150 of 150 matches
Mail list logo
