rsmith added a comment.
In https://reviews.llvm.org/D40948#948843, @t.p.northover wrote:
> Thanks Richard. I'll file the bugs tomorrow for the issues you suggest. Do
> you see either of them blocking the change to C++14 as a default? On a scale
> of "no", "no but I want a commitment to fix them
Author: ab
Date: Thu Dec 7 14:58:02 2017
New Revision: 320112
URL: http://llvm.org/viewvc/llvm-project?rev=320112&view=rev
Log:
Remove line-endings added by r320089. NFC.
Modified:
cfe/trunk/include/clang/Basic/LangOptions.def
Modified: cfe/trunk/include/clang/Basic/LangOptions.def
URL:
ht
On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits
wrote:
> Looks like this might have messed up the line endings in a few files?
Should be taken care of in r320112.
-Ahmed
> On 7 December 2017 at 13:46, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Thu
lichray added a comment.
Ping. Just accept this as a DR, like what GCC does, I guess?
https://reviews.llvm.org/D39451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha wrote:
> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits
> wrote:
>> Looks like this might have messed up the line endings in a few files?
>
> Should be taken care of in r320112.
Thanks, I was just getting on that. Sorry about the inad
xgsa marked an inline comment as done.
xgsa added a comment.
In https://reviews.llvm.org/D40671#948826, @aaron.ballman wrote:
> There are still some outstanding concerns around the documentation wording,
> but once those are resolved it should be ready to commit. If you don't have
> commit acce
rsmith added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1674
+Value *Ptr = EmitScalarExpr(E->getArg(0));
+Ptr = Builder.CreateInvariantGroupBarrier(Ptr);
+return RValue::get(Ptr);
It would be nice to avoid this for types that contain no co
xgsa updated this revision to Diff 126058.
xgsa added a comment.
Documentation update
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/nolint.cpp
test/clang-tidy/nolintnextline.cpp
Index:
Author: aaronballman
Date: Thu Dec 7 15:04:11 2017
New Revision: 320113
URL: http://llvm.org/viewvc/llvm-project?rev=320113&view=rev
Log:
Correct line endings that got mixed up in r320089; NFC.
Modified:
cfe/trunk/include/clang/Frontend/LangStandard.h
cfe/trunk/include/clang/Frontend/Lan
On Thu, Dec 7, 2017 at 3:00 PM, Aaron Ballman wrote:
> On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha
> wrote:
>> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits
>> wrote:
>>> Looks like this might have messed up the line endings in a few files?
>>
>> Should be taken care of in r3
On Thu, Dec 7, 2017 at 6:00 PM, Aaron Ballman wrote:
> On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha
> wrote:
>> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits
>> wrote:
>>> Looks like this might have messed up the line endings in a few files?
>>
>> Should be taken care of in r3
rsmith added a comment.
LGTM, but I'd like the old `IdentifierTable` constructor to be removed if there
are no callers left.
Comment at: include/clang/Basic/IdentifierTable.h:473-476
/// \brief Create the identifier table, populating it with info about the
/// language k
On Thu, Dec 7, 2017 at 3:05 PM, Aaron Ballman wrote:
> On Thu, Dec 7, 2017 at 6:00 PM, Aaron Ballman wrote:
>> On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha
>> wrote:
>>> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits
>>> wrote:
Looks like this might have messed up the lin
Author: aaronballman
Date: Thu Dec 7 15:10:09 2017
New Revision: 320115
URL: http://llvm.org/viewvc/llvm-project?rev=320115&view=rev
Log:
Correct line endings that got mixed up in r320088; NFC.
Modified:
cfe/trunk/test/Preprocessor/has_c_attribute.c
Modified: cfe/trunk/test/Preprocessor/has
rsmith added a comment.
EDG and MSVC do not appear to treat this as a defect resolution; I suspect this
is an oversight in GCC rather than an intentional extension. Let's convert the
error to an (off by default) pedantic `Extension` (ISO C++11 does not allow
...), and suppress the extension war
eugenis updated this revision to Diff 126060.
eugenis added a comment.
clang-format
https://reviews.llvm.org/D40936
Files:
clang/include/clang/Basic/Sanitizers.def
clang/include/clang/Driver/SanitizerArgs.h
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/CodeGen/CGDeclCXX.cpp
clang/lib/Co
russellmcc created this revision.
Herald added a subscriber: klimek.
Add two new options,
AllowAllArgumentsOnNextLine and
AllowAllConstructorInitializersOnNextLine. These mirror the existing
AllowAllParametersOfDeclarationOnNextLine and allow me to support an
internal style guide where I work. I
nathawes added inline comments.
Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:170
+Act = index::createIndexDataRecordingAction(FEOpts, std::move(Act));
+CI.setGenModuleActionWrapper(&index::createIndexDataRecordingAction);
+ }
ioeric wrote:
vsk updated this revision to Diff 126064.
vsk added a comment.
- Handle constant size modifiers while we're at it (e.g "int foo(int p[static
10])").
https://reviews.llvm.org/D40940
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/ubsan-pass-object-size.c
Index: t
vsk added a comment.
Friendly ping.
https://reviews.llvm.org/D40668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nathawes updated this revision to Diff 126065.
nathawes added a comment.
Herald added a subscriber: mgrang.
Worked through the comments from @ioeric and split the code for writing out the
collected indexing data into a separate patch.
https://reviews.llvm.org/D39050
Files:
include/clang/Basi
STL_MSFT created this revision.
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
I recently wrote a tool to audit MSVC's codebase for inconsistent line endings
and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too.
I don't need any of these changes to be co
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks again!
https://reviews.llvm.org/D40940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
george.burgess.iv added a comment.
If the answer to my question is "no, it'll just work," LGTM. Thanks!
Comment at: test/ubsan/TestCases/Misc/bounds.cpp:9
+int get_int(int *const p __attribute__((pass_object_size(0))), int i) {
+ // CHECK-A-2: bounds.cpp:[[@LINE+1]]:10: runtim
vsk added inline comments.
Comment at: test/ubsan/TestCases/Misc/bounds.cpp:9
+int get_int(int *const p __attribute__((pass_object_size(0))), int i) {
+ // CHECK-A-2: bounds.cpp:[[@LINE+1]]:10: runtime error: index 2 out of
bounds for type 'int *'
+ return p[i];
--
Author: rsmith
Date: Thu Dec 7 16:45:25 2017
New Revision: 320122
URL: http://llvm.org/viewvc/llvm-project?rev=320122&view=rev
Log:
Unify implementation of our two different flavours of -Wtautological-compare.
In so doing, fix a handful of remaining bugs where we would report false
positives or
rsmith added a comment.
I've not done a detailed review of the string manipulation here, but this looks
like a great feature, thanks!
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:342
+
+def note_drv_verify_prefix_spelling : Note<"-verify prefixes must start with a
Hi Jonas,
On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits
wrote:
> Author: hahnfeld
> Date: Tue Oct 17 06:37:36 2017
> New Revision: 315996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315996&view=rev
> Log:
> [CMake][OpenMP] Customize default offloading arch
>
> For the shuff
Author: rsmith
Date: Thu Dec 7 17:00:27 2017
New Revision: 320124
URL: http://llvm.org/viewvc/llvm-project?rev=320124&view=rev
Log:
Fold together the in-range and out-of-range portions of -Wtautological-compare.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/Sema
Hi Ahmed,
Am 2017-12-07 19:57, schrieb Ahmed Bougacha:
Hi Jonas,
On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits
wrote:
Author: hahnfeld
Date: Tue Oct 17 06:37:36 2017
New Revision: 315996
URL: http://llvm.org/viewvc/llvm-project?rev=315996&view=rev
Log:
[CMake][OpenMP] Custo
Am 2017-12-07 20:34, schrieb Jonas Hahnfeld via cfe-commits:
Hi Ahmed,
Am 2017-12-07 19:57, schrieb Ahmed Bougacha:
Hi Jonas,
On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits
wrote:
Author: hahnfeld
Date: Tue Oct 17 06:37:36 2017
New Revision: 315996
URL: http://llvm.org/view
Author: vedantk
Date: Thu Dec 7 17:51:47 2017
New Revision: 320128
URL: http://llvm.org/viewvc/llvm-project?rev=320128&view=rev
Log:
[ubsan] Use pass_object_size info in bounds checks
Teach UBSan's bounds check to opportunistically use pass_object_size
information to check array accesses.
rdar:
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
I was wondering if there are other places where this propagation needs to be
added, for example, other calls to GenerateBlockFunction.
https://reviews.llvm.org/D40668
jdenny marked 13 inline comments as done.
jdenny added a comment.
I marked the comments related to Hal's suggestions as done to avoid confusion
for future reviews. I'm not used to using this sort of tool for reviews.
Hopefully it's appropriate for the author to do that rather than the reviewer
jdenny added a comment.
In https://reviews.llvm.org/D39694#949066, @rsmith wrote:
> I've not done a detailed review of the string manipulation here, but this
> looks like a great feature, thanks!
Hi Richard. Thanks for your feedback. I'll fix the line wrapping you pointed
out.
https://rev
jdenny created this revision.
The frontend currently groups diagnostics from the command line
according to diagnostic level, but that places all notes last. Fix
that by emitting such diagnostics in the order they were generated.
https://reviews.llvm.org/D40995
Files:
include/clang/Frontend/T
Author: aaronballman
Date: Thu Dec 7 18:39:26 2017
New Revision: 320131
URL: http://llvm.org/viewvc/llvm-project?rev=320131&view=rev
Log:
Add a test that the __STDC_VERSION__ macro reports the correct value for
-std=c17.
Added:
cfe/trunk/test/Preprocessor/c17.c
Added: cfe/trunk/test/Prepro
vsk added a comment.
In https://reviews.llvm.org/D40668#949096, @zaks.anna wrote:
> LGTM.
>
> Thanks!
>
> I was wondering if there are other places where this propagation needs to be
> added, for example, other calls to GenerateBlockFunction.
Thanks for the review :). Yes there is one other si
jdenny updated this revision to Diff 126086.
jdenny added a comment.
This update does the following:
1. Fixes the line wrapping that Richard pointed out.
2. Converts from std::vector to std::set for more efficient prefix lookup.
3. Grows a dependence on https://reviews.llvm.org/D40995 (which is
Author: vedantk
Date: Thu Dec 7 18:47:58 2017
New Revision: 320132
URL: http://llvm.org/viewvc/llvm-project?rev=320132&view=rev
Log:
[Blocks] Inherit sanitizer options from parent decl
There is no way to apply sanitizer suppressions to ObjC blocks. A
reasonable default is to have blocks inherit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320132: [Blocks] Inherit sanitizer options from parent decl
(authored by vedantk).
Repository:
rC Clang
https://reviews.llvm.org/D40668
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/no-sanitize
kkwli0 created this revision.
This unit test fails on the system that has CUDA Toolkit 9.0 installed. And
CUDA 9 does not support GPU arch sm_20. It results in the following error.
clang-6.0: error: GPU arch sm_20 is supported by CUDA versions between 7.0
and 8.0 (inclusive), but installati
arphaman created this revision.
Herald added a subscriber: javed.absar.
Repository:
rC Clang
https://reviews.llvm.org/D40997
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/appletvos-version-min.c
test/Driver/darwin-multiarch-arm.c
test/Driver/darwin-stdlib.cpp
test/Driver/darwin
arphaman abandoned this revision.
arphaman added a comment.
Sorry, accidental Return. Will close and reopen.
Repository:
rC Clang
https://reviews.llvm.org/D40997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
arphaman created this revision.
Herald added a subscriber: javed.absar.
The OS version is specified in `-target` should be used instead of the one in
an environment variable / SDK name.
rdar://35813850
Repository:
rC Clang
https://reviews.llvm.org/D40998
Files:
lib/Driver/ToolChains/Darw
dexonsmith requested changes to this revision.
dexonsmith added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1234-1276
+// The -target option specifies the deployment target when
+// -m-version-min is not giv
malaperle added inline comments.
Comment at: clangd/Symbol.h:23
+ // The path of the source file where a symbol occurs.
+ std::string FilePath;
+ // The offset to the first character of the symbol from the beginning of the
malaperle wrote:
> sammccall wrote:
>
malaperle added a comment.
As a follow-up, here's the interface for querying the index that I am using
right now. It's meant to be able to retrieve from any kind of "backend", i.e.
in-memory, ClangdIndexDataStore, libIndexStore, etc. I was able to implement
"Open Workspace Symbol" (which is clo
Author: hans
Date: Thu Dec 7 21:19:12 2017
New Revision: 320133
URL: http://llvm.org/viewvc/llvm-project?rev=320133&view=rev
Log:
Revert r320124 "Fold together the in-range and out-of-range portions of
-Wtautological-compare."
This broke Chromium:
../../base/trace_event/trace_log.cc:1545:29: e
I've reverted in r320133 since it caused new warnings in Chromium that
I'm not sure were intentional. See comment on the revert.
On Thu, Dec 7, 2017 at 5:00 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Dec 7 17:00:27 2017
> New Revision: 320124
>
> URL: http://llvm.org/v
malaperle added a comment.
In https://reviews.llvm.org/D39050#948500, @akyrtzi wrote:
> @malaperle, to clarify we are not suggesting that you write your own parser,
> the suggestion is to use clang in 'fast-scan' mode to get the structure of
> the declarations of a single file, see `CXTranslati
lichray updated this revision to Diff 126092.
lichray added a comment.
Keep a pedantic Extension warning.
Repository:
rC Clang
https://reviews.llvm.org/D39451
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExprCXX.cpp
test/CXX/expr/expr.unary/expr.new/p2-cxx0x.cpp
tes
101 - 152 of 152 matches
Mail list logo
