[PATCH] D40936: Hardware-assisted AddressSanitizer (clang part).

2017-12-06 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis created this revision. Herald added subscribers: javed.absar, srhines. Driver, frontend and LLVM codegen for HWASan. A clone of ASan, basically. https://reviews.llvm.org/D40936 Files: clang/include/clang/Basic/Sanitizers.def clang/include/clang/Driver/SanitizerArgs.h clang/lib/Cod

r320000 - CodeGen: Fix invalid bitcasts for memcpy

2017-12-06 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Wed Dec 6 17:39:52 2017 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32&view=rev Log: CodeGen: Fix invalid bitcasts for memcpy CreateCoercedLoad/CreateCoercedStore assumes pointer argument of memcpy is in addr space 0, which is not correct and causes

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

2017-12-06 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL32: CodeGen: Fix invalid bitcasts for memcpy (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D40806?vs=125417&id=125863#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Peter Szecsi via Phabricator via cfe-commits
szepet created this revision. Herald added subscribers: rnkovacs, baloghadamsoftware, whisperity, mgorny. The checker aims to find loops where none of the condition variables are updated in the body. In this version it only works on integer types but the final aim is to make it work for objects

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Does it really belong to Clang-tidy or Clang Analyzer is better place because of path-ensitivity? Please rebase from trunk. General note: CLang-tidy use //check// in terminology, not //checker//. Comment at: docs/ReleaseNotes.rst:63 + + The c

[PATCH] D40938: update hwasan docs

2017-12-06 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc created this revision. Herald added a subscriber: cfe-commits. - use more readable name - document the hwasan attribute Repository: rC Clang https://reviews.llvm.org/D40938 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst =

[PATCH] D40939: [analyzer] Avoid element regions of void type.

2017-12-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Herald added subscribers: cfe-commits, rnkovacs. Add an assertion that `ElementRegion`'s element type is not void. Fix two violations of this rule that shown up on four of our existing test files. I accidentally noticed that problem when i was looking at how `c++-all

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Peter Szecsi via Phabricator via cfe-commits
szepet updated this revision to Diff 125870. szepet marked an inline comment as done. szepet added a comment. Updated the wording in the docs. https://reviews.llvm.org/D40937 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/InfiniteLoopCheck.cpp clang-tidy/misc/InfiniteLoopCheck.h

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added a comment. Hi Eugen! Good question, probably should have detailed it in the description. This matcher based solution would not gain much benefit from the symbolic execution provided information. (I mean, it would mean a much different type of check on the states.) The main problems

[PATCH] D40939: [analyzer] Avoid element regions of void type.

2017-12-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > I accidentally noticed that problem The actual problem was that `RegionStore` was unable to retrieve the binding to such `ElementRegion` (in case of this example, `5 S32b`). There may be more problems with such regions. But at the same time i believe that the very idea o

[PATCH] D40936: Hardware-assisted AddressSanitizer (clang part).

2017-12-06 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM please give at least Aleksey a chance to review as well. https://reviews.llvm.org/D40936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D40940: [ubsan] Use pass_object_size info in bounds checks

2017-12-06 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. Herald added a reviewer: george.burgess.iv. Teach UBSan's bounds check to opportunistically use pass_object_size information to check array accesses. rdar://33272922 https://reviews.llvm.org/D40940 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h tes

[PATCH] D40941: [ubsan] Use pass_object_size info in bounds checks (compiler-rt)

2017-12-06 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. Herald added subscribers: dberris, kubamracek. This is a test update for the clang change in https://reviews.llvm.org/D40940 https://reviews.llvm.org/D40941 Files: test/ubsan/TestCases/Misc/bounds.cpp Index: test/ubsan/TestCases/Misc/bounds.cpp ===

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

2017-12-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: cfe/trunk/lib/CodeGen/CGCall.cpp:1238 + Address Casted = CGF.Builder.CreateBitCast(Tmp, CGF.AllocaInt8PtrTy); + Address SrcCasted = CGF.Builder.CreateBitCast(Src, CGF.AllocaInt8PtrTy); CGF.Builder.CreateMemCpy(Casted, SrcCasted, --

[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

2017-12-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added reviewers: rnk, majnemer. rjmccall added a comment. Reid, David, do you have a recommendation about the right way to support non-MS-supported CCs here? Repository: rC Clang https://reviews.llvm.org/D40929 ___ cfe-commits mailing l

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In https://reviews.llvm.org/D40937#947658, @szepet wrote: > Other note: If somebody would came up with an approach which can benefit from > the symbolic execution, these solutions could still live happily in the > different tools eg. UseAfterMove (tidy) and Misus

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/InfiniteLoopCheck.cpp:94 + +std::unique_ptr createSequence(Stmt *FunctionBody, + ASTContext &ASTCtx) { Missing static? Comment at: cla

[PATCH] D37057: [clang] Require address space to be specified when creating functions (4/4)

2017-12-06 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay updated this revision to Diff 125887. dylanmckay added a comment. Herald added a subscriber: cfe-commits. - Remove the switch table stuff for a later patch - Rebased on top of trunk Repository: rC Clang https://reviews.llvm.org/D37057 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGe

r320008 - Test commit access

2017-12-06 Thread Zhihao Yuan via cfe-commits
Author: lichray Date: Wed Dec 6 22:27:58 2017 New Revision: 320008 URL: http://llvm.org/viewvc/llvm-project?rev=320008&view=rev Log: Test commit access Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

2017-12-06 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320011: Allow conditions to be decomposed with structured bindings (authored by lichray). Changed prior to commit: https://reviews.llvm.org/D39284?vs=125665&id=125892#toc Repository: rC Clang https:

r320011 - Allow conditions to be decomposed with structured bindings

2017-12-06 Thread Zhihao Yuan via cfe-commits
Author: lichray Date: Wed Dec 6 23:03:15 2017 New Revision: 320011 URL: http://llvm.org/viewvc/llvm-project?rev=320011&view=rev Log: Allow conditions to be decomposed with structured bindings Summary: This feature was discussed but not yet proposed. It allows a structured binding to appear as

[PATCH] D40937: [clang-tidy] Infinite loop checker

2017-12-06 Thread JVApen via Phabricator via cfe-commits
JVApen added a comment. How does this check deal with atomic members? struct A { std:: atomic a; void f() const { while (a); } }; https://reviews.llvm.org/D40937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-06 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. So can this patch be submitted? Should I do something to make it happen? https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2