beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: sammccall
Date: Thu Nov 30 15:16:23 2017
New Revision: 319496
URL: http://llvm.org/viewvc/llvm-project?rev=319496&view=rev
Log:
[clangd] Log file compile commands
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp
URL:
htt
On Thu, Nov 30, 2017 at 10:21 AM, Dan Olson via Phabricator <
revi...@reviews.llvm.org> wrote:
> dolson added a comment.
>
> Hello,
>
> In the process of upgrading from clang 3.6.1 to a newer version, I ran
> into this new error and thus imported the new intrinsics from intrin.h for
> rep movsb an
Author: sammccall
Date: Thu Nov 30 15:21:34 2017
New Revision: 319497
URL: http://llvm.org/viewvc/llvm-project?rev=319497&view=rev
Log:
[clangd] Logger implicitly adds newline
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.
smeenai created this revision.
Herald added subscribers: mgorny, dberris.
This gains us the install-*-stripped targets, to strip binaries during
installation. These targets otherwise mimic the existing install targets.
https://reviews.llvm.org/D40687
Files:
cmake/Modules/AddCompilerRT.cmake
Author: smeenai
Date: Thu Nov 30 15:24:08 2017
New Revision: 319498
URL: http://llvm.org/viewvc/llvm-project?rev=319498&view=rev
Log:
[libunwind] Switch to add_llvm_install_targets
This gains us the install-unwind-stripped target, to perform stripping
during installation.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319498: [libunwind] Switch to add_llvm_install_targets
(authored by smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D40685
Files:
libunwind/trunk/src/CMakeLists.txt
Index: libunwind/trunk/s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319499: [libc++abi] Add install-cxxabi-stripped target
(authored by smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D40681
Files:
libcxxabi/trunk/src/CMakeLists.txt
Index: libcxxabi/trunk/s
Author: smeenai
Date: Thu Nov 30 15:25:51 2017
New Revision: 319499
URL: http://llvm.org/viewvc/llvm-project?rev=319499&view=rev
Log:
[libc++abi] Add install-cxxabi-stripped target
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for inst
kcc updated this revision to Diff 125045.
kcc added a comment.
Rename the new tool to HWASAN
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/HardwareAssistedAddressSanitizerDesign.rst
docs/index.rst
Index: docs/index.rst
=
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D40563#940536, @ioeric wrote:
> In https://reviews.llvm.org/D40563#939964, @arphaman wrote:
>
> > If nothing uses `getCXXScopeSpecifier` right now we can't reall
Author: zturner
Date: Thu Nov 30 16:53:10 2017
New Revision: 319505
URL: http://llvm.org/viewvc/llvm-project?rev=319505&view=rev
Log:
Mark all library options as hidden.
These command line options are not intended for public use, and often
don't even make sense in the context of a particular tool
compnerd added inline comments.
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
smeenai wrote:
> compnerd wrote:
> > smeenai wrote:
> > > I guess `_D
bob.wilson requested changes to this revision.
bob.wilson added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTrip
Author: rsmith
Date: Thu Nov 30 17:07:10 2017
New Revision: 319509
URL: http://llvm.org/viewvc/llvm-project?rev=319509&view=rev
Log:
[c++2a] P0515R3: lexer support for new <=> token.
Added:
cfe/trunk/test/Lexer/cxx2a-spaceship.cpp
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:414
+def ext_decomp_decl_cond : ExtWarn<
+ "decomposed condition is a Clang extension">;
def err_decomp_decl_spec : Error<
Phrase this as "ISO C++17 does not permit structured
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTriple().getArch() == llvm::Triple::x86_64))
Platform = IPhoneOSSimulator;
if (TvOSVersion &
vsk created this revision.
It's possible to reach an 'unreachable' instruction if a call to a
noreturn function returns. Diagnose this behavior.
Note: Most of the changes in this patch -- passing empty SourceLocations
in places where they are either not needed or do not apply -- are NFC.
Testing
arphaman added a comment.
In https://reviews.llvm.org/D40562#940201, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D40562#939950, @arphaman wrote:
>
> > This change breaks cached completions for declarations in namespaces in
> > libclang. What exactly are you trying to achieve here? We cou
Author: rsmith
Date: Thu Nov 30 18:13:10 2017
New Revision: 319513
URL: http://llvm.org/viewvc/llvm-project?rev=319513&view=rev
Log:
[c++2a] P0515R3: Support for overloaded operator<=>.
No CodeGen support for MSABI yet, we don't know how to mangle this there.
Added:
cfe/trunk/test/CodeGenCXX
vsk planned changes to this revision.
vsk added a comment.
Ah, I've found a problem while writing run-time tests. I'll need to take
another cut at this.
https://reviews.llvm.org/D40698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
vsk updated this revision to Diff 125069.
vsk retitled this revision from "[ubsan] Diagnose reached-unreachable after
noreturn calls" to "[ubsan] Diagnose noreturn functions which return".
vsk edited the summary of this revision.
vsk added a comment.
- Emit the check in the noreturn function, so
vsk created this revision.
Herald added subscribers: dberris, kubamracek.
This is a test and a wording update for the clang change:
https://reviews.llvm.org/D40698
https://reviews.llvm.org/D40700
Files:
lib/ubsan/ubsan_handlers.cc
test/ubsan/TestCases/Misc/unreachable.cpp
Index: test/ubs
vsk updated this revision to Diff 125071.
vsk added a comment.
- Leave out an unrelated change in the handling of NakedAttr.
https://reviews.llvm.org/D40698
Files:
docs/UndefinedBehaviorSanitizer.rst
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/C
efriedma added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
Unfortunately, this won't catch cases where the caller ha
vsk added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
efriedma wrote:
> Unfortunately, this won't catch cases where
efriedma added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
vsk wrote:
> efriedma wrote:
> > Unfortunately, this won'
Author: phosek
Date: Thu Nov 30 19:16:50 2017
New Revision: 319515
URL: http://llvm.org/viewvc/llvm-project?rev=319515&view=rev
Log:
Include AddLLVM needed for tests in the right context
AddLLVM is needed for several functions that are used in tests and
as such needs to be included from the right
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319515: Include AddLLVM needed for tests in the right
context (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40280?vs=123711&id=125072#toc
Repository:
rL LLVM
https://revie
vsk planned changes to this revision.
vsk added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
efriedma wrote:
> vsk wr
bob.wilson added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTriple().getArch() == llvm::Triple::x86_64))
Platform = IPhoneOSSimulator;
if (TvOSVersion
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319523: [libcxx] Support getentropy as a source of
randomness for std::random_device (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40319?vs=123842&id=125076#toc
Repository:
Author: phosek
Date: Thu Nov 30 22:34:33 2017
New Revision: 319523
URL: http://llvm.org/viewvc/llvm-project?rev=319523&view=rev
Log:
[libcxx] Support getentropy as a source of randomness for std::random_device
Use this source use on Fuchsia where this is the oficially way
to obtain randomness. Th
JonasToth added a comment.
Could you please explain what category means? Could i disable all of
`cppcoreguidelines` with something like `// NOLINT (cppcoreguidelines-*)`?
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:297
+ if (NolintIndex != StringRef::npos) {
+a
nik added reviewers: ilya-biryukov, cameron314.
nik added a comment.
Anyone?
https://reviews.llvm.org/D39903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 136 of 136 matches
Mail list logo
