Author: rsmith
Date: Thu Nov 30 00:18:21 2017
New Revision: 319408
URL: http://llvm.org/viewvc/llvm-project?rev=319408&view=rev
Log:
Preserve the "last diagnostic was suppressed" flag across SFINAE checks.
Sometimes we check the validity of some construct between producing a
diagnostic and produc
nemanjai added a comment.
This has been sitting in approved state for more than 2 months. As far as I can
tell, it wasn't committed. Do you plan to commit this soon or are you
abandoning it for some reason?
https://reviews.llvm.org/D36431
___
cfe-
Author: kosarev
Date: Thu Nov 30 01:26:39 2017
New Revision: 319413
URL: http://llvm.org/viewvc/llvm-project?rev=319413&view=rev
Log:
[CodeGen] Add initial support for union members in TBAA
The basic idea behind this patch is that since in strict aliasing
mode all accesses to union members requir
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319413: [CodeGen] Add initial support for union members in
TBAA (authored by kosarev).
Changed prior to commit:
https://reviews.llvm.org/D39455?vs=124726&id=124883#toc
Repository:
rL LLVM
https://re
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:67
);
+
if (Params.rootUri && !Params.rootUri->file.empty())
malaperle wro
erikjv created this revision.
This is actually a failing assert. When doing object argument
initialization, it is valid to have e.g. 'this' as a base in a member
access expression (which is a prvalue). It's also possible to have a
scope specifier as part of the member expression, in which case a b
ilya-biryukov added a comment.
In https://reviews.llvm.org/D40562#939950, @arphaman wrote:
> This change breaks cached completions for declarations in namespaces in
> libclang. What exactly are you trying to achieve here? We could introduce
> another flag maybe.
Am I right to assume this cach
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4609
+ if (SS.isInvalid()) {
+CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
ioeric wrote:
> ilya-biryukov wrote:
> > ilya-biryukov wrote:
> > > Why do we alter this
mprobst created this revision.
Herald added subscribers: cfe-commits, klimek.
Otherwise automatic semicolon insertion can trigger, i.e. wrapping
produces invalid syntax.
Repository:
rC Clang
https://reviews.llvm.org/D40642
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJ
erikjv created this revision.
This can be used by clients in conjunction with an offset returned by
e.g. clang_getFileLocation. Now those clients do not need to also
open/read the file.
https://reviews.llvm.org/D40643
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
Index: tools/l
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D40642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: mprobst
Date: Thu Nov 30 02:25:17 2017
New Revision: 319415
URL: http://llvm.org/viewvc/llvm-project?rev=319415&view=rev
Log:
clang-format: [JS] do not wrap after async/await.
Summary:
Otherwise automatic semicolon insertion can trigger, i.e. wrapping
produces invalid syntax.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319415: clang-format: [JS] do not wrap after async/await.
(authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D40642
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unitte
erikjv updated this revision to Diff 124903.
erikjv added a comment.
I moved all code to the TextDiagnostics, so all other interfaces still get byte
offsets.
https://reviews.llvm.org/D33765
Files:
lib/Frontend/TextDiagnostic.cpp
test/Misc/diag-utf8.cpp
Index: test/Misc/diag-utf8.cpp
erikjv updated this revision to Diff 124904.
erikjv added a comment.
Bumped the CINDEX_VERSION_MINOR.
https://reviews.llvm.org/D40643
Files:
include/clang-c/Index.h
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
=
Author: kwalker
Date: Thu Nov 30 03:38:56 2017
New Revision: 319420
URL: http://llvm.org/viewvc/llvm-project?rev=319420&view=rev
Log:
[ARM] disable FPU features when using soft floating point.
To be compatible with GCC if soft floating point is in effect any FPU
specified is effectively ignored,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319420: [ARM] disable FPU features when using soft floating
point. (authored by kwalker).
Changed prior to commit:
https://reviews.llvm.org/D40256?vs=124579&id=124905#toc
Repository:
rC Clang
https:
Author: kwalker
Date: Thu Nov 30 04:05:18 2017
New Revision: 319425
URL: http://llvm.org/viewvc/llvm-project?rev=319425&view=rev
Log:
Revert [ARM] disable FPU features when using soft floating point.
This reverts r319420
It is failing the test Driver/arm-mfpu.c so reverting while I investigate th
zahiraam added a comment.
Looks good to me 2.
Repository:
rL LLVM
https://reviews.llvm.org/D40621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added a subscriber: djasper.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1422
+ Strict);
+}
}
The problem here is that we're calling breakProtrudingToken 3 times more than
we used to.
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks you very much for this patch, JSON parsing now looks better than ever!
LGTM. (Just a few minor NITs).
Comment at: clangd/JSONExpr.h:71
+// The convention
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D40588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1422
+ Strict);
+}
}
krasimir wrote:
> The problem here is that we're calling breakProtrudingToken 3 times more than
> we used to. Seems like such a wa
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
aaron.ballman added subscribers: dcoughlin, sbaranga, jmolloy.
aaron.ballman added a comment.
Added @dcoughlin for opinions about the static analyzer, added @sbaranga and
@jmolloy for questions about NEON.
Comment at: include/clang/Basic/Attr.td:602
def AnalyzerNoReturn : Inh
mclow.lists created this revision.
This patch implements most of https://wg21.link/P0451r1 - the notable exception
being division.
The current implementation of complex division in libc++ uses `logb`, `fmax`,
and a couple of other primitives that are not constexpr. The paper has some
approaches
klimek updated this revision to Diff 124940.
klimek added a comment.
Fix incorrect return value leading to unnecessary computation.
Repository:
rC Clang
https://reviews.llvm.org/D40605
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
unittests/Format/FormatT
ioeric added a comment.
In https://reviews.llvm.org/D40563#939964, @arphaman wrote:
> If nothing uses `getCXXScopeSpecifier` right now we can't really test it with
> a clang or c-index-test regression test. A completion unit test could work
> here. I don't think we actually have existing comple
ilya-biryukov created this revision.
Herald added a subscriber: klimek.
Previously, completion options were set per ClangdServer instance.
It will allow to change completion preferences during the lifetime
of a single ClangdServer instance.
Also rewrote ClangdCompletionTest.CompletionOptions to r
Nebiroth updated this revision to Diff 124945.
Nebiroth marked an inline comment as done.
Nebiroth added a comment.
Simplified getHover() function
Proper usage of ErrorOr to return errors
Given range for Hover struct now only applies to the open file
Fixed crash on MacroExpansion
Reposit
mgrang added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:47
+Features.push_back("+d");
+break;
+ }
Can you also add a case for pushing back +c here?
https://reviews.llvm.org/D39963
__
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
spatel added a comment.
Added a blurb to the LangRef with https://reviews.llvm.org/rL319437, so I think
we can abandon this patch.
https://reviews.llvm.org/D40594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: erichkeane
Date: Thu Nov 30 08:37:02 2017
New Revision: 319446
URL: http://llvm.org/viewvc/llvm-project?rev=319446&view=rev
Log:
Fix __has_unique_object_representations implementation
As rsmith pointed out, the original implementation of this intrinsic
missed a number of important situati
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319446: Fix __has_unique_object_representations
implementation (authored by erichkeane).
Repository:
rC Clang
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AS
juliehockett updated this revision to Diff 124949.
juliehockett added a comment.
Updated warning wording to more accurately reflect guidelines
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInher
Nebiroth updated this revision to Diff 124951.
Nebiroth marked 6 inline comments as done.
Nebiroth added a comment.
Minor code cleanup
getDeclarationLocation now returns llvm::Optional
operator< for DocumentHighlight struct now properly compares the kind field
Repository:
rCTE Clang Tool
krasimir added inline comments.
Comment at: unittests/Format/FormatTest.cpp:10007
+format("// foo foo foo foo foo foo foo foo foo foo foo foo\n",
+ Style));
}
Could you also add a test with line comments surrounded by stuff,
saugustine added a comment.
In https://reviews.llvm.org/D36431#940169, @nemanjai wrote:
> This has been sitting in approved state for more than 2 months. As far as I
> can tell, it wasn't committed. Do you plan to commit this soon or are you
> abandoning it for some reason?
My apologies. I ha
alexfh added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:35-36
+ StringRef Name = Node->getIdentifier()->getName();
+ if (InterfaceMap.count(Name)) {
+isInterface = InterfaceMap.lookup(Name);
+return true;
One lookup is
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D40448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Thu Nov 30 10:01:54 2017
New Revision: 319450
URL: http://llvm.org/viewvc/llvm-project?rev=319450&view=rev
Log:
[OPENMP] Fix possible assert for target regions with incorrect inner
teams region.
If the inner teams region is not correct, it may cause an assertion when
process
compnerd created this revision.
Herald added a subscriber: cfe-commits.
The MSVC driver and clang do not link against the C++ runtime
explicitly. Instead, they rely on the auto-linking via the pragma
(through `use_ansi.h`) to link against the correct version of the C++
runtime. Attempt to do som
dolson added a comment.
Hello,
In the process of upgrading from clang 3.6.1 to a newer version, I ran into
this new error and thus imported the new intrinsics from intrin.h for rep movsb
and friends. I see several discussions in this thread about how having the
registers solely in the inputs
sammccall updated this revision to Diff 124968.
sammccall marked 5 inline comments as done.
sammccall added a comment.
- added more VSCode tests, and made test assert matched characters. This
uncovered algorithm problems
- cache now includes "did previous character match" in the key (scoring depe
sammccall added a comment.
Thanks @ilya-biryukov, @inspirer, @klimek for the helpful comments!
I've addressed hopefully the most important and added more rigorous testing.
Sorry for the large delta, the most invasive change was of course adding the
extra dimension to the scoring table. (Which fi
Author: kli
Date: Thu Nov 30 10:52:06 2017
New Revision: 319458
URL: http://llvm.org/viewvc/llvm-project?rev=319458&view=rev
Log:
[OpenMP] Diagnose undeclared variables on declare target clause
Clang asserts on undeclared variables on the to or link clause in the declare
target directive. The pat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319458: [OpenMP] Diagnose undeclared variables on declare
target clause (authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D40588?vs=124811&id=124969#toc
Repository:
rL LLVM
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319458: [OpenMP] Diagnose undeclared variables on declare
target clause (authored by kli).
Repository:
rC Clang
https://reviews.llvm.org/D40588
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/declare_t
Wizard updated this revision to Diff 124971.
Wizard added a comment.
change file name cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSEErrorInitCheck.cpp
clang-tidy/objc/AvoidNSEErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319459: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124974#toc
Repository:
rL LLVM
https://reviews.llvm.
Wizard updated this revision to Diff 124972.
Wizard added a comment.
restore file names
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSErrorInitCheck.cpp
clang-tidy/objc/AvoidNSErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319460: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124973#toc
Repository:
rL LLVM
https://reviews.llvm.
compnerd updated this revision to Diff 124976.
compnerd added a comment.
Fix pragma, ensure that we do not try to recursively link.
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--- include
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
This feels more like a Windows (or perhaps COFF) thing than a Microsoft A
rnk added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> This feels more like a Windows (or perhaps COFF) thing than
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
rnk wrote:
> smeenai wrote:
> > This feels more like a Windows (or perhap
saugustine closed this revision.
saugustine added a comment.
Committed as R319464.
https://reviews.llvm.org/D36555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> rnk wrote:
> > smeenai wrote:
> > > This feels more lik
compnerd updated this revision to Diff 124983.
compnerd added a comment.
@rnk/@smeenai don't want future proofing
Repository:
rCXX libc++
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--
smeenai added a comment.
I'm fine with future proofing, but not if it doesn't actually work in the
present :)
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
-
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
very minor comments
Comment at: clangd/ClangdServer.h:288
+ /// Get document highlights for a symbol hovered on.
+ llvm::Expected>>
+ findDocumentHighlight
vsk created this revision.
There is no way to apply sanitizer suppressions to ObjC blocks. A
reasonable default is to have blocks inherit their parent's sanitizer
options.
rdar://32769634
https://reviews.llvm.org/D40668
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/no-sanitize.m
Index
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:228
llvm::toString(Items.takeError()));
+
C.reply(json::ary(Items->Value));
---
malaperle added inline comments.
Comment at: clangd/ClangdServer.cpp:526
+if (!AST)
+ llvm::make_error(
+ "invalid AST",
missing return?
I get a warning that looks legit:
./tools/clang/tools/extra/clangd/ClangdServer.cpp:526:7: warning: igno
saugustine closed this revision.
saugustine added a comment.
Committed as https://reviews.llvm.org/rL319474.
https://reviews.llvm.org/D36431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
xgsa created this revision.
xgsa added a project: clang-tools-extra.
The NOLINT directive was extended to support the "NOLINT(category)" and
"NOLINT(*)" syntax. Also it is possible to specify a few categories separated
with comma "NOLINT(cat1, cat2)"
Repository:
rCTE Clang Tools Extra
https
juliehockett updated this revision to Diff 125000.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleIn
mibintc created this revision.
mibintc added a project: clang.
Fedora27 is using a new version of glibc that refers to the _Float128 type.
This patch adds that name as an alias to __float128. I also added some
predefined macro values for the digits, mantissa, epilon, etc (FloatMacros).
For the
lebedev.ri added a comment.
Please upload patches with full context (`-U99`)
Also, you probably want to add some reviewers, see CODE_OWNERS.txt e.g.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40671
___
cfe-commits mailing li
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clangd/JSONExpr.h:71
+// The convention is to have a deserialize function findable via ADL:
+// deserialize(const json::Expr&, T&)->bool
+// Deserializers are provided for:
--
Author: sammccall
Date: Thu Nov 30 13:32:29 2017
New Revision: 319478
URL: http://llvm.org/viewvc/llvm-project?rev=319478&view=rev
Log:
[clangd] New conventions for JSON-marshalling functions, centralize machinery
Summary:
- JSON<->Obj interface is now ADL functions, so they play nicely with enu
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE319478: [clangd] New conventions for JSON-marshalling
functions, centralize machinery (authored by sammccall).
Changed prior to commit:
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319478: [clangd] New conventions for JSON-marshalling
functions, centralize machinery (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40596?vs=124715&id=125004#toc
Repositor
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
LGTM for the CUDA test changes.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
sammccall accepted this revision.
sammccall added a comment.
Nice!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: eugenezelenko
Date: Thu Nov 30 13:42:27 2017
New Revision: 319479
URL: http://llvm.org/viewvc/llvm-project?rev=319479&view=rev
Log:
[Documentation] Style fixes for Objective-C checks documentation to follow
C/C++ example.
Release Notes should just repeat first sentence from documentation
rsmith added a comment.
Per https://gcc.gnu.org/onlinedocs/gcc/Floating-Types.html, this doesn't appear
to be correct: `_Float128` is only *sometimes* the same type as `__float128`.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-c
xgsa updated this revision to Diff 125008.
xgsa added a reviewer: dcoughlin.
xgsa added a comment.
Update the diff to contain the full context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
test/clang-tidy/nolint.cpp
sammccall updated this revision to Diff 125009.
sammccall added a comment.
Herald added a subscriber: klimek.
Rebase and remove debug output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
Files:
clangd/ClangdUnit.cpp
unittests/clangd/ClangdTests.cpp
Index: unittests
sammccall added a comment.
@ilya-biryukov Ping... this is the patch we wanted to land this week, so long
result sets are correct for user testing next week.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
___
cfe-commits maili
sammccall added a comment.
@ilya-biryukov We should get this landed.
I'm happy (my comments were addressed a few rounds ago) - any concerns?
https://reviews.llvm.org/D39430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
smeenai created this revision.
Herald added a subscriber: mgorny.
Use this function to create the install targets rather than doing so
manually, which gains us the `-stripped` install targets to perform
stripped installations.
Repository:
rC Clang
https://reviews.llvm.org/D40675
Files:
cma
efriedma added a comment.
> _Float128 is only *sometimes* the same type as __float128.
But we don't have hppa or IA-64 backends, so we're fine for now, I think. :)
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat()
sammccall added a comment.
This is pretty bikesheddy, but I wonder what you think about passing Ctx as the
first vs last parameter.
First has some advantages (maybe I just read too much Go though):
- it's a short expr, and F(short, long) tends to format better than F(long,
short). Particularly
vsapsai created this revision.
It covers the cases when the sentry object returns false and when an exception
was thrown. Corresponding standard paragraph is C++14 [istream.unformatted]p9:
[...] In any case, if n is greater than zero it then stores a null
character into the next successive lo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319485: [CUDA] Tweak CUDA wrappers to make cuda-9 work with
libc++ (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40198?vs=123421&id=125021#toc
Repository:
rL LLVM
https://rev
Author: tra
Date: Thu Nov 30 14:22:21 2017
New Revision: 319485
URL: http://llvm.org/viewvc/llvm-project?rev=319485&view=rev
Log:
[CUDA] Tweak CUDA wrappers to make cuda-9 work with libc++
CUDA-9 headers check for specific libc++ version and ifdef out
some of the definitions we need if LIBCPP_VER
hubert.reinterpretcast added inline comments.
Comment at: test/Sema/_Float128.cpp:1
+// RUN: %clang_cc1 -verify -std=gnu++11 %s
+// RUN: %clang_cc1 -verify -std=c++11 %s
GCC documents that it does not support `_Float128` in C++ mode, and I think
their decision m
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D40675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: eugenezelenko
Date: Thu Nov 30 14:33:48 2017
New Revision: 319487
URL: http://llvm.org/viewvc/llvm-project?rev=319487&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/CXXInheritance.h
Author: smeenai
Date: Thu Nov 30 14:35:02 2017
New Revision: 319489
URL: http://llvm.org/viewvc/llvm-project?rev=319489&view=rev
Log:
[clang] Use add_llvm_install_targets
Use this function to create the install targets rather than doing so
manually, which gains us the `-stripped` install targets
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319489: [clang] Use add_llvm_install_targets (authored by
smeenai).
Changed prior to commit:
https://reviews.llvm.org/D40675?vs=125013&id=125026#toc
Repository:
rC Clang
https://reviews.llvm.org/D40
smeenai created this revision.
Herald added a subscriber: mgorny.
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for install-distribution, all
potential distribution components should have stripped installation
targets. LLVM has a functi
smeenai updated this revision to Diff 125034.
smeenai added a comment.
Don't add deprecated target names, since clients should be switching over to
the new ones.
https://reviews.llvm.org/D40680
Files:
include/CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
smeenai created this revision.
Herald added a subscriber: mgorny.
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for install-distribution, all
potential distribution components should have stripped installation
targets. LLVM has a functi
arphaman created this revision.
r316380 added support for the 'simulator' environment to LLVM's triple. Clang's
driver should pass this to the compiler when `-msimulator-version-min`
option is specified so that the compiler can avoid using OS & arch specific
checks.
Repository:
rC Clang
ht
efriedma added a comment.
Still worried about the effect on tools which parse clang diagnostics... please
send a message to cfe-dev. Hopefully we'll get responses there.
https://reviews.llvm.org/D33765
___
cfe-commits mailing list
cfe-commits@list
Author: rsmith
Date: Thu Nov 30 15:07:29 2017
New Revision: 319495
URL: http://llvm.org/viewvc/llvm-project?rev=319495&view=rev
Log:
Update website to mention that you still need -frelaxed-template-template-args
to enable the corresponding C++17 feature in Clang 5.
Modified:
cfe/trunk/www/cx
smeenai created this revision.
Herald added a subscriber: mgorny.
This gains us the install-unwind-stripped target, to perform stripping
during installation.
https://reviews.llvm.org/D40685
Files:
src/CMakeLists.txt
Index: src/CMakeLists.txt
=
1 - 100 of 136 matches
Mail list logo
