[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

szepet added a comment. Hello Aleksei, Thank you for the review! (and sorry for the late update) Comment at: lib/AST/ASTImporter.cpp:5510 + UnresolvedSet<8> ToDecls; + for (Decl *D : E->decls()) { +if (NamedDecl *To = cast_or_null(Importer.Import(D))) a.

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 124116. Nebiroth marked 32 inline comments as done. Nebiroth added a comment. Minor code cleanup and improvements getRawCommentForDeclNoCache() now called for every Decl and only once per Decl getHover() now properly handles templates https://reviews.llvm.o

[PATCH] D38425: [clangd] Document highlights for clangd

malaperle added a comment. In https://reviews.llvm.org/D38425#922408, @ioeric wrote: > Drive-by comment: in general, have you considered reusing the existing > declarations and occurrences finding functionalities in clang-rename? AFAIK, > it deals with templates and macros pretty well. > > o >

[PATCH] D40406: [clangd] Switch from YAMLParser to JSONExpr

sammccall created this revision. - Converted Protocol.h parse() functions to take JSON::Expr. These no longer detect and log unknown fields, as this is not that useful and no longer free. I haven't changed the error handling too much: fields that were treated as optional before are still option

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

szepet updated this revision to Diff 124119. szepet marked 6 inline comments as done. szepet added a comment. Herald added a subscriber: rnkovacs. Updated based on review comments. Hello Aleksei, Thank for the review and the code snippet as well! https://reviews.llvm.org/D38845 Files: lib/AS

[PATCH] D40406: [clangd] Switch from YAMLParser to JSONExpr

sammccall edited reviewers, added: ioeric; removed: ilya-biryukov. sammccall added a comment. Oops, Eric is most likely to have this stuff in cache :-) Sorry this is huge and ugly, -500 lines though! I think the `Protocol` code could be a lot tighter (there's still a lot of repeated "is this an

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

szepet updated this revision to Diff 124123. szepet added a comment. Updating the usage of `ImportTemplateArgumentListInfo`. https://reviews.llvm.org/D38694 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp ===

[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

tk1012 updated this revision to Diff 124124. tk1012 added a comment. Hello there, I update the diff and add `void f() { declToImport().m(); }` after `declToImport` definition. I leave the matcher for private in the test file, so I don't update the documentation. https://reviews.llvm.org/D3972

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. @davidxl David, is that ok with you? Can you sign off this change? Thanks https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D33537: [clang-tidy] Exception Escape Checker

JVApen added a comment. Looking at the documentation and the examples, it is unclear to me what the behavior of checking is when you call a function without throw/noexcept if you can't see the implementation. (Other cpp file) https://reviews.llvm.org/D33537

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

krytarowski added inline comments. Comment at: compiler-rt/lib/xray/xray_x86_64.cc:25 + size_t Len = 0; + if (sysctlbyname("hw.cpufrequency_max", &CPUFreq, &Len, NULL, 0) == -1) { +Report("Unable to determine CPU frequency for TSC accounting; errno = %d\n", ---

<    1   2