[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:63 + + Warns if a function is declared or called with default arguments. + I think will be good idea to change to //function// to //function or method//. Same in documentation. ==

Re: r318536 - [OPENMP] Codegen for `target simd` construct.

Ah ok. Thanks for checking! On Fri, Nov 17, 2017 at 4:59 PM, Alexey Bataev wrote: > No, it is caused by some other changes. Seems to me, somebody changed the > interface of functions, but forgot to remove the variables that are not used > anymore. > The changes look good to me, thanks. > > Best r

r318582 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Nov 17 17:47:41 2017 New Revision: 318582 URL: http://llvm.org/viewvc/llvm-project?rev=318582&view=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/ExprCXX.h cfe/

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM with comment added but if a different approach will be required for multiple Linux targets (which we all treat as "hostish") then it's worth at least thinking about that now. =

<    1   2