juliehockett created this revision.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
This adds a Fuchsia module to clang-tidy to warn for features that are
disallowed. The following checks were added to the new module:
fuchsia-default-arguments: Check
rnk created this revision.
Herald added a subscriber: aprantl.
The MS ABI convention is that the 'this' pointer on entry is the address
of the vfptr that was used to make the virtual method call. In other
words, the pointer on entry always points to the base subobject that
introduced the virtual m
mgrang added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8845
+
+ // Structures with either a non-trivial destructor or a non-trivial
+ // copy constructor are always indirectly.
Comment sounds incomplete.
Comment at: lib/CodeGen/
ahatanak created this revision.
Herald added a subscriber: javed.absar.
IRGen for __fp16 vectors on X86 is currently completely broken. For example
when the following code is compiled:
half4 hv0, hv1, hv2; // these are vectors of __fp16.
void foo221() {
hv0 = hv1 + hv2;
}
clang gen
arphaman added a comment.
Thanks for the patch!
Comment at: lib/Frontend/ASTUnit.cpp:541
+// language.
+PP.getIdentifierTable().AddKeywords(LangOpt);
+
Have you tried adding the keywords in `PP.Initialize`? We might not need an
additional parameter to
hans added a comment.
I think the patch is fine, but Zach should probably sign off on it.
https://reviews.llvm.org/D39994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D40109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
compnerd created this revision.
Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff, jfb.
This option is not used in the frontend. Remove the method.
Repository:
rL LLVM
https://reviews.llvm.org/D40115
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChains/BareMe
compnerd added a comment.
@rjmccall this is quite a straightforward change, just not sure if there is
some use for this that I cant think of off the top of my head to preserve this.
Repository:
rL LLVM
https://reviews.llvm.org/D40115
___
cfe-com
Author: arphaman
Date: Wed Nov 15 17:28:25 2017
New Revision: 318365
URL: http://llvm.org/viewvc/llvm-project?rev=318365&view=rev
Log:
[DeclPrinter] Honor TerseOutput for constructors
Patch by Nikolai Kosjar!
Differential Revision: https://reviews.llvm.org/D39957
Modified:
cfe/trunk/lib/AST
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318366: add check to avoid throwing objc exception according
to Google Objective-C guide (authored by Wizard).
Repository:
rL LLVM
https://reviews.llvm.org/D40058
Files:
clang-tools-extra/trunk/clan
Author: arphaman
Date: Wed Nov 15 17:31:27 2017
New Revision: 318367
URL: http://llvm.org/viewvc/llvm-project?rev=318367&view=rev
Log:
[DeclPrinter] Extract function PrintConstructorInitializers, NFC
Patch by Nikolai Kosjar!
Differential Revision: https://reviews.llvm.org/D40066
Modified:
c
Author: wizard
Date: Wed Nov 15 17:28:29 2017
New Revision: 318366
URL: http://llvm.org/viewvc/llvm-project?rev=318366&view=rev
Log:
add check to avoid throwing objc exception according to Google Objective-C guide
Summary:
This is a small check to avoid throwing objc exceptions.
In specific it wi
rnk added a comment.
This seems to cause a crash on startup in some gtest binaries when I self-host,
so I guess I should debug that tomorrow before committing. The rest of clang's
tests pass. I guess we don't use virtual inheritance. =S
https://reviews.llvm.org/D40109
__
Eugene.Zelenko added a comment.
Please split this review with one check per review.
Comment at: docs/ReleaseNotes.rst:83
+
+ Check to prevent creation of statically-stored objects in Fuchsia.
+
Please fix double space
Comment at: docs/clang
zturner added a comment.
I'm not suuuper opposed, but at the same time if this code is bothering people
(and it is, consistently), I don't changing the requirements from "confusing
rule A" to "confusing rule B" is going to solve the long term burden that
people keep running into.
Not asking yo
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:31
+ void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+
+CheckFactories.registerCheck(
Please remove empty line.
Comment a
Eugene.Zelenko added a comment.
Please mention new module in docs/clang-tidy/index.rst.
Repository:
rL LLVM
https://reviews.llvm.org/D40108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: echristo
Date: Wed Nov 15 19:18:09 2017
New Revision: 318371
URL: http://llvm.org/viewvc/llvm-project?rev=318371&view=rev
Log:
Add NDEBUG checks around LLVM_DUMP_METHOD functions for Wunused-function
warnings.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp
alexfh added a comment.
In https://reviews.llvm.org/D38171#925929, @xazax.hun wrote:
> In https://reviews.llvm.org/D38171#909346, @leanil wrote:
>
> > In https://reviews.llvm.org/D38171#901427, @xazax.hun wrote:
> >
> > > One problem to think about when we add all clang-diagnostic as "first or
>
alexfh added a comment.
And, btw, sorry for the long delay. I've been on travelling / on vacation for
the last few weeks.
https://reviews.llvm.org/D38171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: marshall
Date: Wed Nov 15 20:48:34 2017
New Revision: 318375
URL: http://llvm.org/viewvc/llvm-project?rev=318375&view=rev
Log:
More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in
match_results.
Added:
libcxx/trunk/test/std/re/re.results/re.results.size/empty.
Author: marshall
Date: Wed Nov 15 21:48:32 2017
New Revision: 318378
URL: http://llvm.org/viewvc/llvm-project?rev=318378&view=rev
Log:
More of P0600 - '[[nodiscard]] in the Library' mark empty() as nodiscard in
filesystem::path
Added:
libcxx/trunk/test/std/experimental/filesystem/class.path
Author: mstorsjo
Date: Wed Nov 15 23:16:36 2017
New Revision: 318383
URL: http://llvm.org/viewvc/llvm-project?rev=318383&view=rev
Log:
[docs] Mention that dwarf unwinding should be supported on arm64/windows
This didn't require any further changes to libunwind as long as win64
in general is handl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318383: [docs] Mention that dwarf unwinding should be
supported on arm64/windows (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39632?vs=121601&id=123130#toc
Repository:
r
kastiglione updated this revision to Diff 123131.
kastiglione added a comment.
Add tests
https://reviews.llvm.org/D40024
Files:
lib/Tooling/ArgumentsAdjusters.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/ToolingTest.cpp
===
101 - 126 of 126 matches
Mail list logo
