[PATCH] D38798: [OpenMP] Support for implicit "declare target" functions - Sema patch

mikerice added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1197 + Context, OMPDeclareTargetDeclAttr::MT_To); + D->addAttr(A); + When D already has an OMPDeclareTargetAttr this seems to add another. Repository: rL LLVM https://r

[PATCH] D39703: [CUDA] Remove implementations of nexttoward and nextafter.

jlebar added a comment. > Libdevice does provide implementation for __nv_nextafterf() and > __nv_nextafter() and it has corresponding wrappers in math_functions.h[pp]. > > Perhaps we should keep nextafter around. Oh, that changes things, since nexttoward is basically the same thing as nextafte

[PATCH] D39702: [test-suite] [CUDA] Delete nexttoward and nextafter CUDA tests, because these functions have no implementations.

jlebar abandoned this revision. jlebar added a comment. Abandoning because it looks like we *can* implement nexttoward in CUDA, see https://reviews.llvm.org/D39703. Will send a different patch. https://reviews.llvm.org/D39702 ___ cfe-commits maili

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

george.karpenkov updated this revision to Diff 122170. george.karpenkov added a comment. Handle non-zero case, more tests cases, cleaner code. https://reviews.llvm.org/D39707 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp test/Analysis/constant-folding.c Index: test/Analysis/con

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

jakehehrlich created this revision. Herald added subscribers: aprantl, mgorny. llvm-objcopy is getting to where it can be used in non-trivial ways (such as for dwarf fission in clang). It now supports dwarf fission but this feature hasn't been thoroughly tested yet. This change allows people to

[PATCH] D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list.

george.karpenkov added a comment. I think I lack context to completely get what is going on here: I assume we don't model the assignment here? Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:533 - if (isa(Init)) { + if (isa(Init) || isa(Init)) { // No work needed.

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && dcoughlin wrote: > xazax.hun wrote:

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny updated this revision to Diff 122172. jdenny retitled this revision from "[VerifyDiagnosticConsumer] support -verify=PREFIX" to "[VerifyDiagnosticConsumer] support -verify=". jdenny edited the summary of this revision. jdenny added a comment. 1. Extended -verify to accept multiple prefixes

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

george.karpenkov added a comment. @dcoughlin OK to commit? https://reviews.llvm.org/D39584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

Hahnfeld added inline comments. Comment at: CMakeLists.txt:236 +set(CLANG_DEFAULT_OBJCOPY "objcopy" CACHE STRING + "Default objcopy runtime to use.") + Nit: `runtime` -> `executable` https://reviews.llvm.org/D39821 __

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

alexshap updated this revision to Diff 122194. alexshap added a comment. Fix Repository: rL LLVM https://reviews.llvm.org/D39438 Files: lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp test/Analysis/stack-capture-leak-arc.mm test/Analysis/stack-capture-leak-no-arc.mm Index: test

r317758 - [Coverage] Emit a gap area after if conditions

Author: vedantk Date: Wed Nov 8 18:33:38 2017 New Revision: 317758 URL: http://llvm.org/viewvc/llvm-project?rev=317758&view=rev Log: [Coverage] Emit a gap area after if conditions The area immediately after the closing right-paren of an if condition should have a count equal to the 'then' block'

r317759 - [Coverage] Complete top-level deferred regions before labels

Author: vedantk Date: Wed Nov 8 18:33:39 2017 New Revision: 317759 URL: http://llvm.org/viewvc/llvm-project?rev=317759&view=rev Log: [Coverage] Complete top-level deferred regions before labels The area immediately after a terminated region in the function top-level should have the same count as

r317760 - [Coverage] Emit deferred regions in headers

Author: vedantk Date: Wed Nov 8 18:33:40 2017 New Revision: 317760 URL: http://llvm.org/viewvc/llvm-project?rev=317760&view=rev Log: [Coverage] Emit deferred regions in headers There are some limitations with emitting regions in macro expansions because we don't gather file IDs within the expans

[PATCH] D38818: Template Instantiation Observer + a few other templight-related changes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thank you! Please move the tests to a new subdirectory under test, say test/Templight. Comment at: tools/CMakeLists.txt:37 add_clang_subdirectory(libclang) +add_subdirector

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

rsmith added a comment. I'm not entirely sure what's happening with this and https://reviews.llvm.org/D38818, but the direction looks good to me, and I left a couple of comments on the other review thread. https://reviews.llvm.org/D5767 ___ cfe-co

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell added a comment. @rnk ping :) Repository: rL LLVM https://reviews.llvm.org/D39673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39588: Distro: initial support for alpine

martell added a comment. @rnk ping. Feel free to add anyone you think might be more suitable if you can't review this. Repository: rL LLVM https://reviews.llvm.org/D39588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r317766 - [X86] Rename the VEX scalar fma builtins to end with a '3' to match gcc

Author: ctopper Date: Wed Nov 8 20:10:46 2017 New Revision: 317766 URL: http://llvm.org/viewvc/llvm-project?rev=317766&view=rev Log: [X86] Rename the VEX scalar fma builtins to end with a '3' to match gcc I think we need to use different builtins for the FMA4 instructions since those instructio

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && george.karpenkov wrote: > dcoughlin wrote:

[PATCH] D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list.

NoQ added a comment. In https://reviews.llvm.org/D39803#919945, @george.karpenkov wrote: > I think I lack context to completely get what is going on here: I assume we > don't model the assignment here? - We model `IntegralLiteral` as `nonloc::ConcreteInt` `12 S32b`. - We model `InitListExpr`

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:289 + /// ChangedSettings + void changeConfiguration(std::map ChangedSettings); + Nebiroth wrote: > ilya-biryukov wrote: > > This function is way too general for `ClangdServer`'s interface,

<    1   2