[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

hfinkel added a comment. Please upload diffs with full context. Comment at: include/clang/Driver/Options.td:1907 def mvsx : Flag<["-"], "mvsx">, Group; +def msave_toc_indirect : Flag<["-"], "msave-toc-indirect">, Group; def mno_vsx : Flag<["-"], "mno-vsx">, Group; --

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: ioeric wrote: > arphaman wrote: > > hokein wrote: > > > sammccall wrote: > > > > As discussed

r316784 - Replace a few usages of llvm::join with range-version[NFC]

Author: erichkeane Date: Fri Oct 27 11:45:06 2017 New Revision: 316784 URL: http://llvm.org/viewvc/llvm-project?rev=316784&view=rev Log: Replace a few usages of llvm::join with range-version[NFC] I noticed a few usages of llvm::join that were using begin/end rather than just the range version. T

[PATCH] D24933: Enable configuration files in clang

sepavloff marked 3 inline comments as done. sepavloff added inline comments. Comment at: lib/Driver/Driver.cpp:739 + // like: i386-clang.cfg -> x86_64-clang.cfg. + if (ArchPrefixLen < CfgFileName.size()) +FixedConfigFile += CfgFileName.substr(ArchPrefixLen); ---

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

v.g.vassilev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1171 + StringRef TargetFlag = PassedFlags; + for (; TargetFlag.find(':') != StringRef::npos;) { +StringRef CurFlag; Why not a `while` loop? https://reviews.llvm.org/D39342

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev updated this revision to Diff 120675. kosarev added a comment. Reworked to distinct may-alias accesses from ordinary ones with an explicit 'kind' field. https://reviews.llvm.org/D39008 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjCRuntime.cpp lib/CodeGen/CGOpenMPRuntime.cpp l

Re: [libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

On Fri, 27 Oct 2017, John Baldwin wrote: On 10/27/17 8:59 AM, Martin Storsjo via cfe-commits wrote: Author: mstorsjo Date: Fri Oct 27 00:59:01 2017 New Revision: 316745 URL: http://llvm.org/viewvc/llvm-project?rev=316745&view=rev Log: Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

mstorsjo created this revision. This restores the previous behaviour of the Registers_* classes after SVN r316745. https://reviews.llvm.org/D39382 Files: include/__libunwind_config.h src/Registers.hpp Index: src/Registers.hpp ===

[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

rnk added a comment. Doesn't this change the ABI considerably? I suspect Apple cares about that. Is remotely unwinding a 64-bit thread from a 32-bit process a concern? That's the main use case that forcing 64-bit words seems to enable. https://reviews.llvm.org/D39365 ___

[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

mstorsjo added a comment. In https://reviews.llvm.org/D39365#909706, @rnk wrote: > Doesn't this change the ABI considerably? I suspect Apple cares about that. It does change the ABI of the lower level unw_* API yes, but it shouldn't be visible outside via the higher level APIs. > Is remotely

r316794 - StaticAnalyzer: Modularize/fix ODR violations making functions inline but non-static in headers

Author: dblaikie Date: Fri Oct 27 13:40:46 2017 New Revision: 316794 URL: http://llvm.org/viewvc/llvm-project?rev=316794&view=rev Log: StaticAnalyzer: Modularize/fix ODR violations making functions inline but non-static in headers Also move these out of the llvm namespace & rely on ADL as is app

r316792 - CharInfo.h: Modularize/fix ODR violations by making inline functions in header not static

Author: dblaikie Date: Fri Oct 27 13:40:45 2017 New Revision: 316792 URL: http://llvm.org/viewvc/llvm-project?rev=316792&view=rev Log: CharInfo.h: Modularize/fix ODR violations by making inline functions in header not static Modified: cfe/trunk/include/clang/Basic/CharInfo.h Modified: cfe/t

r316791 - ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline functions in headers

Author: dblaikie Date: Fri Oct 27 13:40:44 2017 New Revision: 316791 URL: http://llvm.org/viewvc/llvm-project?rev=316791&view=rev Log: ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline functions in headers Modified: cfe/trunk/include/clang/AST/ASTContext.h Modifie

r316793 - Sanitizers.h: Modularize/Fix ODR violations by making inline functions non-static

Author: dblaikie Date: Fri Oct 27 13:40:45 2017 New Revision: 316793 URL: http://llvm.org/viewvc/llvm-project?rev=316793&view=rev Log: Sanitizers.h: Modularize/Fix ODR violations by making inline functions non-static Modified: cfe/trunk/include/clang/Basic/Sanitizers.h Modified: cfe/trunk/i

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: ioeric wrote: > ioeric wrote: > > arphaman wrote: > > > hokein wrote: > > > > sammccall wro

[PATCH] D39057: [clangd][WIP] Integrate the refactoring actions into clangd

arphaman added a comment. In https://reviews.llvm.org/D39057#907820, @sammccall wrote: > In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote: > > > There's another patch (https://reviews.llvm.org/D39276) that tries to add > > `workspace/executeCommand` for a slightly different use-ca

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

efriedma added a comment. Are you sure the change to APCS is right? I mean, it looks like it's right if I compare to gcc with -mabi=gnu-apcs, but I'm not sure what, exactly, we're trying to be compatible with, so I'd prefer not to touch it, especially not in a patch with a bunch of changes whi

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

rnk created this revision. Clang typically warns that in the following class hierarchy, 'A' is inaccessible because there is no series of casts that the user can write to access it unambiguously: struct A { }; struct B : A { }; struct C : A, B { }; MSVC allows the user to convert from C* t

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: arphaman wrote: > ioeric wrote: > > ioeric wrote: > > > arphaman wrote: > > > > hokein wrote:

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

smeenai added a comment. When you say "latest Windows SDK headers", do you mean SDK version 10.0.16299.15? https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yuck, LGTM :) https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

arphaman added a comment. Hi, Thanks for your patch! Could you please post a patch with full context (git diff -U9)? Comment at: lib/Serialization/ASTWriterDecl.cpp:1541 - bool OwnsDefaultArg = D->hasDefaultArgument() && -!D->defaultArgumentWasI

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

timshen updated this revision to Diff 120711. timshen added a comment. Remove the uses of variadic template and auto. I'm not sure of how to implement this without a ABI change (the addition of __storage_). https://reviews.llvm.org/D39308 Files: libcxx/include/regex Index: libcxx/include/r

r316806 - [Analyzer] [Tests] Dump the output of scan-build to stdout on failure.

Author: george.karpenkov Date: Fri Oct 27 15:39:54 2017 New Revision: 316806 URL: http://llvm.org/viewvc/llvm-project?rev=316806&view=rev Log: [Analyzer] [Tests] Dump the output of scan-build to stdout on failure. Eliminates extra lookup step during debugging. Modified: cfe/trunk/utils/analy

r316807 - [MS] Allow access to ambiguous, inaccessible direct bases

Author: rnk Date: Fri Oct 27 15:48:41 2017 New Revision: 316807 URL: http://llvm.org/viewvc/llvm-project?rev=316807&view=rev Log: [MS] Allow access to ambiguous, inaccessible direct bases Summary: Clang typically warns that in the following class hierarchy, 'A' is inaccessible because there is no

r316808 - [Analyzer] [Tests] Fixing typo from the previous commit.

Author: george.karpenkov Date: Fri Oct 27 15:52:36 2017 New Revision: 316808 URL: http://llvm.org/viewvc/llvm-project?rev=316808&view=rev Log: [Analyzer] [Tests] Fixing typo from the previous commit. Can not open a non-existent file with r+. Modified: cfe/trunk/utils/analyzer/SATestBuild.py

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Yeah, we have coverage for the various environments in `test/Preprocessor/init.c`. The one case that I didn't find was the APCS-GNU case, which I added a test for additional coverage. Repository: rL LLVM https://reviews.llvm.org/D39321 _

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd closed this revision. compnerd added a comment. SVN r316810 Repository: rL LLVM https://reviews.llvm.org/D39321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r316810 - ARM: centralise SizeType, PtrDiffType, and IntPtrType

Author: compnerd Date: Fri Oct 27 16:04:27 2017 New Revision: 316810 URL: http://llvm.org/viewvc/llvm-project?rev=316810&view=rev Log: ARM: centralise SizeType, PtrDiffType, and IntPtrType Centralise the definitions of these compiler vended types to aid inspection to ensure that they are defined

[PATCH] D39149: [libc++] Prevent tautological comparisons

smeenai added a comment. Ping. Like I said, not a huge fan of this change, but also not a huge fan of running into clang diagnostics (especially since we build with `-Werror` downstream). https://reviews.llvm.org/D39149 ___ cfe-commits mailing lis

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Well, without matching that ABI, I think that centralizing the logic isn't any cleaner, since we determine the ABI later. With this, we also match the ABI as GNU defines it, and we can move the logic to the same location. `intptr_t` on Darwin && !WatchOS has the one

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. I guess... fine. LGTM, assuming we have test coverage for all the different cases. Repository: rL LLVM https://reviews.llvm.org/D39321 __

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is fine, although, how does the cross-unwinding work without the remote address space support? https://reviews.llvm.org/D39382 ___ cfe-

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

This revision was automatically updated to reflect the committed changes. Closed by commit rL316807: [MS] Allow access to ambiguous, inaccessible direct bases (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D39389?vs=120694&id=120713#toc Repository: rL LLVM https://revi

[PATCH] D38596: Implement attribute target multiversioning

rsmith added a comment. I'm not entirely happy with the AST representation you're using here. Allowing multiple declarations of the same entity to have (semantically distinct) bodies breaks our AST invariants, and will cause things like our PCH / modules support to fail. This can probably be ma

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

yamaguchi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1171 + StringRef TargetFlag = PassedFlags; + for (; TargetFlag.find(':') != StringRef::npos;) { +StringRef CurFlag; v.g.vassilev wrote: > Why not a `while` loop? I didn't have special

[PATCH] D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk.

wolfgangp created this revision. The problem in PRR33930 comes about because clang is cloning a function (to generate varargs thunks) before all the Metadata nodes are resolved. The value mapper, which is used by the cloner to deal with Medatdata no

r316820 - Never try to instantiate a deduction guide's "definition". Fixes bogus warning when there inevitably isn't one.

Author: rsmith Date: Fri Oct 27 18:15:00 2017 New Revision: 316820 URL: http://llvm.org/viewvc/llvm-project?rev=316820&view=rev Log: Never try to instantiate a deduction guide's "definition". Fixes bogus warning when there inevitably isn't one. Modified: cfe/trunk/lib/Sema/SemaTemplateInstan

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet created this revision. Herald added subscribers: baloghadamsoftware, whisperity. This patch adds a LoopExit element to the CFG whenever a loop is exited by a ReturnStmt, GotoStmt or IndirectGotoStmt. The LoopExit element is consumed by the Static Analyzer in order to simulate the loops mo

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet updated this revision to Diff 120726. szepet added a comment. Just removed some accidentally left changes from the patch. https://reviews.llvm.org/D39398 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp test/Analysis/loopexit-cfg-output.cpp Index: test/Analysis/loopexit-cf

[PATCH] D38596: Implement attribute target multiversioning

erichkeane added a comment. Hi Richard, thanks for the review! I'll make another attempt with this based on your feedback, though if you could clarify your suggestion, it would be greatly appreciated. In https://reviews.llvm.org/D38596#909957, @rsmith wrote: > I'm not entirely happy with the

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

mstorsjo added a comment. In https://reviews.llvm.org/D39382#909918, @compnerd wrote: > This is fine, although, how does the cross-unwinding work without the remote > address space support? No idea - I also was under the impression that it wasn't actually useful but mostly theoretical/planned

r316826 - Basic: improve coverage for Darwin targets and fix ABI

Author: compnerd Date: Fri Oct 27 23:00:43 2017 New Revision: 316826 URL: http://llvm.org/viewvc/llvm-project?rev=316826&view=rev Log: Basic: improve coverage for Darwin targets and fix ABI The existing coverage for the Darwin targets wasn't enough to catch all the variations. Improve the covera

<    1   2