r315276 - [ASTMatchers] Don't create a copy of a std::set when iterating over it.

Author: d0k Date: Tue Oct 10 00:21:34 2017 New Revision: 315276 URL: http://llvm.org/viewvc/llvm-project?rev=315276&view=rev Log: [ASTMatchers] Don't create a copy of a std::set when iterating over it. This is a bit awkward because lookup returns a copy instead of a reference. No functionality ch

[clang-tools-extra] r315277 - [clang-tidy] Use a more efficient map for the virtual near miss check.

Author: d0k Date: Tue Oct 10 00:21:51 2017 New Revision: 315277 URL: http://llvm.org/viewvc/llvm-project?rev=315277&view=rev Log: [clang-tidy] Use a more efficient map for the virtual near miss check. DenseMap performs better here. No functionality change intended. Modified: clang-tools-extr

[PATCH] D38627: [clangd] Added move-only function helpers.

chapuni added a comment. Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :( Any idea? In file included from clang-tools-extra/clangd/ClangdServer.h:23:0, from clang-tools-extra/clangd/ClangdServer.cpp:10: clang-tools-extra/clangd/Function.h: In instantiation of ‘Ret

[PATCH] D38628: Remove unneeded typename from test

rogfer01 added a comment. Thanks @chill , @mclow.lists and @EricWF ! https://reviews.llvm.org/D38628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38628: Remove unneeded typename from test

This revision was automatically updated to reflect the committed changes. Closed by commit rL315278: Remove unneeded typename from test (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38628?vs=118183&id=118321#toc Repository: rL LLVM https://reviews.llvm.org/D3862

[libcxx] r315278 - Remove unneeded typename from test

Author: rogfer01 Date: Tue Oct 10 00:42:19 2017 New Revision: 315278 URL: http://llvm.org/viewvc/llvm-project?rev=315278&view=rev Log: Remove unneeded typename from test Differential Revision: https://reviews.llvm.org/D38628 Modified: libcxx/trunk/test/std/utilities/utility/pairs/pair.astu

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

danielmarjamaki added a comment. In https://reviews.llvm.org/D38675#891912, @xazax.hun wrote: > In https://reviews.llvm.org/D38675#891750, @danielmarjamaki wrote: > > > > However, the checker seems to work with a low false positive rate. (<15 > > > on the LLVM, 6 effectively different) > > > >

Re: [clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

Will do, sorry about that. On Oct 10, 2017 01:15, "Galina Kistanova" wrote: > Hello Ilya, > > This commit broke build on one of our builders: > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/16435 > > Please have a look? > > Thanks > > Galina > > > On Mon, Oct 9, 2017 at

[clang-tools-extra] r315284 - [clangd] Fix compilation on gcc.

Author: ibiryukov Date: Tue Oct 10 01:40:57 2017 New Revision: 315284 URL: http://llvm.org/viewvc/llvm-project?rev=315284&view=rev Log: [clangd] Fix compilation on gcc. Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL: http://llvm.o

Re: [clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

Fixed in r315284. On Tue, Oct 10, 2017 at 10:28 AM, Ilya Biryukov wrote: > Will do, sorry about that. > > On Oct 10, 2017 01:15, "Galina Kistanova" wrote: > >> Hello Ilya, >> >> This commit broke build on one of our builders: >> >> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi- >> te

r315286 - Fix small nits in clang-refactor doc.

Author: hokein Date: Tue Oct 10 02:00:56 2017 New Revision: 315286 URL: http://llvm.org/viewvc/llvm-project?rev=315286&view=rev Log: Fix small nits in clang-refactor doc. Modified: cfe/trunk/docs/RefactoringEngine.rst Modified: cfe/trunk/docs/RefactoringEngine.rst URL: http://llvm.org/viewv

[clang-tools-extra] r315287 - Revert "Revert r315214 since diff -Z isn't portable, this is breaking:"

Author: ibiryukov Date: Tue Oct 10 02:08:47 2017 New Revision: 315287 URL: http://llvm.org/viewvc/llvm-project?rev=315287&view=rev Log: Revert "Revert r315214 since diff -Z isn't portable, this is breaking:" This reverts commit r315242 and restores r315214. To fix original failure, replaced non-

[PATCH] D38627: [clangd] Added move-only function helpers.

ilya-biryukov added a comment. In https://reviews.llvm.org/D38627#892773, @chapuni wrote: > Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :( > Any idea? Sorry about that. Fixed in https://reviews.llvm.org/rL315284. clang and gcc (at least version 4.8) behave differently here, so I di

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn updated this revision to Diff 118330. jklaehn added a comment. Added `c-index-test`-based test. https://reviews.llvm.org/D36955 Files: bindings/python/tests/cindex/test_cursor.py test/Index/annotate-attribute.cpp tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp ===

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn updated this revision to Diff 118333. jklaehn added a comment. Use user-defined function for test of `AvailabilityKind.DEPRECATED`. https://reviews.llvm.org/D36973 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py Index: bindings/python/tests/cindex

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Sorry about that, `diff -b` seems to work. Restored commit and changed to `diff -b` in r315287. Thanks for spotting and reverting this. On Mon, Oct 9, 2017 at 8:45 PM, Bruno Cardoso Lopes wrote: > Hi, > > On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits > wrote: > > Author: ibiryuk

[PATCH] D38717: Patch to Bugzilla 31373

erikv created this revision. Committing a patch to Bugzilla 31373 A novice programmer so hopefully it complies with the coding policy. I had to disable an assert in lib/CodeGen/CGExpr.cpp since it requires that all expressions are marked as Used or referenced, which is not possible if we want t

[PATCH] D38695: [CodeGen] Do not construct complete LValue base info in trivial cases

This revision was automatically updated to reflect the committed changes. Closed by commit rL315289: [CodeGen] Do not construct complete LValue base info in trivial cases (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38695?vs=118234&id=118335#toc Repository: rL LL

r315289 - [CodeGen] Do not construct complete LValue base info in trivial cases

Author: kosarev Date: Tue Oct 10 02:39:32 2017 New Revision: 315289 URL: http://llvm.org/viewvc/llvm-project?rev=315289&view=rev Log: [CodeGen] Do not construct complete LValue base info in trivial cases Besides obvious code simplification, avoiding explicit creation of LValueBaseInfo objects mak

r315290 - [clang-refactor] Fix clang-tidy misc-move-const-arg warning.

Author: hokein Date: Tue Oct 10 02:48:38 2017 New Revision: 315290 URL: http://llvm.org/viewvc/llvm-project?rev=315290&view=rev Log: [clang-refactor] Fix clang-tidy misc-move-const-arg warning. NFC Modified: cfe/trunk/tools/clang-refactor/ClangRefactor.cpp Modified: cfe/trunk/tools/clang-re

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

NoQ added a comment. Last time i was running on WebKit; i already lost my results, so i'd try to reproduce the results on the fixed checker and follow up. Apart from https://reviews.llvm.org/D31538, i've seen a few cases where a method was safe to be called on a moved-from object (which led me

[PATCH] D38718: Patch to Bugzilla 20951

erikv created this revision. Submitting a patch to Bugzilla 20951. Simply replaced the function call IgnoreImpCasts to IgnoreParenImpCasts which seems to more appropriate. I also had to modify a test cast in test/Sema/conditional-expr.c /E https://reviews.llvm.org/D38718 Files: lib/Sema/Se

[PATCH] D38718: Patch to Bugzilla 20951

lebedev.ri added inline comments. Comment at: test/Sema/conditional-expr.c:84 + //char x; + return (((x != ((void *) 0)) ? (*x = ((char) 1)) : (void) ((void *) 0)), (unsigned long) ((void *) 0)); // expected-warning {{C99 forbids conditional expressions with only one void sid

r315296 - [analyzer] Implement pointer arithmetic on constants

Author: xazax Date: Tue Oct 10 04:01:49 2017 New Revision: 315296 URL: http://llvm.org/viewvc/llvm-project?rev=315296&view=rev Log: [analyzer] Implement pointer arithmetic on constants Patch by: Rafael Stahl! Differential Revision: https://reviews.llvm.org/D37478 Added: cfe/trunk/test/Analy

[PATCH] D37478: [analyzer] Implement pointer arithmetic on constants

This revision was automatically updated to reflect the committed changes. Closed by commit rL315296: [analyzer] Implement pointer arithmetic on constants (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D37478?vs=118182&id=118342#toc Repository: rL LLVM https://reviews

[PATCH] D38718: Patch to Bugzilla 20951

danielmarjamaki added a reviewer: danielmarjamaki. danielmarjamaki added a comment. I think a test for -Wtautological-pointer-compare should be added that shows that the bug is fixed. Comment at: test/Sema/conditional-expr.c:84 + //char x; + return (((x != ((void *) 0)) ? (*

[PATCH] D38720: [clangd] Report proper kinds for 'Keyword' and 'Snippet' completion items.

ilya-biryukov created this revision. https://reviews.llvm.org/D38720 Files: clangd/ClangdUnit.cpp test/clangd/completion-items-kinds.test Index: test/clangd/completion-items-kinds.test === --- /dev/null +++ test/clangd/completi

[PATCH] D38718: [Sema] No -Wtautological-pointer-compare warning on variables within parentheses

erikv updated this revision to Diff 118347. erikv added a comment. Added new test Repository: rL LLVM https://reviews.llvm.org/D38718 Files: lib/Sema/SemaChecking.cpp test/Sema/conditional-expr.c test/Sema/warn-tautological-compare.c Index: test/Sema/conditional-expr.c ==

[PATCH] D38171: Implement clang-tidy check aliases.

xazax.hun added a comment. Let's also summarize what do we have now and what do we want. > I also think this sounds good, though I'm not quite sure it can be done in > this patch. Anyway, we should definitely specify what we expect from > first-class citizen checks. Please correct & extend the

[PATCH] D38718: [Sema] No -Wtautological-pointer-compare warning on variables within parentheses

danielmarjamaki added a comment. LGTM! However I would like to see a review from somebody else also. There are a number of diagnostics that might be affected. The Sema::DiagnoseAlwaysNonNullPointer diagnoses these: diag::warn_this_null_compare diag::warn_this_bool_conversion diag::warn_address_

r315298 - [analyzer] PthreadLockChecker: Add printState() method for self-debugging.

Author: dergachev Date: Tue Oct 10 04:49:09 2017 New Revision: 315298 URL: http://llvm.org/viewvc/llvm-project?rev=315298&view=rev Log: [analyzer] PthreadLockChecker: Add printState() method for self-debugging. This method injects additional information into program state dumps, describing states

[PATCH] D37805: [analyzer] PthreadLock: add printState().

This revision was automatically updated to reflect the committed changes. Closed by commit rL315298: [analyzer] PthreadLockChecker: Add printState() method for self-debugging. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D37805?vs=115028&id=118349#toc Repository:

r315300 - [analyzer] MisusedMovedObject: Add printState() method for self-debugging.

Author: dergachev Date: Tue Oct 10 04:50:45 2017 New Revision: 315300 URL: http://llvm.org/viewvc/llvm-project?rev=315300&view=rev Log: [analyzer] MisusedMovedObject: Add printState() method for self-debugging. This method injects additional information into program state dumps, describing which

[PATCH] D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315300: [analyzer] MisusedMovedObject: Add printState() method for self-debugging. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D31541?vs=93661&id=118350#toc Repository:

r315301 - [analyzer] MisusedMovedObject: Fix state-resetting a base-class sub-object.

Author: dergachev Date: Tue Oct 10 04:55:56 2017 New Revision: 315301 URL: http://llvm.org/viewvc/llvm-project?rev=315301&view=rev Log: [analyzer] MisusedMovedObject: Fix state-resetting a base-class sub-object. If a method is resetting the state of an object that was moved from, it should be saf

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315301: [analyzer] MisusedMovedObject: Fix state-resetting a base-class sub-object. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D31538?vs=93652&id=118351#toc Repository:

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D36471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

Hi Richard, This is breaking the boostrap stage in the internal integration. I'm seeing "unsupported: typedef changes linkage of anonymous type, but linkage was already computed" error for many `struct`s defined with typedef. I'm not sure if it is user code or clang that needs fixing; however, as

[PATCH] D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

hokein created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D38723 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/RenameClassTest.cpp Index: unittests/Rename/RenameClassTest.cpp ===

Re: r315256 - [Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module.

I am reverting this commit as it depends on r315251. See r315251 thread for reason. On Tue, Oct 10, 2017 at 2:49 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Oct 9 17:49:38 2017 > New Revision: 315256 > > URL: http://llvm.org/viewvc/llvm-proj

r315308 - Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module."

Author: ioeric Date: Tue Oct 10 06:00:18 2017 New Revision: 315308 URL: http://llvm.org/viewvc/llvm-project?rev=315308&view=rev Log: Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext for a declaration in the global module." This reverts commit r315256. See the origina

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

RKSimon added inline comments. Comment at: test/CodeGen/avx512cdintrin.c:106 + // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}} + return _mm512_broadcastmw_epi32(_mm512_cmpeq_epi32_mask ( a, b)); } Any reason why you can't use the actual insertion indi

r315309 - Revert "[Modules TS] Module ownership semantics for redeclarations."

Author: ioeric Date: Tue Oct 10 06:09:40 2017 New Revision: 315309 URL: http://llvm.org/viewvc/llvm-project?rev=315309&view=rev Log: Revert "[Modules TS] Module ownership semantics for redeclarations." This reverts commit r315251. See the original commit thread for reason. Removed: cfe/trunk

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

FYI, I tweaked the tree in rL315283. Shall we restore it? On Tue, Oct 10, 2017 at 9:41 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > This is breaking the boostrap stage in the internal integration. I'm > seeing "unsupported: typedef changes linkage of anonymou

[PATCH] D38452: Mark test as a long-test

rogfer01 added a comment. Friendly ping :) https://reviews.llvm.org/D38452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg with nits. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:163 const NestedNameSpecifier *Specifier; +// Determine whether the prefix qualifiers of th

r315314 - Fix a (slightly weird) 'comma operator within array index expression' warning on VS builds. NFCI.

Author: rksimon Date: Tue Oct 10 06:56:17 2017 New Revision: 315314 URL: http://llvm.org/viewvc/llvm-project?rev=315314&view=rev Log: Fix a (slightly weird) 'comma operator within array index expression' warning on VS builds. NFCI. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modifie

r315315 - [OPENMP] Add default codegen|tests for 'target parallel for[ simd]'

Author: abataev Date: Tue Oct 10 07:14:43 2017 New Revision: 315315 URL: http://llvm.org/viewvc/llvm-project?rev=315315&view=rev Log: [OPENMP] Add default codegen|tests for 'target parallel for[ simd]' constructs. Added default codegen for 'target parallel for' construct + tests for default codeg

[PATCH] D38731: [clangd] Allow to pass code completion opts to ClangdServer.

ilya-biryukov created this revision. https://reviews.llvm.org/D38731 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp

[clang-tools-extra] r315317 - [clangd] clang-format the source code. NFC.

Author: ibiryukov Date: Tue Oct 10 07:21:04 2017 New Revision: 315317 URL: http://llvm.org/viewvc/llvm-project?rev=315317&view=rev Log: [clangd] clang-format the source code. NFC. Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp clang-tools-extra/trunk/clangd/Protoco

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

mppf added a comment. Since I don't have commit access, could somebody commit this for me please? Thanks. https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D38733: [CodeGen] Generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. This patch enables explicit generation of TBAA information in all cases where LValue base info is propagated or constructed in non-trivial ways. Eventually, we will consider each of these cases to make sure the TBAA information is c

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

uriel.k created this revision. Changed Header files of the intrinsics fro lowering test and testn intrinsics to IR code. Removed test and testn builtins from clang this is the clang side, the llvm side revision is D38736 . https://reviews.llvm.org/D38737 File

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

martong added inline comments. Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39 + // primary template. + if (const FunctionDecl *InstantiatedFrom = + Target->getInstantiatedFromMemberFunction()) Could we use here FunctionDecl::getPrimaryTemplate()

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

Thanks for reverting. We saw build failures in Chromium too. E.g. from https://build.chromium.org/p/chromium.clang/builders/ToTLinux/builds/134: In file included from ../../third_party/breakpad/breakpad/src/common/linux/symbol_upload.cc:34: ../../third_party/breakpad/breakpad/src/common/linux/sym

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

On 10 Oct 2017 05:41, "Eric Liu via cfe-commits" wrote: Hi Richard, This is breaking the boostrap stage in the internal integration. I'm seeing "unsupported: typedef changes linkage of anonymous type, but linkage was already computed" error for many `struct`s defined with typedef. I'm not sure i

[clang-tools-extra] r315324 - [clangd] Added missing #includes to Function.h

Author: ibiryukov Date: Tue Oct 10 09:12:50 2017 New Revision: 315324 URL: http://llvm.org/viewvc/llvm-project?rev=315324&view=rev Log: [clangd] Added missing #includes to Function.h Modified: clang-tools-extra/trunk/clangd/Function.h Modified: clang-tools-extra/trunk/clangd/Function.h URL:

[clang-tools-extra] r315323 - [clangd] Added forgotten return in UniqueFunction.

Author: ibiryukov Date: Tue Oct 10 09:12:47 2017 New Revision: 315323 URL: http://llvm.org/viewvc/llvm-project?rev=315323&view=rev Log: [clangd] Added forgotten return in UniqueFunction. This hasn't bitten us because we only used functions returning 'void'. Modified: clang-tools-extra/trunk/

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

No :( I tried reverting only r315256 but still got the errors. On Tue, Oct 10, 2017 at 6:10 PM Richard Smith wrote: > On 10 Oct 2017 05:41, "Eric Liu via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Hi Richard, > > This is breaking the boostrap stage in the internal integration. I'm >

[clang-tools-extra] r315325 - [clangd] Use UniqueFunction for deferred computations.

Author: ibiryukov Date: Tue Oct 10 09:12:54 2017 New Revision: 315325 URL: http://llvm.org/viewvc/llvm-project?rev=315325&view=rev Log: [clangd] Use UniqueFunction for deferred computations. Previsouly, `std::future` that were results of `std::async(std::launch::deferred, ...` were used. Modifie

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb added a comment. I keep running into issues trying to cross-build LLVM (it keeps wanting to use /usr/bin/cc or host libraries even though cross-compiling is enabled). I wonder if the failures you saw Simon might be due to https://bugs.llvm.org/show_bug.cgi?id=33858? Could you try apply

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP of this alloca. yaxu

[PATCH] D38567: [config] Warn when POSIX_C_SOURCE breaks threading support on Darwin

arphaman added inline comments. Comment at: include/__threading_support:26 +#if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && (__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)) \ +|| (defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && (__IPHONE_OS_VERSION_MIN_REQUIRED < 11)) \

r315330 - For dllexport class templates, export specializations of member functions (PR34849) (take 2)

Author: hans Date: Tue Oct 10 09:53:25 2017 New Revision: 315330 URL: http://llvm.org/viewvc/llvm-project?rev=315330&view=rev Log: For dllexport class templates, export specializations of member functions (PR34849) (take 2) This is a re-commit of r315025, but making sure to only apply this to sp

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

tra created this revision. Herald added subscribers: sanjoy, jholewinski. https://reviews.llvm.org/D38742 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-nvptx-sm_70.cu Index: clang/test/CodeGen/builtins-nvptx-sm_70.cu

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added a comment. > (*) I know that you aren't considering OpenCL C++ yet, but often these > representation/model questions are easier to answer when thinking about C++ > instead of C because type differences are so much more directly important in > C++. In OpenCL C++, I assume it w

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

Anastasia accepted this revision. Anastasia added a comment. I would prefer to merge the new test with test/SemaOpenCL/func.cl, but otherwise LGTM! Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Carrot added a comment. In https://reviews.llvm.org/D38656#892740, @nemanjai wrote: > In https://reviews.llvm.org/D38656#892072, @Carrot wrote: > > > I worked on a similar bug as 31161, and then found this one, it should be > > same as in comment7. > > What is the current status of the work on

[PATCH] D38567: [config] Warn when POSIX_C_SOURCE breaks threading support on Darwin

vsk abandoned this revision. vsk added a comment. For those following along, Alex worked out that this doesn't affect apple-clang 802. We took a closer look and found that the build break just affects clang-900, and was introduced in this r290889. The fix (r293167) didn't make it into clang-900

r315336 - [clang-fuzzer] Allow building without coverage instrumentation.

Author: morehouse Date: Tue Oct 10 10:41:43 2017 New Revision: 315336 URL: http://llvm.org/viewvc/llvm-project?rev=315336&view=rev Log: [clang-fuzzer] Allow building without coverage instrumentation. Summary: Compile with DummyClangFuzzer.cpp as entry point rather than libFuzzer's main when cover

[PATCH] D38642: [clang-fuzzer] Allow building without coverage instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315336: [clang-fuzzer] Allow building without coverage instrumentation. (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D38642?vs=118097&id=118420#toc Repository: rL LLVM

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315338 - [lit] Add host_cxx to lit config

Author: fjricci Date: Tue Oct 10 10:53:45 2017 New Revision: 315338 URL: http://llvm.org/viewvc/llvm-project?rev=315338&view=rev Log: [lit] Add host_cxx to lit config Summary: This is required to get the clang version for sanitized builds. Reviewers: zturner Subscribers: llvm-commits Different

r315339 - [clang-fuzzer] Build proto-to-cxx with fuzzer-no-link.

Author: morehouse Date: Tue Oct 10 10:59:37 2017 New Revision: 315339 URL: http://llvm.org/viewvc/llvm-project?rev=315339&view=rev Log: [clang-fuzzer] Build proto-to-cxx with fuzzer-no-link. Makes it possible to build with any sanitizer or none at all. Modified: cfe/trunk/tools/clang-fuzzer/

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

arphaman added inline comments. Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29 + // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#> + // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#> +} -

[libclc] r315341 - Make image builtins r600/llvm-3.9 only

Author: jvesely Date: Tue Oct 10 11:10:21 2017 New Revision: 315341 URL: http://llvm.org/viewvc/llvm-project?rev=315341&view=rev Log: Make image builtins r600/llvm-3.9 only The implementation uses r600 sepcific intrinsics LLVM-4 switched to _ro_t and _rw_t image types Portions of the code can be

[libclc] r315343 - travis: enable checks of nvptx libraries

Author: jvesely Date: Tue Oct 10 11:10:25 2017 New Revision: 315343 URL: http://llvm.org/viewvc/llvm-project?rev=315343&view=rev Log: travis: enable checks of nvptx libraries Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.travis

[libclc] r315342 - travis: Enable external function call checks on llvm-{4, 5}

Author: jvesely Date: Tue Oct 10 11:10:24 2017 New Revision: 315342 URL: http://llvm.org/viewvc/llvm-project?rev=315342&view=rev Log: travis: Enable external function call checks on llvm-{4,5} Reviewer: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libc

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144 + if (auto *I = dyn_cast(V)) { +// If the block literal is emitted as an instruction, it is an alloca +// and the block invoke function is stored to GEP

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader updated this revision to Diff 118437. bader added a comment. Applied comments. https://reviews.llvm.org/D33681 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/func.cl test/SemaOpenCL/invalid-pipes-cl2.0.cl Index: test/SemaOpenCL/invalid-pipes-cl2.0.cl ==

[PATCH] D38755: Fixed crash during indexing default template template param

jkorous-apple created this revision. fix + testcase https://reviews.llvm.org/D38755 Files: lib/Index/IndexDecl.cpp test/Index/index-template-template-param.cpp Index: test/Index/index-template-template-param.cpp === --- /dev/

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov added inline comments. Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29 + // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar c#>, <#ns::baz d#> + // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz c#>

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. Thanks for the pointer to that patch, I'll take a look tomorrow. Comment at: src/UnwindRegistersRestore.S:492 +#elif defined(__mips__) && _MIPS_SIM == _ABIO32 + Needs checking for soft-float. Comment at: src/UnwindR

r315355 - Revert "[clang-fuzzer] Allow building without coverage instrumentation."

Author: morehouse Date: Tue Oct 10 13:13:13 2017 New Revision: 315355 URL: http://llvm.org/viewvc/llvm-project?rev=315355&view=rev Log: Revert "[clang-fuzzer] Allow building without coverage instrumentation." This reverts r315336 due to build breakage with gcc. http://lab.llvm.org:8011/builders/u

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

This revision was automatically updated to reflect the committed changes. Closed by commit rL315358: [CGExprScalar] In EmitCompare trunc the result if it has different type as E… (authored by Carrot). Changed prior to commit: https://reviews.llvm.org/D38656?vs=118236&id=118464#toc Repository:

[PATCH] D38402: [clang-refactor] Apply source replacements

arphaman updated this revision to Diff 118471. arphaman marked 6 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D38402 Files: include/clang/Frontend/CommandLineSourceLoc.h test/Refactor/tool-apply-replacements.cpp

[PATCH] D38402: [clang-refactor] Apply source replacements

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D38402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D38755: Fixed crash during indexing default template template param

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D38755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

r315358 - [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Author: carrot Date: Tue Oct 10 13:31:27 2017 New Revision: 315358 URL: http://llvm.org/viewvc/llvm-project?rev=315358&view=rev Log: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType() Usually compare expression should return i1 type, so EmitScalarConversion i

r315366 - Add test for regression caused by reverted patch r315251.

Author: rsmith Date: Tue Oct 10 14:07:44 2017 New Revision: 315366 URL: http://llvm.org/viewvc/llvm-project?rev=315366&view=rev Log: Add test for regression caused by reverted patch r315251. Modified: cfe/trunk/test/SemaCXX/linkage2.cpp Modified: cfe/trunk/test/SemaCXX/linkage2.cpp URL: htt

r315367 - Fix indexer crash for default template template parameter value

Author: jkorous Date: Tue Oct 10 14:09:49 2017 New Revision: 315367 URL: http://llvm.org/viewvc/llvm-project?rev=315367&view=rev Log: Fix indexer crash for default template template parameter value rdar://33058798 Differential Revision: https://reviews.llvm.org/D38755 Added: cfe/trunk/test/

[PATCH] D38755: Fixed crash during indexing default template template param

This revision was automatically updated to reflect the committed changes. Closed by commit rL315367: Fix indexer crash for default template template parameter value (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38755?vs=118451&id=118476#toc Repository: rL LLVM ht

[PATCH] D36973: [libclang] Add support for querying cursor availability

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. LGTM Would you like me to commit this for you? https://reviews.llvm.org/D36973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. LGTM Would you like me to commit this for you? https://reviews.llvm.org/D36955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

rsmith added a comment. @rjmccall Do you have any more comments? https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 118482. Nebiroth added a comment. Rebased on master. https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Pro

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

rprichard added a comment. I assume std::type_info::operator== also needs to be adjusted to compare string names? It looks like libc++'s version of the function does string comparisons for ARM64 iOS, but only on some classes (e.g. public(?) ones). Look for the _LIBCPP_HAS_NONUNIQUE_TYPEINFO and

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

rprichard added a comment. Here's the Clang bug I filed: https://bugs.llvm.org/show_bug.cgi?id=34907 Repository: rL LLVM https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun, mgorny. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/NonnilStringConstantsChecker.cpp tes

  1   2   >