thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
Should probably get a release note too.
https://reviews.llvm.org/D38646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
kcc added a comment.
We often suggest to code owners to implement their own dummy main to run fuzz
targets as regression tests.
But for ourselves (LLVM) this recommendations makes less sense since libFuzzer
is part of LLVM and we can use it's main directly.
https://reviews.llvm.org/D38642
rnk updated this revision to Diff 118079.
rnk added a comment.
- go to 1911, 1910 was the preview
- add release notes
https://reviews.llvm.org/D38646
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Driver/ToolChains/MSVC.cpp
Index: clang/lib/Driver/ToolChains/MSVC.cpp
===
Author: rnk
Date: Fri Oct 6 14:02:28 2017
New Revision: 315107
URL: http://llvm.org/viewvc/llvm-project?rev=315107&view=rev
Log:
[MS] Raise the default value of _MSC_VER to 1911, which is VS 2017
Summary:
This raises our default past 1900, which controls whether char16_t is a
builtin type or not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315107: [MS] Raise the default value of _MSC_VER to 1911,
which is VS 2017 (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D38646?vs=118079&id=118080#toc
Repository:
rL LLVM
htt
Author: rnk
Date: Fri Oct 6 14:28:21 2017
New Revision: 315111
URL: http://llvm.org/viewvc/llvm-project?rev=315111&view=rev
Log:
Revert "For dllexport class templates, export specializations of member
functions (PR34849)"
This reverts r315025, it caused http://crbug.com/772461
Modified:
cf
compnerd updated this revision to Diff 118085.
compnerd added a comment.
Split the defaulting back to all the various targets.
Repository:
rL LLVM
https://reviews.llvm.org/D37891
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Basic/LangOptions.def
include/clang/Dri
morehouse updated this revision to Diff 118087.
morehouse added a comment.
- Remove dummy main and link with -fsantize=fuzzer.
https://reviews.llvm.org/D38642
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt
Index: clang/tools/clang-fuzzer
kcc added a comment.
grrr. I am sorry, I've just contradicted myself. :(
The goal here is to build the fuzz targets always and use them as tests, which
includes building with any toolchain, including toolchains that don't support
-fsanitize=fuzzer
your original change actually solved this.
morehouse updated this revision to Diff 118097.
morehouse added a comment.
- Revert "Remove dummy main and link with -fsantize=fuzzer."
https://reviews.llvm.org/D38642
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer.cpp
clang/tools/clang-fuzzer/DummyCla
kcc added a reviewer: vitalybuka.
kcc added a comment.
conceptually ok, but please let Vitaly review the cmake part.
https://reviews.llvm.org/D38642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
morehouse added a comment.
In https://reviews.llvm.org/D38642#891074, @kcc wrote:
> If you can *easily* share main() with the one in LLVM -- do it, otherwise
> don't bother.
Does the fuzzer main come from LLVM or compiler-rt now? There's still
FuzzerMain.cpp, but I'm not sure if we should be
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good with nits
Comment at: lib/Basic/Targets/AArch64.cpp:47-51
+ bool IsNetBSD = getTriple().getOS() == llvm::Triple::NetBSD;
+ bool IsOpenBSD = getTriple().getOS() == llvm
jkorous-apple updated this revision to Diff 118104.
jkorous-apple added a comment.
Ammenended as suggested.
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
===
compnerd added inline comments.
Comment at: lib/Basic/Targets/AArch64.cpp:47-51
+ bool IsNetBSD = getTriple().getOS() == llvm::Triple::NetBSD;
+ bool IsOpenBSD = getTriple().getOS() == llvm::Triple::OpenBSD;
+ if (!getTriple().isOSDarwin() && !IsNetBSD && !IsOpenBSD)
+WCha
Author: compnerd
Date: Fri Oct 6 16:09:55 2017
New Revision: 315126
URL: http://llvm.org/viewvc/llvm-project?rev=315126&view=rev
Log:
Driver: hoist the `wchar_t` handling to the driver
Move the logic for determining the `wchar_t` type information into the
driver. Rather than passing the single
compnerd closed this revision.
compnerd added a comment.
SVN r315126
Repository:
rL LLVM
https://reviews.llvm.org/D37891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Thanks, it looks much better! A couple more comments:
Comment at: lib/Index/USRGeneration.cpp:819
}
+if (const ArrayType *const AT = dyn_cast(T)) {
+ Out << "{";
You can use `const auto *` here.
Comment
kcc added a comment.
In https://reviews.llvm.org/D38642#891125, @morehouse wrote:
> In https://reviews.llvm.org/D38642#891074, @kcc wrote:
>
> > If you can *easily* share main() with the one in LLVM -- do it, otherwise
> > don't bother.
>
>
> Does the fuzzer main come from LLVM or compiler-rt no
jkorous-apple added a comment.
Replied and going to delete the end delimiter.
Comment at: lib/Index/USRGeneration.cpp:819
}
+if (const ArrayType *const AT = dyn_cast(T)) {
+ Out << "{";
arphaman wrote:
> You can use `const auto *` here.
That's wha
jkorous-apple updated this revision to Diff 118115.
jkorous-apple added a comment.
Solved issues from CR.
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
=
Carrot created this revision.
Herald added a subscriber: nemanjai.
Usually compare expression should return i1 type, so EmitScalarConversion is
called before return
return EmitScalarConversion(Result, CGF.getContext().BoolTy, E->getType(),
E->getExprLoc());
But when ppc intrinsic is called t
ahatanak updated this revision to Diff 118119.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D36918
Files:
lib/Sema/SemaAccess.cpp
test/SemaCXX/access.cpp
Index: test/SemaCXX/access.cpp
===
--- t
ahatanak added inline comments.
Comment at: lib/Sema/SemaAccess.cpp:1798
+ EffectiveContext EC(CurScope->getEntity());
+ if (IsAccessible(*this, EC, Entity) == ::AR_accessible)
+return AR_accessible;
Rakete wrote:
> You don't need that scope resolution
Author: vedantk
Date: Fri Oct 6 18:42:09 2017
New Revision: 315142
URL: http://llvm.org/viewvc/llvm-project?rev=315142&view=rev
Log:
[Driver] Fix -static-libsan / -shared-libsan on Darwin
Don't ignore these flags on Darwin. The old behavior of using the
dynamic runtime when neither flag is passe
ahatanak created this revision.
This is a follow-up patch to r314370.
Rather than throwing away the enclosing parentheses in maybeUndoReclaimObject,
this patch walks down the expression until an ARCReclaimReturnedObject cast is
found and removes just the cast, preserving the syntactic sugar exp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
101 - 127 of 127 matches
Mail list logo
