Author: coby
Date: Fri Sep 29 00:02:49 2017
New Revision: 314494
URL: http://llvm.org/viewvc/llvm-project?rev=314494&view=rev
Log:
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /
immediate expressions
Allow the proper recognition of Enum values and global variables i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314494: [X86][MS-InlineAsm] Extended support for variables /
identifiers on memory /… (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D37413?vs=115564&id=117095#toc
Repository:
Author: danielmarjamaki
Date: Fri Sep 29 02:44:41 2017
New Revision: 314499
URL: http://llvm.org/viewvc/llvm-project?rev=314499&view=rev
Log:
[Sema] Suppress warnings for C's zero initializer
Patch by S. Gilles!
Differential Revision: https://reviews.llvm.org/D28148
Added:
cfe/trunk/test/Se
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314499: [Sema] Suppress warnings for C's zero initializer
(authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D28148?vs=82849&id=117107#toc
Repository:
rL LLVM
https://r
arphaman updated this revision to Diff 117124.
arphaman marked 10 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D37856
Files:
include/clang/Tooling/Refactoring/RefactoringActionRule.h
include/clang/Tooling/Refactor
arphaman added inline comments.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:78
+ std::vector>
+ getRefactoringOptions() const final override {
+return {Opt};
ioeric wrote:
> Why return a vector instead of a single valu
Author: arphaman
Date: Fri Sep 29 05:21:38 2017
New Revision: 314509
URL: http://llvm.org/viewvc/llvm-project?rev=314509&view=rev
Log:
[docs][refactor] Add refactoring engine design documentation
This commit adds a refactoring engine design document that talks about the
design and provides severa
This revision was automatically updated to reflect the committed changes.
arphaman marked 2 inline comments as done.
Closed by commit rL314509: [docs][refactor] Add refactoring engine design
documentation (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37976?vs=115638
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314512: [CMake] Fix configuration on PowerPC with sanitizers
(authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D38277?vs=116977&id=117132#toc
Repository:
rL LLVM
https://revi
arphaman created this revision.
This patch actually brings clang-refactor to a usable state as it can now apply
the refactoring changes to the source files.
The `-selection` option is now also fully supported.
Repository:
rL LLVM
https://reviews.llvm.org/D38402
Files:
include/clang/Fronte
chrib updated this revision to Diff 117139.
chrib added a comment.
Hello,
I realized that testing CCCisCXX for IsUnwindTablesDefault was not really good
and useless here, because we cannot treat C as C++ mode. In fact only the file
type matters, as seen in the tests.
So I'd like to amend my pr
kosarev created this revision.
kosarev added a project: clang.
This patch fixes misleading names of entities related to getting, setting and
generation of TBAA access type descriptors.
This is effectively an attempt to provide a review for
https://reviews.llvm.org/D37826 by breaking it into sma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314524: Fix
Modules/{builtin-import.mm,umbrella-header-include-builtin.mm} to be able…
(authored by filcab).
Repository:
rL LLVM
https://reviews.llvm.org/D38364
Files:
cfe/trunk/test/Modules/builti
Author: filcab
Date: Fri Sep 29 08:45:34 2017
New Revision: 314524
URL: http://llvm.org/viewvc/llvm-project?rev=314524&view=rev
Log:
Fix Modules/{builtin-import.mm,umbrella-header-include-builtin.mm} to be able
to handle non-Darwin targets
Summary: Also makes them pass on Darwin, if the default
Author: fjricci
Date: Fri Sep 29 08:46:27 2017
New Revision: 314526
URL: http://llvm.org/viewvc/llvm-project?rev=314526&view=rev
Log:
[test] Disable leak checking on a clang crash test on Darwin
Suspected failure due to LSan's atexit and exit interception behavior.
Reviewers: kcc, kubamracek, bo
alekseyshl added a comment.
http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/4004 is broken
by this change
Repository:
rL LLVM
https://reviews.llvm.org/D38277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
alekseyshl added inline comments.
Comment at: compiler-rt/trunk/cmake/base-config-ix.cmake:154
+ cmake_push_check_state()
+ string(REPLACE "-nodefaultlibs" "" CMAKE_REQUIRED_FLAGS
${OLD_CMAKE_REQUIRED_FLAGS})
TEST_BIG_ENDIAN(HOST_IS_BIG_ENDIAN)
Author: coby
Date: Fri Sep 29 09:04:16 2017
New Revision: 314529
URL: http://llvm.org/viewvc/llvm-project?rev=314529&view=rev
Log:
fixup, post rL314493
'InlineAsmIdentifierInfo' is now a struct - notify Sema.h it isn't a class
anymore
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified:
Hahnfeld added inline comments.
Comment at: compiler-rt/trunk/cmake/base-config-ix.cmake:154
+ cmake_push_check_state()
+ string(REPLACE "-nodefaultlibs" "" CMAKE_REQUIRED_FLAGS
${OLD_CMAKE_REQUIRED_FLAGS})
TEST_BIG_ENDIAN(HOST_IS_BIG_ENDIAN)
al
kosarev created this revision.
kosarev added a project: clang.
This is part of https://reviews.llvm.org/D37826 reworked to be a separate patch
to simplify review.
Repository:
rL LLVM
https://reviews.llvm.org/D38408
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGe
Author: sammccall
Date: Fri Sep 29 09:41:23 2017
New Revision: 314532
URL: http://llvm.org/viewvc/llvm-project?rev=314532&view=rev
Log:
Small clangd cleanups, NFC
- remove old ASTUnit includes
- fix typo (regiterCallbackHandlers)
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
sammccall created this revision.
There doesn't seem to be any real separation between the current three objects.
Feel free to reject this if you find the current style valuable, though.
(Mostly I'm just looking around for cleanups to help me understand the code).
https://reviews.llvm.org/D38414
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/AST/DeclCXX.cpp:1473
+static bool IsDeclContextInNamespace(const DeclContext *DC) {
+ while (!DC->isTranslationUnit()) {
Lower case `isDecl
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:122
;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-format to format the code between START and END according to STYLE
-using ASSUME-FILE-NAME to loca
boris added a comment.
Ping.
https://reviews.llvm.org/D37299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
predator5047 updated this revision to Diff 117193.
predator5047 marked 12 inline comments as done.
predator5047 added a comment.
Address review comments:
- Don't use auto if the type is not spelled out in initialization.
- Better names for variables.
- Elide braces.
- Format changes.
https://
Author: jvesely
Date: Fri Sep 29 12:06:50 2017
New Revision: 314547
URL: http://llvm.org/viewvc/llvm-project?rev=314547&view=rev
Log:
travis: Check built libraries on llvm-3.9
Signed-off-by: Jan Vesely
Acked-by: Aaron Watry
Modified:
libclc/trunk/.travis.yml
Modified: libclc/trunk/.travis
Author: jvesely
Date: Fri Sep 29 12:06:45 2017
New Revision: 314544
URL: http://llvm.org/viewvc/llvm-project?rev=314544&view=rev
Log:
travis: add build using llvm-3.9
Signed-off-by: Jan Vesely
Acked-by: Aaron Watry
Modified:
libclc/trunk/.travis.yml
Modified: libclc/trunk/.travis.yml
URL:
Author: jvesely
Date: Fri Sep 29 12:06:47 2017
New Revision: 314545
URL: http://llvm.org/viewvc/llvm-project?rev=314545&view=rev
Log:
geometric: geometric functions are only supported for vector lengths <=4
Signed-off-by: Jan Vesely
Reviewed-by: Aaron Watry
Modified:
libclc/trunk/generic/i
Author: jvesely
Date: Fri Sep 29 12:06:52 2017
New Revision: 314548
URL: http://llvm.org/viewvc/llvm-project?rev=314548&view=rev
Log:
Fix amdgcn-amdhsa on llvm-3.9
Signed-off-by: Jan Vesely
Acked-by: Aaron Watry
Added:
libclc/trunk/amdgcn-amdhsa/lib/OVERRIDES_3.9
libclc/trunk/amdgcn-am
Author: jvesely
Date: Fri Sep 29 12:06:48 2017
New Revision: 314546
URL: http://llvm.org/viewvc/llvm-project?rev=314546&view=rev
Log:
Add script to check for unresolved function calls
v2: add shell shebang
improve error checks and reporting
v3: fix typo
Signed-off-by: Jan Vesely
Reviewed-by
Author: jvesely
Date: Fri Sep 29 12:06:41 2017
New Revision: 314543
URL: http://llvm.org/viewvc/llvm-project?rev=314543&view=rev
Log:
Restore support for llvm-3.9
Signed-off-by: Jan Vesely
Acked-by: Aaron Watry
Added:
libclc/trunk/amdgcn/lib/OVERRIDES_3.9
libclc/trunk/amdgcn/lib/SOURCE
On 28/09/17 21:28, Jonathan Roelofs wrote:
+silvas
On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote:
Hi,
Please find attached a diff to fix the issue 12176.
Link for the lazy: llvm.org/PR12176
Thanks ;)
Let me know if there is anything any improvements you can think of.
Nebiroth created this revision.
Implementation of Document Highlights Request as described in LSP.
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/Protocol.cpp
clangd/P
Nebiroth updated this revision to Diff 117217.
Nebiroth added a comment.
Fixed missed comments and suggstions.
https://reviews.llvm.org/D37150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/GlobalCompilationDatabase.cpp
clangd/GlobalCompilationDatabase.h
clangd/tool
malaperle added a comment.
Just a few quick comments.
Comment at: clangd/ClangdServer.cpp:295
+ assert(FileContents.Draft &&
+ "findDefinitions is called for non-added document");
+
findDocumentHighlights?
Comment at: clangd/ClangdSe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314557: [Sema] Correct IUnknown to support Unknwnbase.h
Header. (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38303?vs=116876&id=117218#toc
Repository:
rL LLVM
https:/
Author: erichkeane
Date: Fri Sep 29 14:06:00 2017
New Revision: 314557
URL: http://llvm.org/viewvc/llvm-project?rev=314557&view=rev
Log:
[Sema] Correct IUnknown to support Unknwnbase.h Header.
Apparently, the MSVC SDK has a strange implementation that
causes a number of implicit functions as well
Author: probinson
Date: Fri Sep 29 14:25:07 2017
New Revision: 314558
URL: http://llvm.org/viewvc/llvm-project?rev=314558&view=rev
Log:
[PS4] Tidy up some debug-tuning v. triple decision-making.
Modified:
cfe/trunk/include/clang/Driver/CC1Options.td
cfe/trunk/lib/Driver/ToolChains/Clang.c
eugenis created this revision.
Also enable -no-pie on Gnu toolchain (previously available on Darwin only).
Non-PIE executables won't even start on recent Android, and DT_RPATH is ignored
by the loader.
https://reviews.llvm.org/D38430
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/lib/Dri
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
PS I actually remember arguing to keep those classes separate in the original
review :-)
https://reviews.llvm.org/D38414
__
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.h:41
private:
- class LSPProtocolCallbacks;
- class LSPDiagnosticsConsumer : public DiagnosticsConsumer {
- public:
-LSPDiagnosticsConsumer(ClangdLSPServer &Server);
-
-virtual void
-onDiagnos
ilya-biryukov added a comment.
Friendly ping.
https://reviews.llvm.org/D37970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
Thanks for the patch, I'll take a closer look a bit later.
But just wanted to post one very important comment right away.
Comment at: clangd/ClangdUnit.h:268
+std::vector findDocumentHighlights(ParsedAST &AST, Position
Pos,
+
ahatanak added a comment.
ping.
Any comments on this patch or alternate approaches?
https://reviews.llvm.org/D36915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
ping
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson abandoned this revision.
probinson added a comment.
Abandoning. This change is irrelevant to the SCE debugger, and while I believe
it could be made more complete and better reflect the original source (which is
what the DWARF spec says names should be), I do not have time to pursue it
Author: rsmith
Date: Fri Sep 29 16:57:25 2017
New Revision: 314570
URL: http://llvm.org/viewvc/llvm-project?rev=314570&view=rev
Log:
Add a "vexing parse" warning for ambiguity between a variable declaration and a
function-style cast.
This fires for cases such as
T(x);
... where 'x' was previo
Author: george.karpenkov
Date: Fri Sep 29 17:03:22 2017
New Revision: 314571
URL: http://llvm.org/viewvc/llvm-project?rev=314571&view=rev
Log:
[Analyzer] Synthesize function body for std::call_once
Differential Revision: https://reviews.llvm.org/D37840
Added:
cfe/trunk/test/Analysis/call_onc
Author: george.karpenkov
Date: Fri Sep 29 17:05:24 2017
New Revision: 314572
URL: http://llvm.org/viewvc/llvm-project?rev=314572&view=rev
Log:
[Analyzer] Add nullability to the list of tested checkers in SATestBuild
Differential Revision: https://reviews.llvm.org/D38162
Modified:
cfe/trunk/u
Author: george.karpenkov
Date: Fri Sep 29 17:07:22 2017
New Revision: 314573
URL: http://llvm.org/viewvc/llvm-project?rev=314573&view=rev
Log:
[Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in
function name
Differential Revision: https://reviews.llvm.org/D37596
Modi
dcoughlin requested changes to this revision.
dcoughlin added a subscriber: zaks.anna.
dcoughlin added a comment.
This revision now requires changes to proceed.
Rafael: Thanks for the patch! @NoQ, @zaks.anna, and I spoke about this off-line
yesterday.
While this patch improves the modeling of po
rsmith added a comment.
A couple of remaining pieces that I think are missing:
- Tests for instantiation of templates containing one of these lambdas. I would
expect you'll find you need to change Sema/TreeTransform.h to make that work.
- Updates to Itanium mangling (AST/ItaniumMangle.cpp) for t
Author: george.karpenkov
Date: Fri Sep 29 18:15:35 2017
New Revision: 314580
URL: http://llvm.org/viewvc/llvm-project?rev=314580&view=rev
Log:
[Analyzer] Add dummy implementation to call_once to avoid linkage warnings in
tests.
Modified:
cfe/trunk/test/Analysis/call_once.cpp
Modified: cfe/t
hfinkel added a comment.
Please also add a C++ test to check the mangling-related features.
Comment at: lib/CodeGen/CodeGenFunction.cpp:419
+// Assume that __cxa_demangle is provided by libcxxabi (except for Windows).
+extern "C" char *__cxa_demangle(const char *mangled_name, c
Author: rtrieu
Date: Fri Sep 29 19:19:17 2017
New Revision: 314581
URL: http://llvm.org/viewvc/llvm-project?rev=314581&view=rev
Log:
[ODRHash] Add base classes to hashing CXXRecordDecl.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/include/clang/Seriali
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D38408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Hello everyone,
Below are some buildbot numbers for the week of 09/03/2017 - 09/09/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the week of 09/10/2017 - 09/16/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 09/17/2017 -
09/23/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
61 matches
Mail list logo
