Author: ahatanak
Date: Thu Sep 21 17:41:05 2017
New Revision: 313945
URL: http://llvm.org/viewvc/llvm-project?rev=313945&view=rev
Log:
Add support for attribute 'noescape'.
The attribute informs the compiler that the annotated pointer parameter
of a function cannot escape and enables IRGen to att
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D38134#877831, @Anastasia wrote:
> Now if we have a block which is being called and enqueued at the same time,
> will we generate 2 functions for it? Could we add such test case btw?
Yes. It is covered
ilya-biryukov updated this revision to Diff 116297.
ilya-biryukov added a comment.
- Fixed CHECK-DAG typo.
https://reviews.llvm.org/D38083
Files:
clangd/ClangdUnit.cpp
test/clangd/completion-qualifiers.test
Index: test/clangd/completion-qualifiers.test
ilya-biryukov added inline comments.
Comment at: test/clangd/completion-qualifiers.test:12
+# CHECK: {"jsonrpc":"2.0","id":2,"result":[
+# CHEKC-DAG: {"label":"foo()
const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}
eugenis added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:2917
+CodeGenFunction &CGF, llvm::Function *F,
+bool ForceThumb) {
+ StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;
---
Author: rsmith
Date: Thu Sep 21 18:04:22 2017
New Revision: 313948
URL: http://llvm.org/viewvc/llvm-project?rev=313948&view=rev
Log:
Fix tracking of whether a destructor would be deleted.
I've been unable to find any cases whose behavior is actually changed by this,
but only because an implicitly
gtbercea added a comment.
In https://reviews.llvm.org/D38040#878090, @Hahnfeld wrote:
> Hi Doru,
>
> if I remember correctly I submitted https://reviews.llvm.org/D34888 for a
> crash when mapping a scalar value with nested regions.
> I've marked another test in this file that the codegen for `t
echristo added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:2917
+CodeGenFunction &CGF, llvm::Function *F,
+bool ForceThumb) {
+ StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;
--
Author: george.karpenkov
Date: Thu Sep 21 18:41:16 2017
New Revision: 313949
URL: http://llvm.org/viewvc/llvm-project?rev=313949&view=rev
Log:
[Analyzer] Refactor analyzer testing scripts.
- Exporting needed function for future reuse.
- Idiomatic python: using with `file as f` instead of `try/f
Author: george.karpenkov
Date: Thu Sep 21 18:43:12 2017
New Revision: 313950
URL: http://llvm.org/viewvc/llvm-project?rev=313950&view=rev
Log:
[Analyzer] Static analyzer script for updating reference results
The script updates reference results from the previous run, and stages them.
Differentia
Author: ahatanak
Date: Thu Sep 21 18:54:36 2017
New Revision: 313952
URL: http://llvm.org/viewvc/llvm-project?rev=313952&view=rev
Log:
Add test cases that weren't committed in r313945.
Added:
cfe/trunk/test/CodeGenCXX/noescape.cpp
cfe/trunk/test/CodeGenObjC/noescape.m
cfe/trunk/test/S
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Looks good modulo a few NITS.
Let me know if you need help landing this.
Comment at: unittests/clangd/ClangdTests.cpp:910
+ auto FooH = getVirtualTestFilePath("foo.h");
+ auto invalid = getVirtualTestFilePat
ilya-biryukov added a comment.
Could you please run `clang-format` on every submission?
Comment at: clangd/GlobalCompilationDatabase.cpp:98
+ {
+CompileCommandsDir = "/";
+return tryLoadDatabaseFromPath(CompileCommandsDir.getValue());
Is this some
ilya-biryukov added a comment.
Friendly ping. Any suggestions for other reviewers are also very welcome.
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: rsmith
Date: Thu Sep 21 19:22:32 2017
New Revision: 313953
URL: http://llvm.org/viewvc/llvm-project?rev=313953&view=rev
Log:
Clean up some mistreatment of enumerations.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/lib/AST/Linkage.h
Modifie
efriedma added subscribers: cfe-commits, efriedma.
efriedma added a comment.
Please make sure to add the mailing list as a subscriber when you post a patch.
(I haven't looked at the patch yet.)
https://reviews.llvm.org/D38126
___
cfe-commits maili
Author: compnerd
Date: Thu Sep 21 21:01:12 2017
New Revision: 313954
URL: http://llvm.org/viewvc/llvm-project?rev=313954&view=rev
Log:
Driver: remove support for libstdc++ from CrossWindows
This code path is entirely untested and not really maintained. The
expected use here is with libc++ only.
Author: rsmith
Date: Thu Sep 21 21:25:05 2017
New Revision: 313955
URL: http://llvm.org/viewvc/llvm-project?rev=313955&view=rev
Log:
Give external linkage and mangling to lambdas inside inline variables and
variable templates.
This implements the proposed approach in
https://github.com/itanium-
Author: krasimir
Date: Thu Sep 21 21:37:56 2017
New Revision: 313962
URL: http://llvm.org/viewvc/llvm-project?rev=313962&view=rev
Log:
[clang-tidy] Fix example in documentation, NFC
Summary: A fix in documentation.
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: JDevlieghere, xazax.hun
D
Author: rsmith
Date: Thu Sep 21 21:33:20 2017
New Revision: 313957
URL: http://llvm.org/viewvc/llvm-project?rev=313957&view=rev
Log:
Closure types have no name (and can't have a typedef name for linkage
purposes), so they never formally have linkage.
Modified:
cfe/trunk/lib/AST/Decl.cpp
c
Author: krasimir
Date: Thu Sep 21 21:48:17 2017
New Revision: 313963
URL: http://llvm.org/viewvc/llvm-project?rev=313963&view=rev
Log:
[clang-format] Ignore case and stable sort using-declarations
Summary:
This ignores case while sorting using-declarations, fixing a case where `_`
would appear b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313963: [clang-format] Ignore case and stable sort
using-declarations (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D37263
Files:
cfe/trunk/lib/Format/UsingDeclarationsSorter.
dberris added inline comments.
Comment at: lib/Basic/XRayLists.cpp:29
// whether it's treated as a "never" instrument function.
- if (AlwaysInstrument->inSection("fun", FunctionName, "arg1"))
+ if (AlwaysInstrument->inSection("xray_always_instrument", "fun",
FunctionName,
+
rnkovacs added a comment.
In https://reviews.llvm.org/D35796#878200, @dcoughlin wrote:
> This looks good to me! Do you have commit access, or do you need someone to
> commit it for you?
Thanks! I don't, so it would be nice if someone committed it for me.
https://reviews.llvm.org/D35796
__
101 - 124 of 124 matches
Mail list logo
