[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jbcoe added a comment. Do you need someone to commit this change for you? I'm happy to do so if you don't have commit access. https://reviews.llvm.org/D36953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#877032, @dcoughlin wrote: > I'm OK with this going into the repo a is (although it is light on tests!), > as long as we have an agreement that you'll be OK with iteration on both the > interface and the implementation to handle real-

r313866 - [analyzer] Fix an assertion fail in VirtualCallChecker

Author: xazax Date: Thu Sep 21 01:18:59 2017 New Revision: 313866 URL: http://llvm.org/viewvc/llvm-project?rev=313866&view=rev Log: [analyzer] Fix an assertion fail in VirtualCallChecker Differential Revision: https://reviews.llvm.org/D37978 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/Vi

[PATCH] D37978: [analyzer] Fix an assertion fail in VirtualCallChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL313866: [analyzer] Fix an assertion fail in VirtualCallChecker (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D37978?vs=115656&id=116145#toc Repository: rL LLVM https://revie

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

xazax.hun added a comment. Ping. https://reviews.llvm.org/D37437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

daxpedda created this revision. Current "/std:c++latest" adds "-std=c++17", VS has it's own "/std:c++17" for that now. This is my first commit by the way, please tell me if there is anything I can do to improve. Thanks. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D37963: [analyzer] PthreadLock: Don't track dead regions.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Maybe it worth a comment why we do not want to clean up `LockSet`? Otherwise LGTM! https://reviews.llvm.org/D37963 ___ cfe-commits mailin

[PATCH] D37812: [analyzer] PthreadLock: Escape the pointers.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:594 +// it takes the mutex explicitly as an argument. +if (IsLibraryFunction && +std::find(ExplicitRegions.begin(), ExplicitRegions.end(), R) == Wouldn

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. gcov / gcda-based profiling crashes when shared libraries are unloaded Patch by Benoit Belley and tested by Marco Castelluccio for Firefox See https://bugs.llvm.org/show_bug.cgi?id=27224 & https://bugzilla.mozilla.or

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

daxpedda updated this revision to Diff 116154. daxpedda added a comment. Discovered that these flags were tested and added new test. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c Index: test/Driver/cl-options.c

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jklaehn added a comment. In https://reviews.llvm.org/D36953#877367, @jbcoe wrote: > Do you need someone to commit this change for you? > > I'm happy to do so if you don't have commit access. Yes that would be great, thanks! https://reviews.llvm.org/D36953 __

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

klimek added a comment. Apart from nits, LGTM, unless Daniel sees issues. Comment at: lib/Format/TokenAnnotator.cpp:2516 return Style.SpacesInAngles; + // space before TT_StructuredBindingLSquare + if (Right.is(TT_StructuredBindingLSquare)) Super-Nit: ca

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

curdeius added a comment. Could you add just one more test for `PAS_Middle` please? A single line will be just enough. Otherwise, LGTM. https://reviews.llvm.org/D35743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

yvvan added a comment. ping 3 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

klimek added a reviewer: akyrtzi. klimek added a comment. Adding Argyrios, who might have insight on how this is used. I think this had the wrong list of reviewers so far :( https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. Hello, I didn't find an easy way factorize the change in IsUnwindTableDefault to support the multiple ARM toolchains. After a quick check in Triple::arm in Driver/Toochains, many seem impacted (excepted NetBSD and Darwin that uses DwarfCFI or SJLG). So here is an attemp

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 116176. chrib added a comment. Herald added a subscriber: javed.absar. Changes since last revision: - Check IsUnwindTablesDefault in ARM Toolchains that support ExceptionHandling::ARM (not Darwin, NetBSD) - Check input type with driver mode for C++ mode. - Add

r313880 - [OPENMP] Use canonical declarations for redeclarations checks.

Author: abataev Date: Thu Sep 21 07:06:59 2017 New Revision: 313880 URL: http://llvm.org/viewvc/llvm-project?rev=313880&view=rev Log: [OPENMP] Use canonical declarations for redeclarations checks. If the captured variable has some redeclarations we may run into the situation where the redeclarati

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl marked 4 inline comments as done. yaxunl added a comment. In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > In https://reviews.llvm.org/D37822#872291, @Anastasia wrote: > > > > > Could you please explain a bit mor

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl created this revision. Herald added a subscriber: nhaehnle. In OpenCL the kernel function and non-kernel function has different calling conventions. For certain targets they have different argument ABIs. Also kernels have special function attributes and metadata for runtime to launch them

[PATCH] D37263: [clang-format] Ignore case and stable sort using-declarations

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG, thanks! https://reviews.llvm.org/D37263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell added a comment. LGTM we should probably set c++17 as the default over c++14 as part of this change. given that everything seems in order for c++17 bar P0522R0 so this looks like the change should be good. adding @rnk to confirm. @daxpedda do you have commit access?

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

daxpedda added a comment. According to this the default is still c++14. I do not have commit access, I would prefer if somebody else commits this in my stead. Comment at: test/Driver

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh added a comment. In https://reviews.llvm.org/D20689#871947, @barancsuk wrote: > @alexfh, would you mind taking a look at the changes that have been > introduced in the new patch? > > The main improvements are: > > - The checker has been shifted to the module `readability`. > - It is c

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. It seems that msvc enabled some c++17 features when in c++14 mode and they left them enabled because projects became dependant on them. switching to c++17 as the default and removing the c++1

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

alexfh added a comment. > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource > specification version 1.2 (19 April 2017), Err, "I did ask them, and received an answer that it is it can be implemented in clang-tidy" might not be enough. Repository: rL LLVM https://reviews.

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In https://reviews.llvm.org/D36836#877636, @alexfh wrote: > > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource > > specification version 1.2 (19 April 2017), > > Err, "I did ask them, and received an answer that it is it can be implemented > in cl

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 116195. xazax.hun added a comment. - Unittests now creates temporary files at the correct location - Temporary files are also cleaned up when the process is terminated - Absolute paths are handled correctly by the library https://reviews.llvm.org/D34512 F

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 116198. Nebiroth added a comment. More consistent logging in clangdmain. Restructured argument checking in ClangdMain Fixed empty compile-commands-dir triggering error messages. Fixed failing standard tests. https://reviews.llvm.org/D37150 Files: clangd/

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

chh updated this revision to Diff 116201. chh marked 2 inline comments as done. chh edited the summary of this revision. https://reviews.llvm.org/D35743 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added a comment. Tried stage2 build, so far only one warning. But found out that `ubsan_value.h`'s `typedef s128 SIntMax;` crashes this code because class LLVM_NODISCARD APSInt : public APInt { ... /// \brief Get the correctly-extended \c int64_t value. int64_t getExtValue

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

Rakete added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:5185 if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) { // C++2a allows functions with ref-qualifier & if they are also 'const'. +if (Proto->isConst() && !Proto->isVolatile

[PATCH] D36487: Emit section information for extern variables.

eandrews updated this revision to Diff 116211. eandrews added a comment. I've updated the patch based on review comments. The changes include setting section unconditionally for extern variables and emitting a warning if section attribute is specified on a redeclaration. https://reviews.llvm.o

[PATCH] D36487: Emit section information for extern variables.

eandrews added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2434 +// Emit section information for extern variables. +if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) { + if (const SectionAttr *SA = D->getAttr()) efried

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich updated this revision to Diff 116213. vlad.tsyrklevich marked 5 inline comments as done. vlad.tsyrklevich added a comment. - sanitizerCompile -> createSanitizerSections - ASanMask -> AsanMask and fix another bug relating to ANDing with LangOpts.Sanitize.Mask https://reviews.llv

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich added inline comments. Comment at: lib/AST/Decl.cpp:3953 ReasonToReject = 5; // is standard layout. - else if (Blacklist.isBlacklistedLocation(getLocation(), "field-padding")) + else if (Blacklist.isBlacklistedLocation(ASanMask, getLocation(), +

r313892 - [lit] Rename lld and clang lit configs to end in .py

Author: zturner Date: Thu Sep 21 10:38:13 2017 New Revision: 313892 URL: http://llvm.org/viewvc/llvm-project?rev=313892&view=rev Log: [lit] Rename lld and clang lit configs to end in .py This follows in line with a previous patch of renaming LLVM's. Working on these files is difficult in certain

r313894 - [fixup][Sema] Allow in C to define tags inside enumerations.

Author: vsapsai Date: Thu Sep 21 10:41:30 2017 New Revision: 313894 URL: http://llvm.org/viewvc/llvm-project?rev=313894&view=rev Log: [fixup][Sema] Allow in C to define tags inside enumerations. Fix for too aggressive error err_type_defined_in_enum introduced in r313386. Defining tags inside enum

[PATCH] D38109: [fixup][Sema] Allow in C to define tags inside enumerations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313894: [fixup][Sema] Allow in C to define tags inside enumerations. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38109?vs=116110&id=116219#toc Repository: rL LLVM https

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added a comment. Now if we have a block which is being called and enqueued at the same time, will we generate 2 functions for it? Could we add such test case btw? I feel it would be much simpler if we could always generate the kernel metadata for blocks. A lot of special case code wou

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane created this revision. As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692 A non-defined enum with a backing type was always defaulting to being treated as a signed type. IN the case where it IS defined, the signed-ness of the actual items is used. This patch uses the unde

r313896 - [Sema] Fix using old initializer during switch statement transformation.

Author: vsapsai Date: Thu Sep 21 10:58:27 2017 New Revision: 313896 URL: http://llvm.org/viewvc/llvm-project?rev=313896&view=rev Log: [Sema] Fix using old initializer during switch statement transformation. It fixes a crash in CodeGen when we are trying to generate code for initializer expression

[PATCH] D38009: [Sema] Fix using old initializer during switch statement transformation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313896: [Sema] Fix using old initializer during switch statement transformation. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38009?vs=115754&id=116226#toc Repository: rL

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added a comment. The problem of adding this attribute conservatively for all functions is that it prevents some optimizations to happen. I agree to commit this as a temporary fix to guarantee correctness of generated code. But if we ask to add the `convergent` attribute into the spec

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

tra created this revision. Herald added a subscriber: sanjoy. https://reviews.llvm.org/D38147 Files: clang/lib/Headers/__clang_cuda_intrinsics.h Index: clang/lib/Headers/__clang_cuda_intrinsics.h === --- clang/lib/Headers/__clang

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

jlebar added a comment. Naturally they're different orders in the PTX and CUDA. :) https://reviews.llvm.org/D38147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

Anastasia added a comment. In https://reviews.llvm.org/D37822#877572, @yaxunl wrote: > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > > > In https://reviews.llvm.org/D37822#872291, @Anastasia wrote: > > > > > > >

[PATCH] D38113: OpenCL: Assume functions are convergent

jlebar added a comment. > The problem of adding this attribute conservatively for all functions is that > it prevents some optimizations to happen. function-attrs removes the convergent attribute from anything it can prove does not call a convergent function. I agree this is a nonoptimal solut

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

b-sumner added a comment. In https://reviews.llvm.org/D37822#877903, @Anastasia wrote: > In https://reviews.llvm.org/D37822#877572, @yaxunl wrote: > > > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > > > > > I

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi updated this revision to Diff 116232. wmi added a comment. Changes following the discussion: - Put the bitfield split logic under an option and off by default. - When sanitizer is enabled, the option for bitfield split will be ignored and a warning message will be emitted. In addition, a te

[PATCH] D38148: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

tra created this revision. Herald added subscribers: hiraditya, sanjoy, jholewinski. https://reviews.llvm.org/D38148 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Headers/__clang_cuda_intrinsics.h clang/test/CodeGen/builtins-nvptx-ptx60.cu clang/test/CodeGen/builtins-nvptx.

[PATCH] D38148: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

tra updated this revision to Diff 116236. tra added a comment. Fixed a typo in one test. https://reviews.llvm.org/D38148 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Headers/__clang_cuda_intrinsics.h clang/test/CodeGen/builtins-nvptx-ptx60.cu clang/test/CodeGen/builtins-

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 +return IntRange(C.getIntWidth(QualType(T, 0)), +!ET->isSignedIntegerOrEnumerationType()); Maybe add a comment noting what can trigger this case? ==

r313898 - [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

Author: tra Date: Thu Sep 21 11:44:49 2017 New Revision: 313898 URL: http://llvm.org/viewvc/llvm-project?rev=313898&view=rev Log: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins. Differential Revision: https://reviews.llvm.org/D38148 Modified:

[PATCH] D38148: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313898: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync}… (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38148?vs=116236&id=116237#toc Repository: rL LLVM http

r313899 - [CUDA] Fixed order of words in the names of shfl builtins.

Author: tra Date: Thu Sep 21 11:46:39 2017 New Revision: 313899 URL: http://llvm.org/viewvc/llvm-project?rev=313899&view=rev Log: [CUDA] Fixed order of words in the names of shfl builtins. Differential Revision: https://reviews.llvm.org/D38147 Modified: cfe/trunk/lib/Headers/__clang_cuda_int

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313899: [CUDA] Fixed order of words in the names of shfl builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38147?vs=116228&id=116238#toc Repository: rL LLVM https://rev

[PATCH] D38046: [Atomic][X8664] set max atomic inline/promote width according to the target

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D38046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane updated this revision to Diff 116244. erichkeane marked 2 inline comments as done. erichkeane added a comment. Updated based on Eli's feedback. https://reviews.llvm.org/D38145 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/warn-sign-conversion-cpp11.cpp Index: test/SemaCXX/warn-

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 + // underlying type, so that when someone specifies the type as + // "unsigned" it doesn't cause sign-conversion type warnings. if (!Enum->isCompleteDefinition()) Explici

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 + // underlying type, so that when someone specifies the type as + // "unsigned" it doesn't cause sign-conversion type warnings. if (!Enum->isCompleteDefinition()) efrie

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane updated this revision to Diff 116245. erichkeane marked an inline comment as done. https://reviews.llvm.org/D38145 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/warn-sign-conversion-cpp11.cpp Index: test/SemaCXX/warn-sign-conversion-cpp11.cpp =

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r313906 - [Sema] Prevent InstantiateClass from checking unrelated exception specs.

Author: vsapsai Date: Thu Sep 21 12:54:12 2017 New Revision: 313906 URL: http://llvm.org/viewvc/llvm-project?rev=313906&view=rev Log: [Sema] Prevent InstantiateClass from checking unrelated exception specs. Sema::InstantiateClass should check only exception specs added during class instantiation

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313906: [Sema] Prevent InstantiateClass from checking unrelated exception specs. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D37881?vs=116056&id=116250#toc Repository: rL

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi added a comment. ping https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r313907 - Suppress Wsign-conversion for enums with matching underlying type

Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692 A non-defined enum with a backi

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

This revision was automatically updated to reflect the committed changes. Closed by commit rL313907: Suppress Wsign-conversion for enums with matching underlying type (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38145?vs=116245&id=116252#toc Repository: rL LLV

[PATCH] D38151: [clang] Fix isExternC matcher docs

alexshap created this revision. Herald added a subscriber: klimek. The wording in the documentation for the matcher isExternC appears to be misleading since this matcher is applicable to functions and variables as well. This diff changes the comment regenerates the html file. Repository: rL

Re: r313907 - Suppress Wsign-conversion for enums with matching underlying type

On 9/21/2017 12:58 PM, Erich Keane via cfe-commits wrote: Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907&view=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here: https://bugs.llv

RE: r313907 - Suppress Wsign-conversion for enums with matching underlying type

Ugg... good catch, thanks. -Original Message- From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Thursday, September 21, 2017 1:14 PM To: Keane, Erich ; cfe-commits@lists.llvm.org Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching underlying type On 9/21/20

r313909 - Add testcase I forgot to add in R313907.

Author: erichkeane Date: Thu Sep 21 13:14:08 2017 New Revision: 313909 URL: http://llvm.org/viewvc/llvm-project?rev=313909&view=rev Log: Add testcase I forgot to add in R313907. Added: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (with props) Added: cfe/trunk/test/SemaCXX/warn-sig

RE: r313907 - Suppress Wsign-conversion for enums with matching underlying type

Fixed in 313909. -Original Message- From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Thursday, September 21, 2017 1:14 PM To: Keane, Erich ; cfe-commits@lists.llvm.org Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching underlying type On 9/21/2017 12:58 P

r313911 - Remove svn-properties for file added in 313909 (NFC)

Author: erichkeane Date: Thu Sep 21 13:31:01 2017 New Revision: 313911 URL: http://llvm.org/viewvc/llvm-project?rev=313911&view=rev Log: Remove svn-properties for file added in 313909 (NFC) Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (props changed) Propchange: cfe/trun

[PATCH] D38040: [OpenMP] Add an additional test for D34888

Hahnfeld added a comment. Hi Doru, if I remember correctly I submitted https://reviews.llvm.org/D34888 for a crash when mapping a scalar value with nested regions. I've marked another test in this file that the codegen for `tofrom` is correct. So I don't know if this test checks some other cond

r313913 - [libclang] Keep track of TranslationUnit instance when annotating tokens

Author: jbcoe Date: Thu Sep 21 13:48:43 2017 New Revision: 313913 URL: http://llvm.org/viewvc/llvm-project?rev=313913&view=rev Log: [libclang] Keep track of TranslationUnit instance when annotating tokens Summary: Previously the `_tu` was not propagated to the returned cursor, leading to errors

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rL313913: [libclang] Keep track of TranslationUnit instance when annotating tokens (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D36953?vs=111959&id=116262#toc Repository: rL L

r313919 - [lit] Refactor out some more common lit configuration code.

Author: zturner Date: Thu Sep 21 14:27:31 2017 New Revision: 313919 URL: http://llvm.org/viewvc/llvm-project?rev=313919&view=rev Log: [lit] Refactor out some more common lit configuration code. debuginfo-tests has need to reuse a lot of common configuration from clang and lld, and in general it s

[libunwind] r313920 - [libunwind] Partially revert r297174 to fix build on at least FreeBSD.

Author: jhb Date: Thu Sep 21 14:28:48 2017 New Revision: 313920 URL: http://llvm.org/viewvc/llvm-project?rev=313920&view=rev Log: [libunwind] Partially revert r297174 to fix build on at least FreeBSD. The changes in r297174 moved the #include of on FreeBSD (and probably other systems) inside of

[PATCH] D34512: Add preliminary Cross Translation Unit support library

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. > But I also think it wouldn't be good to block this until ClanD indexing > reaching a mature state. I agree 100%. > All in all, we are willing to reuse as much of ClangD indexing as we

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Do you want me to commit this for you? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D35796: [analyzer] Delete with non-virtual destructor check

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me! Do you have commit access, or do you need someone to commit it for you? https://reviews.llvm.org/D35796 ___ cfe-com

r313922 - Revert "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 14:45:45 2017 New Revision: 313922 URL: http://llvm.org/viewvc/llvm-project?rev=313922&view=rev Log: Revert "[lit] Refactor out some more common lit configuration code." This is breaking several bots. I have enough information to investigate, so I'm reverting to

r313923 - [Analyzer] Remove dead code from CmpRuns.py.

Author: george.karpenkov Date: Thu Sep 21 14:47:13 2017 New Revision: 313923 URL: http://llvm.org/viewvc/llvm-project?rev=313923&view=rev Log: [Analyzer] Remove dead code from CmpRuns.py. Differential Revision: https://reviews.llvm.org/D38003 Modified: cfe/trunk/utils/analyzer/CmpRuns.py Mo

r313924 - [Analyzer] Add simple help to SATestAdd.py

Author: george.karpenkov Date: Thu Sep 21 14:47:33 2017 New Revision: 313924 URL: http://llvm.org/viewvc/llvm-project?rev=313924&view=rev Log: [Analyzer] Add simple help to SATestAdd.py Differential Revision: https://reviews.llvm.org/D38003 Modified: cfe/trunk/utils/analyzer/SATestAdd.py Mo

[PATCH] D32520: Support __fp16 vectors

ahatanak added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1042 +} + +assert(SrcElementTy->isFloatingPointTy() && bruno wrote: > What happens if the SrcElementTy is float and DstElementTy isn't? Seems like > it will hit the assertion below.

[PATCH] D32520: Support __fp16 vectors

ahatanak updated this revision to Diff 116275. ahatanak marked 8 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D32520 Files: lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/CodeGen/fp16vec-ops.c test/Sema/fp16vec-sema.c Ind

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl updated this revision to Diff 116277. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revise by Anastasia's comments. https://reviews.llvm.org/D37822 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenCLRuntime.h test/CodeGen/blocks

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

kongyi created this revision. kongyi added a project: clang. Qualtype may point to null if we cannot infer its type yet. Fixes PR33843 Repository: rL LLVM https://reviews.llvm.org/D38158 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/typo-correction-crash.cpp Index: test/SemaCXX/typo-corre

r313927 - [Analyzer] Use CC environment variable to select analyzer path in SATestBuild.

Author: george.karpenkov Date: Thu Sep 21 15:12:49 2017 New Revision: 313927 URL: http://llvm.org/viewvc/llvm-project?rev=313927&view=rev Log: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild. This change is required to easily test the given checkout of the analyzer,

r313928 - Resubmit "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 15:16:40 2017 New Revision: 313928 URL: http://llvm.org/viewvc/llvm-project?rev=313928&view=rev Log: Resubmit "[lit] Refactor out some more common lit configuration code." There were two issues, one Python 3 specific related to Unicode, and another which is that t

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vsapsai > Date: Fri Sep 15 12:51:42 2017 > New Revision: 313386 > > URL: http://llvm.org/viewvc/llvm-project?rev=313386&view=rev > Log: > [Sema] Error out early for tags defined inside an

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl added a comment. In https://reviews.llvm.org/D37822#877903, @Anastasia wrote: > In https://reviews.llvm.org/D37822#877572, @yaxunl wrote: > > > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > > > > > In

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

eugenis added a comment. ping https://reviews.llvm.org/D37656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38159: [clang] Fix printf fixit for objc specific types

alexshap created this revision. Let's take a look at the following example: for the triple thumbv7-apple-ios8.0.0 ssize_t is long and size_t is unsigned long, while NSInteger is int and NSUinteger is unsigned int. Following https://developer.apple.com/library/content/documentation/Cocoa/Concept

r313943 - Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData.

Author: rsmith Date: Thu Sep 21 17:11:15 2017 New Revision: 313943 URL: http://llvm.org/viewvc/llvm-project?rev=313943&view=rev Log: Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData. Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/Frontend/float16.cpp

[PATCH] D38118: [CodeGen][ObjC] Build the global block structure before emitting the body of global block invoke functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM with one tweak. Comment at: lib/CodeGen/CGBlocks.cpp:1124 LocalDeclMap, -

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

echristo added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2917 +CodeGenFunction &CGF, llvm::Function *F, +bool ForceThumb) { + StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU; --

r313944 - [Analyzer] Log when auto-synthesized body is used.

Author: george.karpenkov Date: Thu Sep 21 17:37:12 2017 New Revision: 313944 URL: http://llvm.org/viewvc/llvm-project?rev=313944&view=rev Log: [Analyzer] Log when auto-synthesized body is used. Differential Revision: https://reviews.llvm.org/D37910 Modified: cfe/trunk/lib/StaticAnalyzer/Core

  1   2   >