Author: mstorsjo
Date: Thu Sep 14 00:04:59 2017
New Revision: 313232
URL: http://llvm.org/viewvc/llvm-project?rev=313232&view=rev
Log:
[Headers] Fix the return type of _InterlockedCompareExchange_rel
This was a typo in SVN r282447, where it was added.
Modified:
cfe/trunk/lib/Headers/intrin.h
chrib added a comment.
OK, we can refine so that unwind-table is also not generated for C++
-fno-exceptions.
To summarize this gives or C++ :
|| Unwind (table) | Exceptions (can throw) |
| default| Y| Y |
| fno-unwind | N
chrib updated this revision to Diff 115176.
chrib added a comment.
Update IsUnwindTablesDefault to test fno-exceptions. (see Darwin.cpp)
Add comments.
https://reviews.llvm.org/D31140
Files:
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
Index: lib/Driver/ToolChains
djasper added a comment.
I still don't understand yet. breakProtrudingToken has basically two options:
1. Don't wrap/reflow: In this case the penalty is determined by the number of
excess characters.
2. Wrap/reflow: I this case the penalty is determined by PenaltySplitComments
plus the remainin
krasimir added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2407
+ "int b = 0;",
+ Style);
}
Please add tests where:
- the macro occurs inside a function body, thus having nontrivial indentation
- there are two macros
PriMee created this revision.
Herald added a subscriber: klimek.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **"extern C part"**
**Problem:**
Due to the lack of "brace wrapping extern" flag, clang format does parse the
block after **extern** keyword moving the opening bracket to the head
PriMee created this revision.
PriMee added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, JDevlieghere.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34449
**Problem:**
Clang-tidy check misc-unused-parameters comments out parameter name omitting
following characters (e.g. squar
PriMee added a comment.
It turned out that removal range has to be even shorter than in
https://reviews.llvm.org/D37566
Repository:
rL LLVM
https://reviews.llvm.org/D37846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
djasper added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:642
tok::pp_define) &&
-std::find(ForEachMacros.begin(), ForEachMacros.end(),
- FormatTok->Tok.getIdentifierInfo()) != ForEachMacros.end()) {
- FormatTok->Type
arphaman marked 8 inline comments as done.
arphaman added inline comments.
Comment at: tools/clang-refactor/TestSupport.h:32
+
+namespace refactor {
+
hokein wrote:
> Do you plan to use `refactor` on other files?
Probably in the future, yeah.
Repository:
rL
krasimir added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:664
+ * ``bool AfterExternC`` Wrap extern "C" blocks.
+
I think this is overly specific. The C++ standard also [[
http://en.cppreference.com/w/cpp/language/language_linkage | allows
hokein added a comment.
Seems that you have attached a wrong diff, which is committed in r313025.
Comment at: tools/clang-refactor/TestSupport.h:32
+
+namespace refactor {
+
arphaman wrote:
> hokein wrote:
> > Do you plan to use `refactor` on other files?
> Pr
arphaman added a comment.
Yeah, I accidentally committed a prior patch with the link to this diff. I will
commit this patch today though so it should be updated.
Repository:
rL LLVM
https://reviews.llvm.org/D36574
___
cfe-commits mailing list
cf
Author: arphaman
Date: Thu Sep 14 03:06:52 2017
New Revision: 313244
URL: http://llvm.org/viewvc/llvm-project?rev=313244&view=rev
Log:
[refactor] add clang-refactor tool with initial testing support and
local-rename action
This commit introduces the clang-refactor tool alongside the local-rename
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313244: [refactor] add clang-refactor tool with initial
testing support and (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36574?vs=114806&id=115191#toc
Repository:
rL LLV
EricWF added inline comments.
Comment at: docs/LanguageExtensions.rst:2118
+point is the location of the caller. When the builtins appear as part of a
+default member initializer, the invocation point is the location of the
+constructor or aggregate initialization used to create
PriMee updated this revision to Diff 115192.
PriMee added a comment.
Done :)
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLineParser.cpp
unittests
Author: arphaman
Date: Thu Sep 14 03:38:04 2017
New Revision: 313249
URL: http://llvm.org/viewvc/llvm-project?rev=313249&view=rev
Log:
Link clang-refactor with clangAST and clangLex
This is an attempt to fix http://bb.pgr.jp/builders/clang-i686-linux-RA/ after
r313244.
Modified:
cfe/trunk/to
Author: arphaman
Date: Thu Sep 14 03:46:29 2017
New Revision: 313252
URL: http://llvm.org/viewvc/llvm-project?rev=313252&view=rev
Log:
Link clang-refactor with clangFormat
This is an attempt to fix
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage after r313244.
Modified:
cfe/
rnkovacs marked 3 inline comments as done.
rnkovacs added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:296
+def MisusedPolymorphicObjectChecker: Checker<"MisusedPolymorphicObject">,
+ HelpText<"Reports deletions of polymorphic objects with
rnkovacs updated this revision to Diff 115198.
rnkovacs marked an inline comment as done.
rnkovacs retitled this revision from "[analyzer] Misused polymorphic object
checker" to "[analyzer] Delete with non-virtual destructor check".
rnkovacs edited the summary of this revision.
rnkovacs added a co
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1047
+else
+ parseBlock(/*MustBeDeclaration=*/true, /*AddLevel=*/false);
addUnwrappedLine();
Please `clang-format` the newly added lines.
https://reviews.ll
alexfh added a comment.
Once we got that far, could you also ensure this works for function pointer
arguments (e.g. `void f(void (*fn)()) {}`)?
Repository:
rL LLVM
https://reviews.llvm.org/D37846
___
cfe-commits mailing list
cfe-commits@lists.ll
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:141
!Indexer->getOtherRefs(Function).empty() || isOverrideMethod(Function)) {
-SourceRange RemovalRange(Param->getLocation(),
- Param->DeclaratorDecl::getSou
PriMee updated this revision to Diff 115202.
PriMee added a comment.
Sorry, forgot again...
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLineParser.
PriMee added a comment.
Diff will be updated as soon as possible.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:141
!Indexer->getOtherRefs(Function).empty() || isOverrideMethod(Function)) {
-SourceRange RemovalRange(Param->getLocation(),
-
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#870305, @rsmith wrote:
> Also, your wording paper appears to allow things like
>
> struct [[foo]] S *p; // ok in c n2137, ill-formed in c++
> struct T {};
> int n = sizeof(struct [[foo]] T); // ok in c n2137, ill-formed in c+
Author: arphaman
Date: Thu Sep 14 06:16:14 2017
New Revision: 313260
URL: http://llvm.org/viewvc/llvm-project?rev=313260&view=rev
Log:
[refactor] Use CommonOptionsParser in clang-refactor
This commit ensures that CommonOptionsParser works with subcommands. This allows
clang-refactor to use the Co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313260: [refactor] Use CommonOptionsParser in clang-refactor
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37618?vs=114328&id=115208#toc
Repository:
rL LLVM
https://revi
arphaman updated this revision to Diff 115211.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Make methods private
Repository:
rL LLVM
https://reviews.llvm.org/D37681
Files:
include/clang/Tooling/Refactoring/RefactoringActionRule.h
include/clang/Tooling/Refactoring/
krasimir added a comment.
Looks great! Just one more nit: please add a line checking the parsing of the
new option similar to the line `CHECK_PARSE_NESTED_BOOL(BraceWrapping,
AfterStruct);` in `unittests/Format/FormatTest.cpp`.
https://reviews.llvm.org/D37845
___
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
See my comments about removing `StartOffset` field, but other than that looks
good.
Comment at: include/clang/Lex/Lexer.h:52
+ /// a BOM is present at the sta
yaxunl updated this revision to Diff 115222.
yaxunl added a comment.
Fix bug about calling blocks.
https://reviews.llvm.org/D37822
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGOpenCLRuntime.cpp
lib/CodeGen/CGOpenCLRuntime.h
test/CodeGen/blocks-opencl.cl
test/CodeGenOpenCL/blocks.cl
Author: arphaman
Date: Thu Sep 14 08:10:39 2017
New Revision: 313266
URL: http://llvm.org/viewvc/llvm-project?rev=313266&view=rev
Log:
Fix Refactor/tool-test-support.c test on Windows by avoiding
the STDERR redirect
Modified:
cfe/trunk/test/Refactor/tool-test-support.c
Modified: cfe/trunk/te
cameron314 added inline comments.
Comment at: include/clang/Lex/Lexer.h:52
+ /// a BOM is present at the start of the file.
+ unsigned StartOffset;
+ /// \brief Size of the preamble in bytes.
ilya-biryukov wrote:
> We could simplify it further by removing `Sta
ilya-biryukov added inline comments.
Comment at: include/clang/Lex/Lexer.h:52
+ /// a BOM is present at the start of the file.
+ unsigned StartOffset;
+ /// \brief Size of the preamble in bytes.
cameron314 wrote:
> ilya-biryukov wrote:
> > We could simplify it
Author: zturner
Date: Thu Sep 14 09:47:58 2017
New Revision: 313270
URL: http://llvm.org/viewvc/llvm-project?rev=313270&view=rev
Log:
[lit] Force site configs to be run before source-tree configs
This patch simplifies LLVM's lit infrastructure by enforcing an ordering
that a site config is always
Author: zturner
Date: Thu Sep 14 09:47:58 2017
New Revision: 313270
URL: http://llvm.org/viewvc/llvm-project?rev=313270&view=rev
Log:
[lit] Force site configs to be run before source-tree configs
This patch simplifies LLVM's lit infrastructure by enforcing an ordering
that a site config is always
PriMee updated this revision to Diff 115240.
PriMee added a comment.
Thank you for noticing! Done.
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLine
Sorry, I have no particular insight. My commit was reapplied verbatim shortly
after that and the tests passed, so I’m not sure if there’s any relation.
> On Sep 13, 2017, at 4:16 AM, Tsafrir, Yael wrote:
>
> Hello Galina,
>
> I tried to re-create the issue but with no success. I ran the test
Prazek updated this revision to Diff 115243.
Prazek marked 8 inline comments as done.
Prazek added a comment.
Fixed links
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index
Author: prazek
Date: Thu Sep 14 10:33:08 2017
New Revision: 313278
URL: http://llvm.org/viewvc/llvm-project?rev=313278&view=rev
Log:
Enable __declspec(selectany) on any platform
Summary:
This feature was disabled probably by mistake in rL300562
This fixes bug https://bugs.llvm.org/show_bug.cgi?id
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313278: Enable __declspec(selectany) on any platform
(authored by Prazek).
Repository:
rL LLVM
https://reviews.llvm.org/D33852
Files:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/
Prazek marked 3 inline comments as done.
Prazek added a comment.
Thanks for help. I checked and docs build and looks legit. Sorry that it took
so long.
Repository:
rL LLVM
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
yaxunl wr
The bot is unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7880/steps/build%20libcxx%2Fasan/logs/stdio
1/6] Building CXX object
projects/libcxxabi/src/CMakeFiles/cxxabi_objects.dir/cxa_exception.cpp.o
FAILED: projects/libcxxabi/src/CMakeFiles/cxxabi_objects.dir/cxa_ex
frutiger updated this revision to Diff 115246.
frutiger added a comment.
Rebased on top of the latest master.
https://reviews.llvm.org/D37573
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/tests/cindex/test_linkage.py
===
frutiger added a comment.
@compnerd if nothing else remains here, I would also appreciate it if you could
merge this. Thanks!
https://reviews.llvm.org/D37573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
frutiger created this revision.
Some API calls accept 'NULL' instead of a char array (e.g. the second
argument to 'clang_ParseTranslationUnit'). For Python 3 compatibility,
all strings are passed through 'c_interop_string' which expects to
receive only 'bytes' or 'str' objects. This change exten
arphaman created this revision.
This patch adds initial support for refactoring options. One can now use
optional and required `std::string` options.
The options are implemented in the following manner:
- A base interface `RefactoringOption` declares methods that describe the
option's name, de
smeenai added inline comments.
Comment at: CMakeLists.txt:633
+ if (EXISTS "${site_config_path}")
+file(REMOVE "${site_config_path}")
+ endif()
EricWF wrote:
> Maybe print a warning or a message here? While it seems useful to
> re-configure and remove the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313284: [libc++] Prevent stale site configuration headers
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D36720?vs=111096&id=115250#toc
Repository:
rL LLVM
https://reviews.
Author: smeenai
Date: Thu Sep 14 11:23:43 2017
New Revision: 313284
URL: http://llvm.org/viewvc/llvm-project?rev=313284&view=rev
Log:
[libc++] Prevent stale site configuration headers
If we define cmake macros that require a site config, and then undefine
all such macros, a stale site config head
smeenai added a comment.
@mclow.lists, any final verdict here? I ended up doing this differently for my
internal use case, so if you think this isn't generally useful, I'm happy to
abandon.
https://reviews.llvm.org/D36713
___
cfe-commits mailing l
rnk added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1474
+bool CXXRecordDecl::isInterfaceLike() const {
+ // All __interfaces are inheritently interface like.
+ if (isInterface())
nit: use "interface-like" for consistency with the comments below
==
smeenai updated this revision to Diff 115259.
smeenai added a comment.
Herald added a subscriber: fedor.sergeev.
Address comments
https://reviews.llvm.org/D31363
Files:
benchmarks/CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
=
smeenai added a comment.
This depends on https://reviews.llvm.org/D37859 for the `SOURCE_DIR` parameter
to `llvm_check_source_file_list`.
https://reviews.llvm.org/D31363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
morehouse created this revision.
Enable the compile-time flag -fsanitize-memory-use-after-dtor by
default. Note that the run-time option MSAN_OPTIONS=poison_in_dtor=1
still needs to be enabled for destructors to be poisoned.
https://reviews.llvm.org/D37860
Files:
clang/include/clang/Driver/Op
andrew.w.kaylor updated this revision to Diff 115262.
andrew.w.kaylor added a comment.
-Changed GNU idiom from extension to warning.
-Updated to ToT.
https://reviews.llvm.org/D37042
Files:
include/clang/AST/Expr.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaK
cameron314 added inline comments.
Comment at: include/clang/Lex/Lexer.h:52
+ /// a BOM is present at the start of the file.
+ unsigned StartOffset;
+ /// \brief Size of the preamble in bytes.
ilya-biryukov wrote:
> cameron314 wrote:
> > ilya-biryukov wrote:
>
erichkeane marked 4 inline comments as done.
erichkeane added a comment.
Thanks for the quick response! New patch coming soon.
Comment at: lib/AST/DeclCXX.cpp:1478
+
+ // No interface-like types can have a user declared constructor, destructor,
+ // friends, VBases, conersi
zibi created this revision.
Herald added subscribers: kbarton, nemanjai.
When #pragma clang assume_nonnull begin || end is present in the source it is
completely gone from pre-processed output when compiled with -E or -P. This
patch make sure the pragma is preserved. I included 1 test case which
Author: dyung
Date: Thu Sep 14 12:51:26 2017
New Revision: 313290
URL: http://llvm.org/viewvc/llvm-project?rev=313290&view=rev
Log:
Fix refactoring missed in previous commit r313270 which resulted in an
undefined variable being used.
Modified:
clang-tools-extra/trunk/test/Unit/lit.cfg
Modif
smeenai added a comment.
@compnerd, @EricWF and I discussed this a bit on IRC yesterday.
My motivation here is that I'm using libc++ with other headers that clash badly
with the vcruntime headers, which prevents me from using libc++'s
`_LIBCPP_ABI_MICROSOFT` support. Reducing libc++'s dependenc
erichkeane updated this revision to Diff 115272.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Fixed for @rnk s comments.
https://reviews.llvm.org/D37308
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-iunknown-i
vitalybuka added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/Driver/fsanitize.c:175
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory
-fsanitize-memory-use-after-dtor -pie %s -##
morehouse added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-d
vitalybuka added inline comments.
Comment at: compiler-rt/test/msan/use-after-dtor.cc:13
#include
#include
morehouse wrote:
> vitalybuka wrote:
> > Probably we need one test which check that we stop detecting bugs with
> > -fno-sanitize-memory-track-origin
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane created this revision.
The two examples in the test would both cause a compiler assert when attempting
to calculate
the exception specifier for the default constructor for the template classes.
The problem was
that dependents of this function expect that Field->getInClassInitializer
aaron.ballman updated this revision to Diff 115279.
aaron.ballman added a comment.
Updated based on review feedback.
- Rename CAttributes to DoubleSquareBracketAttributes
- Added Objective-C test cases to demonstrate no regressed behavior (based on a
use-case pointed out during review)
- Fixed r
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
I see. It looks like there is an ambiguity between 'new_anotation' and
'new_annotations' that can't be resolved in ActOnMemberAccessExpr because they
have the same distance from 'new_annot
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
- List Item
In https://reviews.llvm.org/D28212#871034, @smeenai wrote:
> @compnerd, @EricWF and I discussed this a bit on IRC yesterday.
>
> In this particular case, however, I don
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Woops. didn't mean to reject.
https://reviews.llvm.org/D28212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
morehouse created this revision.
Flag is -fno-sanitize-use-after-dtor.
https://reviews.llvm.org/D37867
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/SanitizerArgs.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/Driver/fsanitize.c
Index: clang/test/Driver/fsani
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313299: [WebAssembly] Remove invliad lld arguments (authored
by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D36595
Files:
cfe/trunk/lib/Driver/ToolChains/WebAssembly.cpp
Index: cfe/trunk/li
Author: zturner
Date: Thu Sep 14 14:30:27 2017
New Revision: 313300
URL: http://llvm.org/viewvc/llvm-project?rev=313300&view=rev
Log:
Fix 2 stage build on some apple bots.
The recent lit refactor changed the location of the lit script
run by check targets from /utils/lit/lit.py to
/llvm-lit.py.
morehouse updated this revision to Diff 115295.
morehouse added a comment.
- Use hasFlag() in CompilerInvocation.cpp as well.
https://reviews.llvm.org/D37867
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/SanitizerArgs.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/t
EricWF created this revision.
Libc++abi attempts to use the newly added `__asan_handle_no_return()` when
built under ASAN. Unfortunately older versions of compiler-rt do not provide
this symbol, and so libc++abi needs a way to detect if `asan_interface.h`
actually provides the function.
This p
EricWF created this revision.
Herald added a subscriber: dberris.
compiler-rt recently added the `__asan_handle_no_return()` function that
libc++abi needs to use, however older versions of compiler-rt don't provide
this interface and that breaks the libc++abi build.
This patch attempts to fix t
mclow.lists added a comment.
This looks fine to me (along with https://reviews.llvm.org/D37872)
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Looks good to me; sorry for the delay.
https://reviews.llvm.org/D37089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: ericwf
Date: Thu Sep 14 15:19:28 2017
New Revision: 313304
URL: http://llvm.org/viewvc/llvm-project?rev=313304&view=rev
Log:
[libc++abi] Fix ASAN build with older compiler-rt versions.
Summary:
compiler-rt recently added the `__asan_handle_no_return()` function that
libc++abi needs to us
eugenis added a comment.
This function was added to the header recently, but it has been provided by
ASan runtime library since the beginning. Why not simply declare it in
libc++abi?
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe
EricWF added a comment.
In https://reviews.llvm.org/D37871#871325, @eugenis wrote:
> This function was added to the header recently, but it has been provided by
> ASan runtime library since the beginning. Why not simply declare it in
> libc++abi?
I didn't know that. I'll come up with a separa
eugenis added a comment.
Have you looked at performance?
https://reviews.llvm.org/D37867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Sep 14 15:37:34 2017
New Revision: 313308
URL: http://llvm.org/viewvc/llvm-project?rev=313308&view=rev
Log:
Fix ASAN build with older compiler-rt versions.
compiler-rt recently added the __asan_handle_no_return() function that libc++abi
needs to use, however older version
vitalybuka added a comment.
In https://reviews.llvm.org/D37867#871353, @eugenis wrote:
> Have you looked at performance?
Not the answer to your question, but this patch just adds negative flag without
changing defaults.
https://reviews.llvm.org/D37867
_
eugenis accepted this revision.
eugenis added a comment.
Oh right, I was looking at https://reviews.llvm.org/D37860.
https://reviews.llvm.org/D37867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313307: [WebAssembly] Fix wasm-toolchain.c tests (authored
by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D37873
Files:
cfe/trunk/test/Driver/wasm-toolchain.c
Index: cfe/trunk/test/Driver/w
pirama added a comment.
@bruno Any suggestion on how to update test/Headers/float-darwin,c* so make it
check the include_next? I am unable to find the darwin-specific float.h inside
an XCode installation directory.
- Oops, my earlier comment had the wrong test name
https://reviews.llvm.org/D
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:494
+ options::OPT_fno_sanitize_memory_use_after_dtor,
+ false);
NeedP
eugenis added a comment.
Looking at __sanitizer_dtor_callback implementation, this change will add a
(fast) stack unwind in every destructor. In extreme cases (like a tight loop
doing string operations) it could be bad for performance. I've seen ~15% AFAIR.
https://reviews.llvm.org/D37860
_
ahatanak updated this revision to Diff 115304.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
===
morehouse updated this revision to Diff 115312.
morehouse edited the summary of this revision.
morehouse added a comment.
- Move the new flag to https://reviews.llvm.org/D37867
- Address Vitaly's comments.
https://reviews.llvm.org/D37860
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/test/
morehouse added a comment.
In https://reviews.llvm.org/D37860#871368, @eugenis wrote:
> Looking at __sanitizer_dtor_callback implementation, this change will add a
> (fast) stack unwind in every destructor. In extreme cases (like a tight loop
> doing string operations) it could be bad for perfo
1 - 100 of 137 matches
Mail list logo
