RKSimon added a comment.
In https://reviews.llvm.org/D37448#866700, @rnk wrote:
> lgtm
>
> I was hoping for a test case that didn't require assertions, but this is
> enough to land the fix.
My mistake, I should be able to remove that as well - I'll do it as part of the
commit. Thanks.
Repos
frutiger updated this revision to Diff 114701.
frutiger added a comment.
Use more specific target platform.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libc
vsk closed this revision.
vsk added a comment.
Thanks, r312948
https://reviews.llvm.org/D37642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Mon Sep 11 14:37:05 2017
New Revision: 312957
URL: http://llvm.org/viewvc/llvm-project?rev=312957&view=rev
Log:
[ubsan-minimal] Document the new runtime
Differential Revision: https://reviews.llvm.org/D37647
Modified:
cfe/trunk/docs/ReleaseNotes.rst
cfe/trunk/docs/U
Author: vedantk
Date: Mon Sep 11 14:37:06 2017
New Revision: 312958
URL: http://llvm.org/viewvc/llvm-project?rev=312958&view=rev
Log:
[Driver] Support ubsan-minimal on Darwin
Make it possible to use the minimal ubsan runtime on Darwin.
Differential Revision: https://reviews.llvm.org/D37649
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312957: [ubsan-minimal] Document the new runtime (authored
by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37647?vs=114449&id=114703#toc
Repository:
rL LLVM
https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312958: [Driver] Support ubsan-minimal on Darwin (authored
by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D37649?vs=114458&id=114704#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Sorry, I completely missed that this affected the version string on
released binaries; I was even a reviewer on r312043 :-/ For Windows
release builds, the version info gets set explicitly, but not for
other builds.
We should have merged r312043 to 5.0.0.. perhaps it will go into 5.0.1.
- Hans
rjmccall added a comment.
In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote:
> In https://reviews.llvm.org/D33826#866161, @JonasToth wrote:
>
> > There is an exception to the general rule (EXP36-C-EX2), stating that the
> > result of `malloc` and friends is allowed to be casted to str
inglorion updated this revision to Diff 114715.
inglorion added a comment.
renamed get{Nested,}ExpressionLocationsEnabled and moved it into
CodeGetModule.cpp
https://reviews.llvm.org/D37529
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CodeGenModule.cpp
clang/lib/CodeGen/Cod
Author: inglorion
Date: Mon Sep 11 15:11:57 2017
New Revision: 312965
URL: http://llvm.org/viewvc/llvm-project?rev=312965&view=rev
Log:
[codeview] omit debug locations for nested exprs unless column info enabled
Summary:
Microsoft Visual Studio expects debug locations to correspond to
statements.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312965: [codeview] omit debug locations for nested exprs
unless column info enabled (authored by inglorion).
Changed prior to commit:
https://reviews.llvm.org/D37529?vs=114715&id=114716#toc
Repository:
rsmith added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:327
+
+ SmallVector getStmtChildren(CXXOperatorCallExpr *CE) {
+SmallVector Children(CE->children());
The copy here is more expensive than I'd like. Instead of returning a list
rsmith added a comment.
If this is just supposed to be an experiment to get feedback on the feature,
then I don't think we should be treating it as a different attribute syntax at
all. Rather, I think we just want to permit C++11 attributes to be parsed in
other language modes. If/when this bec
martell accepted this revision.
martell added a comment.
LGMT
https://reviews.llvm.org/D37530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcgrathr created this revision.
Herald added subscribers: kristof.beyls, aemerson.
This regressed for x86-64 in r307856 because it's no longer inherited
from Generic_GCC. We'd never noticed that it was missing other
targets (i.e. aarch64), but Fuchsia is uniform across all machines.
Repository:
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D37723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: vlad.tsyrklevich
Date: Mon Sep 11 17:21:17 2017
New Revision: 312986
URL: http://llvm.org/viewvc/llvm-project?rev=312986&view=rev
Log:
Fix broken links to the Itanium CXX ABI
Modified:
cfe/trunk/docs/ControlFlowIntegrityDesign.rst
cfe/trunk/docs/Toolchain.rst
cfe/trunk/lib/AST
Author: phosek
Date: Mon Sep 11 18:28:37 2017
New Revision: 312989
URL: http://llvm.org/viewvc/llvm-project?rev=312989&view=rev
Log:
[Driver] Fuchsia targets default to -fasynchronous-unwind-tables
This regressed for x86-64 in r307856 because it's no longer inherited
from Generic_GCC. We'd never
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312989: [Driver] Fuchsia targets default to
-fasynchronous-unwind-tables (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D37723?vs=114737&id=114746#toc
Repository:
rL LLVM
ht
martell created this revision.
Alias `-static-compiler-rt` and `static-libc++` to their gcc counterparts.
Currently invoking `-static-libgcc` or `-static-libstdc++` will ensure only use
of static libs.
In future if we want to do more accurate handling with better behaviour with
the linker we can
ahatanak updated this revision to Diff 114753.
ahatanak added a comment.
Address review comments.
- Detect invalid references to parameters or local variables by default
arguments in tryCaptureVariable. Before parsing or instantiating the default
argument expression, the enclosing DeclContext i
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
LGTM with the nits below. Thanks!
Comment at: include/llvm/IR/DiagnosticHandler.h:1
+//===- DiagnosticHandler.cpp - DiagnosticHandler class for LLVM -*- C++
-*-===//
+//
--
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:882-883
BEConsumer = Result.get();
-
+ VMContext->setDiagnosticHandler(llvm::make_unique(
+ CI.getCodeGenOpts(), Result.get()));
// Enable generating macro debug info only when debug info is not d
erichkeane added a comment.
You seem to have had a hard time with the diff tool too... there is an extra
file here that needs to be removed.
Comment at: lib/Sema/SemaDeclCXX.cpp:2390
+ Uuid && Uuid->getGuid() =="---C000-0046" &&
+ dyn_ca
kristof.beyls added a comment.
Still LGTM; please commit.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jina.nahias updated this revision to Diff 114765.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
101 - 127 of 127 matches
Mail list logo
