vsk created this revision.
Don't emit alignment checks which the IR constant folder throws away.
I've tested this out on X86FastISel.cpp. While this doesn't decrease
end-to-end compile-time significantly, it results in 122 fewer type
checks (1% reduction) overall, without adding any real complexi
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: clang/lib/Headers/cuda_wrappers/new:79
+}
+__device__ void operator delete[](void *ptr, std::size_t sz) CUDA_NOEXCEPT {
+ ::operator delete(ptr);
tra wrote:
> Is std::size_t inten
jlebar updated this revision to Diff 114104.
jlebar marked an inline comment as done.
jlebar added a comment.
Address review comments.
https://reviews.llvm.org/D37539
Files:
clang/lib/Headers/cuda_wrappers/new
Index: clang/lib/Headers/cuda_wrappers/new
==
inglorion planned changes to this revision.
inglorion added a comment.
rnk and I talked about a different approach. The idea is to explicitly emit
locations in some cases (e.g. inside compound statements, the braces of for
loops, ...), and otherwise emit locations only when emitting column info
Author: jlebar
Date: Wed Sep 6 17:37:20 2017
New Revision: 312681
URL: http://llvm.org/viewvc/llvm-project?rev=312681&view=rev
Log:
[CUDA] Add device overloads for non-placement new/delete.
Summary:
Tests have to live in the test-suite, and so will come in a separate
patch.
Fixes PR34360.
Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312682: [CUDA] Tests for device-side overloads of
non-placement new/delete. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D37540?vs=114094&id=114109#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312681: [CUDA] Add device overloads for non-placement
new/delete. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D37539?vs=114104&id=114108#toc
Repository:
rL LLVM
https://r
hintonda added a comment.
In https://reviews.llvm.org/D35533#862852, @minseong.kim wrote:
> @hintonda, Absolutely. Incorporating @modocache's module changes into the
> version in AddLLVM.cmake would solve the current version display issue for
> repo and do not affect the process of other versio
Author: rsmith
Date: Wed Sep 6 17:55:55 2017
New Revision: 312684
URL: http://llvm.org/viewvc/llvm-project?rev=312684&view=rev
Log:
[modules ts] Ensure that module linkage variables are always emitted and always
have their name mangled.
Modified:
cfe/trunk/lib/AST/Mangle.cpp
cfe/trunk/l
srhines added a comment.
Ping.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
Herald added a subscriber: sanjoy.
That is, instead of "1 error generated", we now say "1 error generated
when compiling for sm_35".
This (partially) solves a usability foogtun wherein e.g. users call a
function that's only defined on sm_60 when compiling for sm_35,
Author: marshall
Date: Wed Sep 6 19:46:09 2017
New Revision: 312690
URL: http://llvm.org/viewvc/llvm-project?rev=312690&view=rev
Log:
Add more string_view tests
Added:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_insert/string_view.pass.cpp
libcxx/trunk/test/std/s
Author: marshall
Date: Wed Sep 6 20:03:48 2017
New Revision: 312691
URL: http://llvm.org/viewvc/llvm-project?rev=312691&view=rev
Log:
Another missing string_view test
Added:
libcxx/trunk/test/std/strings/basic.string/string.cons/string_view_assignment.pass.cpp
Added:
libcxx/trunk/test/std
minseong.kim updated this revision to Diff 114115.
minseong.kim edited the summary of this revision.
minseong.kim added a reviewer: hintonda.
minseong.kim removed a subscriber: hintonda.
minseong.kim added a comment.
I have updated the diff.
https://reviews.llvm.org/D35533
Files:
lib/Basic/CM
Author: marshall
Date: Wed Sep 6 21:19:32 2017
New Revision: 312693
URL: http://llvm.org/viewvc/llvm-project?rev=312693&view=rev
Log:
Add even more string_view tests. These found some bugs in the default parameter
value for rfind/find_last_of/find_last_not_of
Added:
libcxx/trunk/test/std/s
mstorsjo added a comment.
In https://reviews.llvm.org/D37530#862644, @rnk wrote:
> What do you think of letting people spell this as `-lmsvcrt120`? We could
> forward those options and suppress our implicit addition of `-lmsvcrt` if we
> see `-lmsvcr*` anywhere.
That might work and would prob
Author: rsmith
Date: Wed Sep 6 22:29:39 2017
New Revision: 312696
URL: http://llvm.org/viewvc/llvm-project?rev=312696&view=rev
Log:
[modules ts] Add test for [basic.link]p3.
Added:
cfe/trunk/test/CXX/modules-ts/basic/basic.link/p3.cppm
Added: cfe/trunk/test/CXX/modules-ts/basic/basic.link/p
Author: rsmith
Date: Wed Sep 6 22:41:24 2017
New Revision: 312700
URL: http://llvm.org/viewvc/llvm-project?rev=312700&view=rev
Log:
Fix off-by-one error in block mangling.
This restores the ABI prior to r214699.
Modified:
cfe/trunk/lib/AST/ItaniumMangle.cpp
cfe/trunk/test/CodeGenObjCXX/
Author: atanasyan
Date: Wed Sep 6 23:05:06 2017
New Revision: 312701
URL: http://llvm.org/viewvc/llvm-project?rev=312701&view=rev
Log:
[mips] Replace Triple::Environment check by the isGNUEnvironment() call. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
cfe/trunk/lib/Driver
bjope added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5888
def note_typecheck_assign_const : Note<
"%select{"
Shouldn't there be one more entry here as well?
(see comment about updating both err_typecheck_assign_const and
note
101 - 120 of 120 matches
Mail list logo
