Ka-Ka updated this revision to Diff 113803.
Ka-Ka edited the summary of this revision.
Ka-Ka added a reviewer: dblaikie.
Ka-Ka added a comment.
I updated the testcase according to what David Blaikie suggested.
I also rewrote to code to be a bit more robust and avoid emitting unnecessary
stoppoint
arphaman updated this revision to Diff 113804.
arphaman marked 8 inline comments as done.
arphaman added a comment.
- Test by checking the modified source directly. This allowed me to get rid of
the refactoring result wrapper as well.
- Remove ASTRefactoringContext
- Address the other review comm
arphaman added inline comments.
Comment at: tools/clang-refactor/ClangRefactor.cpp:60
+ : SubCommand(Name, Description), Action(&Action) {
+Sources = llvm::make_unique>(
+cl::Positional, cl::ZeroOrMore, cl::desc(" [... ]"),
arphaman wrote:
> ioer
emankov accepted this revision.
emankov added a comment.
LGTM
https://reviews.llvm.org/D37386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:45
std::unique_ptr
createRefactoringRule(Expected (*RefactoringFunction)(
typename RequirementTypes::OutputType...),
Can we get rid o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312523: [X86][AVX512] _mm512_stream_load_si512 should take a
void const* argument… (authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D37449?vs=113786&id=113819#toc
Repository:
Author: rksimon
Date: Tue Sep 5 03:06:41 2017
New Revision: 312523
URL: http://llvm.org/viewvc/llvm-project?rev=312523&view=rev
Log:
[X86][AVX512] _mm512_stream_load_si512 should take a void const* argument
(PR33977)
Based off the Intel Intrinsics guide, we should expect a void const* argument.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312524: [AMDGPU] Implement infrastructure to set options in
AMDGPUToolChain (authored by kasaurov).
Changed prior to commit:
https://reviews.llvm.org/D37386?vs=113780&id=113825#toc
Repository:
rL LLV
lebedev.ri added a comment.
I understand that everyone is likely busy with 5.0, but still,
give me at least some feedback, please :) ping
Repository:
rL LLVM
https://reviews.llvm.org/D36836
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
arphaman added inline comments.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRulesInternal.h:99
+ template
+ void invokeImplDispatch(
+ RefactoringResultConsumer &Consumer, RefactoringRuleContext &,
ioeric wrote:
> Do we still need this
arphaman updated this revision to Diff 113826.
arphaman marked 6 inline comments as done.
arphaman added a comment.
- Always pass in `RefactoringRuleContext` to the refactoring rule's function.
- Remove now redundant overloads.
- Make LocalRename's actions members private.
- Add CommandLienParser
Author: rksimon
Date: Tue Sep 5 03:37:13 2017
New Revision: 312525
URL: http://llvm.org/viewvc/llvm-project?rev=312525&view=rev
Log:
Removed dead code (PR34467). NFCI.
The for loop already checks that Idx < NumOfArgs.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp
Modified: cfe/
teemperor created this revision.
Currently clang segfaults when invoked with `clang --autocomplete=`.
This patch adds the necessary boundary checks and some tests for corner cases
like this.
Repository:
rL LLVM
https://reviews.llvm.org/D37465
Files:
lib/Driver/Driver.cpp
test/Driver/aut
barancsuk updated this revision to Diff 113830.
barancsuk added a comment.
Check if argument and parameter numbers differ, add test cases for functions
with default parameters
https://reviews.llvm.org/D20689
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTid
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D37466
Files:
test/CodeGen/ms-inline-asm-64.c
test/CodeGen/ms-inline-asm-offset-err.cpp
test/CodeGen/ms-inline-asm-offset.c
test/CodeGen/ms-inline-asm.c
test/CodeGen/ms-inline-
Author: kasaurov
Date: Tue Sep 5 03:24:38 2017
New Revision: 312524
URL: http://llvm.org/viewvc/llvm-project?rev=312524&view=rev
Log:
[AMDGPU] Implement infrastructure to set options in AMDGPUToolChain
In current OpenCL implementation some options are set in OpenCL RT/Driver,
which causes discr
coby added a comment.
might be a bit unrelated - but do we've got a hint regarding why is this even
an issue?
by all means - it doesn't seems right for an empty ms inline-asm statement to
affect successful compilation, without even mentioning the involvement of the
encapsulating function's retu
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the fix!
Repository:
rL LLVM
https://reviews.llvm.org/D37465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
xazax.hun updated this revision to Diff 113837.
xazax.hun retitled this revision from "[analyzer] Fix SimpleStreamChecker's
output plist not containing the checker name" to "[analyzer] Fix some checker's
output plist not containing the checker name".
xazax.hun edited the summary of this revision.
mstorsjo created this revision.
_strftime_l is only available in the numbered msvcrt versions (starting from
msvcr80.dll). In the default configuration, mingw targets the unversioned
msvcrt.dll - and there, _strftime_l is not available (not even on windows 10).
If __MSVCRT_VERSION__ is set to a
xazax.hun added a comment.
In https://reviews.llvm.org/D37437#860311, @NoQ wrote:
> Cool. Thanks!
>
> > In the future probably it would be better to alter the signature of the
> > checkers' constructor to set the name in the constructor so it is possible
> > to create the BugType eagerly.
>
> S
Author: kfunk
Date: Tue Sep 5 05:36:33 2017
New Revision: 312532
URL: http://llvm.org/viewvc/llvm-project?rev=312532&view=rev
Log:
Make run-clang-tidy compatible with Python 3.x
Reviewers: alexfh
Reviewed By: alexfh
Subscribers: cfe-commits, JDevlieghere
Tags: #clang-tools-extra
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312532: Make run-clang-tidy compatible with Python 3.x
(authored by kfunk).
Changed prior to commit:
https://reviews.llvm.org/D37138?vs=112677&id=113841#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: teemperor
Date: Tue Sep 5 05:41:00 2017
New Revision: 312533
URL: http://llvm.org/viewvc/llvm-project?rev=312533&view=rev
Log:
[Bash-autocomplete] Fix crash when invoking --autocomplete without value.
Summary:
Currently clang segfaults when invoked with `clang --autocomplete=`.
This patc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312533: [Bash-autocomplete] Fix crash when invoking
--autocomplete without value. (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D37465?vs=113829&id=113842#toc
Repository:
xazax.hun created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
The users of CallDescription no longer need to make sure that the called
function is a C function. This makes the API usage easier and it conservatively
will never match ObjC Messages. In the future, this
chrib updated this revision to Diff 113846.
chrib added a comment.
Herald added a subscriber: kristof.beyls.
Rebase and cleanup NeedsUnwindTable for be variants.
https://reviews.llvm.org/D31140
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
Index: lib/CodeGen/CodeGenModu
cameron314 created this revision.
Herald added a subscriber: mgorny.
When using a virtual file-system (VFS) and a preamble file (PCH) is generated,
it is generated on-disk in the real file-system instead of in the VFS (which I
guess makes sense, since the VFS is read-only). However, when subsequ
cameron314 abandoned this revision.
cameron314 added a comment.
This patch is obsolete. While waiting over a year for a review, somebody else
came across the same fix (for a different manifestation of the same bug) in
https://reviews.llvm.org/D27810 and managed to get it through. I think my test
erichkeane added a comment.
I apologize for the lack of detail for this comment, but I didn't seem to
capture this at the time. When I investigated this initially, I came up with
this solution and it was insufficient. I don't remember WHAT this ends up not
fixing however.
When discussing it
Author: sylvestre
Date: Tue Sep 5 06:56:40 2017
New Revision: 312535
URL: http://llvm.org/viewvc/llvm-project?rev=312535&view=rev
Log:
add the option IndentPPDirectives to the release notes. Landed in r312125
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rs
Author: krasimir
Date: Tue Sep 5 06:58:53 2017
New Revision: 312536
URL: http://llvm.org/viewvc/llvm-project?rev=312536&view=rev
Log:
[clang-format] Fix lines=all case in clang-format.py
Modified:
cfe/trunk/tools/clang-format/clang-format.py
Modified: cfe/trunk/tools/clang-format/clang-form
RKSimon added a comment.
In https://reviews.llvm.org/D37448#861019, @erichkeane wrote:
> I apologize for the lack of detail for this comment, but I didn't seem to
> capture this at the time. When I investigated this initially, I came up with
> this solution and it was insufficient. I don't re
ilya-biryukov added a comment.
Could we fix this in tests instead by providing an overlay over `RealFS` there
instead of doing that in `ASTUnit`?
If I'm passing `vfs::FileSystem`, I specifically **do not want** any file
accesses to silently go through `RealFS`, ignoring the `vfs::FileSystem` th
erichkeane added a comment.
In https://reviews.llvm.org/D37448#861069, @RKSimon wrote:
> In https://reviews.llvm.org/D37448#861019, @erichkeane wrote:
>
> > I apologize for the lack of detail for this comment, but I didn't seem to
> > capture this at the time. When I investigated this initially
erichkeane added a comment.
Ah, I seem to remember that the problem here is that we don't know whether this
value should be signed or unsigned at this point, so it could be
CreateZExtOrTrunc OR CreateSignExtOrTrunc? However, there is no information as
to whether the integer is signed here as f
r.stahl created this revision.
Herald added a subscriber: eraman.
The "Multiplicand" variable in SimpleSValBuilder::evalBinOpLN was always
initialized to zero, causing all pointer arithmetic on constant values to be
no-ops.
This fixes two FIXMEs in existing tests. The added tests were all faili
dblaikie added a comment.
Not sure what you mean by "avoid emitting unnecessary stop points" - do you
have a test case for that?
https://reviews.llvm.org/D37428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Ka-Ka added a comment.
In https://reviews.llvm.org/D37428#861140, @dblaikie wrote:
> Not sure what you mean by "avoid emitting unnecessary stop points" - do you
> have a test case for that?
In my previous patch you could end up doing two calls to EmitStopPoint() for
the same statement. In the
aaron.ballman added a comment.
Aside from a few small nits, this looks reasonable. Have you run it over any
large code bases that use signals to test the quality of the check?
Comment at: docs/clang-tidy/checks/cert-msc54-cpp.rst:23
+extern "C" void cpp_signal_handler(int
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
OK, sounds good - thanks :)
https://reviews.llvm.org/D37428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
cameron314 added a comment.
I suppose we could do the overlay manually in all the tests that need it; I
guess it depends on what the goal of the VFS support is. To my mind, it doesn't
make sense that a file is placed in the RealFS in the first place if a VFS is
used, but this is quite entrenche
rnk added a comment.
I think this is a reasonable stop-gap fix since the code isn't trying to return
EAX:EDX or XMM0 from the inline asm blob. This affects any function that
contains inline asm and returns a vector, which is potentially a lot of stuff.
Comment at: test/CodeGe
vivekvpandya updated this revision to Diff 113879.
vivekvpandya added a comment.
Clang-formated
https://reviews.llvm.org/D37196
Files:
lib/CodeGen/CodeGenAction.cpp
Index: lib/CodeGen/CodeGenAction.cpp
===
--- lib/CodeGen/CodeG
aaron.ballman added a comment.
Have you run this check over any large code bases to see what the quality of
the diagnostics are?
Comment at: docs/clang-tidy/checks/cert-exp36-c.rst:9
+
+This check is the same as `-Wcast-align`, except it checks for
`reinterpret_cast` as well
dcoughlin added a comment.
I'm worried about doing this for main(). I think many people would find it
surprising if analyzing main() were to behave differently than other functions.
I'm particularly worried because I think it is quite common to create a small
test program with only main() to un
dcoughlin added a comment.
I'm a bit surprised that this is needed for unit tests. Aren't unit tests
supposed to clean up their own state? Leaking a scarce resource in one unit
test can cause another unit test to fail, which can be hard to track down. Or
is this for deliberately testing a scena
Author: erichkeane
Date: Tue Sep 5 10:32:36 2017
New Revision: 312542
URL: http://llvm.org/viewvc/llvm-project?rev=312542&view=rev
Log:
[Preprocessor] Correct internal token parsing of newline characters in CRLF
Correct implementation: Apparently I managed in r311683 to submit the wrong
version
Author: jdevlieghere
Date: Tue Sep 5 11:04:34 2017
New Revision: 312545
URL: http://llvm.org/viewvc/llvm-project?rev=312545&view=rev
Log:
[NFC] Loop modernization in diagtool
Precommit for https://reviews.llvm.org/D37390
Modified:
cfe/trunk/tools/diagtool/DiagnosticNames.cpp
cfe/trunk/t
Author: jdevlieghere
Date: Tue Sep 5 11:04:40 2017
New Revision: 312546
URL: http://llvm.org/viewvc/llvm-project?rev=312546&view=rev
Log:
[diagtool] Change default tree behavior to print only flags
This patch changes the default behavior of `diagtool tree` to only
display warning flags and not t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312546: [diagtool] Change default tree behavior to print
only flags (authored by JDevlieghere).
Changed prior to commit:
https://reviews.llvm.org/D37390?vs=113737&id=113885#toc
Repository:
rL LLVM
h
andrew.w.kaylor added a comment.
Ping.
https://reviews.llvm.org/D37042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Tue Sep 5 11:20:11 2017
New Revision: 312552
URL: http://llvm.org/viewvc/llvm-project?rev=312552&view=rev
Log:
Creating release candidate final from release_500 branch
Added:
libcxx/tags/RELEASE_500/final/ (props changed)
- copied from r312551, libcxx/branches/rele
Author: hans
Date: Tue Sep 5 11:20:18 2017
New Revision: 312559
URL: http://llvm.org/viewvc/llvm-project?rev=312559&view=rev
Log:
Creating release candidate final from release_500 branch
Added:
libunwind/tags/RELEASE_500/final/ (props changed)
- copied from r312558, libunwind/branche
Author: hans
Date: Tue Sep 5 11:20:11 2017
New Revision: 312553
URL: http://llvm.org/viewvc/llvm-project?rev=312553&view=rev
Log:
Creating release candidate final from release_500 branch
Added:
libcxxabi/tags/RELEASE_500/final/
- copied from r312552, libcxxabi/branches/release_50/
___
GorNishanov marked an inline comment as done.
GorNishanov added inline comments.
Comment at: test/SemaCXX/coroutines.cpp:169
+void check_auto_await_suspend() {
+ co_await auto_await_suspend{}; // OK
+}
javed.absar wrote:
> maybe change the comment to something m
Author: gornishanov
Date: Tue Sep 5 12:31:52 2017
New Revision: 312565
URL: http://llvm.org/viewvc/llvm-project?rev=312565&view=rev
Log:
[coroutines] Make sure auto return type of await_resume is properly handled
Reviewers: rsmith, EricWF
Reviewed By: rsmith
Subscribers: javed.absar, cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312565: [coroutines] Make sure auto return type of
await_resume is properly handled (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D37454?vs=113800&id=113894#toc
Repositor
Nebiroth updated this revision to Diff 113895.
Nebiroth added a comment.
Added function to avoid code reuse and extra nesting.
https://reviews.llvm.org/D37150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/GlobalCompilat
rwols updated this revision to Diff 113901.
rwols added a comment.
- Fix failing clangd tests
https://reviews.llvm.org/D37101
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/P
rwols updated this revision to Diff 113899.
rwols added a comment.
- Don't use const for non-reference parameters
- `lowerCamelCase` for functions, verb phrase
- Field definitions at the bottom of the class
- Make ProcessChunks virtual
- Add comment that fallthrough to the next case is intended
-
jbcoe created this revision.
jbcoe added a project: clang-c.
Also move misplaced tests for exception specification to fix failing Python
tests.
Repository:
rL LLVM
https://reviews.llvm.org/D37490
Files:
clang/bindings/python/clang/cindex.py
clang/bindings/python/tests/cindex/test_diagno
rwols marked 7 inline comments as done.
rwols added inline comments.
Comment at: clangd/ClangdUnit.cpp:376
+
+CompletionItem Item{InsertTextFormat::PlainText};
+
ilya-biryukov wrote:
> Implementations of this function in `PlainTextCompletionItemsCollector` an
cameron314 created this revision.
This patch fixes preamble skipping when the preamble region includes a byte
order mark (BOM). Previously, parsing would fail if preamble PCH generation was
enabled and a BOM was present.
This also fixes the preamble incorrectly being invalidated when a BOM appe
erichkeane added a comment.
In https://reviews.llvm.org/D37448#861211, @rnk wrote:
> I think this is a reasonable stop-gap fix since the code isn't trying to
> return EAX:EDX or XMM0 from the inline asm blob. This affects any function
> that contains inline asm and returns a vector, which is po
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:979-980
Decl *ManglingContextDecl,
- bool IsDecltype)
+ bool IsDecltype,
+
Author: rnk
Date: Tue Sep 5 13:27:35 2017
New Revision: 312572
URL: http://llvm.org/viewvc/llvm-project?rev=312572&view=rev
Log:
[ms] Implement the __annotation intrinsic
Added:
cfe/trunk/test/CodeGen/ms-annotation.c
cfe/trunk/test/Sema/ms-annotation.c
Modified:
cfe/trunk/include/cla
Hi Richard,
this change has triggered a bunch of leak reports on the sanitizer bots:
Direct leak of 1824 byte(s) in 1 object(s) allocated from:
#0 0xb48430 in operator new(unsigned long)
/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/projects/compiler-rt/lib/asan/asan_new_d
Author: rnk
Date: Tue Sep 5 13:38:29 2017
New Revision: 312573
URL: http://llvm.org/viewvc/llvm-project?rev=312573&view=rev
Log:
Commit changes missing from r312572
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/ms-annotation.c
Modified: cfe/trunk/lib/CodeGen/CGBui
efriedma added a comment.
> According to our definition, v4si is NOT a "Vector" type, since a vector type
> requires it be a FP value.
Umm, what? An integer vector is still a vector. The backend will return it in
xmm0 on x86 (both 32 and 64-bit).
The actual problem here is that
X86_32Target
Test?
On Tue, Sep 5, 2017 at 1:32 PM, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Tue Sep 5 10:32:36 2017
> New Revision: 312542
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312542&view=rev
> Log:
> [Preprocessor] Correct internal token parsi
There’s an existing test in r311683. I’d initially implemented handling ‘\r\n’
as well as ‘\n\r’, but Reid had suggested that I simply handle the former. I’d
inadvertently contributed the previous revision. I noticed this morning that
I’d done so, so I corrected my commit.
From: tha...@googl
Thanks, looking...
On 5 September 2017 at 13:31, Evgenii Stepanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> this change has triggered a bunch of leak reports on the sanitizer bots:
>
> Direct leak of 1824 byte(s) in 1 object(s) allocated from:
> #0 0xb48430 in ope
erichkeane added a comment.
In https://reviews.llvm.org/D37448#861443, @efriedma wrote:
> > According to our definition, v4si is NOT a "Vector" type, since a vector
> > type requires it be a FP value.
>
> Umm, what? An integer vector is still a vector. The backend will return it
> in xmm0 on
Prazek marked an inline comment as done.
Prazek added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> Pra
yaxunl added a comment.
In https://reviews.llvm.org/D36410#856907, @bader wrote:
> In https://reviews.llvm.org/D36410#856716, @yaxunl wrote:
>
> > The captured variable is still passed by value. The address taking is on
> > the duplicate of the captured variable, not on the original variable.
>
Author: rsmith
Date: Tue Sep 5 14:46:22 2017
New Revision: 312580
URL: http://llvm.org/viewvc/llvm-project?rev=312580&view=rev
Log:
Fix memory leak after r312467. The ModuleMap is the owner of the global module
object until it's reparented under a real module.
Modified:
cfe/trunk/include/cl
Should be fixed in r312580, thanks!
On 5 September 2017 at 13:58, Richard Smith wrote:
> Thanks, looking...
>
> On 5 September 2017 at 13:31, Evgenii Stepanov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Richard,
>>
>> this change has triggered a bunch of leak reports on the sa
echristo added inline comments.
Comment at: test/CodeGen/debug-info-attributed-stmt.c:1
+// RUN: %clang_cc1 -triple x86_64-unk-unk -disable-llvm-passes
-debug-info-kind=limited -emit-llvm %s -o - | FileCheck %s
+
Since we're not optimizing or generating code you
Eugene.Zelenko added a comment.
I think will be good idea to introduce command line option to control progress
display: turn it off, show in absolute numbers or percents.
https://reviews.llvm.org/D37479
___
cfe-commits mailing list
cfe-commits@list
kfunk added a comment.
In https://reviews.llvm.org/D37479#861580, @Eugene.Zelenko wrote:
> I think will be good idea to introduce command line option to control
> progress display: turn it off, show in absolute numbers or percents.
Honestly, I don't think this configurability is necessary. I'd
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
ick
https://reviews.llvm.org/D37468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Eugene.Zelenko added a comment.
It'll be also nice to output progress in terminal when all messages will saved
into file.
https://reviews.llvm.org/D37479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
itessier created this revision.
The ToolChain class validates the -mthread-model flag in the constructor which
doesn't work correctly since the thread model methods are virtual methods. The
check is moved into Clang::ConstructJob() when constructing the internal
command line.
https://reviews.
itessier added a comment.
I don't have SVN access, can somebody commit this change for me?
https://reviews.llvm.org/D37493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Sep 5 16:50:58 2017
New Revision: 312595
URL: http://llvm.org/viewvc/llvm-project?rev=312595&view=rev
Log:
[Darwin] Enable -fstack-protector (back) by default with -ffreestanding
Go back to behavior prior to r289005.
rdar://problem/32987198
Modified:
cfe/trunk/lib/D
On Tue, Sep 05, 2017 at 11:50:58PM -, Bruno Cardoso Lopes via cfe-commits
wrote:
> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=312595&r1=312594&r2=312595&view=diff
>
yaxunl marked an inline comment as done.
yaxunl added a comment.
ping
https://reviews.llvm.org/D35082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Sep 5 17:44:10 2017
New Revision: 312599
URL: http://llvm.org/viewvc/llvm-project?rev=312599&view=rev
Log:
Fix indentation mistake from r312595
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http://llvm.o
On Tue, Sep 5, 2017 at 4:58 PM, Joerg Sonnenberger via cfe-commits
wrote:
> On Tue, Sep 05, 2017 at 11:50:58PM -, Bruno Cardoso Lopes via cfe-commits
> wrote:
>> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains
compnerd added a comment.
The change looks good. Can you please add some test cases for this? Or do
existing test cases cover this already?
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: phosek
Date: Tue Sep 5 19:43:54 2017
New Revision: 312606
URL: http://llvm.org/viewvc/llvm-project?rev=312606&view=rev
Log:
[libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return
The ASan runtime on many systems intercepts cxa_throw just so it
can call asan_handle_no
Author: phosek
Date: Tue Sep 5 20:00:42 2017
New Revision: 312609
URL: http://llvm.org/viewvc/llvm-project?rev=312609&view=rev
Log:
Revert "[libcxxabi] When built with ASan, __cxa_throw calls
__asan_handle_no_return"
This reverts commit r312606 because it's causing an error on
libcxx-libcxxabi-
Author: compnerd
Date: Tue Sep 5 21:56:23 2017
New Revision: 312616
URL: http://llvm.org/viewvc/llvm-project?rev=312616&view=rev
Log:
Driver: remove unused variable (NFC)
Remove `IsHosted` which is no longer needed in `RenderSSPOptions` after
SVN r312595. The single use can now be inlined. NFC
Author: mstorsjo
Date: Tue Sep 5 22:07:25 2017
New Revision: 312617
URL: http://llvm.org/viewvc/llvm-project?rev=312617&view=rev
Log:
Redirect strftime_l to the locale-ignorant strftime on mingw
_strftime_l is only available in the numbered msvcrt versions
(starting from msvcr80.dll). In the def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312617: Redirect strftime_l to the locale-ignorant strftime
on mingw (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37468?vs=113838&id=113956#toc
Repository:
rL LLVM
http
Author: compnerd
Date: Tue Sep 5 22:11:19 2017
New Revision: 312618
URL: http://llvm.org/viewvc/llvm-project?rev=312618&view=rev
Log:
Driver: delete some dead code (NFC)
This code has been `#if 0`'ed out for a very long time. After speaking
with Duncan, opt to remove it even if it is something
Ka-Ka added inline comments.
Comment at: test/CodeGen/debug-info-attributed-stmt.c:1
+// RUN: %clang_cc1 -triple x86_64-unk-unk -disable-llvm-passes
-debug-info-kind=limited -emit-llvm %s -o - | FileCheck %s
+
echristo wrote:
> Since we're not optimizing or gene
98 matches
Mail list logo
