Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Thanks for the revert; looks like there was another bug in the interaction of lambdas an UBSan 'this' sanitization that was exposed by this (the lambda static invoker calls the operator() with a null this pointer, and the sanitizer doesn't know that's actually OK). Should be fixed in r311695. On 2

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please add a test that the attribute is emitted into IR. Other than that, this looks good to me. Comment at: include/clang/Driver/Options.td:645 + profile is a

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112601. danielcdh added a comment. Herald added subscribers: eraman, mehdi_amini. Add an end-to-end test. https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cp

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added inline comments. Comment at: test/CodeGen/thinlto-profile-sample-accurate.c:2-4 +// RUN: %clang -O2 %s -flto=thin -fprofile-sample-accurate -c -o %t.o +// RUN: llvm-lto -thinlto -o %t %t.o +// RUN: %clang_cc1 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -emit-llvm -o

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112604. danielcdh marked an inline comment as done. danielcdh added a comment. update https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp lib/Driver/ToolC

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. sounds good - so long as other tests would fail if the fix this test was testing wasn't present (on a reverse iteration enabled build) https://reviews.llvm.org/D36386 _

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added a comment. Thanks, looks great. https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D36501: add flag to undo ABI change in r310401

Paul: is the PS4 toolchain's ABI based on that of a particular Clang release, or is it a branch from trunk at some point? Or something else? (And which release / revision?) I am reminded that there are two parts to the ABI, the C++ part and the platform part. PS4's C++ ABI is whatever Clang 3.2

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

davidxl accepted this revision. davidxl added a comment. lgtm https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Man, I have to admit it's really a shame that I didn't find time to work on this further but I'm truly too busy these days. However, I believe the primary point why I didn't have motivation to do this is because the flaw that was pointed out actually never bo

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols updated this revision to Diff 112609. rwols added a comment. [clangd] [WIP] Add support for snippet completions - Restore the sortText logic - Return CompletionItem instead of modifying a ref param - Make all helper methods const - Only set to Snippet once we encounter CK_Placeholder/CK_Cur

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols marked 10 inline comments as done. rwols added inline comments. Comment at: clangd/ClangdUnit.cpp:321 + +// Fill in the label, detail, documentation and insertText fields of the +// CompletionItem. ilya-biryukov wrote: > Maybe split writes into `Ite

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Looks good to myself. https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[libcxx] r311705 - [libcxx] [test] Update for C++17 feature removals.

Author: stl_msft Date: Thu Aug 24 14:24:08 2017 New Revision: 311705 URL: http://llvm.org/viewvc/llvm-project?rev=311705&view=rev Log: [libcxx] [test] Update for C++17 feature removals. test/std/containers/Emplaceable.h test/std/containers/NotConstructible.h test/support/counting_predicates.hpp R

r311707 - Expose -mllvm -accurate-sample-profile to clang.

Author: dehao Date: Thu Aug 24 14:37:33 2017 New Revision: 311707 URL: http://llvm.org/viewvc/llvm-project?rev=311707&view=rev Log: Expose -mllvm -accurate-sample-profile to clang. Summary: With accurate sample profile, we can do more aggressive size optimization. For some size-critical applicat

[PATCH] D37120: [analyzer] Fix modeling arithmetic

alexshap created this revision. Herald added a subscriber: xazax.hun. This diff attempts to fix modeling of arithmetic expressions where pointers are treated as integers (i.e. via C-style / reinterpret casts). In particular, it resolves https://bugs.llvm.org/show_bug.cgi?id=34309 Test plan: make

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

This change seems to have broken the git mirrors, as I can no longer check out clang without having a merge conflict as git alters the line endings. Setting core.autocrlf to false doesn't help either. Does anyone have any idea how to fix this svn <-> git issue? Thanks, Steve On Thu, Aug 24, 2017

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Can you better clarify what went wrong? I included a ‘.gitattriutes’ that matches only the new test that is supposed to keep it as CLRF From: Stephen Hines [mailto:srhi...@google.com] Sent: Thursday, August 24, 2017 3:18 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r311683 - [Preprocessor

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane created this revision. Diagnostic Categories are fairly annoying, and are only enforced by a runtime-debug-only assert. This puts in a touch more work to get this all done at compile-time with static asserts. https://reviews.llvm.org/D37122 Files: include/clang/Basic/AllDiagnostic

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane added a comment. Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm going to try to figure that out https://reviews.llvm.org/D37122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Hi Stephen- I’m digging through this, and it seems odd. SVN seems to store it with the CRLF line endings. The Git mirror for some reason is not paying attention to the svn file attribute. However, the .gitattribute file seems to convert it to the CRLF endings (as it should be), but it seems t

r311719 - [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters

Author: kcc Date: Thu Aug 24 15:40:03 2017 New Revision: 311719 URL: http://llvm.org/viewvc/llvm-project?rev=311719&view=rev Log: [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL311720: [clang] Remove unit test which uses reverse-iterate flag (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D36386?vs=111557&id=112624#toc Repository: rL LLVM https://re

r311720 - [clang] Remove unit test which uses reverse-iterate flag

Author: mgrang Date: Thu Aug 24 15:40:32 2017 New Revision: 311720 URL: http://llvm.org/viewvc/llvm-project?rev=311720&view=rev Log: [clang] Remove unit test which uses reverse-iterate flag Summary: This patch is in response to https://reviews.llvm.org/D35043 which removed -reverse-iterate flag.

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

1 more dataset, Craig has the git mirror working right, but with the public mirror… From: Stephen Hines [mailto:srhi...@google.com] Sent: Thursday, August 24, 2017 3:18 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r311683 - [Preprocessor] Correct internal token parsing of newline character

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

mgrang added a comment. In https://reviews.llvm.org/D36386#851853, @dblaikie wrote: > sounds good - so long as other tests would fail if the fix this test was > testing wasn't present (on a reverse iteration enabled build) Thanks! Yes, I verified that the test objc-modern-metadata-visibility.m

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

rnk added a comment. In https://reviews.llvm.org/D37122#851978, @erichkeane wrote: > Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm > going to try to figure that out Yeah, I'm seeing issues with that as well. I'm not sure what's up. https://reviews.llvm.org

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane added a comment. In https://reviews.llvm.org/D37122#852018, @rnk wrote: > In https://reviews.llvm.org/D37122#851978, @erichkeane wrote: > > > Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, > > I'm going to try to figure that out > > > Yeah, I'm seeing is

[PATCH] D36501: Add flag to request Clang is ABI-compatible with older versions of itself

rsmith updated this revision to Diff 112634. rsmith retitled this revision from "add flag to undo ABI change in r310401" to "Add flag to request Clang is ABI-compatible with older versions of itself". rsmith edited the summary of this revision. Herald added a subscriber: srhines. Repository: rL

r311732 - Remove .gitattributes, add comment to lineendings.

Author: erichkeane Date: Thu Aug 24 16:25:05 2017 New Revision: 311732 URL: http://llvm.org/viewvc/llvm-project?rev=311732&view=rev Log: Remove .gitattributes, add comment to lineendings. Removed: cfe/trunk/test/Frontend/.gitattributes Modified: cfe/trunk/test/Frontend/system-header-line-

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Alright, final update. Thanks to some fantastic help on #llvm, I believe this is fixed. Stephen: You may have to do some shenanigans to fix your local stuff, but the monorepo and another repo both seem to work. Sorry for this everyone :/ From: Stephen Hines [mailto:srhi...@google.com] Sent: T

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Ah, sorry I had to run off for a meeting. Yes, I was able to finally fix this. For anyone else who hits it, you can "git reset --hard" back to the CL before the initial change. Then you can "git pull" to move past the issue. Thanks for fixing this. Steve On Thu, Aug 24, 2017 at 4:35 PM, Keane, Er

[PATCH] D36719: [libc++] Add site config option for ABI macros

smeenai added a comment. Ping. https://reviews.llvm.org/D36719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36713: [libc++] Add a persistent way to disable availability

smeenai added a comment. Ping. https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36720: [libc++] Prevent stale site configuration headers

smeenai added a comment. Ping. https://reviews.llvm.org/D36720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36501: Add flag to request Clang is ABI-compatible with older versions of itself

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I'm not familiar with the details of the ABI changes, but the mechanics of the code look good to me. Repository: rL LLVM https://reviews.llvm.org/D36501

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. Any other comments? https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Sorry for the delay, this looks good to me. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

r311744 - [c++2a] P0704R1: Allow pointers to const& member functions to be called on rvalues.

Author: rsmith Date: Thu Aug 24 18:47:55 2017 New Revision: 311744 URL: http://llvm.org/viewvc/llvm-project?rev=311744&view=rev Log: [c++2a] P0704R1: Allow pointers to const& member functions to be called on rvalues. Patch by Blitz Rakete! Added: cfe/trunk/test/SemaCXX/cxx2a-pointer-to-cons

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith closed this revision. rsmith added a comment. Committed as r311744. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r311746 - Fix MSVC bots which include '__attribute__((thiscall))' in pretty-printed member function types.

Author: rsmith Date: Thu Aug 24 18:55:50 2017 New Revision: 311746 URL: http://llvm.org/viewvc/llvm-project?rev=311746&view=rev Log: Fix MSVC bots which include '__attribute__((thiscall))' in pretty-printed member function types. We really shouldn't be including inferred calling conventions here

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3851 + ->getType() + ->getPointerAddressSpace(); const unsigned ArgAddrSpace = yaxunl wrote: > rjmccall wro

Re: r311695 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Hi Hans, This fixes a regression in ubsan's handling of lambda expressions. Seems like a reasonable candidate for Clang 5, but it is rather late in the day... On 24 August 2017 at 13:10, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 24 13:10:

r311750 - Fix up the -Wc++XX-compat warnings to properly handle C++2a.

Author: rsmith Date: Thu Aug 24 19:25:07 2017 New Revision: 311750 URL: http://llvm.org/viewvc/llvm-project?rev=311750&view=rev Log: Fix up the -Wc++XX-compat warnings to properly handle C++2a. Added: cfe/trunk/test/SemaCXX/cxx17-compat.cpp Modified: cfe/trunk/include/clang/Basic/Diagnost

r311758 - Rename diagnostic groups from CXX1z to CXX17. No functionality change.

Author: rsmith Date: Thu Aug 24 19:39:05 2017 New Revision: 311758 URL: http://llvm.org/viewvc/llvm-project?rev=311758&view=rev Log: Rename diagnostic groups from CXX1z to CXX17. No functionality change. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/clang/B

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane updated this revision to Diff 112651. erichkeane added a comment. Removed file due to git weirdness. https://reviews.llvm.org/D37122 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/DiagnosticIDs.h lib/Basic/DiagnosticIDs.cpp Index: lib/Basic/DiagnosticIDs.cpp =

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

GorNishanov created this revision. If await_suspend returns a coroutine_handle, as in the example below: coroutine_handle<> await_suspend(coroutine_handle<> h) { coro.promise().waiter = h; return coro; } suspensionExpression processing will resume the coroutine pointed at by that ha

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r311762 - [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

Author: gornishanov Date: Thu Aug 24 21:46:54 2017 New Revision: 311762 URL: http://llvm.org/viewvc/llvm-project?rev=311762&view=rev Log: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer) Summary: If await_suspend returns a coroutine_handle, as in the

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

This revision was automatically updated to reflect the committed changes. Closed by commit rL311762: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D37131?vs=112658&id=112659#toc Reposit

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2