Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

> On Aug 22, 2017, at 2:05 PM, Dan Albert via cfe-commits > wrote: > > Author: danalbert > Date: Tue Aug 22 14:05:01 2017 > New Revision: 311487 > > URL: http://llvm.org/viewvc/llvm-project?rev=311487&view=rev > Log: > Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for > non-Li

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

r311488 was submitted moments later and should fix this (one of the other buildbots caught this really quickly). On Tue, Aug 22, 2017 at 3:09 PM, Adrian Prantl wrote: > > > On Aug 22, 2017, at 2:05 PM, Dan Albert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: danalbert >

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

Great. Thanks! -- adrian > On Aug 22, 2017, at 3:11 PM, Dan Albert wrote: > > r311488 was submitted moments later and should fix this (one of the other > buildbots caught this really quickly). > > On Tue, Aug 22, 2017 at 3:09 PM, Adrian Prantl > wrote: > > > On Aug

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine added a comment. OK. I understand how these should work now. As they are 80-bit specific, I am going to abandon this change and add them to my other patch which moves 80-bit specific floats and tests to x86-specific lists. https://reviews.llvm.org/D36764

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112242. saugustine added a comment. Thanks for the various comments. Please take another look. https://reviews.llvm.org/D36555 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/lib/builtins

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine added a reviewer: weimingz. saugustine added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c mgorny wrote: > This and the following files have only: > > ``` > #if !_ARCH_PPC > ``` > > s

Re: r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Okay, r311505. On Tue, Aug 22, 2017 at 12:02 PM, Akira Hatanaka wrote: > Hans, can this be merged to 5.0 too? This is a follow-up to r310006. > > Thanks. > >> On Aug 21, 2017, at 3:46 PM, Akira Hatanaka via cfe-commits >> wrote: >> >> Author: ahatanak >> Date: Mon Aug 21 15:46:46 2017 >> New Re

[PATCH] D36336: [X86] Add support for __builtin_cpu_init

craig.topper added a comment. Ping https://reviews.llvm.org/D36336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112244. saugustine added a comment. Remove two files inadvertantly included in last patch. https://reviews.llvm.org/D36555 Files: compiler-rt/lib/builtins/CMakeLists.txt Index: compiler-rt/lib/builtins/CMakeLists.txt ==

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

weimingz added reviewers: rengolin, compnerd. weimingz added a comment. LGTM. Adding Renato and Saleem to approve. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

weimingz added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:483 +set(powerpc64le_SOURCES ${powerpc64_SOURCES}) + set(wasm32_SOURCES ${GENERIC_SOURCES}) why these files were not used before? should the change be in a separate patch? or up

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF created this revision. This patch implements the source location builtins `__builtin_LINE(), `__builtin_FUNCTION()`, `__builtin_FILE()` and `__builtin_COLUMN()`. These builtins are needed to implement [`std::experimental::source_location`](https://rawgit.com/cplusplus/fundamentals-ts/v2/

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson created this revision. Make sure all temporary MD nodes have been replaced with uniqued or distinct nodes before we clone a function. Fixes PR33930. https://reviews.llvm.org/D37038 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGVTables.cpp test/Co

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

hfinkel added inline comments. Comment at: include/clang/AST/Expr.h:3814 +/// BuiltinSourceLocExpr - Represents a function call to one of +/// __builtin_LINE(), __builtin_COLUMN(), __builtin_FUNCTION(), or BuiltinSourceLocExpr -> SourceLocExpr ===

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:157 + if (DebugInfo) +DebugInfo->replaceTemporaryNodes(); + Have you looked at what it would take to only finalize the nodes reachable via the function? Otherwise — have you audited that t

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. I mentioned this in the PR but I should have restated it here, sorry... Wolfgang authored this patch. He is away for a month so I volunteered to post this, in case it was okay for resolving the PR as the crash is present in the 5.0 branch. I do know Wolfgang was not r

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

On Tue, Aug 22, 2017 at 5:56 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added a comment. > > Looks functionally correct > > > > > Comment at: test/Sema/warn-unreachable-ms.c:42 > + } > +} > > Can we add a test to exercise that this builds the

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

majnemer added inline comments. Comment at: include/clang/AST/Expr.h:3816 +/// __builtin_LINE(), __builtin_COLUMN(), __builtin_FUNCTION(), or +/// __BUILTIN_FILE() +class SourceLocExpr final : public Expr { __BUILTIN_FILE -> __builtin_FILE Comm

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

thakis updated this revision to Diff 112261. thakis added a comment. add test from rnk https://reviews.llvm.org/D36914 Files: lib/Analysis/CFG.cpp test/Sema/warn-unreachable-ms.c Index: test/Sema/warn-unreachable-ms.c === ---

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith added inline comments. Comment at: test/SemaCXX/source_location.cpp:10-35 +struct source_location { +private: + unsigned int __m_line = 0; + unsigned int __m_col = 0; + const char *__m_file = nullptr; + const char *__m_func = nullptr; +public: This see

r311514 - Remove LLVMFuzzer from list of bundled libraries for Fuchsia

Author: george.karpenkov Date: Tue Aug 22 17:09:33 2017 New Revision: 311514 URL: http://llvm.org/viewvc/llvm-project?rev=311514&view=rev Log: Remove LLVMFuzzer from list of bundled libraries for Fuchsia As of now, libFuzzer is located in compiler-rt and is bundled with Clang's toolchain by defau

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added a comment. Performance-wise the change is fine because it does the same amount of work, but I would prefer someone to audit the code to make sure that we aren't uniquing a node while we still want to make changes to it. Unfortunately testcases for these issues will involve impossi

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 112268. EricWF marked 4 inline comments as done. EricWF added a comment. - Address inline comments. - Fix calls to class call operators. https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/Decl.h include/clang/AST/Expr.

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor created this revision. This patch adds a hack to clang's emitPointerArithmetic() function to get it to emit an inttoptr instruction rather than a GEP with a null base pointer when the 'p = nullptr + n' idiom is used to convert a pointer-sized integer to a pointer. This idiom is

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith added a comment. I don't like the model of conditionally rebuilding the default initializer / default argument if it contains one of these builtins; it seems more heavy-handed than necessary. I'm also not convinced that we need to store the computed value in the AST. As an alternative,

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added a comment. I'm not sure why the svn attributes got attached to the file I added. I'll remove them before committing. https://reviews.llvm.org/D37042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

r311516 - Update Clang fuzzers to use libFuzzer bundled with the toolchain.

Author: george.karpenkov Date: Tue Aug 22 17:42:22 2017 New Revision: 311516 URL: http://llvm.org/viewvc/llvm-project?rev=311516&view=rev Log: Update Clang fuzzers to use libFuzzer bundled with the toolchain. Differential Revision: https://reviews.llvm.org/D37043 Modified: cfe/trunk/tools/cl

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF marked an inline comment as done. EricWF added a comment. In https://reviews.llvm.org/D37035#849574, @rsmith wrote: > I don't like the model of conditionally rebuilding the default initializer / > default argument if it contains one of these builtins; it seems more > heavy-handed than ne

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

This change makes it impossible to change the visibility of operator+ with -fvisibility=hidden, which is not desirable on Darwin. For example: $ cat test.cpp #include using namespace std; string foo1(string s) { return "abc" + s; } $ clang++ test.cpp -fvisibility=hidden -c; nm -m -a test.o

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

faisalv added a comment. I don't think this approach is entirely correct for at least the following reasons: 1. in the lambda case the machinery that diagnoses capture failures should be the machinery erroring on the lambda (when the parameter is odr-used) 2. in the unevaluated case, once you d

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good! Comment at: test/Sema/warn-unreachable-ms.c:42 + } +} rnk wrote: > Can we add a test to exercise that this builds the right CFG? > ``` > __try { > _

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

The point of the extern template was to prevent that operator from being defined in any other object files. The extern template wasn't taking effect because of its placement in the file, but I fixed that in r309474. Does your issue get resolved with that second change in place? From: on behalf

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi updated this revision to Diff 112271. wmi added a comment. Try another idea suggested by David. All the bitfields in a single run are still wrapped inside of a large integer according to CGBitFieldInfo. For the bitfields with legal integer types and aligned, change their access manner when

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chandlerc added a comment. I'm really not a fan of the degree of complexity and subtlety that this introduces into the frontend, all to allow particular backend optimizations. I feel like this is Clang working around a fundamental deficiency in LLVM and we should instead find a way to fix this

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

Ah I see. I think r309474 should fix our problem. Thanks for your quick response. > On Aug 22, 2017, at 6:28 PM, Shoaib Meenai wrote: > > The point of the extern template was to prevent that operator from being > defined in any other object files. The extern template wasn't taking effect > be

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < revi...@reviews.llvm.org> wrote: > chandlerc added a comment. > > I'm really not a fan of the degree of complexity and subtlety that this > introduces into the frontend, all to allow particular backend optimizations. > > I feel li

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < > revi...@reviews.llvm.org> wrote: > >> chandlerc added a comment. >> >> I'm really not a fan of the degree of complexity and

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < >> revi...@re

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On 08/22/2017 09:18 PM, Xinliang David Li via llvm-commits wrote: On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits mailto:llvm-comm...@lists.llvm.org>> wrote: On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits mailto:cfe-commits@lists.llvm.org>>

r311519 - [ODRHash] Diagnose differing template parameters.

Author: rtrieu Date: Tue Aug 22 19:43:59 2017 New Revision: 311519 URL: http://llvm.org/viewvc/llvm-project?rev=311519&view=rev Log: [ODRHash] Diagnose differing template parameters. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td cfe/trunk/lib/AST/ODRHash.cpp

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:18 PM Xinliang David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < >> cfe-comm

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo

minseong.kim added a comment. I will test your patch with repo. Thanks for your time and efforts, @hintonda. https://reviews.llvm.org/D35533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl updated this revision to Diff 112288. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: nhaehnle, jholewinski. Add a flag to indicate whether address space qualifier is implicit and only print explicit address space in diagnostics. https://revi

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type Anastasia wrote: >

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:116 + // B32: store i32 4, i32* %[[TMP3]], align 4 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %st

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:46 PM, Chandler Carruth wrote: > > > On Tue, Aug 22, 2017 at 7:18 PM Xinliang David Li via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < >> llvm-comm...@lists.llvm.org> wrote: >> >>> On Tue,

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > >

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

majnemer added a comment. I'd expect this to be more limited. Something like, "if we have a BinaryOperator of + between a CStyleCastExpr of NullToPointer and 'X', emit inttoptr(X)" https://reviews.llvm.org/D37042 ___ cfe-commits mailing list cfe-c

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:163 +else + CGF.EmitLValue(ME->getBase()); +return *Constant; There's an EmitIgnoredExpr you could use. Also, I think it would be fine to add a generic tryEmitMemb

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

majnemer added a comment. In https://reviews.llvm.org/D37042#849726, @majnemer wrote: > I'd expect this to be more limited. > > Something like, "if we have a BinaryOperator of + between a CStyleCastExpr of > NullToPointer and 'X', emit inttoptr(X)" Although maybe that is too strict... I guess

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:03 PM, Xinliang David Li wrote: > > > On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator > wrote: >> >> chandlerc added a comment. >> >> I'm really not a fan of the degree of complexity and subtlety that this >> introduces into the frontend, all to allow p

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:163 +else + CGF.EmitLValue(ME->getBase()); +return *Constant; rjmccall wrote: > There's an EmitIgnoredExpr you could use. > > Also, I think it would be fine to add

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

mgorny added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c saugustine wrote: > mgorny wrote: > > This and the following files have only: > > > > ``` > > #if !_ARCH_PPC > > ``` > > > > so I suppo

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

compnerd accepted this revision. compnerd added a comment. Would be nice to split up the PPC fixes into its own commit. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

I believe that it is merely a compile-time issue (warning), it doesn't prevent the use of compiler-rt on ARM as a libgcc replacement. I need to understand why my attempt to remove the `struct` modifier failed on one of the buildbots. On Tue, Aug 22, 2017 at 2:45 PM, Evgenii Stepanov wrote: > No

ps4-buildslave1a down 08.23.2017

Hello all, ps4-buildslave1a is currently down. We are detecting the cause and will fix it ASAP. I will inform when it is accessible again. Sorry for the inconvenience. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits

Re: ps4-buildslave1a down 08.23.2017

ps4-buildslave1a is back. On 08/23/2017 08:49 AM, Victor Leschuk wrote: > Hello all, ps4-buildslave1a is currently down. We are detecting the > cause and will fix it ASAP. I will inform when it is accessible again. > > Sorry for the inconvenience. > -- Best Regards, Victor Leschuk | Software E

<    1   2