Author: hahnfeld
Date: Mon Aug 14 00:44:05 2017
New Revision: 310817
URL: http://llvm.org/viewvc/llvm-project?rev=310817&view=rev
Log:
Fix memory leak in ToolChain::TranslateOpenMPTargetArgs
rL310433 introduced a code path where DAL is not returned and must be freed.
This change allows to run ope
Hahnfeld added a comment.
In https://reviews.llvm.org/D29660#839736, @alekseyshl wrote:
> In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote:
>
> > Bad news, the bot is still red:
> > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7114
>
>
> Disabled openmp-offloa
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:851
+ XOpenMPTargetArg->setBaseArg(A);
+ A = XOpenMPTargetArg.release();
+ DAL->append(A);
This is a memory leak that is currently triggered in
`tests/Driver/openmp-offload-gpu.c
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I think this can be committed now. It's still a bit awkward but we can address
that later.
https://reviews.llvm.org/D36397
___
cfe-commits mai
Author: ibiryukov
Date: Mon Aug 14 01:17:24 2017
New Revision: 310818
URL: http://llvm.org/viewvc/llvm-project?rev=310818&view=rev
Log:
[clangd] Fixed a data race.
Summary:
Calling addDocument after removeDocument could have resulted in an
invalid program state (AST and Preamble for the valid doc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310818: [clangd] Fixed a data race. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36397
Files:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clang
ilya-biryukov added a comment.
Thanks. I'll make sure to address the awkwardness in further commits.
https://reviews.llvm.org/D36397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
LGTM
https://reviews.llvm.org/D35370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
LGTM
https://reviews.llvm.org/D35368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
LGTM
Comment at: clang-tidy/android/CloexecCheck.h:91
+ /// Helper function to get the spelling of a particular argument.
+ StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult
&Result,
+
Author: ibiryukov
Date: Mon Aug 14 01:37:32 2017
New Revision: 310819
URL: http://llvm.org/viewvc/llvm-project?rev=310819&view=rev
Log:
[clangd] Check if CompileCommand has changed on forceReparse.
Reviewers: krasimir, bkramer, klimek
Reviewed By: klimek
Subscribers: cfe-commits
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310819: [clangd] Check if CompileCommand has changed on
forceReparse. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36398
Files:
clang-tools-extra/trunk/clangd/ClangdServer.
Author: dergachev
Date: Mon Aug 14 01:38:47 2017
New Revision: 310820
URL: http://llvm.org/viewvc/llvm-project?rev=310820&view=rev
Log:
[analyzer] Rename functions responsible for CFG-based suppress-on-sink.
Update comments. No functional change intended.
Addresses Devin's post-commit review com
johannes created this revision.
Herald added subscribers: xazax.hun, mgorny.
Herald added 1 blocking reviewer(s): teemperor.
This moves the data collection macro calls for Stmt nodes
to lib/AST/StmtDataCollectors.inc
Users can subclass ConstStmtVisitor and include StmtDataCollectors.inc
to define
Author: ibiryukov
Date: Mon Aug 14 01:45:47 2017
New Revision: 310821
URL: http://llvm.org/viewvc/llvm-project?rev=310821&view=rev
Log:
[clangd] Use multiple working threads in clangd.
Reviewers: bkramer, krasimir, klimek
Reviewed By: klimek
Subscribers: arphaman, cfe-commits
Differential Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310821: [clangd] Use multiple working threads in clangd.
(authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D36261?vs=110381&id=110922#toc
Repository:
rL LLVM
https://reviews
olista01 created this revision.
Herald added a subscriber: javed.absar.
The comment markers accepted by the assembler vary between different targets,
but '//' is always accepted, so we should use that for consistency.
Repository:
rL LLVM
https://reviews.llvm.org/D3
Files:
lib/CodeGen/
yvvan added a comment.
Can someone help me to commit it to the proper branch?
(I don't have permissions)
https://reviews.llvm.org/D35355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Hi,
Strangely enough, it turns out that if I run
Asan-armhf-with-calls-Noinst-Test on the command line it fails,
although it doesn't fail when run with lit. I've attached the stack
trace from gdb. It looks like some trouble passing down va_arg
parameters, but I haven't looked into too much details
Author: arphaman
Date: Mon Aug 14 03:59:44 2017
New Revision: 310829
URL: http://llvm.org/viewvc/llvm-project?rev=310829&view=rev
Log:
Set the lexical context for dummy tag decl inside createTagFromNewDecl
This is a follow-up to r310706. This change has been recommended by
Bruno Cardoso Lopes and
Sure, I committed r310829 which moves the lexical decl adjustment.
Hans, can you please merge r310706 with r310829.
Cheers,
Alex
On 12 August 2017 at 01:29, Richard Smith wrote:
> On 11 August 2017 at 17:20, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Ale
Author: rksimon
Date: Mon Aug 14 04:05:56 2017
New Revision: 310830
URL: http://llvm.org/viewvc/llvm-project?rev=310830&view=rev
Log:
Add braces to silence gcc dangling-else warnings. NFCI.
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: clang-tools-extra/trunk/u
Author: krasimir
Date: Mon Aug 14 04:06:07 2017
New Revision: 310831
URL: http://llvm.org/viewvc/llvm-project?rev=310831&view=rev
Log:
clang-format: Fix left pointer alignment after delctype/typeof
Change 272124* introduced a regression in spaceRequiredBetween for left aligned
pointers to declty
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310831: clang-format: Fix left pointer alignment after
delctype/typeof (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D35847?vs=110032&id=110938#toc
Repository:
rL LLVM
ht
AndersRonnholm created this revision.
AndersRonnholm added a project: clang-tools-extra.
Fixes assert reported in https://bugs.llvm.org/show_bug.cgi?id=33660
Repository:
rL LLVM
https://reviews.llvm.org/D36670
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
test/clang-tidy/misc-mis
Hi Diana,
On 14/08/17 11:27, Diana Picus wrote:
Hi,
Strangely enough, it turns out that if I run
Asan-armhf-with-calls-Noinst-Test on the command line it fails,
although it doesn't fail when run with lit. I've attached the stack
trace from gdb. It looks like some trouble passing down va_arg
par
On 14/08/17 11:27, Diana Picus wrote:
Hi,
Strangely enough, it turns out that if I run
Asan-armhf-with-calls-Noinst-Test on the command line it fails,
although it doesn't fail when run with lit. I've attached the stack
trace from gdb. It looks like some trouble passing down va_arg
parameters, bu
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D36156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Also if you want the disassembly for the whole test executable (with
just that test in it):
https://goo.gl/pjULbN
It's 177MB though.
On 14 August 2017 at 14:04, Diana Picus wrote:
> See attached.
>
> On 14 August 2017 at 13:30, Vassil Vassilev wrote:
>> On 14/08/17 11:27, Diana Picus wrote:
>>>
danielmarjamaki added a comment.
LGTM. I let others approve this.
Repository:
rL LLVM
https://reviews.llvm.org/D36670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, with one request below:
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:96
- /// Finds an edit script that converts T1 to T2.
- std::vector computeChanges(Mapping &
AndersRonnholm created this revision.
Fixes issue reported in https://bugs.llvm.org/show_bug.cgi?id=33219
Repository:
rL LLVM
https://reviews.llvm.org/D36672
Files:
clang-tidy/readability/NonConstParameterCheck.cpp
test/clang-tidy/readability-non-const-parameter.cpp
Index: test/clang-t
arphaman added a comment.
Awesome, thanks! LGTM.
https://reviews.llvm.org/D36182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes updated this revision to Diff 110945.
johannes added a comment.
format
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-basic.cpp
tools/clang-
hokein added a comment.
Sorry for the delay. The code looks good roughly, a few nits below.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolName.h:19
+namespace clang {
+namespace tooling {
+
An off-topic thought: currently we put everything into `cl
svenvh updated this revision to Diff 110947.
svenvh edited the summary of this revision.
svenvh added a comment.
Herald added a subscriber: nhaehnle.
Apologies for the late followup! Rebased the patch and addressed your comments.
https://reviews.llvm.org/D33989
Files:
include/clang/Basic/Tar
svenvh marked 2 inline comments as done.
svenvh added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1041
+default:
+ return LangAS::Default;
+}
yaxunl wrote:
> Anastasia wrote:
> > bader wrote:
> > > yaxunl wrote:
> > > > bader wrote:
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:738
+ }
+ double Denominator = T1.getNumberOfDescendants(Id1) - 1 +
+ T2.getNumberOfDescendants(
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D33989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
johannes updated this revision to Diff 110951.
johannes added a comment.
comment getJaccardSimilarity
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
tes
johannes updated this revision to Diff 110952.
johannes added a comment.
add test for delegating initializer and unwritten initializer
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tool
arphaman marked 5 inline comments as done.
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolName.h:19
+namespace clang {
+namespace tooling {
+
hokein wrote:
> An off-topic thought: currently we put everything into `clang
arphaman updated this revision to Diff 110954.
arphaman marked an inline comment as done.
arphaman added a comment.
Address review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D36156
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
include/clang/Tooling/Refactor
yaxunl created this revision.
Herald added a subscriber: Anastasia.
Only define enums necessary for the tests to speed up the tests.
https://reviews.llvm.org/D36676
Files:
test/CodeGenOpenCL/atomic-ops-libcall.cl
test/CodeGenOpenCL/atomic-ops.cl
test/SemaOpenCL/atomic-ops.cl
Index: test/
yaxunl created this revision.
Herald added a subscriber: tpr.
Not all targets support vararg (e.g. amdgpu). Instead of using vararg in the
emitted functions for enqueue_kernel,
this patch creates a temporary array of size_t, stores the size arguments in
the temporary array
and passes it to the e
mprobst updated this revision to Diff 110959.
mprobst marked 2 inline comments as done.
mprobst added a comment.
- clean up implementation, just use getIdentifierInfo
- clean up tests, remove illegal syntax, add more tests
https://reviews.llvm.org/D36142
Files:
lib/Format/TokenAnnotator.cpp
mprobst added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2355
+(Left.Tok.getIdentifierInfo() ||
+ Left.isOneOf(tok::kw_switch, tok::kw_case, tok::kw_delete)))
+ return false;
djasper wrote:
> Why is instanceof not required in
yaxunl added a comment.
In https://reviews.llvm.org/D36327#839809, @rjmccall wrote:
> Could you just implement this in SimplifyLibCalls? I assume there's some way
> to fill in TargetLibraryInfo appropriately for a platform. Is that too late
> for your linking requirements?
Both the optimize
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks.
https://reviews.llvm.org/D36676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
NoQ added a comment.
Hmm, looks correct. Thanks! I guess this problem appeared when we enabled
`SymSymExpr`s, otherwise `(End - Begin)` would have been `UnknownVal`.
Repository:
rL LLVM
https://reviews.llvm.org/D36564
___
cfe-commits mailing lis
On 14/08/17 13:04, Diana Picus wrote:
See attached.
Thanks! It looks like asan_test.i doesn't have gtest.cc which appears in
the stack trace. Am I missing something?
On 14 August 2017 at 13:30, Vassil Vassilev wrote:
On 14/08/17 11:27, Diana Picus wrote:
Hi,
Strangely enough, it turns out
Author: aaronballman
Date: Mon Aug 14 07:16:00 2017
New Revision: 310837
URL: http://llvm.org/viewvc/llvm-project?rev=310837&view=rev
Log:
Fixes a typo in a comment; NFC.
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
Modified: cfe/trunk/include/clang/AST/ASTContext.h
URL:
http://llvm.o
hokein added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/SymbolOccurrences.cpp:17
+
+SymbolOccurrence::SymbolOccurrence(const SymbolName &Name, OccurrenceKind Kind,
+ ArrayRef Locations)
arphaman wrote:
> hokein w
Author: modocache
Date: Mon Aug 14 07:29:11 2017
New Revision: 310838
URL: http://llvm.org/viewvc/llvm-project?rev=310838&view=rev
Log:
[Parse] Fix typo in header docs (NFC)
Summary:
Fix typo "delcarations", added in rL310609 and rL310627.
Modified:
cfe/trunk/include/clang/Parse/ParseAST.h
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Perfect, thanks!
https://reviews.llvm.org/D36186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
bader added a comment.
In https://reviews.llvm.org/D36327#840616, @yaxunl wrote:
> In https://reviews.llvm.org/D36327#839809, @rjmccall wrote:
>
> > Could you just implement this in SimplifyLibCalls? I assume there's some
> > way to fill in TargetLibraryInfo appropriately for a platform. Is th
Hello everyone,
LLVM buildmaster was updated and restarted, downtime was about 2 minutes.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
arphaman added a comment.
Please rebase, it doesn't apply cleanly anymore.
https://reviews.llvm.org/D36187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes updated this revision to Diff 110962.
johannes added a comment.
rebase
https://reviews.llvm.org/D36187
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-basic.cpp
test/Tooling/clang-diff-html
On 14/08/17 15:08, Vassil Vassilev wrote:
On 14/08/17 13:04, Diana Picus wrote:
See attached.
Thanks! It looks like asan_test.i doesn't have gtest.cc which appears
in the stack trace. Am I missing something?
Could you paste the compiler invocation. Are we building with -O0 (I
see quite a lot
No, the buildbots don't build with -O0 (at least not the ones that broke).
The command line for that particular object is:
build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time
-std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedan
Author: abataev
Date: Mon Aug 14 08:01:03 2017
New Revision: 310840
URL: http://llvm.org/viewvc/llvm-project?rev=310840&view=rev
Log:
[OPENMP] Generalization of calls of the outlined functions.
General improvement of the outlined functions calls.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRunti
On 14 August 2017 at 16:59, Diana Picus wrote:
> No, the buildbots don't build with -O0 (at least not the ones that broke).
>
> The command line for that particular object is:
> build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time
> -std=c++11 -Wall -W -Wno-unused-parameter -Wwrit
On 14/08/17 15:59, Diana Picus wrote:
No, the buildbots don't build with -O0 (at least not the ones that broke).
The command line for that particular object is:
build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time
-std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:398
Visitor.TraverseDecl(Decl);
- return Visitor.getLocationsFound();
+ return std::move(Visitor.getOccurrences());
}
hoke
arphaman updated this revision to Diff 110964.
arphaman marked an inline comment as done.
arphaman added a comment.
Use `takeOccurrences`
Repository:
rL LLVM
https://reviews.llvm.org/D36156
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
include/clang/Tooling/Refactoring
yvvan updated this revision to Diff 110978.
yvvan added a comment.
I have minimized the crash case and added simple test for it.
https://reviews.llvm.org/D36458
Files:
lib/Parse/Parser.cpp
test/Index/std-begin-error.cpp
Index: test/Index/std-begin-error.cpp
===
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolName.h:19
+namespace clang {
+namespace tooling {
+
arphaman wrote:
> hokein wrote:
> > An o
szepet updated this revision to Diff 110981.
szepet marked an inline comment as done.
szepet added a comment.
Updates based on comments.
https://reviews.llvm.org/D35670
Files:
include/clang/Analysis/ProgramPoint.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnal
szepet added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
dcoughlin wrote:
> Can you add a comment explaining what meaning of this program point is.
Can you help me with that? I am not s
yaxunl added a comment.
In https://reviews.llvm.org/D36327#840658, @bader wrote:
> In https://reviews.llvm.org/D36327#840616, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D36327#839809, @rjmccall wrote:
> >
> > > Could you just implement this in SimplifyLibCalls? I assume there's some
> > >
mprobst created this revision.
Herald added a subscriber: klimek.
clang-format wraps object literal keys in an object literal if they are
marked as `TT_SelectorName`s and/or the colon is marked as
`TT_DictLiteral`. Previously, clang-format would accidentally work
because colons in type aliases wer
Merged in r310848.
On Wed, Aug 9, 2017 at 1:12 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Aug 9 13:12:53 2017
> New Revision: 310516
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310516&view=rev
> Log:
> Make -std=c++17 an alias of -std=c++1z
>
> As suggested on PR339
johannes created this revision.
This adds shortcuts j and k to jump between changes.
It is especially useful in diffs with few changes.
https://reviews.llvm.org/D36685
Files:
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
===
Author: abataev
Date: Mon Aug 14 09:03:47 2017
New Revision: 310850
URL: http://llvm.org/viewvc/llvm-project?rev=310850&view=rev
Log:
[OPENMP][DEBUG] Fix for PR33676: Debug info for OpenMP region is broken.
After some changes in clang/LLVM debug info for task-based regions was
not generated at al
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D36684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D36142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
johannes created this revision.
This adds a command line option "-git-rev=".
When it is used, only one filename is accepted. The file in its version
in the specified revision is compared against the current version. Note
that this calls `git checkout` in the current directory.
https://reviews.l
johannes created this revision.
This adds another pass to the matching algorithm that tries to match nodes with
common parents, if they have similar values.
https://reviews.llvm.org/D36687
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-di
johannes created this revision.
Herald added a subscriber: klimek.
This makes Node::getIdentifier return a valid value for special
NamedDecl nodes that do not have a name, such as ctors, dtors
and unnamed classes / namespaces.
https://reviews.llvm.org/D36688
Files:
lib/Tooling/ASTDiff/ASTDiff
Author: mprobst
Date: Mon Aug 14 09:08:16 2017
New Revision: 310851
URL: http://llvm.org/viewvc/llvm-project?rev=310851&view=rev
Log:
clang-format: [JS] do not insert whitespace in call positions.
Summary:
In JavaScript, may keywords can be used in method names and thus call sites:
foo.delet
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310851: clang-format: [JS] do not insert whitespace in call
positions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36142
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe
Author: mprobst
Date: Mon Aug 14 09:09:08 2017
New Revision: 310852
URL: http://llvm.org/viewvc/llvm-project?rev=310852&view=rev
Log:
clang-format: [JS] wrap optional properties in type aliases.
Summary:
clang-format wraps object literal keys in an object literal if they are
marked as `TT_Selecto
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310852: clang-format: [JS] wrap optional properties in type
aliases. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36684
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/t
arphaman added a comment.
It might be useful to have both source and destination in a different revision.
Maybe something like `-src-git-rev` and `-dst-git-rev`?
https://reviews.llvm.org/D36686
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
danielmarjamaki added a comment.
LGTM. But others should approve.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Mon Aug 14 09:19:24 2017
New Revision: 310853
URL: http://llvm.org/viewvc/llvm-project?rev=310853&view=rev
Log:
[rename] Introduce symbol occurrences
Symbol occurrences store the results of local rename and will also be used for
the global, indexed rename results. Their kin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310853: [rename] Introduce symbol occurrences (authored by
arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36156?vs=110964&id=110999#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
It's an NFC, thus untested.
On 14 August 2017 at 17:19, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Mon Aug 14 09:19:24 2017
> New Revision: 310853
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310853&view=rev
> Log:
> [rename] Introduce symbol o
Hi,
I didn't manage to reproduce this at -O0. Yes, I think the version in
1.8.0, slightly modified (see
llvm/utils/unittest/googletest/README.LLVM)
On 14 August 2017 at 17:06, Vassil Vassilev wrote:
> On 14/08/17 15:59, Diana Picus wrote:
>>
>> No, the buildbots don't build with -O0 (at least no
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: chh
Date: Mon Aug 14 10:04:16 2017
New Revision: 310858
URL: http://llvm.org/viewvc/llvm-project?rev=310858&view=rev
Log:
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Summary:
dup() is better to be replaced by fcntl() to avoid file descriptor leakage.
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310858: [clang-tidy] Add a close-on-exec check on dup() in
Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35364?vs=110753&id=111021#toc
Repository:
rL LLVM
htt
mibintc updated this revision to Diff 111019.
mibintc added a comment.
@jyknight recommended adding the new option to skipArgs in Job.cpp. This
revision makes that change and tests that in crash-report.c; look OK?
https://reviews.llvm.org/D34158
Files:
include/clang/Driver/CC1Options.td
i
Sounds good to me. Let's give it another day and see how it goes.
On Fri, Aug 11, 2017 at 6:48 PM, Richard Smith wrote:
> Hi Hans,
>
> I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps
> we could leave it in the tree for a little while and then merge if it seems
> OK?
>
DIVYA updated this revision to Diff 111027.
https://reviews.llvm.org/D36423
Files:
benchmarks/algorithms.bench.cpp
include/algorithm
include/rng_utils.h
include/test_configs.h
include/test_utils.h
Index: include/test_utils.h
=
DIVYA added a comment.
Added benchmark from Aditya's repo into the libcxx benchmark code base
https://reviews.llvm.org/D36423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310861: [clang-tidy] Add a close-on-exec check on
inotify_init() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35370?vs=110749&id=111028#toc
Repository:
rL
Author: chh
Date: Mon Aug 14 10:25:41 2017
New Revision: 310861
URL: http://llvm.org/viewvc/llvm-project?rev=310861&view=rev
Log:
[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
Summary:
inotify_init() is better to be replaced by inotify_init1() with IN_CLOEXEC flag
t
1 - 100 of 161 matches
Mail list logo
