t-tye added inline comments.
Comment at: include/clang/Basic/SyncScope.h:56
/// enums in opencl-c.h.
-enum class SyncScope {
- OpenCLWorkGroup = 1,
- OpenCLDevice = 2,
- OpenCLAllSVMDevices = 3,
- OpenCLSubGroup = 4,
+enum class OpenCLMemoryScope {
+ WorkGroup = 1,
Add an option, -ast-dump-no-include, to clang and clang-check. Usage
example:
clang++ -Xclang -ast-dump -Xclang -ast-dump-no-include -fsyntax-only
test.cpp
clang-check -ast-print -ast-dump-no-include test.cpp
This option work with -ast-dump, -ast-dump-lookups or -ast-print to not
show decl
yaxunl marked 8 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/SyncScope.h:56
/// enums in opencl-c.h.
-enum class SyncScope {
- OpenCLWorkGroup = 1,
- OpenCLDevice = 2,
- OpenCLAllSVMDevices = 3,
- OpenCLSubGroup = 4,
+enum class Open
boris updated this revision to Diff 110875.
boris added a comment.
Richard, sorry for the last ping, somehow I missed your review.
I've uploaded a new revision with a test case (note that the issue is with
'module a.b' not 'import a.b' but I have tested both for good measure).
My understanding
faisalv added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:959
+ ? diag::ext_equals_this_lambda_capture_cxx2a
+ : diag::warn_cxx1z_compat_equals_this_lambda_capture);
Shouldn't we try and hit the 'continue
hamzasood added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:959
+ ? diag::ext_equals_this_lambda_capture_cxx2a
+ : diag::warn_cxx1z_compat_equals_this_lambda_capture);
faisalv wrote:
> Shouldn't we try an
faisalv accepted this revision.
faisalv added a comment.
This revision is now accepted and ready to land.
OK - looks good enough to me. I say we give the rest of the reviewers until
friday to chime in, and if no one blocks it, can you commit then?
nice work - thanks!
https://reviews.llvm.org/D
compnerd accepted this revision.
compnerd added a comment.
Yeah, I think that this is okay.
https://reviews.llvm.org/D36364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t-tye added inline comments.
Comment at: lib/CodeGen/CGAtomic.cpp:678
+ auto &Builder = CGF.Builder;
+ auto Scopes = getAllLanguageSyncScopes();
+ llvm::DenseMap BB;
yaxunl wrote:
> t-tye wrote:
> > Should only the scopes that apply to the language be returned
Author: mstorsjo
Date: Sun Aug 13 12:42:17 2017
New Revision: 310798
URL: http://llvm.org/viewvc/llvm-project?rev=310798&view=rev
Log:
[AArch64] Add support for a MinGW AArch64 target
Differential Revision: https://reviews.llvm.org/D36364
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310798: [AArch64] Add support for a MinGW AArch64 target
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D36364?vs=109935&id=110886#toc
Repository:
rL LLVM
https://reviews.
Author: rsmith
Date: Sun Aug 13 14:32:33 2017
New Revision: 310803
URL: http://llvm.org/viewvc/llvm-project?rev=310803&view=rev
Log:
[c++2a] Treat 'concept' and 'requires' as keywords, add compat warning for
C++17 and before.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cf
Author: rsmith
Date: Sun Aug 13 15:26:53 2017
New Revision: 310804
URL: http://llvm.org/viewvc/llvm-project?rev=310804&view=rev
Log:
Replace remaining user-visible mentions of C++1z with C++17.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Diagn
Since we took the -std=c++17 change for Clang 5, we should take this one
too.
On 13 August 2017 at 15:26, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sun Aug 13 15:26:53 2017
> New Revision: 310804
>
> URL: http://llvm.org/viewvc/llvm-project?rev=31
Author: rsmith
Date: Sun Aug 13 16:37:29 2017
New Revision: 310805
URL: http://llvm.org/viewvc/llvm-project?rev=310805&view=rev
Log:
Rename cxx1z -> cxx17 across all diagnostic IDs.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
cfe/trunk/include/clang/Basic/DiagnosticParse
wangxindsb updated this revision to Diff 110899.
wangxindsb added a comment.
Fix the Assertion Failed when run the checker to check the building of
LibreOffice.
https://reviews.llvm.org/D34275
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
test/Analysis/virtualcall.cpp
Index: t
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGAtomic.cpp:678
+ auto &Builder = CGF.Builder;
+ auto Scopes = getAllLanguageSyncScopes();
+ llvm::DenseMap BB;
t-tye wrote:
> yaxunl wrote:
> > t-tye wrote:
> > >
yaxunl updated this revision to Diff 110904.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Refactor to introduce classes AtomicScopeABI and AtomicScopeOpenCLABI for easy
extension to other languages.
https://reviews.llvm.org/D36580
Files:
include/clang/AST/ASTContext.h
i
t-tye accepted this revision.
t-tye added a comment.
LGTM
https://reviews.llvm.org/D36580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff updated this revision to Diff 110906.
sepavloff added a comment.
Herald added a subscriber: mgorny.
Updated patch
- The class representing info about clang executable name now keeps driver mode
component as well,
- Added unit tests.
https://reviews.llvm.org/D36057
Files:
include/c
sepavloff updated this revision to Diff 110909.
sepavloff edited the summary of this revision.
sepavloff added a comment.
Updated patch
- Some functionality, not related to config files directly, is move to separate
changes
- Cleanup of tests.
This change does not implement using construct @fil
21 matches
Mail list logo
