This revision was automatically updated to reflect the committed changes.
Closed by commit rL310521: [Sema] Assign new flag -Wenum-compare-switch to
switch-related parts of -Wenum… (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D36526?vs=110407&id=110473#toc
Repository:
atanasyan created this revision.
atanasyan added a project: clang.
Herald added a subscriber: arichardson.
The `-mabicalls` option does not have a sense in case of non position
independent code on N64 ABI. After this change driver starts to show a warning
that `-mabicalls` is ignored in that cas
atanasyan created this revision.
atanasyan added a project: clang.
Herald added a subscriber: arichardson.
While we do not support `-mshared / -mno-shared` properly, show warning and
ignore `-mlong-calls` option in case of implicitly or explicitly provided
`-mabicalls` option.
The patch depends
Author: gbiv
Date: Wed Aug 9 14:20:41 2017
New Revision: 310523
URL: http://llvm.org/viewvc/llvm-project?rev=310523&view=rev
Log:
Use unsigned instead of an enum for map keys
ubsan's enum sanitizer doesn't like the latter, and we had to have
out-of-bounds values for DenseMapInfo's tombstone/empt
Sorry about that!
Attempted fix is r310523. I'll keep an eye on the bot to make sure it
turns green.
On Wed, Aug 9, 2017 at 1:23 PM, Juergen Ributzka wrote:
> This seems to cause UBSAN issues:
>
> runtime error: load of value 4294967295, which is not a valid value for type
> 'clang::LVComputatio
Author: epilk
Date: Wed Aug 9 14:30:57 2017
New Revision: 310525
URL: http://llvm.org/viewvc/llvm-project?rev=310525&view=rev
Log:
[demangler] Improve representation of substitutions/templates
Differential revision: https://reviews.llvm.org/D36427
Added:
libcxxabi/trunk/test/unittest_demang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310525: [demangler] Improve representation of
substitutions/templates (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D36427?vs=110281&id=110480#toc
Repository:
rL LLVM
https:
Author: arsenm
Date: Wed Aug 9 14:44:58 2017
New Revision: 310527
URL: http://llvm.org/viewvc/llvm-project?rev=310527&view=rev
Log:
AMDGPU: Use direct struct returns and arguments
This is an improvement over always using byval for
structs.
This will use registers until ~16 are used, and then
sw
Author: coby
Date: Wed Aug 9 14:50:22 2017
New Revision: 310529
URL: http://llvm.org/viewvc/llvm-project?rev=310529&view=rev
Log:
[X86][Asm] Allow negative immediate to appear before bracketed expression
Currently, only non-negative immediate is allowed prior to a brac expression
(memory refere
Author: epilk
Date: Wed Aug 9 14:51:56 2017
New Revision: 310530
URL: http://llvm.org/viewvc/llvm-project?rev=310530&view=rev
Log:
Mark test as unsupported c++98/03 to fix buildbots
Modified:
libcxxabi/trunk/test/unittest_demangle.pass.cpp
Modified: libcxxabi/trunk/test/unittest_demangle.pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310529: [X86][Asm] Allow negative immediate to appear before
bracketed expression (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36230?vs=109374&id=110485#toc
Repository:
rL L
saugustine created this revision.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D36555
Files:
compiler-rt/lib/builtins/CMakeLists.txt
Index: compiler-rt/lib/builtins/CMakeLists.txt
===
--- compiler-rt/lib/builtins/C
arsenm closed this revision.
arsenm added a comment.
r310527
https://reviews.llvm.org/D36171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
Author: d0k
Date: Wed Aug 9 15:09:29 2017
New Revision: 310532
URL: http://llvm.org/viewvc/llvm-project?rev=310532&view=rev
Log:
[clang-tidy] Don't compute the edit distance if it's over the threshold.
No functional change intended.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/VirtualN
jyknight added a comment.
Just to restate: the ideal outcome of this discussion for me would be to
resolve things such that _ALL_ libc implementations will feel comfortable using
this technique to provide the C11-required predefined macros.
I'd love for linux, freebsd, macos, solaris, etc etc l
Author: epilk
Date: Wed Aug 9 15:45:35 2017
New Revision: 310535
URL: http://llvm.org/viewvc/llvm-project?rev=310535&view=rev
Log:
[demangler] Fix a bunch of -Wshadow warnings
These were causing failures in -Werror builds.
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/
alekseyshl added a comment.
r310519 did not fix the problem, see
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I
would suggest to revert and fix it properly, our bots are broken for a few days
already.
Repository:
rL LLVM
https://reviews.llvm.org/D29660
Marshall: ping?
On Thu, Aug 3, 2017 at 10:20 AM, Hans Wennborg wrote:
> Sounds good to me, but Eric or Marshall need to sign off.
>
> On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai wrote:
>> Ping.
>>
>> On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote:
>>
>> Marshall, Eric, Hans,
>>
>> Any ob
gtbercea added a comment.
I've removed that test. Let's see if the other two tests pass or not.
I can't reproduce the error locally so it's hard to figure out what's failing.
If you have a machine with that configuration and can run the command I would
appreciate seeing the output of the failin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310539: clang-format: Fix bug with ENAS_DontAlign and empty
lines (authored by jtbandes).
Repository:
rL LLVM
https://reviews.llvm.org/D36019
Files:
cfe/trunk/lib/Format/WhitespaceManager.cpp
cfe/
Author: arsenm
Date: Wed Aug 9 17:19:43 2017
New Revision: 310540
URL: http://llvm.org/viewvc/llvm-project?rev=310540&view=rev
Log:
Remove unused function
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-project/
bob.wilson created this revision.
Herald added a subscriber: mcrosier.
Swift would like to be able to access the name of a ModuleMacro. There was some
discussion of this in https://github.com/apple/swift-clang/pull/93, suggesting
that it makes sense to have this accessor in Clang.
https://revi
alexshap created this revision.
Herald added a subscriber: xazax.hun.
This diff attempts to address a crash (triggered assert) on the newly-added
test case.
The assert being discussed is inside SValBuilder::evalBinOp
if (Optional RV = rhs.getAs()) {
// Support pointer arithmetic where the
Author: jtbandes
Date: Wed Aug 9 17:15:31 2017
New Revision: 310539
URL: http://llvm.org/viewvc/llvm-project?rev=310539&view=rev
Log:
clang-format: Fix bug with ENAS_DontAlign and empty lines
This fixes a bug in `ENAS_DontAlign` (introduced in D32733) where blank lines
had an EscapedNewlineColu
dyung added a comment.
Hi, we are seeing this test fail on our internal linux build bot. I built/ran
your latest change r310537 and here is the test result:
/home/dyung/src/upstream/llvm_clean/tools/clang/test/Driver/openmp-offload.c:722:23:
error: expected string not found in input
craig.topper resigned from this revision.
craig.topper added a comment.
Guessing I'm only on here because I did the bulk of the 0->nullptr changes to
clang a few years back.
https://reviews.llvm.org/D36530
___
cfe-commits mailing list
cfe-commits@l
Author: epilk
Date: Wed Aug 9 19:48:13 2017
New Revision: 310546
URL: http://llvm.org/viewvc/llvm-project?rev=310546&view=rev
Log:
[demangler] Fix some more -Wshadow warnings I missed in r310535
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_demangle.cpp
UR
malhar1995 updated this revision to Diff 110514.
malhar1995 marked 7 inline comments as done.
malhar1995 added a comment.
Addressed comments.
P.S: I'm yet to test this callee-side parameter checking functionality on the
actual ISL codebase. I'll do that ASAP.
Repository:
rL LLVM
https://rev
gtbercea added a comment.
Thanks for running the test on your machine! This is very useful.
I see what the problem is now:
"clang: error: cannot find libdevice for sm_20. Provide path to different CUDA
installation via --cuda-path, or pass -nocudalib to build without linking with
libdevice."
jtbandes added a comment.
FWIW, I'm able to reproduce the failure using Docker:
Dockerfile:
FROM ubuntu:xenial
RUN apt-get update
RUN apt-get install -y build-essential ca-certificates subversion python
cmake --no-install-recommends
WORKDIR /
RUN svn co -q -r 310537 http://llvm.org
Author: phosek
Date: Wed Aug 9 21:16:38 2017
New Revision: 310548
URL: http://llvm.org/viewvc/llvm-project?rev=310548&view=rev
Log:
[Driver] Search compiler-rt paths in -print-file-name=
This makes it possible to print the name of compiler-rt libraries
by using simply clang -print-file-name=libc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310548: [Driver] Search compiler-rt paths in
-print-file-name= (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D35820?vs=109485&id=110515#toc
Repository:
rL LLVM
https://revi
gtbercea added a comment.
310549 should solve this problem by using a default architecture that is
supported by the current device version.
Repository:
rL LLVM
https://reviews.llvm.org/D29660
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
zaks.anna added a comment.
> What do you suggest? Should we widen the type of the difference, or abandon
> this patch and revert back to the local solution I originally used in the
> iterator checker?
Does the local solution you used in the iterator checker not have the same
problem?
https:/
wmi added a comment.
In https://reviews.llvm.org/D36562#837594, @chandlerc wrote:
> This has been discussed before and I still pretty strongly disagree with it.
>
> This cripples the ability of TSan to find race conditions between accesses to
> consecutive bitfields -- and these bugs have actual
yamaguchi created this revision.
I thought we should add this information to release notes, because we
added a new flag to clang driver.
https://reviews.llvm.org/D36567
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:561
+ // manager to handle these comparisons.
+ if (BinaryOperator::isComparisonOp(op) &&
+ rhs.getSubKind() == nonloc::SymbolValKind) {
some thoughts - e
101 - 138 of 138 matches
Mail list logo
