mgrang added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:49
// Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
mstorsjo wrote:
> Shouldn't these be limited to MSVC mode only? Have a look at
> `BuiltinsARM.def`,
Author: pcc
Date: Mon Jul 31 13:53:16 2017
New Revision: 309624
URL: http://llvm.org/viewvc/llvm-project?rev=309624&view=rev
Log:
Revert r309622, "Fix logic for generating llvm.type.test()s"
Caused a bot test failure:
http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA/builds/5325
Remo
Nebiroth added a comment.
I had missed a typo in the code, should be fixed and compiling properly now.
https://reviews.llvm.org/D35894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nebiroth updated this revision to Diff 108997.
Nebiroth added a comment.
Implemention of Code Hover as described in LSP definition.
Removed unintentional changes to formatting.
Removed file id field in Location struct.
https://reviews.llvm.org/D35894
Files:
clangd/ClangdLSPServer.cpp
clangd
mstorsjo added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:49
// Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
mgrang wrote:
> mstorsjo wrote:
> > Shouldn't these be limited to MSVC mode only? Have a look at
>
Author: waltl
Date: Mon Jul 31 14:00:16 2017
New Revision: 309626
URL: http://llvm.org/viewvc/llvm-project?rev=309626&view=rev
Log:
Move RTEMS to OSTargets.h
Differential Revision: https://reviews.llvm.org/D36106
Modified:
cfe/trunk/lib/Basic/Targets/OSTargets.h
cfe/trunk/lib/Basic/Targe
mgrang added inline comments.
Comment at: include/clang/Basic/BuiltinsAArch64.def:49
// Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
mstorsjo wrote:
> mgrang wrote:
> > mstorsjo wrote:
> > > Shouldn't these be limited to MSVC mode onl
On Mon, Jul 31, 2017 at 9:57 PM, David Blaikie wrote:
>
>
> On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via
> cfe-commits wrote:
>>
>> lebedev.ri added a comment.
>>
>> How does this relate to the gcc behavior?
>> I suspect not everyone would want to have this relaxed `-Wshadow`
fedor.sergeev added inline comments.
Comment at: test/Driver/stdc-predef.c:15
+ /* In this test, the file stdc-predef.h is missing from the
+installation */ #if _STDC_PREDEF_H
+ #error "stdc-predef.h should not be included"
I would rather see a real check on
timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.
Offline discussion discovered that __clear_cache() is not implemented for
powerpc64 (the big-endian target). I think it's correct to use the same
implementation of __clear_cache() for both e
mibintc updated this revision to Diff 108999.
mibintc added a comment.
This patch responds to @fedor.sergeev 's feedback from earlier today. This is a
change to the test case test/Driver/stdc-predef.c in the situation that the
system does not supply a version of stdc-predef.h. Fedor had suggeste
saugustine updated this revision to Diff 109015.
saugustine added a comment.
- The current powerpc implementation of clear cache works for big endian.
https://reviews.llvm.org/D36108
Files:
compiler-rt/cmake/Modules/CompilerRTUtils.cmake
compiler-rt/cmake/builtin-config-ix.cmake
compiler-
Author: ahatanak
Date: Mon Jul 31 15:19:34 2017
New Revision: 309633
URL: http://llvm.org/viewvc/llvm-project?rev=309633&view=rev
Log:
[Driver] Make sure the deployment target is earlier than iOS 11 when
it is inferred from -isysroot.
This fixes a change that was inadvertently introduced in r3096
saugustine added a comment.
In https://reviews.llvm.org/D36108#826673, @timshen wrote:
> Offline discussion discovered that __clear_cache() is not implemented for
> powerpc64 (the big-endian target). I think it's correct to use the same
> implementation of __clear_cache() for both endianness. W
arsenm created this revision.
Herald added subscribers: Anastasia, tpr, wdng.
In a future commit AMDGPU will start passing
aggregates directly to more functions, triggering
asserts in test/CodeGenOpenCL/addr-space-struct-arg.cl
https://reviews.llvm.org/D36118
Files:
lib/CodeGen/CGCall.cpp
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309634: Add powerpc64 to compiler-rt build infrastructure.
(authored by saugustine).
Changed prior to commit:
https://reviews.llvm.org/D36108?vs=109015&id=109017#toc
Repository:
rL LLVM
https://revi
yawanng added a comment.
Ping.
https://reviews.llvm.org/D35372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yawanng added a comment.
Ping.
https://reviews.llvm.org/D35743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Mon Jul 31 15:35:33 2017
New Revision: 309635
URL: http://llvm.org/viewvc/llvm-project?rev=309635&view=rev
Log:
Re-apply r309622 with a fix for MSVC.
Patch by Vlad Tsyrklevich!
Added:
cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
Modified:
cfe/trunk/lib/CodeGen/CGClas
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: ahatanak
Date: Mon Jul 31 15:46:00 2017
New Revision: 309636
URL: http://llvm.org/viewvc/llvm-project?rev=309636&view=rev
Log:
Silence warning -Wmissing-sysroot.
Modified:
cfe/trunk/test/Driver/darwin-version.c
Modified: cfe/trunk/test/Driver/darwin-version.c
URL:
http://llvm.org/vi
Author: ahatanak
Date: Mon Jul 31 16:08:52 2017
New Revision: 309640
URL: http://llvm.org/viewvc/llvm-project?rev=309640&view=rev
Log:
Use -target instead of -arch in test case.
Modified:
cfe/trunk/test/Driver/darwin-version.c
Modified: cfe/trunk/test/Driver/darwin-version.c
URL:
http://llv
jmgao created this revision.
Previously, the assert_capability attribute was completely ignored by
thread safety analysis.
https://reviews.llvm.org/D36122
Files:
include/clang/Basic/Attr.td
lib/Analysis/ThreadSafety.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/warn-thread-safety-analysis.
mgrang added a comment.
@mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and
_WriteStatusReg intrinsics for ARM64. I think I would need to implement them in
llvm. Do you know where can I find a doc explaining their behavior?
https://reviews.llvm.org/D36111
__
Author: epilk
Date: Mon Jul 31 19:38:40 2017
New Revision: 309649
URL: http://llvm.org/viewvc/llvm-project?rev=309649&view=rev
Log:
[demangler] Use _LIBCPP_UNREACHABLE()
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL:
http://llvm.org/viewvc
Author: epilk
Date: Mon Jul 31 19:38:41 2017
New Revision: 309650
URL: http://llvm.org/viewvc/llvm-project?rev=309650&view=rev
Log:
[demangler] Fix another bug found by oss-fuzz in r309340
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_demangle.pass.cpp
Modified
On 7/31/17 11:44 AM, David Blaikie wrote:
On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: epilk
Date: Thu Jul 27 18:35:14 2017
New Revision: 309349
URL: http://llvm.org/viewvc/llvm-project?rev=309349&view=r
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D36118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
hfinkel added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3068
+def err_impcast_complex_scalar : Error<
+ "implicit conversion discards imaginary component: %0 to %1">;
def warn_impcast_float_precision : Warning<
I think that,
djasper added a comment.
Please add all the tests into unittests/Format/FormatTest.cpp instead. We use
FileCheck-based tests only to verify the behavior of the clang-format binary
itself.
https://reviews.llvm.org/D35743
___
cfe-commits mailing lis
djasper added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:1182
+**IndentPPDirectives** (``bool``)
+ Indent preprocessor directives on conditionals.
I think we can foresee that a bool is not going to be enough here. Make this an
enum, which f
mstorsjo added a comment.
In https://reviews.llvm.org/D36111#826878, @mgrang wrote:
> @mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and
> _WriteStatusReg intrinsics for ARM64. I think I would need to implement them
> in llvm. Do you know where can I find a doc explaining thei
teemperor added a comment.
In https://reviews.llvm.org/D36067#825867, @xazax.hun wrote:
> I like the directions of this patch.
> In general, I am in favor of explicitly registering the options from user
> defined checkers.
> But changing a config option will now break the command line compati
101 - 133 of 133 matches
Mail list logo
