v.g.vassilev added a comment.
In https://reviews.llvm.org/D3#818030, @rjmccall wrote:
> In https://reviews.llvm.org/D3#812836, @v.g.vassilev wrote:
>
> > In https://reviews.llvm.org/D3#812418, @rjmccall wrote:
> >
> > > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote:
>
Hi, Sam,
many thanks for the patch,
I'm sorry I didn't notice it earlier.
Do you mind uploading your patch to Phabricator, see
https://llvm.org/docs/Phabricator.html for instructions,
so it would be easier to review / discuss the changes.
Kind regards,
Alexander Shaposhnikov
On Sun, Jul 9, 2017 at
yan12125 updated this revision to Diff 10.
yan12125 added a comment.
Add a test and fix repeated call to defaultSysRoot()
Repository:
rL LLVM
https://reviews.llvm.org/D35137
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Linux.cpp
lib/Driver/Tool
yamaguchi updated this revision to Diff 107778.
yamaguchi added a comment.
Fixed test and update diff according to Rui's comment.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable
yamaguchi added inline comments.
Comment at: llvm/lib/Option/OptTable.cpp:240
if (StringRef(S).startswith(Cur))
-Ret.push_back(S);
+Ret.push_back(S + "\t" + std::string(StringRef(In.HelpText)));
}
ruiu wrote:
> I believe
>
> Ret.pus
yamaguchi updated this revision to Diff 107779.
yamaguchi added a comment.
Add newline after the end of the line.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable.cpp
Index: llv
yamaguchi created this revision.
-Wno- was autocompleted as -Wno, so fixed this typo.
https://reviews.llvm.org/D35762
Files:
clang/lib/Basic/DiagnosticIDs.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
=
Author: faisalv
Date: Sat Jul 22 05:04:37 2017
New Revision: 308823
URL: http://llvm.org/viewvc/llvm-project?rev=308823&view=rev
Log:
[NFC, documentation] Prefer the term expansion instead of macro instantiation
... in the few remaining places where this was not corrected.
Modified:
cf
yamaguchi updated this revision to Diff 107781.
yamaguchi added a comment.
Update diff. Delete trailing whitespace so that -stdlib= autocompletion works
correctly.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocom
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix, LGTM!
https://reviews.llvm.org/D35762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: yamaguchi
Date: Sat Jul 22 05:35:15 2017
New Revision: 308824
URL: http://llvm.org/viewvc/llvm-project?rev=308824&view=rev
Log:
[Bash-autocompletion] Fixed typo and add '-' after -Wno
Summary: -Wno- was autocompleted as -Wno, so fixed this typo.
Differential Revision: https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308824: [Bash-autocompletion] Fixed typo and add '-' after
-Wno (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35762?vs=107780&id=107782#toc
Repository:
rL LLVM
https://
malhar1995 added a comment.
@dcoughlin Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D35613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
In https://reviews.llvm.org/D3#818047, @v.g.vassilev wrote:
> >> I am open to changing this code as well. That should probably be another
> >> review.
> >
> > I agree. Are you comfortable with blocking this review until that lands?
> > It seems like it would sig
flx updated this revision to Diff 107786.
https://reviews.llvm.org/D35718
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
=
hamzasood added a comment.
Could someone commit this for me? I don't have access.
https://reviews.llvm.org/D35729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi created this revision.
File path wasn't autocompleted after `-fmodule-cache-path=[tab]`, so
fixed this bug by checking if $flags contains only a newline or not.
https://reviews.llvm.org/D35763
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
ruiu added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1303
+ llvm::outs() << S << "\n";
+llvm::outs() << "\n";
return false;
You want to print out just one '\n' at end instead of two, no?
https://reviews.llvm.org/D35759
__
yamaguchi updated this revision to Diff 107790.
yamaguchi added a comment.
Update diff.
Use llvm::join because we don't want to print two '\n's.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/
ruiu added inline comments.
Comment at: clang/utils/bash-autocomplete.sh:60
eval local path=${COMP_WORDS[0]}
- flags=$( "$path" --autocomplete="$arg" 2>/dev/null )
+ flags=$( "$path" --autocomplete="$arg" 2>/dev/null | sed -e 's/\t.*.\s*$//' )
# If clang is old that it do
yamaguchi updated this revision to Diff 107791.
yamaguchi added a comment.
Update diff according to Rui's comment.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable.cpp
Index: ll
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
So, this patch changes the format of the --autocomplete option in an
incompatible way. The bash completion script that will be shipped with LLVM 5.0
will not be able to read the output of --
yamaguchi added a comment.
@ruiu
Yeah, we are planning to merge this to 5.0, so that clang Driver interface will
be compatible among further versions.
https://reviews.llvm.org/D35759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: nico
Date: Sat Jul 22 08:16:42 2017
New Revision: 308827
URL: http://llvm.org/viewvc/llvm-project?rev=308827&view=rev
Log:
Fix grammar-o in comment.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
teemperor accepted this revision.
teemperor added a comment.
LGTM.
Comment at: clang/utils/bash-autocomplete.sh:60
eval local path=${COMP_WORDS[0]}
- flags=$( "$path" --autocomplete="$arg" 2>/dev/null )
+ flags=$( "$path" --autocomplete="$arg" 2>/dev/null | sed -e 's/\t.*.
smeenai updated this revision to Diff 107795.
smeenai edited the summary of this revision.
smeenai added a comment.
Add comment
https://reviews.llvm.org/D34972
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/dllexport-vtable-thunks.cpp
Index: test/CodeGenCXX/dllexport-vtable-thunks.c
Author: chapuni
Date: Sat Jul 22 18:40:36 2017
New Revision: 308832
URL: http://llvm.org/viewvc/llvm-project?rev=308832&view=rev
Log:
clang/module.modulemap: Split out Clang_ToolingCore from Clang_Tooling.
It cuts clangFormat's dependencies out of;
Clang_Analysis
Clang_C
Clang_Diagnostics
rjmccall added a comment.
This revision now requires changes to proceed.
You can't just change the top-level mangling of the symbol because this is used
as part of the function type mangling, and those can appear at more-or-less
arbitrary positions.
I cannot possibly imagine Microsoft actually
On 07/19/2017 10:26 AM, Adrian Prantl wrote:
On Jun 21, 2017, at 11:32 PM, Andrew Jeffery wrote:
For the tests I've extracted the int5 and int8 cases to cater for
different alignments for different platform ABIs. For Linux on POWER the
5 and 8 element vectors must be naturally aligned with res
Author: chapuni
Date: Sat Jul 22 22:09:44 2017
New Revision: 308844
URL: http://llvm.org/viewvc/llvm-project?rev=308844&view=rev
Log:
[Modules] Rework r274270. Let Clang targets depend on intrinsics_gen.
This gets rid of almost LLVM targets unconditionally depending on intrinsic_gen.
Clang's mod
31 matches
Mail list logo
