[PATCH] D35448: [Bash-autocompletion] Fixed a bug on bash

2017-07-14 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

2017-07-14 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticIDs.h:266 + static std::vector getDiagnosticFlags(); + Please write a function comment just like other member functions in this class. Comment at: clang/lib/Basic/Di

r308084 - clang/test/FixIt/format.m: Tweak for i686, where ssize_t is int. (r308067)

2017-07-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Jul 14 23:14:47 2017 New Revision: 308084 URL: http://llvm.org/viewvc/llvm-project?rev=308084&view=rev Log: clang/test/FixIt/format.m: Tweak for i686, where ssize_t is int. (r308067) Modified: cfe/trunk/test/FixIt/format.m Modified: cfe/trunk/test/FixIt/format.m URL

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

2017-07-14 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added inline comments. Comment at: cfe/trunk/test/FixIt/format.m:240 + int x; + printf("%zn", &x); // expected-warning{{format specifies type 'ssize_t *' (aka 'long *') but the argument has type 'int *'}} + // PrintfSpecifier::fixType doesn't handle %n, so a fix-it is

[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

2017-07-14 Thread Dominic Chen via Phabricator via cfe-commits
ddcc created this revision. Generate more IntSymExpr constraints, perform SVal simplification for IntSymExpr and SymbolCast constraints, and create fully symbolic SymExprs https://reviews.llvm.org/D35450 Files: include/clang/Config/config.h.cmake include/clang/StaticAnalyzer/Checkers/SValE

[clang-tools-extra] r308085 - ClangApplyReplacementsTests: Add clangBasic in libdeps.

2017-07-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Jul 14 23:32:10 2017 New Revision: 308085 URL: http://llvm.org/viewvc/llvm-project?rev=308085&view=rev Log: ClangApplyReplacementsTests: Add clangBasic in libdeps. r308015 introduced clangBasic to instantiate Diagnostics &c, Modified: clang-tools-extra/trunk/unittes

[PATCH] D26350: Keep invalid Switch in the AST

2017-07-14 Thread Olivier Goffart via Phabricator via cfe-commits
ogoffart added a comment. Thanks for your review and i'll try to address the concerns. I believe tools that really need valid code relies on the diagnostics and bail out on error. On the other hand, tools that may work on code containing error do a best effort to work on the remaining AST . And

<    1   2