[PATCH] D35306: [diagtool] Add the 'find-diagnostic-id' subcommand that converts a name of the diagnostic to its enum value

This revision was automatically updated to reflect the committed changes. Closed by commit rL307813: [diagtool] Add a 'find-diagnostic-id' subcommand that converts a name of (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35306?vs=106211&id=106245#toc Repository: r

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 106243. wangxindsb added a comment. - Change function name to start with a lower case letter. - Use `StringRef` instead of `const char * ' for ReportBug() const. - Correct the braces for single statement blocks. https://reviews.llvm.org/D34275 Files: l

[PATCH] D34913: [clang-tidy] Add a new Android check "android-cloexec-socket"

yawanng added a comment. In https://reviews.llvm.org/D34913#797577, @Eugene.Zelenko wrote: > Please wait for Alexander, Aaron or Haojian approval. Could you please check this CL? Thank you. https://reviews.llvm.org/D34913 ___ cfe-commits mailing

[PATCH] D34913: [clang-tidy] Add a new Android check "android-cloexec-socket"

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D34913#806799, @yawanng wrote: > In https://reviews.llvm.org/D34913#797577, @Eugene.Zelenko wrote: > > > Please wait for Alexander, Aaron or Haojian approval. > > > Could you please check this CL? Thank you. You could commit changes, s

[clang-tools-extra] r307818 - [clang-tidy] Add a new Android check "android-cloexec-socket"

Author: yawanng Date: Wed Jul 12 10:43:36 2017 New Revision: 307818 URL: http://llvm.org/viewvc/llvm-project?rev=307818&view=rev Log: [clang-tidy] Add a new Android check "android-cloexec-socket" Summary: socket() is better to include SOCK_CLOEXEC in its type argument to avoid the file descripto

[PATCH] D34913: [clang-tidy] Add a new Android check "android-cloexec-socket"

This revision was automatically updated to reflect the committed changes. Closed by commit rL307818: [clang-tidy] Add a new Android check "android-cloexec-socket" (authored by yawanng). Changed prior to commit: https://reviews.llvm.org/D34913?vs=106058&id=106252#toc Repository: rL LLVM http

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Do you have commit access, or do you need someone to commit it for you? https://reviews.llvm.org/D33645 ___ cfe-commits mail

r307822 - [OPENMP] Emit implicit taskgroup block around taskloop directives.

Author: abataev Date: Wed Jul 12 11:09:32 2017 New Revision: 307822 URL: http://llvm.org/viewvc/llvm-project?rev=307822&view=rev Log: [OPENMP] Emit implicit taskgroup block around taskloop directives. If taskloop directive has no associated nogroup clause, it must emitted inside implicit taskgrou

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/AST/Expr.cpp:3235 +// has non-default address space it is not treated as nullptr. +bool PointeeHasDefaultAS = false; +if (Ctx.getLangOpts().OpenCL) Would we still be accepting the following:

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

vsk added a comment. I suggest changing the API for 'canDevirtualizeCall' a bit but this is looking great overall. The code movement and test case changes look good. Comment at: include/clang/AST/DeclCXX.h:1902 + bool canDevirtualizeCall(const Expr *Base, bool IsAppleKext, +

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

rnkovacs updated this revision to Diff 106268. rnkovacs added a comment. Herald added a subscriber: baloghadamsoftware. - Added `char[]` exception along with a test case. There are no more false positives on LLVM. - Simplified fix-its by using `clang::tooling::fixit` functions. https://reviews.

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek updated this revision to Diff 106275. Repository: rL LLVM https://reviews.llvm.org/D32613 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ==

r307830 - [Driver] Update Fuchsia driver path handling

Author: phosek Date: Wed Jul 12 12:15:51 2017 New Revision: 307830 URL: http://llvm.org/viewvc/llvm-project?rev=307830&view=rev Log: [Driver] Update Fuchsia driver path handling Several improvements to the Fuchsia driver: * Search for C++ library headers and libraries in directories that are par

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL307830: [Driver] Update Fuchsia driver path handling (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32613?vs=106275&id=106276#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

vsk added a comment. @dtzWill do you have any further comments on this one? I'd like to get another 'lgtm' before committing, and it'd be nice to get this in before llvm 5.0 branches (7/19). FWIW we've been living on this for a few weeks internally without any issues: https://github.com/apple/s

r307833 - [analyzer] Support generating and reasoning over more symbolic constraint types

Author: ddcc Date: Wed Jul 12 12:37:57 2017 New Revision: 307833 URL: http://llvm.org/viewvc/llvm-project?rev=307833&view=rev Log: [analyzer] Support generating and reasoning over more symbolic constraint types Summary: Generate more IntSymExpr constraints, perform SVal simplification for IntSym

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL307833: [analyzer] Support generating and reasoning over more symbolic constraint types (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D28953?vs=106084&id=106284#toc Repository:

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

szdominik added a comment. In https://reviews.llvm.org/D33645#806852, @dcoughlin wrote: > Do you have commit access, or do you need someone to commit it for you? Thank you. I don't have, I'm quite new at this project. :) https://reviews.llvm.org/D33645 _

r307838 - [DOXYGEN] Corrected typos and incorrect parameters description.

Author: kromanova Date: Wed Jul 12 13:18:55 2017 New Revision: 307838 URL: http://llvm.org/viewvc/llvm-project?rev=307838&view=rev Log: [DOXYGEN] Corrected typos and incorrect parameters description. Corrected several typos and incorrect parameters description that Sony 's techinical writer found

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

dexonsmith added a comment. This LGTM. Mehdi, do you have any other concerns? Comment at: src/cxa_demangle.cpp:44 +class string_ref +{ erik.pilkington wrote: > mehdi_amini wrote: > > If this is supposed to be *the* ultimate LLVM demangler, can we follow LLVM

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

mehdi_amini added inline comments. Comment at: src/cxa_demangle.cpp:44 +class string_ref +{ dexonsmith wrote: > erik.pilkington wrote: > > mehdi_amini wrote: > > > If this is supposed to be *the* ultimate LLVM demangler, can we follow > > > LLVM coding standar

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

ruiu added a comment. Looks like this demangler's design is similar to my demangler for Microsoft name mangling scheme (https://reviews.llvm.org/D34667). Is that a coincidence? Both demanglers create AST, stringize it using print_left/print_right (I named them write_pre/write_post), and use cus

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

mehdi_amini added a comment. In https://reviews.llvm.org/D35159#807075, @dexonsmith wrote: > This LGTM. Mehdi, do you have any other concerns? No other concern (haven't looked further for any either) https://reviews.llvm.org/D35159 ___ cfe-commi

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

dexonsmith added a reviewer: mclow.lists. dexonsmith added a subscriber: mclow.lists. dexonsmith added a comment. +mclow.lists Comment at: src/cxa_demangle.cpp:44 +class string_ref +{ mehdi_amini wrote: > dexonsmith wrote: > > erik.pilkington wrote: > > > meh

r307845 - Revert "[Driver] Update Fuchsia driver path handling"

Author: phosek Date: Wed Jul 12 14:03:54 2017 New Revision: 307845 URL: http://llvm.org/viewvc/llvm-project?rev=307845&view=rev Log: Revert "[Driver] Update Fuchsia driver path handling" The tests are failing on Windows. This reverts commit 429fe8229496f639df6b0b4734beedb1d4317aa5. Modified:

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

erik.pilkington added a comment. > Looks like this demangler's design is similar to my demangler for Microsoft > name mangling scheme (https://reviews.llvm.org/D34667). Is that a > coincidence? Both demanglers create AST, stringize it using > print_left/print_right (I named them write_pre/write

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#805761, @yunlian wrote: > I've sent a reproduce test case to tejohnson. FYI I tracked down what is going on here and reproduced with a small test case. Essentially, two copies of a linkonce odr function were optimized somewhat diff

r307847 - [mips][mt][7/7] Add driver option for the MIPS MT ASE.

Author: sdardis Date: Wed Jul 12 14:13:05 2017 New Revision: 307847 URL: http://llvm.org/viewvc/llvm-project?rev=307847&view=rev Log: [mips][mt][7/7] Add driver option for the MIPS MT ASE. Reviewers: atanasyan, slthakur Differential Revision: https://reviews.llvm.org/D35254 Modified: cfe/tr

[PATCH] D35254: [mips][mt][7/7] Add driver option for the MIPS MT ASE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL307847: [mips][mt][7/7] Add driver option for the MIPS MT ASE. (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D35254 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek created this revision. Several improvements to the Fuchsia driver: - Search for C++ library headers and libraries in directories that are part of the toolchain distribution rather than sysroot. - Use LLVM support utlities to construct paths to make sure the driver is also usable on Wind

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek added a comment. I have fixed the test to also handle Windows paths properly which was causing a build breakage. Repository: rL LLVM https://reviews.llvm.org/D35328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

fhahn added a comment. It's @yunlian, so if the issue you described above covers his failure, than that's great. @tejohnson do you have time to work on a fix soon? Otherwise I could give it a try, I would probably need a few pointers though, as I am not really familiar with ThinLTO. Passing in

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 106311. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

jroelofs accepted this revision. jroelofs added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:134 +static std::string computeTriple(llvm::Triple Triple) { + SmallString<64> T; `normalizeTriple`

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

alexshap created this revision. This diff adds support for reordering fields in structs when the code compiles as plain C, in particular we switch to using RecordDecl instead of CXXRecordDecl where it's appropriate. Test plan: make check-all Repository: rL LLVM https://reviews.llvm.org/D35

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

morehouse added a comment. r307833 is causing the sanitizer-x86_64-linux-fast buildbot to fail during clang regression tests with the following error: clang: /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/bui

[PATCH] D35268: [ObjC] Ambiguous property synthesis should pick the 'readwrite' property and check for incompatible attributes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This all seems reasonable. LGTM. Repository: rL LLVM https://reviews.llvm.org/D35268 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r307853 - Revert "[analyzer] Support generating and reasoning over more symbolic constraint types"

Author: ddcc Date: Wed Jul 12 14:43:42 2017 New Revision: 307853 URL: http://llvm.org/viewvc/llvm-project?rev=307853&view=rev Log: Revert "[analyzer] Support generating and reasoning over more symbolic constraint types" Assertion `Loc::isLocType(SSE->getLHS()->getType())' failed in Analysis/PR39

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

EricWF added a comment. +1 for moving this file to LLVM's internal style. Comment at: src/cxa_demangle.cpp:44 +class string_ref +{ dexonsmith wrote: > mehdi_amini wrote: > > dexonsmith wrote: > > > erik.pilkington wrote: > > > > mehdi_amini wrote: > > > > > I

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

ddcc added a comment. Reverted in https://reviews.llvm.org/rL307853 Repository: rL LLVM https://reviews.llvm.org/D28953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

ddcc added a comment. Reverted in https://reviews.llvm.org/rL307853 Repository: rL LLVM https://reviews.llvm.org/D28953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek updated this revision to Diff 106323. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D35328 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.c

r307855 - [index] Don't add relation to a NamedDecl with no name

Author: benlangmuir Date: Wed Jul 12 15:05:30 2017 New Revision: 307855 URL: http://llvm.org/viewvc/llvm-project?rev=307855&view=rev Log: [index] Don't add relation to a NamedDecl with no name Unless it's one of the special cases (tag, category) that we can handle. This syncs up the check between

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

This revision was automatically updated to reflect the committed changes. Closed by commit rL307856: Reland "[Driver] Update Fuchsia driver path handling" (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35328?vs=106323&id=106327#toc Repository: rL LLVM https://revie

r307856 - Reland "[Driver] Update Fuchsia driver path handling"

Author: phosek Date: Wed Jul 12 15:14:41 2017 New Revision: 307856 URL: http://llvm.org/viewvc/llvm-project?rev=307856&view=rev Log: Reland "[Driver] Update Fuchsia driver path handling" Several improvements to the Fuchsia driver: * Search for C++ library headers and libraries in directories tha

[PATCH] D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant

efriedma added a comment. See https://bugs.llvm.org/show_bug.cgi?id=4898 for more discussion of __builtin_constant_p in LLVM vs. gcc. https://reviews.llvm.org/D35190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

ahatanak updated this revision to Diff 106347. ahatanak marked 2 inline comments as done. ahatanak added a comment. Define and use CXXMethodDecl::getDevirtualizedMethod, which returns the function that is called when a call is devirtualized. https://reviews.llvm.org/D34301 Files: include/cla

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev created this revision. crtbegin.o from gcc toolchain as configured on latest Solaris (with --enable-initfini-array) does not have support for .ctors. Clang needs to switch to .init_array. Doing it unconditionally is fine since older Solaris configurations do support .init_array. h

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, this looks great. https://reviews.llvm.org/D34301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 106349. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev added a comment. Note, that LLVM has already been changed to honor use-init-array on Solaris: https://reviews.llvm.org/rL305948 (before that change setting Options.UseInitArray in clang would not matter). https://reviews.llvm.org/D35337 __

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

dcoughlin added a comment. Thanks for the patch, and apologies for the delay reviewing! Here are some initial comments -- there are more coming. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:159 +llvm::APFloat To(S, llvm::APFloat::uniniti

[PATCH] D35338: Add the -fdestroy-globals flag

itessier created this revision. The -fdestroy-globals flag can be used to disable global variable destructor registration. It is intended to be used with embedded code that never exits. Disabling registration allows the linker to garbage collect unused destructors and vtables. https://reviews.ll

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

mehdi_amini added a comment. In https://reviews.llvm.org/D35081#807172, @fhahn wrote: > It's @yunlian, so if the issue you described above covers his failure, than > that's great. @tejohnson do you have time to work on a fix soon? Otherwise I > could give it a try, I would probably need a few p

[clang-tools-extra] r307876 - clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp: Resolve flakiness in the test.

Author: chapuni Date: Wed Jul 12 19:06:30 2017 New Revision: 307876 URL: http://llvm.org/viewvc/llvm-project?rev=307876&view=rev Log: clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp: Resolve flakiness in the test. Tests would go flaky if; 1. Using %T (not %t) 2.

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 106367. modocache added a comment. Use CMAKE_MATCH_0 instead of using REGEX REPLACE. Thanks for the suggestion! https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt ===

Re: r305860 - Special-case handling of destructors in override lists when dumping ASTs.

Hi Lang, clang crashes when I compile the following code with "-Xclang -ast-dump”: class Base { public: virtual void operator()() {} }; class Derived : public Base { public: void operator()() override {} }; If I change “OS << D->getName()” to “OS << D->getNameAsString()”, the crash disappe

r307883 - [Sema] Mark a virtual CXXMethodDecl as used if a call to it can be

Author: ahatanak Date: Wed Jul 12 23:08:27 2017 New Revision: 307883 URL: http://llvm.org/viewvc/llvm-project?rev=307883&view=rev Log: [Sema] Mark a virtual CXXMethodDecl as used if a call to it can be devirtualized. The code to detect devirtualized calls is already in IRGen, so move the code to

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

This revision was automatically updated to reflect the committed changes. Closed by commit rL307883: [Sema] Mark a virtual CXXMethodDecl as used if a call to it can be (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34301?vs=106347&id=106380#toc Repository: rL LLVM

r307886 - fix typos in comments; NFC

Author: inouehrs Date: Wed Jul 12 23:51:20 2017 New Revision: 307886 URL: http://llvm.org/viewvc/llvm-project?rev=307886&view=rev Log: fix typos in comments; NFC Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/CheckerManager.h cfe/trunk/lib/Parse/ParseCXXInlineMethods.cpp Modified

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

whisperity resigned from this revision. whisperity added inline comments. Comment at: docs/clang-tidy/checks/bugprone-suspicious-memset-usage.rst:10 + +**Case 1: Fill value is a character '0'** + Shouldn't this `'0'` be enclosed within backticks? https://review

<    1   2