[PATCH] D34114: [clang] A better format for unnecessary packed warning.

2017-07-05 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. Richard's points are really valid here. I missed the aspect that packed always implies alignment 1, which does have an effect on the code in most of the cases listed here. I agree that the value of this warning is low, since the possibility of false-positive is quite hi

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-07-05 Thread Matan via Phabricator via cfe-commits
mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D33278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

2017-07-05 Thread Matan via Phabricator via cfe-commits
mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D33277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3