[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM. Just one minor nit on the option help string below. Thanks Comment at: clang/include/clang/Driver/CC1Options.td:329 +def fno_debug_pass_manager : Flag<["-"], "fno

Re: r306692 - Initialize variable and silence potentially uninitialized warning.

This change broke clang/ubsan bot. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio It looks like the value you are initializing SavedAK with may itself be uninitialized? I see a few constructors that do not mention it. On Thu, Jun 29

[PATCH] D34842: [X86] Add RDRND to Goldmont. Add MOVBE to all Atom CPUs

craig.topper created this revision. This adds to RDNRND to Goldmont as I believe it has that feature in addition to RDSEED. I don't know how to test the MOVBE part since we don't have a __MOVBE__ macro nor do we need one. The backend will already infer the feature from the CPU name. We do have

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen updated this revision to Diff 104766. timshen marked an inline comment as done. timshen added a comment. Herald added a subscriber: aprantl. s/the debug prints/debug printing/ https://reviews.llvm.org/D34790 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Fronten

[libcxx] r306755 - [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code.

Author: dlj Date: Thu Jun 29 16:07:27 2017 New Revision: 306755 URL: http://llvm.org/viewvc/llvm-project?rev=306755&view=rev Log: [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code. Summary: This reference to lit.util.capture is functionally identical to su

r306756 - [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

Author: timshen Date: Thu Jun 29 16:08:38 2017 New Revision: 306756 URL: http://llvm.org/viewvc/llvm-project?rev=306756&view=rev Log: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline. Previously it doesn't actually invoke the designated new PM builder functions. This patch moves NameAnonG

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306756: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D34728?vs=104551&id=104767#toc Repository: rL LLVM https://r

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306757: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D34790?vs=104766&id=104768#toc Repositor

r306757 - [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

Author: timshen Date: Thu Jun 29 16:10:13 2017 New Revision: 306757 URL: http://llvm.org/viewvc/llvm-project?rev=306757&view=rev Log: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information. Differential Revision: https://reviews.llvm.org/D34790 Added: cfe/trunk/test/C

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added a comment. Already said LGTM, please go ahead and submit. If tehre are further requsets, we can always amke follow-up changes. Repository: rL LLVM https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

Sorry, email misfire... On Thu, Jun 29, 2017 at 4:15 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > Already said LGTM, please go ahead and submit. If tehre are further > requsets, we can always amke follow-up changes. > > > Repository: > rL LLVM >

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

chandlerc accepted this revision. chandlerc added a comment. LGTM too, but no need to wait for me to land this. =D https://reviews.llvm.org/D34721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306759: [clang-format] Switch to case-insensitive header matching and use it to (authored by chandlerc). Repository: rL LLVM https://reviews.llvm.org/D33932 Files: cfe/trunk/include/clang/Format/For

r306759 - [clang-format] Switch to case-insensitive header matching and use it to

Author: chandlerc Date: Thu Jun 29 16:20:54 2017 New Revision: 306759 URL: http://llvm.org/viewvc/llvm-project?rev=306759&view=rev Log: [clang-format] Switch to case-insensitive header matching and use it to improve support for LLVM-style include sorting. This really is a collection of improvemen

r306760 - Teach ASTReader how to read only the Preprocessor state from an AST file, not the ASTContext state.

Author: rsmith Date: Thu Jun 29 16:23:46 2017 New Revision: 306760 URL: http://llvm.org/viewvc/llvm-project?rev=306760&view=rev Log: Teach ASTReader how to read only the Preprocessor state from an AST file, not the ASTContext state. We use this when running a preprocessor-only action on an AST f

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc created this revision. Herald added subscribers: mcrosier, sanjoy, rengolin. Given the long time for which this path has been unused, off by default, and unnecessary this completely removes the flags. If users are deeply concerned about the commandline compatibility, they can be added ba

r306764 - [PM] Add support for sample PGO in the new pass manager (clang-side)

Author: dehao Date: Thu Jun 29 16:33:13 2017 New Revision: 306764 URL: http://llvm.org/viewvc/llvm-project?rev=306764&view=rev Log: [PM] Add support for sample PGO in the new pass manager (clang-side) Summary: This implements the clang bits of https://reviews.llvm.org/D34720, and add correspondi

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` interface is subject to change without notice. https://reviews.llvm.org/D34846 _

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

hfinkel accepted this revision. hfinkel added a comment. LGTM, but you need to get the: def fslp_vectorize_aggressive : Flag<["-"], "fslp-vectorize-aggressive">, Group, HelpText<"Enable the BB vectorization passes">; def fno_slp_vectorize_aggressive : Flag<["-"], "fno-slp-vectorize-aggr

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

hfinkel added a comment. In https://reviews.llvm.org/D34846#796102, @rsmith wrote: > Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` > interface is subject to change without notice. I'm assuming we can remove the regular flag as well. They'll just get an "unused argume

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc updated this revision to Diff 104775. chandlerc added a comment. Remove the rest of the flag handling that I missed the first time grepping through... https://reviews.llvm.org/D34846 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Fronten

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar created this revision. On RHEL, devtoolset provides a more up-to-date toolchain than the base install, and we want to make sure all the tools use are from the same toolchain. https://reviews.llvm.org/D34848 Files: lib/Driver/ToolChains/Linux.cpp Index: lib/Driver/ToolChains/Linux.c

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc requested review of this revision. chandlerc added a comment. In https://reviews.llvm.org/D34846#796102, @rsmith wrote: > Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` > interface is subject to change without notice. What do you think about this now that it

r306769 - Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser.

Author: echristo Date: Thu Jun 29 17:03:56 2017 New Revision: 306769 URL: http://llvm.org/viewvc/llvm-project?rev=306769&view=rev Log: Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser. Modeled Triple::GNU after front end code (aap

[PATCH] D34425: Unified ARM logic for computing target ABI.

echristo added a comment. I've committed this for you as: M lib/Driver/ToolChains/Clang.cpp M test/CodeGen/arm-v8.1a-neon-intrinsics.c M test/CodeGen/named_reg_global.c M test/CodeGen/neon-immediate-ubsan.c M test/CodeGen/xray-attribut

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute

r306770 - [CodeGen] Propagate dllexport to thunks

Author: smeenai Date: Thu Jun 29 17:07:54 2017 New Revision: 306770 URL: http://llvm.org/viewvc/llvm-project?rev=306770&view=rev Log: [CodeGen] Propagate dllexport to thunks Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL306770: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34850 Files: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/test/CodeGenCXX/wind

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

dlj created this revision. dlj added projects: lld, clang. Herald added subscribers: mehdi_amini, sanjoy. The GoogleTest lit format accepts two parameters to its constructor: a subdirectory to find test binaries, and a required suffix for the test filenames. Typically, the config should look lik

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Per discussion on IRC, a follow-up patch from @nbjoerg will add the flag back with it just producing a warning that the flag has been removed and has no effect. While the usage of the dr

r306775 - [WebAssembly] Add throw/rethrow builtins for exception handling

Author: aheejin Date: Thu Jun 29 17:44:01 2017 New Revision: 306775 URL: http://llvm.org/viewvc/llvm-project?rev=306775&view=rev Log: [WebAssembly] Add throw/rethrow builtins for exception handling Summary: Add new builtins for throw/rethrow instructions. This follows exception handling handling

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and long long is 8 bytes. https://reviews.llvm.org/D34859 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

r306782 - Test Commit

Author: dhinton Date: Thu Jun 29 19:57:34 2017 New Revision: 306782 URL: http://llvm.org/viewvc/llvm-project?rev=306782&view=rev Log: Test Commit Modified: cfe/trunk/README.txt Modified: cfe/trunk/README.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306782&r1=306781&

r306783 - Remove test commit.

Author: dhinton Date: Thu Jun 29 20:03:28 2017 New Revision: 306783 URL: http://llvm.org/viewvc/llvm-project?rev=306783&view=rev Log: Remove test commit. Modified: cfe/trunk/README.txt Modified: cfe/trunk/README.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306783&r1

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

mgrang created this revision. Iteration of the unordered Ivars causes objc-modern-metadata-visibility.mm (uncovered by reverse iterating SmallPtrSet). https://reviews.llvm.org/D34860 Files: lib/Frontend/Rewrite/RewriteModernObjC.cpp test/Rewriter/objc-modern-metadata-visibility2.mm Index

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

alexshap added inline comments. Comment at: tools/extra/clang-rename/tool/ClangRename.cpp:167 FindingAction.getUSRList(); const std::vector &PrevNames = FindingAction.getUSRSpellings(); if (PrintName) { 1. nit: this line caught my eye (not directly r

r306786 - Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's

Author: chandlerc Date: Thu Jun 29 22:13:31 2017 New Revision: 306786 URL: http://llvm.org/viewvc/llvm-project?rev=306786&view=rev Log: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

This revision was automatically updated to reflect the committed changes. Closed by commit rL306786: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's (authored by chandlerc). Repository: rL LLVM https://reviews.llvm.org/D34846 Files: cfe/trunk/include/clang/Driver/CC1

[PATCH] D34529: [Driver] Check that the iOS deployment target is iOS 10 or earlier if the target is 32-bit

bob.wilson added a comment. The proposed error message does not provide any information about why the version is invalid. That could be confusing. Your comment in the code is more clear: "iOS 10 is the maximum deployment target for 32-bit targets". Can you say something like that in the error m

r306789 - fix trivial typos, NFC

Author: inouehrs Date: Thu Jun 29 22:40:31 2017 New Revision: 306789 URL: http://llvm.org/viewvc/llvm-project?rev=306789&view=rev Log: fix trivial typos, NFC Modified: cfe/trunk/include/clang/Lex/PTHLexer.h cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Parse/ParseDeclCXX.cpp

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Can you please double check the type of `long double` as well? Comment at: lib/Basic/Targets.cpp:6583 + +// This is an LLP64 paltform. +// int:4, long:4, long lon

r306790 - Add -no-canonical-prefixes to the test line so that we can handle different build modes.

Author: echristo Date: Thu Jun 29 23:03:47 2017 New Revision: 306790 URL: http://llvm.org/viewvc/llvm-project?rev=306790&view=rev Log: Add -no-canonical-prefixes to the test line so that we can handle different build modes. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trun

[PATCH] D34865: [ORE] Use LLVM's "diagnostics hotness" spelling

modocache created this revision. Depends on https://reviews.llvm.org/D34864. To unify Clang and LLVM's spelling of "diagnostic[s] hotness", use the new "diagnostics hotness" spelling in LLVM, which was added in https://reviews.llvm.org/D34864. https://reviews.llvm.org/D34865 Files: lib/CodeG

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotness thresholds, which were added to LLVM in https://reviews.llvm.org/D34867. This prevents diagnostics that do not meet a mi

<    1   2