graydon created this revision.
Add a test for the change to ASTReader that reproduces the
logic for consolidating multiple ObjC interface definitions to the
case of multiple ObjC protocol definitions.
This test is a modified copy of the test that accompanied the original
change to interfaces, in
tejohnson added a comment.
In https://reviews.llvm.org/D34728#794508, @timshen wrote:
> Added -fexperimental-new-pass-manager=off/on/debug for printing debug
> information.
>
> Added a Clang test.
>
> Do tell if you want me to split this patch. I didn't, becuase then I don't
> have to write a t
Yes, I wasn't sure how to test it at this level (there's a pending test at the
swift level) but, as you pointed out in separate email, there was an adaptable
test in the original commit this is a copy-and-modification of, so I
copied-and-modified the test as well. Posted for review in
https://r
timshen created this revision.
Herald added subscribers: hiraditya, mehdi_amini, sanjoy.
https://reviews.llvm.org/D34790
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/include/clang/Frontend/CodeGenOptions.h
clang/lib/CodeGen/BackendUtil
timshen updated this revision to Diff 104551.
timshen added a comment.
Splitted into two patches. I'll commit this one (ThinLTO change) without the
test first, then commit the flag change with the Clang ThinLTO pipeline test.
https://reviews.llvm.org/D34728
Files:
clang/lib/CodeGen/BackendUt
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM as well.
https://reviews.llvm.org/D34728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: compnerd
Date: Wed Jun 28 17:54:44 2017
New Revision: 306622
URL: http://llvm.org/viewvc/llvm-project?rev=306622&view=rev
Log:
CodeGen: handle missed case of COMDAT handling
When Protocol references are constructed, we need to add the reference
symbol to a COMDAT group on non-MachO object
chandlerc added inline comments.
Comment at: clang/include/clang/Driver/Options.td:971-973
+def fexperimental_new_pass_manager_EQ : Joined<["-"],
"fexperimental-new-pass-manager=">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enables an experimental new pass manager in LLVM.">,
twoh created this revision.
When profile data is given, .hot/.unlikely section prefix is
added to hot/cold functions for linker to improve code locality. GCC
controls this behavior with '-f(no)-reorder-functions' flag, while LLVM
uses opt tool option '-profile-guided-section-prefix=true/false'. Th
Hello everyone,
Below are some buildbot numbers for the week of 06/11/2017 - 06/17/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 06/18/2017 -
06/24/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
yawanng updated this revision to Diff 104574.
yawanng added a comment.
Herald added subscribers: mgorny, srhines.
rename the check.
https://reviews.llvm.org/D34633
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecOpenCheck.cpp
c
timshen added inline comments.
Comment at: clang/include/clang/Driver/Options.td:971-973
+def fexperimental_new_pass_manager_EQ : Joined<["-"],
"fexperimental-new-pass-manager=">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enables an experimental new pass manager in LLVM.">,
Va
zaks.anna added a comment.
I agree that we should not print the values of all variables. The users will be
overwhelmed with the huge amount of information. It is very valuable to
highlight just the right information. (I believe even the current diagnostics
often produce too much info and highli
Author: rsmith
Date: Wed Jun 28 19:19:42 2017
New Revision: 306628
URL: http://llvm.org/viewvc/llvm-project?rev=306628&view=rev
Log:
Track the set of module maps read while building a .pcm file and reload those
when preprocessing from that .pcm file.
Added:
cfe/trunk/test/Modules/Inputs/prep
ahatanak updated this revision to Diff 104579.
ahatanak added a comment.
The updated patch produces diagnostics if an aligned allocation function is
selected that is not implemented in the c++ standard library of the deployment
target (except when the function is defined by the user and its defi
ahatanak added a comment.
I'll revert the changes I made to libc++ that annotates the allocation
functions with availability later.
https://reviews.llvm.org/D34574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: smeenai
Date: Wed Jun 28 19:52:46 2017
New Revision: 306632
URL: http://llvm.org/viewvc/llvm-project?rev=306632&view=rev
Log:
[libc++] Hoist explicit instantiation above implicit. NFC
The string literal operators have implicit instantiations of
basic_string and basic_string, which prevent
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, this looks good to me. Now if we could only figure out when aligned
allocation is unavailable on other platforms this easily :)
Comment at: include/clang/Basic/Diagn
Hahnfeld added a subscriber: cfe-commits.
Hahnfeld edited reviewers, added: rsmith, rengolin; removed: cfe-commits.
Hahnfeld added a comment.
Some comments inline. In general you should consider posting an RFC on cfe-dev
because this change will basically affect all compilations on GNU/Linux if
mibintc planned changes to this revision.
mibintc added a comment.
I'm planning to rework this patch again. sorry for the churn.
Repository:
rL LLVM
https://reviews.llvm.org/D34158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: xazax
Date: Wed Jun 28 23:53:13 2017
New Revision: 306648
URL: http://llvm.org/viewvc/llvm-project?rev=306648&view=rev
Log:
Factor out a functionality from isBeforeInTranslationUnit
The first user of this API will be the cross translation unit
functionality of the Static Analyzer which wi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306648: Factor out a functionality from
isBeforeInTranslationUnit (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D34506?vs=104358&id=104601#toc
Repository:
rL LLVM
https://re
101 - 123 of 123 matches
Mail list logo
